cwd_fd is crucial to maintain: long-term vision for fish is multiple
threads each with their own CWD with the process-wide CWD used for
nothing at all except transiently (e.g. during fork).
Note this fd is heightenized per open_dir.
This reverts commit 6701b7f6c8.
Like 1b16d318cc, reproduces with `cargo test test_pthread`
Fix by using stdlib `println!` to avoid interacting with topicMonitor.
Enable `allow-print-in-tests` like with crates/printf, such that there i
no deny-warning.
Happens when running `cargo nextest run test_replace_home_directory_with_tilde`, due to process-isolation model.
Backtrace shows:
EnvStack::set_one(HOME)
EnvStack::set
env_dispatch_var_change
reader_current_data
reader_data_stack
assert_is_main_thread
is_main_thread
main_thread_id
Fix by using TestEnvironment instead, as this is a unit-test and does
not need anything more.
in `test_path_normalize_for_cd`
This happens when running the tests using `cargo nextest run`, where
each test runs in its own process, but does not happen with normal
`cargo test`.
Fix by avoiding eprintf!, which can reach SigChecker::check. Instead use a custom panic-message.
Simplify these and move the sanitization closer to the point of output.
Stop worrying about control characters beyond what PCRE2 reports in
"[[:cntrl:]]" for clarity.
Strip control characters from VCS branch and state strings before writing them in prompts.
Also route the informative and minimalist sample prompts through prompt_pwd instead of printing PWD directly.
Compared against "terraform -help" from v1.15.4. The completion was
missing the following top-level subcommands:
force-unlock Release a stuck lock on the current workspace
metadata Metadata related commands
modules Show all declared modules in a working directory
query Search and list remote infrastructure with Terraform
stacks Manage HCP Terraform stack operations
Also add the global "-chdir" option, which switches the working
directory before running the subcommand, and teach
"__fish_terraform_needs_command" to skip past it so subcommands are
still offered after e.g. "terraform -chdir=foo".
While at it, fix two unrelated bugs:
* The "refresh" section conditioned "-compact-warnings" on "$apply"
instead of "refresh", so it was only offered for apply/destroy
(where it's already covered).
* The "show" section had a stray "validate -json" completion (a copy
of the entry in the validate section). Replace it with the
actually-missing "show -json".
Closes#12771
Commit 4bdd35b8d1 (feat: stop language fallback at English, 2026-05-11)
rendered en.po unused. Delete it.
In future, we should replace most single quotes in msgids with
backticks, since Markdown is very popular nowadays.
Closes#12745
This parameter is used to suppress certain verbose errors that are
expected during tests. It was awkwardly threaded through multiple call
sites. Just set it (test only) on Parser.
The current file has no platform detection, causing GNU-only completions
on macOS/BSD. It also has a factual error: -H is described as "Human
readable sizes, powers of 1000", but -H actually follows command-line
symlinks.
Rewritten using __fish_gnu_complete and GNU detection, following
the same pattern as sed.fish. Platform-specific flags added.
Closes#12767
We source "COMPLETE=fish cargo xtask" at completion load time.
This means that completions will be missing if completions were requested
before entering a fish-shell worktree.
Also, as reported in [1], this will compile xtask even for non-fish
projects, which is usually fast but not necessarily (it might download
crates etc).
As suggested in the initial revision of #12763, we could
hardcode the output of
$ COMPLETE=fish cargo xtask
complete --keep-order --exclusive --command cargo --arguments \
"(COMPLETE=fish /home/johannes/git/fish-shell/target/debug/xtask --
(commandline --current-process --tokenize --cut-at-cursor) (commandline --current-token))"
but that might still be too intrusive because according to [2],
calls to "cargo metadata" can be slow on big repos with hundreds of
Cargo.toml files.
[1]: 959cbb4259 (r185615416)
[2]: 959cbb4259 (r185637424)
FWIW, commit comments are also accessible via
gh api -H "X-GitHub-Api-Version: 2026-03-10" \
/repos/fish-shell/fish-shell/commits/959cbb42597444577d26ed5ba6151ccb1d7f3600/comments
Set RUSTUP_AUTO_INSTALL=0 for completions, to be consistent with
88d01f7eb8 (completions/cargo: avoid auto-installing toolchain via
rustup, 2026-03-27).
Extend the hack added in ebc140a3ea (Hack path component movement to
skip escaped spaces, 2025-12-16) to apply to all characters, such as
";" that may be part of a file name.
The test balloon in 012007ce7b (Test balloon for ST OSC terminator,
2025-11-18) released in 4.3.0 did not trigger problem reports.
Bravely switch over to the standard ST rather than xterm's BEL.
Closes#12032
Doing
firefox --pro TAB TAB TAB
results in
firefox --profile --ProfileManager
git-bisect points to 3546ffa3ef (reader
handle_completions(): remove dead filtering code, 2026-01-02)
but that regression has already been fixed by 85e76ba356
(Fix option substr completions not being filtered out, 2026-04-16).
However in between those two commits, the above case has also been
broken by 2f6b1eaaf9 (reader handle_completions(): don't consider
odd replacing completions for common prefix, 2026-01-02)
The first TAB inserts "--profile ", including the trailing space.
However it also shows the completion pager, which means that subsequent
TABs will insert after the space.
The trailing space does not make sense unless we navigate the pager.
Remove it in all cases, to fix this smartcase scenario.
Alternatively, we could start navigating the pager in this case
(and keep the trailing space), but that's probably too inconsistent.
Commit f86c9af455 (fish_git_prompt: skip rename/copy source paths in
status parsing, 2026-05-12). filters from "git-status --porcelain"
output all lines that don't look like a status entry. This is
to filter out the rename source path. But the filtering has false
positives, e.g. if a rename source path starts with "AA". Let's only
skip lines immediately after each rename entry. Also for copy (C)
though I haven't found a test case for that yet.
Treating `en` the same as any other language is problematic as shown by
#12690. When the language precedence list contains entries after
English and we don't treat English specially, a lack of translations in
`en.po` (or a lack of `en.po`, once we delete it) results in
translations into those subsequent languages being displayed, instead of
the msgid, which is in English, and thus preferable.
By truncating the fallback list when we encounter `en`, this problem is
resolved. As it is implemented now, the `en.po` catalog is never used.
This is intended, as the plan is to delete it (#12745). In any case, its
translations are identical to the msgids modulo some fancy quotes.
While at it, also treat `LANGUAGE` values of `C` and `POSIX` as
referring to the English version of the messages.
Fixes#12690Closes#12747
The status entry filter regex was missing T, which is a valid
porcelain status code for file type changes (e.g. regular file
to symlink). Without it, typechange entries would be silently
dropped from dirty/staged detection.
Closes#12754
When git status --porcelain -z reports renames or copies, it outputs
the source filename as a separate NUL-delimited field after the status
line. This extra entry was counted as an additional change, inflating
staged/dirty counts when the source filename started with [ACDMRTU].
Filter split results to entries matching a valid two-char status code
prefix, which excludes the bare source filenames.
Fixes#11296
Part of #12754
git status --porcelain -z outputs the rename source filename as a
separate NUL-delimited entry after the status line. When the source
filename starts with [ACDMRTU], the informative prompt miscounts it
as an additional staged change.
Part of #12754
Force the encoding to not be dependent on the environment locale.
In particular on Windows, the encoding could default to an ANSI page
code, which would fail to load any file containing bytes 0x80+, i.e any
multi-byte UTF-8 character.
Closes#12748
Use `clap_complete` to generate completions for our xtasks. This comes
with two complications:
- Due to the unusual CLI of the whole xtask CLI definition being itself
a subcommand under `cargo` (via the `cargo xtask` alias), we need to
tell `clap_complete` that we're generating completions for `cargo`,
which is fairly straightforward to do via two new types which are only
used for generating completions.
- Our completions for `cargo xtask` only make sense within fish's
workspace, so we need to ensure that they are not active elsewhere.
`clap_complete` does not support adding such conditions, so we hack
them together by post-processing its output with sed.
Closes#12739
This command was added in git 2.54:
94f057755b/Documentation/RelNotes/2.54.0.adoc
Both subcommands (`reword` and `split`) take a commit-ish object to
target. `split` also optionally accepts filenames so I tried to handle
that by copying the pattern from existing completions.
Closes#12737
