h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-02 14:01:20 -03:00
Code Issues Packages Projects Releases Wiki Activity

input: remove unnecessary check in bracketed paste code path

Browse Source 
When "self.paste_is_buffering()" is true, "parse_escape_sequence()" explicitly
returns "None" instead of "Some(Escape)".  This is irrelevant because this
return value is never read, as long as "self.paste_is_buffering()" remains
true until "parse_escape_sequence()" returns, because the caller will return
early in that case. Paste buffering only ends if we actually read a complete
escape sequence (for ending bracketed paste).

Remove this extra branch.

(cherry picked from commit e5fdd77b09)
This commit is contained in:
Johannes Altmanninger
2025-05-17 07:30:33 +02:00
parent b9d9e7edc6
commit 68d2cafa6e
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/input_common.rs
View File

@@ -909,10 +909,7 @@ fn parse_escape_sequence(
have_escape_prefix: &mut bool,
) -> Option<KeyEvent> {
let Some(next) = self.try_readb(buffer) else {
if !self.paste_is_buffering() {
return Some(KeyEvent::from_raw(key::Escape));
}
return None;
return Some(KeyEvent::from_raw(key::Escape));
};
let invalid = KeyEvent::from_raw(key::Invalid);
if buffer.len() == 2 && next == b'\x1b' {