From 68d2cafa6e6c8d1efaa8eb0336db67caf7be9439 Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Sat, 17 May 2025 07:30:33 +0200 Subject: [PATCH] input: remove unnecessary check in bracketed paste code path When "self.paste_is_buffering()" is true, "parse_escape_sequence()" explicitly returns "None" instead of "Some(Escape)". This is irrelevant because this return value is never read, as long as "self.paste_is_buffering()" remains true until "parse_escape_sequence()" returns, because the caller will return early in that case. Paste buffering only ends if we actually read a complete escape sequence (for ending bracketed paste). Remove this extra branch. (cherry picked from commit e5fdd77b097c371a83f3641601541627347afda8) --- src/input_common.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/input_common.rs b/src/input_common.rs index 5c8c64f58..52eee9f39 100644 --- a/src/input_common.rs +++ b/src/input_common.rs @@ -909,10 +909,7 @@ fn parse_escape_sequence( have_escape_prefix: &mut bool, ) -> Option { let Some(next) = self.try_readb(buffer) else { - if !self.paste_is_buffering() { - return Some(KeyEvent::from_raw(key::Escape)); - } - return None; + return Some(KeyEvent::from_raw(key::Escape)); }; let invalid = KeyEvent::from_raw(key::Invalid); if buffer.len() == 2 && next == b'\x1b' {