confirm all desktops == empty array

This commit is contained in:
Peter Fajdiga
2024-03-09 19:42:31 +01:00
parent 12901e45ce
commit 0ea75d6348
4 changed files with 7 additions and 7 deletions

View File

@@ -60,7 +60,7 @@ interface KwinClient {
shade: boolean;
minimized: boolean;
frameGeometry: QmlRect;
desktops: KwinDesktop[]; // TODO: is empty = all desktops?
desktops: KwinDesktop[]; // empty array means all desktops
tile: Tile;
opacity: number;

View File

@@ -21,7 +21,7 @@ namespace Clients {
export function getKwinDesktopApprox(kwinClient: KwinClient) {
switch (kwinClient.desktops.length) {
case 0: // TODO: is empty = all desktops?
case 0:
return Workspace.currentDesktop;
case 1:
return kwinClient.desktops[0];
@@ -45,10 +45,10 @@ namespace Clients {
}
export function isOnVirtualDesktop(kwinClient: KwinClient, kwinDesktop: KwinDesktop) {
return kwinClient.desktops.length === 0 || kwinClient.desktops.includes(kwinDesktop); // TODO: is empty = all desktops?
return kwinClient.desktops.length === 0 || kwinClient.desktops.includes(kwinDesktop);
}
export function isOnOneOfVirtualDesktops(kwinClient: KwinClient, kwinDesktops: KwinDesktop[]) {
return kwinClient.desktops.length === 0 || kwinClient.desktops.some(d => kwinDesktops.includes(d)); // TODO: is empty = all desktops?
return kwinClient.desktops.length === 0 || kwinClient.desktops.some(d => kwinDesktops.includes(d));
}
}

View File

@@ -71,7 +71,7 @@ class DesktopManager {
public *getDesktopsForClient(kwinClient: KwinClient) {
// TODO: call `getDesktops` when Qt bug is fixed
const clientActivities = kwinClient.activities.length > 0 ? kwinClient.activities : this.kwinActivities.keys();
const clientDesktops = kwinClient.desktops.length > 0 ? kwinClient.desktops : this.kwinDesktops.keys(); // TODO: is empty = all desktops?
const clientDesktops = kwinClient.desktops.length > 0 ? kwinClient.desktops : this.kwinDesktops.keys();
for (const clientActivity of clientActivities) {
for (const clientDesktop of clientDesktops) {
yield this.getDesktop(clientActivity, clientDesktop);

View File

@@ -63,7 +63,7 @@ namespace ClientState {
});
manager.connect(kwinClient.desktopsChanged, () => {
const changedDesktops = oldDesktops.length === 0 || kwinClient.desktops.length === 0 ? // TODO: is empty = all desktops?
const changedDesktops = oldDesktops.length === 0 || kwinClient.desktops.length === 0 ?
[] :
union(oldDesktops, kwinClient.desktops);
world.do((clientManager, desktopManager) => {
@@ -79,7 +79,7 @@ namespace ClientState {
[] :
union(oldActivities, kwinClient.activities);
world.do((clientManager, desktopManager) => {
for (const desktop of desktopManager.getDesktops(changedActivities, kwinClient.desktops)) { // TODO: is empty = all desktops?
for (const desktop of desktopManager.getDesktops(changedActivities, kwinClient.desktops)) {
desktop.onPinsChanged();
}
});