mirror of
https://github.com/fish-shell/fish-shell.git
synced 2026-06-06 00:41:15 -03:00
Disallow Unicode conversion specifications.
This stops fish from accessing the `bool ok[UCHAR_MAX + 1]` table beyond allocated space potentially accessing memory that doesn't belong to fish, and crashing.
This commit is contained in:
@@ -732,7 +732,7 @@ no_more_flag_characters:
|
||||
|
||||
{
|
||||
wchar_t conversion = *f;
|
||||
if (! ok[conversion])
|
||||
if (conversion > 0xFF || ! ok[conversion])
|
||||
{
|
||||
this->fatal_error(_(L"%.*ls: invalid conversion specification"), (int)(f + 1 - direc_start), direc_start);
|
||||
return 0;
|
||||
|
||||
Reference in New Issue
Block a user