h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-22 20:31:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "exec: If a job includes a builtin, it stays in our pgroup"

Browse Source 
This reverts commit 711260593c.

This ended up breaking the tests; moreover it may have other problems
like preventing backgrounding.

Reopens #5855
This commit is contained in:
ridiculousfish
2019-05-24 17:27:20 -07:00
parent c79c92eb47
commit a5a5ccb73d
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/exec.cpp
View File

@@ -1019,19 +1019,6 @@ bool exec_job(parser_t &parser, shared_ptr<job_t> j) {
j->set_flag(job_flag_t::JOB_CONTROL, true);
}
// If there's a builtin in the pipeline,
// we let the whole job stay in our pgroup.
// This fixes `builtin history | less`, and still lets `read | cat` and `cat | read` work.
// (Note that bash forks for the builtin in these cases, but that's also why its `read` often can't communicate variables back)
if (j->pgid == INVALID_PID) {
for (const auto& proc : j->processes) {
if (proc->type == process_type_t::builtin) {
j->pgid = getpgrp();
break;
}
}
}
size_t stdout_read_limit = 0;
io_chain_t all_ios = j->all_io_redirections();