h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-06 17:31:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

Explain edge case in select_completion_in_direction()

Browse Source 
No functional change.
This commit is contained in:
Johannes Altmanninger
2022-07-28 10:38:28 +02:00
parent 1fc3d51dde
commit a584fc51d9
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/pager.cpp
View File

@@ -750,7 +750,10 @@ bool pager_t::select_next_completion_in_direction(selection_motion_t direction,
// rendering.cols is the first suggested visible completion; add the visible completion
// count to that to get the last one.
size_t visible_row_count = rendering.row_end - rendering.row_start;
if (visible_row_count == 0 || selected_completion_idx == PAGER_SELECTION_NONE) {
if (visible_row_count == 0) {
return true; // this happens if there was no room to draw the pager
}
if (selected_completion_idx == PAGER_SELECTION_NONE) {
return true; // this should never happen but be paranoid
}