h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-31 20:31:19 -03:00
Code Issues Packages Projects Releases Wiki Activity

Fix eager cloning

Browse Source 
https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
This commit is contained in:
Daniel Rainer
2025-06-07 00:22:52 +02:00
parent 08bf5c92a9
commit a138bc328b
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/builtins/path.rs
View File

@@ -885,10 +885,14 @@ fn path_filter_maybe_is(
// Collect arguments into a Vec so we can use .len()
let arguments_vec: Vec<_> = arguments.collect();
for (arg, _) in arguments_vec.iter().cloned().filter(|(f, _)| {
(opts.perms.is_none() && opts.types.is_none())
|| (filter_path(&opts, f, uid, gid) != opts.invert)
}) {
for (arg, _) in arguments_vec
.iter()
.filter(|&(f, _)| {
(opts.perms.is_none() && opts.types.is_none())
|| (filter_path(&opts, f, uid, gid) != opts.invert)
})
.cloned()
{
// If we don't have filters, check if it exists.
if opts.perms.is_none() && opts.types.is_none() {
let ok = waccess(&arg, F_OK) == 0;