h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-30 19:41:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

src/exec: drop unused parameter in can_use_posix_spawn_for_job

Browse Source 
Process object is not checked since 084ff64f4f.
This commit is contained in:
David Adam
2019-02-10 15:57:06 +08:00
parent 0377198fc8
commit 662708e72d
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/exec.cpp
View File

@@ -304,8 +304,7 @@ void internal_exec_helper(parser_t &parser, parsed_source_ref_t parsed_source, t
// To avoid the race between the caller calling tcsetpgrp() and the client checking the
// foreground process group, we don't use posix_spawn if we're going to foreground the process. (If
// we use fork(), we can call tcsetpgrp after the fork, before the exec, and avoid the race).
static bool can_use_posix_spawn_for_job(const std::shared_ptr<job_t> &job,
const process_t *process) {
static bool can_use_posix_spawn_for_job(const std::shared_ptr<job_t> &job) {
if (job->get_flag(job_flag_t::JOB_CONTROL)) { //!OCLINT(collapsible if statements)
// We are going to use job control; therefore when we launch this job it will get its own
// process group ID. But will it be foregrounded?
@@ -642,7 +641,7 @@ static bool exec_external_command(env_stack_t &vars, const std::shared_ptr<job_t
#if FISH_USE_POSIX_SPAWN
// Prefer to use posix_spawn, since it's faster on some systems like OS X.
bool use_posix_spawn = g_use_posix_spawn && can_use_posix_spawn_for_job(j, p);
bool use_posix_spawn = g_use_posix_spawn && can_use_posix_spawn_for_job(j);
if (use_posix_spawn) {
g_fork_count++; // spawn counts as a fork+exec
// Create posix spawn attributes and actions.