h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-06 08:51:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

Minor refactoring of add_to_history

Browse Source 
Preparation for other refactoring in the future.
This commit is contained in:
Peter Ammon
2026-01-04 12:33:53 -08:00
parent af00695383
commit 62cc117c12
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/reader/reader.rs
View File

@@ -6111,19 +6111,20 @@ fn add_to_history(&mut self) {
// Remove ephemeral items - even if the text is empty.
self.history.remove_ephemeral_items();
if !text.is_empty() {
// Mark this item as ephemeral if should_add_to_history says no (#615).
let mode = if !self.should_add_to_history(&text) {
PersistenceMode::Ephemeral
} else if in_private_mode(self.vars()) {
PersistenceMode::Memory
} else {
PersistenceMode::Disk
};
self.history
.add_pending_with_file_detection(&text, &self.parser.variables, mode);
if text.is_empty() {
return;
}
// Mark this item as ephemeral if should_add_to_history says no (#615).
let mode = if !self.should_add_to_history(&text) {
PersistenceMode::Ephemeral
} else if in_private_mode(self.vars()) {
PersistenceMode::Memory
} else {
PersistenceMode::Disk
};
self.history
.add_pending_with_file_detection(&text, &self.parser.variables, mode);
}
/// Check if we have background jobs that we have not warned about.