h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-22 20:31:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

[math] Improve error formatting

Browse Source 
This looked like

    math: Error in expression
    'sin(5,4)'
          ^
    Too many arguments

Now it looks like

    math: Too many arguments
    'sin(5,4)'
          ^
This commit is contained in:
Fabian Homborg
2018-02-15 15:00:11 +01:00
parent 0fa0b620b3
commit 4f56ce6d33
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/builtin_math.cpp
View File

@@ -152,11 +152,9 @@ static int evaluate_expression(const wchar_t *cmd, parser_t &parser, io_streams_
}
} else {
// TODO: Better error reporting!
streams.err.append(L"math: Error in expression\n");
streams.err.append_format(L"%ls: Error: %ls\n", cmd, math_describe_error(error).c_str());
streams.err.append_format(L"'%ls'\n", expression.c_str());
streams.err.append_format(L"%*lc^\n", error.position - 1, L' ');
streams.err.append(math_describe_error(error));
streams.err.append(L"\n");
}
free(narrow_str);
free(saved_locale);