h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-06 00:41:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Drop realpath test built on assumption PWD cannot be a symlink

Browse Source 
The final test in `realpath.in` was based on the no-longer-valid
assumption that $PWD cannot be a symlink. Since the recent changes in
fish 3.0 to allow `cd`ing into "virtual" directories preserving symlinks
as-is, when `make test` was  run from a path that contained a symlink
component, this test would fail the `pwd-resolved-to-itself` check.

As the test is not designed to initialize then cd into an absolute path
guaranteed to not be symbolic, so this final check is just wrong.
This commit is contained in:
Mahmoud Al-Qudsi
2019-03-28 19:01:10 -05:00
parent f8b2e818ed
commit 0be7903859
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/realpath.in
View File

@@ -73,13 +73,4 @@ else
echo "fish-symlink/symlink_file not handled correctly: $real_path != expected_real_path" >&2
end
# The $PWD should undergo no further transformations because it should already
# be a "realpath".
set -l real_path (builtin realpath $PWD)
if test "$real_path" = "$PWD"
echo "pwd-resolved-to-itself"
else
echo "unexpected pwd-resolved-to-itself failure: $real_path != $PWD" >&2
end
exit 0