From 0be79038590d3473b75252bf50ade2f62ea9c207 Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Thu, 28 Mar 2019 19:01:10 -0500 Subject: [PATCH] Drop realpath test built on assumption PWD cannot be a symlink The final test in `realpath.in` was based on the no-longer-valid assumption that $PWD cannot be a symlink. Since the recent changes in fish 3.0 to allow `cd`ing into "virtual" directories preserving symlinks as-is, when `make test` was run from a path that contained a symlink component, this test would fail the `pwd-resolved-to-itself` check. As the test is not designed to initialize then cd into an absolute path guaranteed to not be symbolic, so this final check is just wrong. --- tests/realpath.in | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/realpath.in b/tests/realpath.in index fc39889fe..abaccf4cd 100644 --- a/tests/realpath.in +++ b/tests/realpath.in @@ -73,13 +73,4 @@ else echo "fish-symlink/symlink_file not handled correctly: $real_path != expected_real_path" >&2 end -# The $PWD should undergo no further transformations because it should already -# be a "realpath". -set -l real_path (builtin realpath $PWD) -if test "$real_path" = "$PWD" - echo "pwd-resolved-to-itself" -else - echo "unexpected pwd-resolved-to-itself failure: $real_path != $PWD" >&2 -end - exit 0