Track individual sessions (local and remote id) for each operation

This allows multiple operations to be performed simultaneously

.github/workflows/python-build.yml

@@ -0,0 +1,38 @@
+name: Python - Build packages & Release
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+  release:
+    types: [created]
+
+jobs:
+  build-python-packages:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Build Python stubs
+        run: cargo run --bin stub_gen
+
+      - name: Install Python build dependencies
+        run: pip install maturin==1.8.2
+
+      - name: Build Python packages
+        run: maturin build --sdist --release -m pyadb_client/Cargo.toml
+
+      - name: Publish Python packages
+        if: github.event_name == 'release' && github.event.action == 'created'
+        run: maturin publish -m pyadb_client/Cargo.toml --non-interactive
+        env:
+          MATURIN_PYPI_TOKEN: ${{ secrets.MATURIN_PYPI_TOKEN }}
+
+      - name: "Publish GitHub artefacts"
+        if: github.event_name == 'release' && github.event.action == 'created'
+        uses: softprops/action-gh-release@v2
+        with:
+          files: |
+            target/wheels/pyadb_client*.whl
+            target/wheels/pyadb_client*.tar.gz

.github/workflows/rust-build.yml

@@ -1,15 +1,23 @@
 name: Rust - Build
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - main
+  pull_request:
 
 env:
   CARGO_TERM_COLOR: always
 
 jobs:
-  build-release:
-    name: "build-release"
-    runs-on: ubuntu-latest
+  build:
+    name: "Build on ${{ matrix.os }}"
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+
     steps:
     - uses: actions/checkout@v4
     - name: Build project
-      run: cargo build --release
+      run: cargo build --release --all-features

.github/workflows/rust-quality.yml

@@ -1,6 +1,10 @@
 name: Rust - Quality
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - main
+  pull_request:
 
 env:
   CARGO_TERM_COLOR: always
@@ -13,7 +17,7 @@ jobs:
       - uses: actions/checkout@v4
       - run: rustup component add clippy
       - name: Run clippy
-        run : cargo clippy
+        run: cargo clippy --all-features
 
   fmt:
     name: "fmt"
@@ -21,7 +25,17 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run formatter
-        run : cargo fmt --all --check
+        run: cargo fmt --all --check
+
+  doc:
+    name: "doc"
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Run doc
+        run: cargo doc --all-features --no-deps
+        env:
+          RUSTDOCFLAGS: "-D warnings"
 
   tests:
     name: "tests"
@@ -29,4 +43,4 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run tests
-        run: cargo test --verbose
+        run: cargo test --verbose --all-features

.github/workflows/rust-release.yml

@@ -4,47 +4,101 @@ on:
   release:
     types: [created]
 
+env:
+  CARGO_TERM_COLOR: always
+
 jobs:
-  create-release:
+  release-linux:
+    name: Linux - Build and Publish
     runs-on: ubuntu-latest
 
     steps:
-      - name: "Checkout repository"
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
 
-      - name: "Set up Rust"
+      - name: Set up Rust
         uses: actions-rs/toolchain@v1
         with:
           toolchain: stable
           override: true
 
-      - name: "Install dependencies"
+      - name: Install dependencies
         run: |
           sudo apt update
           sudo apt install -y rpm
           cargo install cargo-deb
           cargo install cargo-generate-rpm
 
-      - name: "build-release"
-        run: cargo build --release
+      - name: Publish crates
+        run: |
+          cargo publish -p adb_client --token ${CRATES_IO_TOKEN}
+          cargo publish -p adb_cli --token ${CRATES_IO_TOKEN}
+        env:
+          CRATES_IO_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
 
-      - name: "Build DEB package"
+      - name: Build release
+        run: cargo build --all-features --release
+
+      - name: Rename binary
+        run: mv target/release/adb_cli target/release/adb_cli-linux
+
+      - name: Build DEB package
         run: cargo deb -p adb_cli
 
-      - name: "Build RPM package"
+      - name: Build RPM package
         run: cargo generate-rpm -p adb_cli
 
-      - name: "Publish GitHub artefacts"
+      - name: Upload Linux artifacts
         uses: softprops/action-gh-release@v2
         with:
           files: |
             target/debian/*.deb
             target/generate-rpm/*.rpm
-            target/release/adb_cli
+            target/release/adb_cli-linux
 
-      - name: "Publish crates"
-        run: |
-          cargo publish -p adb_client --token ${CRATES_IO_TOKEN}
-          cargo publish -p adb_cli --token ${CRATES_IO_TOKEN}
-        env:
-          CRATES_IO_TOKEN: ${{ secrets.CRATES_IO_TOKEN }}
+  release-macos:
+    name: macOS - Build Binary
+    runs-on: macos-13
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+
+      - name: Build release
+        run: cargo build --all-features --release
+
+      - name: Rename binary
+        run: mv target/release/adb_cli target/release/adb_cli-macos
+
+      - name: Upload macOS binary
+        uses: softprops/action-gh-release@v2
+        with:
+          files: target/release/adb_cli-macos
+
+  release-windows:
+    name: Windows - Build Binary
+    runs-on: windows-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Rust
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+
+      - name: Build release
+        run: cargo build --all-features --release
+
+      - name: Rename binary
+        run: Rename-Item -Path target/release/adb_cli.exe -NewName adb_cli-windows.exe
+
+      - name: Upload Windows binary
+        uses: softprops/action-gh-release@v2
+        with:
+          files: target/release/adb_cli-windows.exe

.gitignore

@@ -1,3 +1,6 @@
 target
-Cargo.lock
-.vscode
+/Cargo.lock
+/.vscode
+venv
+/.mypy_cache
+pyadb_client/pyadb_client.pyi

Cargo.toml

@@ -1,15 +1,15 @@
 [workspace]
-members = ["adb_cli", "adb_client"]
+members = ["adb_cli", "adb_client", "pyadb_client"]
 resolver = "2"
 
 [workspace.package]
 authors = ["Corentin LIAUD"]
-edition = "2021"
+edition = "2024"
 homepage = "https://github.com/cocool97/adb_client"
 keywords = ["adb", "android", "tcp", "usb"]
-license-file = "LICENSE"
+license = "MIT"
 repository = "https://github.com/cocool97/adb_client"
-version = "2.0.2"
+version = "2.1.13"
 
 # To build locally when working on a new release
 [patch.crates-io]

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) [year] [fullname]
+Copyright (c) 2023-2024 Corentin LIAUD
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.md

@@ -8,36 +8,53 @@
         <a href="https://crates.io/crates/adb_client">
             <img alt="crates.io" src="https://img.shields.io/crates/v/adb_client.svg"/>
         </a>
+        <a href="https://github.com/cocool97/adb_client/actions">
+            <img alt="ci status" src="https://github.com/cocool97/adb_client/actions/workflows/rust-build.yml/badge.svg"/>
+        </a>
         <a href="https://deps.rs/repo/github/cocool97/adb_client">
             <img alt="dependency status" src="https://deps.rs/repo/github/cocool97/adb_client/status.svg"/>
         </a>
+        <a href="https://opensource.org/licenses/MIT">
+            <img alt="dependency status" src="https://img.shields.io/badge/License-MIT-yellow.svg"/>
+        </a>
     </p>
 </p>
 
 Main features of this library:
 
 - Full Rust, don't use `adb *` shell commands to interact with devices
-- Supports:
-  - **TCP/IP** protocol, using ADB server as a proxy (standard behavior when using `adb` CLI)
-  - **USB** protocol, interacting directly with end devices
+- Supports
+  - Using ADB server as a proxy (standard behavior when using `adb` CLI)
+  - Connecting directly to end devices (without using adb-server)
+    - Over **USB**
+    - Over **TCP/IP**
 - Implements hidden `adb` features, like `framebuffer`
 - Highly configurable
+- Provides wrappers to use directly from Python code
 - Easy to use !
 
 ## adb_client
 
-Rust library implementing both ADB protocols and providing a high-level abstraction over many supported commands.
+Rust library implementing both ADB protocols (server and end-devices) and providing a high-level abstraction over the many supported commands.
 
-Improved documentation [here](./adb_client/README.md).
+Improved documentation available [here](./adb_client/README.md).
 
 ## adb_cli
 
-Rust binary providing an improved version of official `adb` CLI, wrapping `adb_client` library. Can act as an usage example of the library.
+Rust binary providing an improved version of Google's official `adb` CLI, by using `adb_client` library.
+Provides a "real-world" usage example of this library.
 
-Improved documentation [here](./adb_cli/README.md).
+Improved documentation available [here](./adb_cli/README.md).
+
+## pyadb_client
+
+Python wrapper using `adb_client` library to export classes usable directly from a Python environment.
+
+Improved documentation available [here](./pyadb_client/README.md)
 
 ## Related publications
 
 - [Diving into ADB protocol internals (1/2)](https://www.synacktiv.com/publications/diving-into-adb-protocol-internals-12)
+- [Diving into ADB protocol internals (2/2)](https://www.synacktiv.com/publications/diving-into-adb-protocol-internals-22)
 
 Some features may still be missing, all pull requests are welcome !

adb_cli/Cargo.toml

@@ -3,18 +3,18 @@ authors.workspace = true
 description = "Rust ADB (Android Debug Bridge) CLI"
 edition.workspace = true
 keywords.workspace = true
-license-file.workspace = true
+license.workspace = true
 name = "adb_cli"
 readme = "README.md"
 repository.workspace = true
 version.workspace = true
 
 [dependencies]
-adb_client = { version = "2.0.1" }
-anyhow = { version = "1.0.89" }
-clap = { version = "4.5.18", features = ["derive"] }
+adb_client = { version = "^2.0.0" }
+anyhow = { version = "1.0.94" }
+clap = { version = "4.5.23", features = ["derive"] }
 env_logger = { version = "0.11.5" }
-log = { version = "0.4.22" }
+log = { version = "0.4.26" }
 
 [target.'cfg(unix)'.dependencies]
 termios = { version = "0.3.3" }

adb_cli/README.md

@@ -18,38 +18,29 @@ Usage is quite simple, and tends to look like `adb`:
 - To use ADB server as a proxy:
 
 ```bash
-user@laptop ~/adb_client (main)> adb_cli --help
-Rust ADB (Android Debug Bridge) CLI
+user@laptop ~/adb_client (main)> adb_cli local --help
+Device related commands using server
 
-Usage: adb_cli [OPTIONS] <COMMAND>
+Usage: adb_cli local [OPTIONS] <COMMAND>
 
 Commands:
-  host-features  List available server features
-  push           Push a file on device
-  pull           Pull a file from device
-  list           List a directory on device
-  stat           Stat a file specified on device
   shell          Spawn an interactive shell or run a list of commands on the device
+  pull           Pull a file from device
+  push           Push a file on device
+  stat           Stat a file on device
+  run            Run an activity on device specified by the intent
   reboot         Reboot the device
+  install        Install an APK on device
   framebuffer    Dump framebuffer of device
+  host-features  List available server features
+  list           List a directory on device
   logcat         Get logs of device
-  version        Print current ADB version
-  kill           Ask ADB server to quit immediately
-  devices        List connected devices
-  track-devices  Track new devices showing up
-  pair           Pair device with a given code
-  connect        Connect device over WI-FI
-  disconnect     Disconnect device over WI-FI
-  sms            Send a SMS with given phone number and given content
-  rotate         Rotate device screen from 90°
   help           Print this message or the help of the given subcommand(s)
 
 Options:
-  -d, --debug              
   -a, --address <ADDRESS>  [default: 127.0.0.1:5037]
   -s, --serial <SERIAL>    Serial id of a specific device. Every request will be sent to this device
   -h, --help               Print help
-  -V, --version            Print version
 ```
 
 - To interact directly with end devices

adb_cli/src/adb_termios.rs

@@ -2,7 +2,7 @@
 
 use std::os::unix::prelude::{AsRawFd, RawFd};
 
-use termios::{tcsetattr, Termios, TCSANOW, VMIN, VTIME};
+use termios::{TCSANOW, Termios, VMIN, VTIME, tcsetattr};
 
 use crate::Result;
 
@@ -36,7 +36,7 @@ impl Drop for ADBTermios {
     fn drop(&mut self) {
         // Custom drop implementation, restores previous termios structure.
         if let Err(e) = tcsetattr(self.fd, TCSANOW, &self.old_termios) {
-            log::error!("Error while droping ADBTermios: {e}")
+            log::error!("Error while dropping ADBTermios: {e}")
         }
     }
 }

adb_cli/src/commands/emu.rs

@@ -1,12 +0,0 @@
-use clap::Parser;
-
-#[derive(Parser, Debug)]
-pub enum EmuCommand {
-    /// Send a SMS with given phone number and given content
-    Sms {
-        phone_number: String,
-        content: String,
-    },
-    /// Rotate device screen from 90°
-    Rotate,
-}

adb_cli/src/commands/host.rs

@@ -1,24 +0,0 @@
-use std::net::SocketAddrV4;
-
-use clap::Parser;
-
-#[derive(Parser, Debug)]
-pub enum HostCommand {
-    /// Print current ADB version.
-    Version,
-    /// Ask ADB server to quit immediately.
-    Kill,
-    /// List connected devices.
-    Devices {
-        #[clap(short = 'l', long = "long")]
-        long: bool,
-    },
-    /// Track new devices showing up.
-    TrackDevices,
-    /// Pair device with a given code
-    Pair { address: SocketAddrV4, code: String },
-    /// Connect device over WI-FI
-    Connect { address: SocketAddrV4 },
-    /// Disconnect device over WI-FI
-    Disconnect { address: SocketAddrV4 },
-}

adb_cli/src/commands/local.rs

@@ -1,31 +0,0 @@
-use clap::Parser;
-
-use crate::models::RebootTypeCommand;
-
-#[derive(Parser, Debug)]
-pub enum LocalCommand {
-    /// List available server features.
-    HostFeatures,
-    /// Push a file on device
-    Push { filename: String, path: String },
-    /// Pull a file from device
-    Pull { path: String, filename: String },
-    /// List a directory on device
-    List { path: String },
-    /// Stat a file specified on device
-    Stat { path: String },
-    /// Spawn an interactive shell or run a list of commands on the device
-    Shell { commands: Vec<String> },
-    /// Reboot the device
-    Reboot {
-        #[clap(subcommand)]
-        reboot_type: RebootTypeCommand,
-    },
-    /// Dump framebuffer of device
-    Framebuffer { path: String },
-    /// Get logs of device
-    Logcat {
-        /// Path to output file (created if not exists)
-        path: Option<String>,
-    },
-}

adb_cli/src/commands/mod.rs

@@ -1,9 +0,0 @@
-mod emu;
-mod host;
-mod local;
-mod usb;
-
-pub use emu::EmuCommand;
-pub use host::HostCommand;
-pub use local::LocalCommand;
-pub use usb::{UsbCommand, UsbCommands};

adb_cli/src/handlers/emulator_commands.rs

@@ -0,0 +1,20 @@
+use adb_client::ADBEmulatorDevice;
+
+use crate::models::{EmuCommand, EmulatorCommand};
+
+pub fn handle_emulator_commands(emulator_command: EmulatorCommand) -> anyhow::Result<()> {
+    let mut emulator = ADBEmulatorDevice::new(emulator_command.serial, None)?;
+
+    match emulator_command.command {
+        EmuCommand::Sms {
+            phone_number,
+            content,
+        } => {
+            emulator.send_sms(&phone_number, &content)?;
+            log::info!("SMS sent to {phone_number}");
+        }
+        EmuCommand::Rotate => emulator.rotate()?,
+    }
+
+    Ok(())
+}

adb_cli/src/handlers/host_commands.rs

@@ -0,0 +1,82 @@
+use adb_client::{ADBServer, DeviceShort, MDNSBackend, Result, WaitForDeviceState};
+
+use crate::models::{HostCommand, MdnsCommand, ServerCommand};
+
+pub fn handle_host_commands(server_command: ServerCommand<HostCommand>) -> Result<()> {
+    let mut adb_server = ADBServer::new(server_command.address);
+
+    match server_command.command {
+        HostCommand::Version => {
+            let version = adb_server.version()?;
+            log::info!("Android Debug Bridge version {}", version);
+            log::info!("Package version {}-rust", std::env!("CARGO_PKG_VERSION"));
+        }
+        HostCommand::Kill => {
+            adb_server.kill()?;
+        }
+        HostCommand::Devices { long } => {
+            if long {
+                log::info!("List of devices attached (extended)");
+                for device in adb_server.devices_long()? {
+                    log::info!("{}", device);
+                }
+            } else {
+                log::info!("List of devices attached");
+                for device in adb_server.devices()? {
+                    log::info!("{}", device);
+                }
+            }
+        }
+        HostCommand::TrackDevices => {
+            let callback = |device: DeviceShort| {
+                log::info!("{}", device);
+                Ok(())
+            };
+            log::info!("Live list of devices attached");
+            adb_server.track_devices(callback)?;
+        }
+        HostCommand::Pair { address, code } => {
+            adb_server.pair(address, code)?;
+            log::info!("Paired device {address}");
+        }
+        HostCommand::Connect { address } => {
+            adb_server.connect_device(address)?;
+            log::info!("Connected to {address}");
+        }
+        HostCommand::Disconnect { address } => {
+            adb_server.disconnect_device(address)?;
+            log::info!("Disconnected {address}");
+        }
+        HostCommand::Mdns { subcommand } => match subcommand {
+            MdnsCommand::Check => {
+                let check = adb_server.mdns_check()?;
+                let server_status = adb_server.server_status()?;
+                match server_status.mdns_backend {
+                    MDNSBackend::Unknown => log::info!("unknown mdns backend..."),
+                    MDNSBackend::Bonjour => match check {
+                        true => log::info!("mdns daemon version [Bonjour]"),
+                        false => log::info!("ERROR: mdns daemon unavailable"),
+                    },
+                    MDNSBackend::OpenScreen => {
+                        log::info!("mdns daemon version [Openscreen discovery 0.0.0]")
+                    }
+                }
+            }
+            MdnsCommand::Services => {
+                log::info!("List of discovered mdns services");
+                for service in adb_server.mdns_services()? {
+                    log::info!("{}", service);
+                }
+            }
+        },
+        HostCommand::ServerStatus => {
+            log::info!("{}", adb_server.server_status()?);
+        }
+        HostCommand::WaitForDevice { transport } => {
+            log::info!("waiting for device to be connected...");
+            adb_server.wait_for_device(WaitForDeviceState::Device, transport)?;
+        }
+    }
+
+    Ok(())
+}

adb_cli/src/handlers/local_commands.rs

@@ -0,0 +1,35 @@
+use std::{fs::File, io::Write};
+
+use adb_client::ADBServerDevice;
+use anyhow::{Result, anyhow};
+
+use crate::models::LocalDeviceCommand;
+
+pub fn handle_local_commands(
+    mut device: ADBServerDevice,
+    local_device_commands: LocalDeviceCommand,
+) -> Result<()> {
+    match local_device_commands {
+        LocalDeviceCommand::HostFeatures => {
+            let features = device
+                .host_features()?
+                .iter()
+                .map(|v| v.to_string())
+                .reduce(|a, b| format!("{a},{b}"))
+                .ok_or(anyhow!("cannot list features"))?;
+            log::info!("Available host features: {features}");
+
+            Ok(())
+        }
+        LocalDeviceCommand::List { path } => Ok(device.list(path)?),
+        LocalDeviceCommand::Logcat { path } => {
+            let writer: Box<dyn Write> = if let Some(path) = path {
+                let f = File::create(path)?;
+                Box::new(f)
+            } else {
+                Box::new(std::io::stdout())
+            };
+            Ok(device.get_logs(writer)?)
+        }
+    }
+}

adb_cli/src/handlers/mod.rs

@@ -0,0 +1,7 @@
+mod emulator_commands;
+mod host_commands;
+mod local_commands;
+
+pub use emulator_commands::handle_emulator_commands;
+pub use host_commands::handle_host_commands;
+pub use local_commands::handle_local_commands;

adb_cli/src/main.rs

@@ -3,219 +3,161 @@
 #[cfg(any(target_os = "linux", target_os = "macos"))]
 mod adb_termios;
 
-mod commands;
+mod handlers;
 mod models;
+mod utils;
 
-use adb_client::{ADBDeviceExt, ADBEmulatorDevice, ADBServer, ADBUSBDevice, DeviceShort};
-use anyhow::{anyhow, Result};
+use adb_client::{
+    ADBDeviceExt, ADBServer, ADBServerDevice, ADBTcpDevice, ADBUSBDevice, MDNSDiscoveryService,
+};
+
+#[cfg(any(target_os = "linux", target_os = "macos"))]
+use adb_termios::ADBTermios;
+
+use anyhow::Result;
 use clap::Parser;
-use commands::{EmuCommand, HostCommand, LocalCommand, UsbCommands};
-use models::{Command, Opts};
+use handlers::{handle_emulator_commands, handle_host_commands, handle_local_commands};
+use models::{DeviceCommands, LocalCommand, MainCommand, Opts};
+use std::collections::HashMap;
 use std::fs::File;
 use std::io::Write;
 use std::path::Path;
+use utils::setup_logger;
 
 fn main() -> Result<()> {
-    let opt = Opts::parse();
-    env_logger::init();
+    // This depends on `clap`
+    let opts = Opts::parse();
 
-    match opt.command {
-        Command::Local(local) => {
-            let mut adb_server = ADBServer::new(opt.address);
+    // SAFETY:
+    // We are assuming the entire process is single-threaded
+    // at this point.
+    // This seems true for the current version of `clap`,
+    // but there's no guarantee for future updates
+    unsafe { setup_logger(opts.debug) };
 
-            let mut device = match opt.serial {
-                Some(serial) => adb_server.get_device_by_name(&serial)?,
-                None => adb_server.get_device()?,
+    // Directly handling methods / commands that aren't linked to [`ADBDeviceExt`] trait.
+    // Other methods just have to create a concrete [`ADBDeviceExt`] instance, and return it.
+    // This instance will then be used to execute desired command.
+    let (mut device, commands) = match opts.command {
+        MainCommand::Host(server_command) => return Ok(handle_host_commands(server_command)?),
+        MainCommand::Emu(emulator_command) => return handle_emulator_commands(emulator_command),
+        MainCommand::Local(server_command) => {
+            // Must start server to communicate with device, but only if this is a local one.
+            let server_address_ip = server_command.address.ip();
+            if server_address_ip.is_loopback() || server_address_ip.is_unspecified() {
+                ADBServer::start(&HashMap::default(), &None);
+            }
+
+            let device = match server_command.serial {
+                Some(serial) => ADBServerDevice::new(serial, Some(server_command.address)),
+                None => ADBServerDevice::autodetect(Some(server_command.address)),
             };
 
-            match local {
-                LocalCommand::Pull { path, filename } => {
-                    let mut output = File::create(Path::new(&filename))?;
-                    device.pull(&path, &mut output)?;
-                    log::info!("Downloaded {path} as {filename}");
-                }
-                LocalCommand::Push { filename, path } => {
-                    let mut input = File::open(Path::new(&filename))?;
-                    device.push(&mut input, &path)?;
-                    log::info!("Uploaded {filename} to {path}");
-                }
-                LocalCommand::List { path } => {
-                    device.list(path)?;
-                }
-                LocalCommand::Stat { path } => {
-                    let stat_response = device.stat(path)?;
-                    println!("{}", stat_response);
-                }
-                LocalCommand::Shell { commands } => {
-                    if commands.is_empty() {
-                        // Need to duplicate some code here as ADBTermios [Drop] implementation resets terminal state.
-                        // Using a scope here would call drop() too early..
-                        #[cfg(any(target_os = "linux", target_os = "macos"))]
-                        {
-                            let mut adb_termios = adb_termios::ADBTermios::new(std::io::stdin())?;
-                            adb_termios.set_adb_termios()?;
-                            device.shell(std::io::stdin(), std::io::stdout())?;
-                        }
-
-                        #[cfg(not(any(target_os = "linux", target_os = "macos")))]
-                        {
-                            device.shell(std::io::stdin(), std::io::stdout())?;
-                        }
-                    } else {
-                        device.shell_command(commands, std::io::stdout())?;
-                    }
-                }
-                LocalCommand::HostFeatures => {
-                    let features = device
-                        .host_features()?
-                        .iter()
-                        .map(|v| v.to_string())
-                        .reduce(|a, b| format!("{a},{b}"))
-                        .ok_or(anyhow!("cannot list features"))?;
-                    log::info!("Available host features: {features}");
-                }
-                LocalCommand::Reboot { reboot_type } => {
-                    log::info!("Reboots device in mode {:?}", reboot_type);
-                    device.reboot(reboot_type.into())?
-                }
-                LocalCommand::Framebuffer { path } => {
-                    device.framebuffer(&path)?;
-                    log::info!("Framebuffer dropped: {path}");
-                }
-                LocalCommand::Logcat { path } => {
-                    let writer: Box<dyn Write> = if let Some(path) = path {
-                        let f = File::create(path)?;
-                        Box::new(f)
-                    } else {
-                        Box::new(std::io::stdout())
-                    };
-                    device.get_logs(writer)?;
+            match server_command.command {
+                LocalCommand::DeviceCommands(device_commands) => (device.boxed(), device_commands),
+                LocalCommand::LocalDeviceCommand(local_device_command) => {
+                    return handle_local_commands(device, local_device_command);
                 }
             }
         }
-        Command::Host(host) => {
-            let mut adb_server = ADBServer::new(opt.address);
-
-            match host {
-                HostCommand::Version => {
-                    let version = adb_server.version()?;
-                    log::info!("Android Debug Bridge version {}", version);
-                    log::info!("Package version {}-rust", std::env!("CARGO_PKG_VERSION"));
-                }
-                HostCommand::Kill => {
-                    adb_server.kill()?;
-                }
-                HostCommand::Devices { long } => {
-                    if long {
-                        log::info!("List of devices attached (extended)");
-                        for device in adb_server.devices_long()? {
-                            log::info!("{}", device);
-                        }
-                    } else {
-                        log::info!("List of devices attached");
-                        for device in adb_server.devices()? {
-                            log::info!("{}", device);
-                        }
-                    }
-                }
-                HostCommand::TrackDevices => {
-                    let callback = |device: DeviceShort| {
-                        log::info!("{}", device);
-                        Ok(())
-                    };
-                    log::info!("Live list of devices attached");
-                    adb_server.track_devices(callback)?;
-                }
-                HostCommand::Pair { address, code } => {
-                    adb_server.pair(address, code)?;
-                    log::info!("Paired device {address}");
-                }
-                HostCommand::Connect { address } => {
-                    adb_server.connect_device(address)?;
-                    log::info!("Connected to {address}");
-                }
-                HostCommand::Disconnect { address } => {
-                    adb_server.disconnect_device(address)?;
-                    log::info!("Disconnected {address}");
-                }
-            }
-        }
-        Command::Emu(emu) => {
-            let mut emulator = match opt.serial {
-                Some(serial) => ADBEmulatorDevice::new(serial, None)?,
-                None => return Err(anyhow!("Serial must be set to use emulators !")),
-            };
-
-            match emu {
-                EmuCommand::Sms {
-                    phone_number,
-                    content,
-                } => {
-                    emulator.send_sms(&phone_number, &content)?;
-                    log::info!("SMS sent to {phone_number}");
-                }
-                EmuCommand::Rotate => emulator.rotate()?,
-            }
-        }
-        Command::Usb(usb) => {
-            let mut device = match (usb.vendor_id, usb.product_id) {
-                (Some(vid), Some(pid)) => match usb.path_to_private_key {
+        MainCommand::Usb(usb_command) => {
+            let device = match (usb_command.vendor_id, usb_command.product_id) {
+                (Some(vid), Some(pid)) => match usb_command.path_to_private_key {
                     Some(pk) => ADBUSBDevice::new_with_custom_private_key(vid, pid, pk)?,
                     None => ADBUSBDevice::new(vid, pid)?,
                 },
-
-                (None, None) => match usb.path_to_private_key {
+                (None, None) => match usb_command.path_to_private_key {
                     Some(pk) => ADBUSBDevice::autodetect_with_custom_private_key(pk)?,
                     None => ADBUSBDevice::autodetect()?,
                 },
-
                 _ => {
-                    anyhow::bail!("please either supply values for both the --vendor-id and --product-id flags or none.");
+                    anyhow::bail!(
+                        "please either supply values for both the --vendor-id and --product-id flags or none."
+                    );
                 }
             };
+            (device.boxed(), usb_command.commands)
+        }
+        MainCommand::Tcp(tcp_command) => {
+            let device = ADBTcpDevice::new(tcp_command.address)?;
+            (device.boxed(), tcp_command.commands)
+        }
+        MainCommand::Mdns => {
+            let mut service = MDNSDiscoveryService::new()?;
 
-            match usb.commands {
-                UsbCommands::Shell { commands } => {
-                    if commands.is_empty() {
-                        // Need to duplicate some code here as ADBTermios [Drop] implementation resets terminal state.
-                        // Using a scope here would call drop() too early..
-                        #[cfg(any(target_os = "linux", target_os = "macos"))]
-                        {
-                            let mut adb_termios = adb_termios::ADBTermios::new(std::io::stdin())?;
-                            adb_termios.set_adb_termios()?;
-                            device.shell(std::io::stdin(), std::io::stdout())?;
-                        }
+            let (tx, rx) = std::sync::mpsc::channel();
+            service.start(tx)?;
 
-                        #[cfg(not(any(target_os = "linux", target_os = "macos")))]
-                        {
-                            device.shell(std::io::stdin(), std::io::stdout())?;
-                        }
-                    } else {
-                        device.shell_command(commands, std::io::stdout())?;
-                    }
-                }
-                UsbCommands::Pull {
-                    source,
-                    destination,
-                } => {
-                    let mut output = File::create(Path::new(&destination))?;
-                    device.pull(&source, &mut output)?;
-                    log::info!("Downloaded {source} as {destination}");
-                }
-                UsbCommands::Stat { path } => {
-                    let stat_response = device.stat(&path)?;
-                    println!("{}", stat_response);
-                }
-                UsbCommands::Reboot { reboot_type } => {
-                    log::info!("Reboots device in mode {:?}", reboot_type);
-                    device.reboot(reboot_type.into())?
-                }
-                UsbCommands::Push { filename, path } => {
-                    let mut input = File::open(Path::new(&filename))?;
-                    device.push(&mut input, &path)?;
-                    log::info!("Uploaded {filename} to {path}");
-                }
+            log::info!("Starting mdns discovery...");
+            while let Ok(device) = rx.recv() {
+                log::info!(
+                    "Found device {} with addresses {:?}",
+                    device.fullname,
+                    device.addresses
+                )
             }
+
+            return Ok(service.shutdown()?);
+        }
+    };
+
+    match commands {
+        DeviceCommands::Shell { commands } => {
+            if commands.is_empty() {
+                // Need to duplicate some code here as ADBTermios [Drop] implementation resets terminal state.
+                // Using a scope here would call drop() too early..
+                #[cfg(any(target_os = "linux", target_os = "macos"))]
+                {
+                    let mut adb_termios = ADBTermios::new(std::io::stdin())?;
+                    adb_termios.set_adb_termios()?;
+                    device.shell(&mut std::io::stdin(), Box::new(std::io::stdout()))?;
+                }
+
+                #[cfg(not(any(target_os = "linux", target_os = "macos")))]
+                {
+                    device.shell(&mut std::io::stdin(), Box::new(std::io::stdout()))?;
+                }
+            } else {
+                let commands: Vec<&str> = commands.iter().map(|v| v.as_str()).collect();
+                device.shell_command(&commands, &mut std::io::stdout())?;
+            }
+        }
+        DeviceCommands::Pull {
+            source,
+            destination,
+        } => {
+            let mut output = File::create(Path::new(&destination))?;
+            device.pull(&source, &mut output)?;
+            log::info!("Downloaded {source} as {destination}");
+        }
+        DeviceCommands::Stat { path } => {
+            let stat_response = device.stat(&path)?;
+            println!("{}", stat_response);
+        }
+        DeviceCommands::Reboot { reboot_type } => {
+            log::info!("Reboots device in mode {:?}", reboot_type);
+            device.reboot(reboot_type.into())?
+        }
+        DeviceCommands::Push { filename, path } => {
+            let mut input = File::open(Path::new(&filename))?;
+            device.push(&mut input, &path)?;
+            log::info!("Uploaded {filename} to {path}");
+        }
+        DeviceCommands::Run { package, activity } => {
+            let output = device.run_activity(&package, &activity)?;
+            std::io::stdout().write_all(&output)?;
+        }
+        DeviceCommands::Install { path } => {
+            log::info!("Starting installation of APK {}...", path.display());
+            device.install(&path)?;
+        }
+        DeviceCommands::Uninstall { package } => {
+            log::info!("Uninstalling the package {}...", package);
+            device.uninstall(&package)?;
+        }
+        DeviceCommands::Framebuffer { path } => {
+            device.framebuffer(&path)?;
+            log::info!("Successfully dumped framebuffer at path {path}");
         }
     }
 

adb_cli/src/models/device.rs

@@ -0,0 +1,46 @@
+use std::path::PathBuf;
+
+use clap::Parser;
+
+use super::RebootTypeCommand;
+
+#[derive(Parser, Debug)]
+pub enum DeviceCommands {
+    /// Spawn an interactive shell or run a list of commands on the device
+    Shell { commands: Vec<String> },
+    /// Pull a file from device
+    Pull { source: String, destination: String },
+    /// Push a file on device
+    Push { filename: String, path: String },
+    /// Stat a file on device
+    Stat { path: String },
+    /// Run an activity on device specified by the intent
+    Run {
+        /// The package whose activity is to be invoked
+        #[clap(short = 'p', long = "package")]
+        package: String,
+        /// The activity to be invoked itself, Usually it is MainActivity
+        #[clap(short = 'a', long = "activity")]
+        activity: String,
+    },
+    /// Reboot the device
+    Reboot {
+        #[clap(subcommand)]
+        reboot_type: RebootTypeCommand,
+    },
+    /// Install an APK on device
+    Install {
+        /// Path to APK file. Extension must be ".apk"
+        path: PathBuf,
+    },
+    /// Uninstall a package from the device
+    Uninstall {
+        /// Name of the package to uninstall
+        package: String,
+    },
+    /// Dump framebuffer of device
+    Framebuffer {
+        /// Framebuffer image destination path
+        path: String,
+    },
+}

adb_cli/src/models/emu.rs

@@ -0,0 +1,20 @@
+use clap::{Parser, Subcommand};
+
+#[derive(Debug, Parser)]
+pub struct EmulatorCommand {
+    #[clap(short = 's', long = "serial")]
+    pub serial: String,
+    #[clap(subcommand)]
+    pub command: EmuCommand,
+}
+
+#[derive(Debug, Subcommand)]
+pub enum EmuCommand {
+    /// Send a SMS with given phone number and given content
+    Sms {
+        phone_number: String,
+        content: String,
+    },
+    /// Rotate device screen from 90°
+    Rotate,
+}

adb_cli/src/models/host.rs

@@ -0,0 +1,52 @@
+use std::net::SocketAddrV4;
+
+use adb_client::{RustADBError, WaitForDeviceTransport};
+use clap::Parser;
+
+fn parse_wait_for_device_device_transport(
+    value: &str,
+) -> Result<WaitForDeviceTransport, RustADBError> {
+    WaitForDeviceTransport::try_from(value)
+}
+
+#[derive(Parser, Debug)]
+pub enum HostCommand {
+    /// Print current ADB version.
+    Version,
+    /// Ask ADB server to quit immediately.
+    Kill,
+    /// List connected devices.
+    Devices {
+        #[clap(short = 'l', long = "long")]
+        long: bool,
+    },
+    /// Track new devices showing up.
+    TrackDevices,
+    /// Pair device with a given code
+    Pair { address: SocketAddrV4, code: String },
+    /// Connect device over WI-FI
+    Connect { address: SocketAddrV4 },
+    /// Disconnect device over WI-FI
+    Disconnect { address: SocketAddrV4 },
+    /// MDNS services
+    Mdns {
+        #[clap(subcommand)]
+        subcommand: MdnsCommand,
+    },
+    /// Display server status
+    ServerStatus,
+    /// Wait for a device, on optionally given transport
+    WaitForDevice {
+        /// Transport on which wait for devices
+        #[clap(short = 't', long = "transport", value_parser = parse_wait_for_device_device_transport)]
+        transport: Option<WaitForDeviceTransport>,
+    },
+}
+
+#[derive(Parser, Debug)]
+pub enum MdnsCommand {
+    /// Check mdns status
+    Check,
+    /// List mdns services available
+    Services,
+}

adb_cli/src/models/local.rs

@@ -0,0 +1,24 @@
+use clap::Parser;
+
+use super::DeviceCommands;
+
+#[derive(Parser, Debug)]
+pub enum LocalCommand {
+    #[clap(flatten)]
+    DeviceCommands(DeviceCommands),
+    #[clap(flatten)]
+    LocalDeviceCommand(LocalDeviceCommand),
+}
+
+#[derive(Parser, Debug)]
+pub enum LocalDeviceCommand {
+    /// List available server features.
+    HostFeatures,
+    /// List a directory on device
+    List { path: String },
+    /// Get logs of device
+    Logcat {
+        /// Path to output file (created if not exists)
+        path: Option<String>,
+    },
+}

adb_cli/src/models/mod.rs

@@ -1,5 +1,17 @@
+mod device;
+mod emu;
+mod host;
+mod local;
 mod opts;
 mod reboot_type;
+mod tcp;
+mod usb;
 
-pub use opts::{Command, Opts};
+pub use device::DeviceCommands;
+pub use emu::{EmuCommand, EmulatorCommand};
+pub use host::{HostCommand, MdnsCommand};
+pub use local::{LocalCommand, LocalDeviceCommand};
+pub use opts::{MainCommand, Opts, ServerCommand};
 pub use reboot_type::RebootTypeCommand;
+pub use tcp::TcpCommand;
+pub use usb::UsbCommand;

adb_cli/src/models/opts.rs

@@ -1,30 +1,41 @@
 use std::net::SocketAddrV4;
 
-use clap::Parser;
+use clap::{Parser, Subcommand};
 
-use crate::commands::{EmuCommand, HostCommand, LocalCommand, UsbCommand};
+use super::{EmulatorCommand, HostCommand, LocalCommand, TcpCommand, UsbCommand};
 
-#[derive(Parser, Debug)]
+#[derive(Debug, Parser)]
 #[clap(about, version, author)]
 pub struct Opts {
+    #[clap(long = "debug")]
+    pub debug: bool,
+    #[clap(subcommand)]
+    pub command: MainCommand,
+}
+
+#[derive(Debug, Parser)]
+pub enum MainCommand {
+    /// Server related commands
+    Host(ServerCommand<HostCommand>),
+    /// Device related commands using server
+    Local(ServerCommand<LocalCommand>),
+    /// Emulator related commands
+    Emu(EmulatorCommand),
+    /// USB device related commands
+    Usb(UsbCommand),
+    /// TCP device related commands
+    Tcp(TcpCommand),
+    /// MDNS discovery related commands
+    Mdns,
+}
+
+#[derive(Debug, Parser)]
+pub struct ServerCommand<T: Subcommand> {
     #[clap(short = 'a', long = "address", default_value = "127.0.0.1:5037")]
     pub address: SocketAddrV4,
     /// Serial id of a specific device. Every request will be sent to this device.
     #[clap(short = 's', long = "serial")]
     pub serial: Option<String>,
     #[clap(subcommand)]
-    pub command: Command,
-}
-
-#[derive(Parser, Debug)]
-pub enum Command {
-    #[clap(flatten)]
-    Local(LocalCommand),
-    #[clap(flatten)]
-    Host(HostCommand),
-    /// Emulator specific commands
-    #[clap(subcommand)]
-    Emu(EmuCommand),
-    /// Device commands via USB, no server needed
-    Usb(UsbCommand),
+    pub command: T,
 }

adb_cli/src/models/reboot_type.rs

@@ -8,6 +8,7 @@ pub enum RebootTypeCommand {
     Recovery,
     Sideload,
     SideloadAutoReboot,
+    Fastboot,
 }
 
 impl From<RebootTypeCommand> for RebootType {
@@ -18,6 +19,7 @@ impl From<RebootTypeCommand> for RebootType {
             RebootTypeCommand::Recovery => RebootType::Recovery,
             RebootTypeCommand::Sideload => RebootType::Sideload,
             RebootTypeCommand::SideloadAutoReboot => RebootType::SideloadAutoReboot,
+            RebootTypeCommand::Fastboot => RebootType::Fastboot,
         }
     }
 }

adb_cli/src/models/tcp.rs

@@ -0,0 +1,11 @@
+use clap::Parser;
+use std::net::SocketAddr;
+
+use super::DeviceCommands;
+
+#[derive(Parser, Debug)]
+pub struct TcpCommand {
+    pub address: SocketAddr,
+    #[clap(subcommand)]
+    pub commands: DeviceCommands,
+}

adb_cli/src/models/usb.rs

@@ -3,7 +3,7 @@ use std::path::PathBuf;
 
 use clap::Parser;
 
-use crate::models::RebootTypeCommand;
+use super::DeviceCommands;
 
 fn parse_hex_id(id: &str) -> Result<u16, ParseIntError> {
     u16::from_str_radix(id, 16)
@@ -21,22 +21,5 @@ pub struct UsbCommand {
     #[clap(short = 'k', long = "private-key")]
     pub path_to_private_key: Option<PathBuf>,
     #[clap(subcommand)]
-    pub commands: UsbCommands,
-}
-
-#[derive(Parser, Debug)]
-pub enum UsbCommands {
-    /// Spawn an interactive shell or run a list of commands on the device
-    Shell { commands: Vec<String> },
-    /// Pull a file from device
-    Pull { source: String, destination: String },
-    /// Push a file on device
-    Push { filename: String, path: String },
-    /// Stat a file on device
-    Stat { path: String },
-    /// Reboot the device
-    Reboot {
-        #[clap(subcommand)]
-        reboot_type: RebootTypeCommand,
-    },
+    pub commands: DeviceCommands,
 }

adb_cli/src/utils.rs

@@ -0,0 +1,17 @@
+/// # Safety
+///
+/// This conditionally mutates the process' environment.
+/// See [`std::env::set_var`] for more info.
+pub unsafe fn setup_logger(debug: bool) {
+    // RUST_LOG variable has more priority then "--debug" flag
+    if std::env::var("RUST_LOG").is_err() {
+        let level = match debug {
+            true => "trace",
+            false => "info",
+        };
+
+        unsafe { std::env::set_var("RUST_LOG", level) };
+    }
+
+    env_logger::init();
+}

adb_client/Cargo.toml

@@ -3,26 +3,46 @@ authors.workspace = true
 description = "Rust ADB (Android Debug Bridge) client library"
 edition.workspace = true
 keywords.workspace = true
-license-file.workspace = true
+license.workspace = true
 name = "adb_client"
 readme = "README.md"
 repository.workspace = true
 version.workspace = true
 
 [dependencies]
-base64 = "0.22.1"
-bincode = "1.3.3"
+base64 = { version = "0.22.1" }
+bincode = { version = "1.3.3" }
 byteorder = { version = "1.5.0" }
-chrono = { version = "0.4.38" }
+chrono = { version = "0.4.40", default-features = false, features = ["std"] }
 homedir = { version = "0.3.4" }
-image = { version = "0.25.4" }
-lazy_static = { version = "1.5.0" }
-log = { version = "0.4.22" }
-num-bigint = { version = "0.6", package = "num-bigint-dig" }
-rand = { version = "0.7.0" }
-regex = { version = "1.11.0", features = ["perf", "std", "unicode"] }
-rsa = { version = "0.3.0" }
+image = { version = "0.25.5", default-features = false }
+log = { version = "0.4.26" }
+mdns-sd = { version = "0.13.9", default-features = false, features = [
+    "logging",
+] }
+num-bigint = { version = "0.8.4", package = "num-bigint-dig" }
+num-traits = { version = "0.2.19" }
+quick-protobuf = { version = "0.8.1" }
+rand = { version = "0.9.0" }
+rcgen = { version = "0.13.1", default-features = false, features = [
+    "aws_lc_rs",
+    "pem",
+] }
+regex = { version = "1.11.1", features = ["perf", "std", "unicode"] }
+rsa = { version = "0.9.7" }
 rusb = { version = "0.9.4", features = ["vendored"] }
-serde = { version = "1.0.210", features = ["derive"] }
-serde_repr = "0.1.19"
-thiserror = { version = "1.0.64" }
+rustls = { version = "0.23.27" }
+rustls-pki-types = { version = "1.11.0" }
+serde = { version = "1.0.216", features = ["derive"] }
+serde_repr = { version = "0.1.19" }
+sha1 = { version = "0.10.6", features = ["oid"] }
+thiserror = { version = "2.0.7" }
+
+[dev-dependencies]
+anyhow = { version = "1.0.93" }
+criterion = { version = "0.6.0" } # Used for benchmarks
+
+[[bench]]
+harness = false
+name = "benchmark_adb_push"
+path = "../benches/benchmark_adb_push.rs"

adb_client/README.md

@@ -2,7 +2,7 @@
 
 [![MIT licensed](https://img.shields.io/crates/l/adb_client.svg)](./LICENSE-MIT)
 [![Documentation](https://docs.rs/adb_client/badge.svg)](https://docs.rs/adb_client)
-![Crates.io Total Downloads](https://img.shields.io/crates/d/adb_client)
+[![Crates.io Total Downloads](https://img.shields.io/crates/d/adb_client)](https://crates.io/crates/adb_client)
 
 Rust library implementing ADB protocol.
 
@@ -15,6 +15,20 @@ Add `adb_client` crate as a dependency by simply adding it to your `Cargo.toml`:
 adb_client = "*"
 ```
 
+## Benchmarks
+
+Benchmarks run on `v2.0.6`, on a **Samsung S10 SM-G973F** device and an **Intel i7-1265U** CPU laptop
+
+### `ADBServerDevice` push vs `adb push`
+
+`ADBServerDevice` performs all operations by using adb server as a bridge.
+
+|File size|Sample size|`ADBServerDevice`|`adb`|Difference|
+|:-------:|:---------:|:----------:|:---:|:-----:|
+|10 MB|100|350,79 ms|356,30 ms|<div style="color:green">-1,57 %</div>|
+|500 MB|50|15,60 s|15,64 s|<div style="color:green">-0,25 %</div>|
+|1 GB|20|31,09 s|31,12 s|<div style="color:green">-0,10 %</div>|
+
 ## Examples
 
 ### Get available ADB devices
@@ -31,19 +45,19 @@ let mut server = ADBServer::new(SocketAddrV4::new(server_ip, server_port));
 server.devices();
 ```
 
-### Using ADB server as proxy
+### Using ADB server as bridge
 
-#### [TCP] Launch a command on device
+#### Launch a command on device
 
 ```rust no_run
 use adb_client::{ADBServer, ADBDeviceExt};
 
 let mut server = ADBServer::default();
 let mut device = server.get_device().expect("cannot get device");
-device.shell_command(["df", "-h"],std::io::stdout());
+device.shell_command(&["df", "-h"], &mut std::io::stdout());
 ```
 
-#### [TCP] Push a file to the device
+#### Push a file to the device
 
 ```rust no_run
 use adb_client::ADBServer;
@@ -57,9 +71,9 @@ let mut input = File::open(Path::new("/tmp/f")).expect("Cannot open file");
 device.push(&mut input, "/data/local/tmp");
 ```
 
-### Interacting directly with device
+### Interact directly with end devices
 
-#### [USB] Launch a command on device
+#### (USB) Launch a command on device
 
 ```rust no_run
 use adb_client::{ADBUSBDevice, ADBDeviceExt};
@@ -67,10 +81,10 @@ use adb_client::{ADBUSBDevice, ADBDeviceExt};
 let vendor_id = 0x04e8;
 let product_id = 0x6860;
 let mut device = ADBUSBDevice::new(vendor_id, product_id).expect("cannot find device");
-device.shell_command(["df", "-h"],std::io::stdout());
+device.shell_command(&["df", "-h"], &mut std::io::stdout());
 ```
 
-#### [USB] Push a file to the device
+#### (USB) Push a file to the device
 
 ```rust no_run
 use adb_client::{ADBUSBDevice, ADBDeviceExt};
@@ -81,5 +95,17 @@ let vendor_id = 0x04e8;
 let product_id = 0x6860;
 let mut device = ADBUSBDevice::new(vendor_id, product_id).expect("cannot find device");
 let mut input = File::open(Path::new("/tmp/f")).expect("Cannot open file");
-device.push(&mut input, "/data/local/tmp");
+device.push(&mut input, &"/data/local/tmp");
+```
+
+#### (TCP) Get a shell from device
+
+```rust no_run
+use std::net::{SocketAddr, IpAddr, Ipv4Addr};
+use adb_client::{ADBTcpDevice, ADBDeviceExt};
+
+let device_ip = IpAddr::V4(Ipv4Addr::new(192, 168, 0, 10));
+let device_port = 43210;
+let mut device = ADBTcpDevice::new(SocketAddr::new(device_ip, device_port)).expect("cannot find device");
+device.shell(&mut std::io::stdin(), Box::new(std::io::stdout()));
 ```

adb_client/src/adb_device_ext.rs

@@ -1,31 +1,76 @@
-use std::io::{Read, Write};
+use std::io::{Cursor, Read, Write};
+use std::path::Path;
+
+use image::{ImageBuffer, ImageFormat, Rgba};
 
 use crate::models::AdbStatResponse;
 use crate::{RebootType, Result};
 
-/// Trait representing all features available on both [`ADBServerDevice`] and [`ADBUSBDevice`]
+/// Trait representing all features available on both [`crate::ADBServerDevice`] and [`crate::ADBUSBDevice`]
 pub trait ADBDeviceExt {
-    /// Runs 'command' in a shell on the device, and write its output and error streams into [`output`].
-    fn shell_command<S: ToString, W: Write>(
-        &mut self,
-        command: impl IntoIterator<Item = S>,
-        output: W,
-    ) -> Result<()>;
+    /// Runs command in a shell on the device, and write its output and error streams into output.
+    fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()>;
 
     /// Starts an interactive shell session on the device.
-    /// Input data is read from [reader] and write to [writer].
-    /// [W] has a 'static bound as it is internally used in a thread.
-    fn shell<R: Read, W: Write + Send + 'static>(&mut self, reader: R, writer: W) -> Result<()>;
+    /// Input data is read from reader and write to writer.
+    fn shell(&mut self, reader: &mut dyn Read, writer: Box<(dyn Write + Send)>) -> Result<()>;
 
     /// Display the stat information for a remote file
     fn stat(&mut self, remote_path: &str) -> Result<AdbStatResponse>;
 
-    /// Pull the remote file pointed to by [source] and write its contents into [`output`]
-    fn pull<A: AsRef<str>, W: Write>(&mut self, source: A, output: W) -> Result<()>;
+    /// Pull the remote file pointed to by `source` and write its contents into `output`
+    fn pull(&mut self, source: &dyn AsRef<str>, output: &mut dyn Write) -> Result<()>;
 
-    /// Push [stream] to [path] on the device.
-    fn push<R: Read, A: AsRef<str>>(&mut self, stream: R, path: A) -> Result<()>;
+    /// Push `stream` to `path` on the device.
+    fn push(&mut self, stream: &mut dyn Read, path: &dyn AsRef<str>) -> Result<()>;
 
-    /// Reboots the device using given reboot type
+    /// Reboot the device using given reboot type
     fn reboot(&mut self, reboot_type: RebootType) -> Result<()>;
+
+    /// Run `activity` from `package` on device. Return the command output.
+    fn run_activity(&mut self, package: &str, activity: &str) -> Result<Vec<u8>> {
+        let mut output = Vec::new();
+        self.shell_command(
+            &["am", "start", &format!("{package}/{package}.{activity}")],
+            &mut output,
+        )?;
+
+        Ok(output)
+    }
+
+    /// Install an APK pointed to by `apk_path` on device.
+    fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()>;
+
+    /// Uninstall the package `package` from device.
+    fn uninstall(&mut self, package: &str) -> Result<()>;
+
+    /// Inner method requesting framebuffer from an Android device
+    fn framebuffer_inner(&mut self) -> Result<ImageBuffer<Rgba<u8>, Vec<u8>>>;
+
+    /// Dump framebuffer of this device into given path
+    fn framebuffer(&mut self, path: &dyn AsRef<Path>) -> Result<()> {
+        // Big help from AOSP source code (<https://android.googlesource.com/platform/system/adb/+/refs/heads/main/framebuffer_service.cpp>)
+        let img = self.framebuffer_inner()?;
+        Ok(img.save(path.as_ref())?)
+    }
+
+    /// Dump framebuffer of this device and return corresponding bytes.
+    ///
+    /// Output data format is currently only `PNG`.
+    fn framebuffer_bytes(&mut self) -> Result<Vec<u8>> {
+        let img = self.framebuffer_inner()?;
+        let mut vec = Cursor::new(Vec::new());
+        img.write_to(&mut vec, ImageFormat::Png)?;
+
+        Ok(vec.into_inner())
+    }
+
+    /// Return a boxed instance representing this trait
+    fn boxed(self) -> Box<dyn ADBDeviceExt>
+    where
+        Self: Sized,
+        Self: 'static,
+    {
+        Box::new(self)
+    }
 }

adb_client/src/device/adb_message_device.rs

@@ -0,0 +1,256 @@
+use byteorder::{LittleEndian, ReadBytesExt};
+use rand::Rng;
+use std::io::{Cursor, Read, Seek};
+
+use crate::{ADBMessageTransport, AdbStatResponse, Result, RustADBError, constants::BUFFER_SIZE};
+
+use super::{ADBTransportMessage, MessageCommand, models::MessageSubcommand};
+
+/// Generic structure representing an ADB device reachable over an [`ADBMessageTransport`].
+/// Structure is totally agnostic over which transport is truly used.
+#[derive(Debug)]
+pub struct ADBMessageDevice<T: ADBMessageTransport> {
+    transport: T,
+}
+
+#[derive(Debug, Clone, Copy)]
+pub struct ADBSession {
+    pub local_id: u32,
+    pub remote_id: u32,
+}
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    /// Instantiate a new [`ADBMessageTransport`]
+    pub fn new(transport: T) -> Self {
+        Self { transport }
+    }
+
+    pub(crate) fn get_transport(&mut self) -> &T {
+        &self.transport
+    }
+
+    pub(crate) fn get_transport_mut(&mut self) -> &mut T {
+        &mut self.transport
+    }
+
+    /// Receive a message and acknowledge it by replying with an `OKAY` command
+    pub(crate) fn recv_and_reply_okay(
+        &mut self,
+        session: ADBSession,
+    ) -> Result<ADBTransportMessage> {
+        let message = self.transport.read_message()?;
+        self.transport.write_message(ADBTransportMessage::new(
+            MessageCommand::Okay,
+            session.local_id,
+            session.remote_id,
+            &[],
+        ))?;
+        Ok(message)
+    }
+
+    /// Expect a message with an `OKAY` command after sending a message.
+    pub(crate) fn send_and_expect_okay(
+        &mut self,
+        message: ADBTransportMessage,
+    ) -> Result<ADBTransportMessage> {
+        self.transport.write_message(message)?;
+
+        self.transport.read_message().and_then(|message| {
+            message.assert_command(MessageCommand::Okay)?;
+            Ok(message)
+        })
+    }
+
+    pub(crate) fn recv_file<W: std::io::Write>(
+        &mut self,
+        session: ADBSession,
+        mut output: W,
+    ) -> std::result::Result<(), RustADBError> {
+        let mut len: Option<u64> = None;
+        loop {
+            let payload = self.recv_and_reply_okay(session)?.into_payload();
+            let mut rdr = Cursor::new(&payload);
+            while rdr.position() != payload.len() as u64 {
+                match len.take() {
+                    Some(0) | None => {
+                        rdr.seek_relative(4)?;
+                        len.replace(rdr.read_u32::<LittleEndian>()? as u64);
+                    }
+                    Some(length) => {
+                        let remaining_bytes = payload.len() as u64 - rdr.position();
+                        if length < remaining_bytes {
+                            std::io::copy(&mut rdr.by_ref().take(length), &mut output)?;
+                        } else {
+                            std::io::copy(&mut rdr.take(remaining_bytes), &mut output)?;
+                            len.replace(length - remaining_bytes);
+                            // this payload is now exhausted
+                            break;
+                        }
+                    }
+                }
+            }
+            if Cursor::new(&payload[(payload.len() - 8)..(payload.len() - 4)])
+                .read_u32::<LittleEndian>()?
+                == MessageSubcommand::Done as u32
+            {
+                break;
+            }
+        }
+        Ok(())
+    }
+
+    pub(crate) fn push_file<R: std::io::Read>(
+        &mut self,
+        session: ADBSession,
+        mut reader: R,
+    ) -> std::result::Result<(), RustADBError> {
+        let mut buffer = [0; BUFFER_SIZE];
+        let amount_read = reader.read(&mut buffer)?;
+        let subcommand_data = MessageSubcommand::Data.with_arg(amount_read as u32);
+
+        let mut serialized_message =
+            bincode::serialize(&subcommand_data).map_err(|_e| RustADBError::ConversionError)?;
+        serialized_message.append(&mut buffer[..amount_read].to_vec());
+
+        let message = ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            &serialized_message,
+        );
+
+        self.send_and_expect_okay(message)?;
+
+        loop {
+            let mut buffer = [0; BUFFER_SIZE];
+
+            match reader.read(&mut buffer) {
+                Ok(0) => {
+                    // Currently file mtime is not forwarded
+                    let subcommand_data = MessageSubcommand::Done.with_arg(0);
+
+                    let serialized_message = bincode::serialize(&subcommand_data)
+                        .map_err(|_e| RustADBError::ConversionError)?;
+
+                    let message = ADBTransportMessage::new(
+                        MessageCommand::Write,
+                        session.local_id,
+                        session.remote_id,
+                        &serialized_message,
+                    );
+
+                    self.send_and_expect_okay(message)?;
+
+                    // Command should end with a Write => Okay
+                    let received = self.transport.read_message()?;
+                    match received.header().command() {
+                        MessageCommand::Write => return Ok(()),
+                        c => {
+                            return Err(RustADBError::ADBRequestFailed(format!(
+                                "Wrong command received {}",
+                                c
+                            )));
+                        }
+                    }
+                }
+                Ok(size) => {
+                    let subcommand_data = MessageSubcommand::Data.with_arg(size as u32);
+
+                    let mut serialized_message = bincode::serialize(&subcommand_data)
+                        .map_err(|_e| RustADBError::ConversionError)?;
+                    serialized_message.append(&mut buffer[..size].to_vec());
+
+                    let message = ADBTransportMessage::new(
+                        MessageCommand::Write,
+                        session.local_id,
+                        session.remote_id,
+                        &serialized_message,
+                    );
+
+                    self.send_and_expect_okay(message)?;
+                }
+                Err(e) => {
+                    return Err(RustADBError::IOError(e));
+                }
+            }
+        }
+    }
+
+    pub(crate) fn begin_synchronization(&mut self) -> Result<ADBSession> {
+        self.open_session(b"sync:\0")
+    }
+
+    pub(crate) fn stat_with_explicit_ids(
+        &mut self,
+        session: ADBSession,
+        remote_path: &str,
+    ) -> Result<AdbStatResponse> {
+        let stat_buffer = MessageSubcommand::Stat.with_arg(remote_path.len() as u32);
+        let message = ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            &bincode::serialize(&stat_buffer).map_err(|_e| RustADBError::ConversionError)?,
+        );
+        self.send_and_expect_okay(message)?;
+        self.send_and_expect_okay(ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            remote_path.as_bytes(),
+        ))?;
+        let response = self.transport.read_message()?;
+        // Skip first 4 bytes as this is the literal "STAT".
+        // Interesting part starts right after
+        bincode::deserialize(&response.into_payload()[4..])
+            .map_err(|_e| RustADBError::ConversionError)
+    }
+
+    pub(crate) fn end_transaction(&mut self, session: ADBSession) -> Result<()> {
+        let quit_buffer = MessageSubcommand::Quit.with_arg(0u32);
+        self.send_and_expect_okay(ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            &bincode::serialize(&quit_buffer).map_err(|_e| RustADBError::ConversionError)?,
+        ))?;
+        let _discard_close = self.transport.read_message()?;
+        Ok(())
+    }
+
+    pub(crate) fn open_session(&mut self, data: &[u8]) -> Result<ADBSession> {
+        let mut rng = rand::rng();
+        let local_id: u32 = rng.random();
+
+        let message = ADBTransportMessage::new(
+            MessageCommand::Open,
+            local_id, // Our 'local-id'
+            0,
+            data,
+        );
+        self.get_transport_mut().write_message(message)?;
+
+        let response = self.get_transport_mut().read_message()?;
+
+        if response.header().command() != MessageCommand::Okay {
+            return Err(RustADBError::ADBRequestFailed(format!(
+                "Open session failed: got {} in respone instead of OKAY",
+                response.header().command()
+            )));
+        }
+
+        if response.header().arg1() != local_id {
+            return Err(RustADBError::ADBRequestFailed(format!(
+                "Open session failed: respones used {} for our local_id instead of {local_id}",
+                response.header().arg1()
+            )));
+        }
+
+        let session = ADBSession {
+            local_id,
+            remote_id: response.header().arg0(),
+        };
+
+        Ok(session)
+    }
+}

adb_client/src/device/adb_message_device_commands.rs

@@ -0,0 +1,45 @@
+use crate::{ADBDeviceExt, ADBMessageTransport, RebootType, Result, models::AdbStatResponse};
+use std::{
+    io::{Read, Write},
+    path::Path,
+};
+
+use super::ADBMessageDevice;
+
+impl<T: ADBMessageTransport> ADBDeviceExt for ADBMessageDevice<T> {
+    fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()> {
+        self.shell_command(command, output)
+    }
+
+    fn shell(&mut self, reader: &mut dyn Read, writer: Box<(dyn Write + Send)>) -> Result<()> {
+        self.shell(reader, writer)
+    }
+
+    fn stat(&mut self, remote_path: &str) -> Result<AdbStatResponse> {
+        self.stat(remote_path)
+    }
+
+    fn pull(&mut self, source: &dyn AsRef<str>, output: &mut dyn Write) -> Result<()> {
+        self.pull(source, output)
+    }
+
+    fn push(&mut self, stream: &mut dyn Read, path: &dyn AsRef<str>) -> Result<()> {
+        self.push(stream, path)
+    }
+
+    fn reboot(&mut self, reboot_type: RebootType) -> Result<()> {
+        self.reboot(reboot_type)
+    }
+
+    fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()> {
+        self.install(apk_path)
+    }
+
+    fn uninstall(&mut self, package: &str) -> Result<()> {
+        self.uninstall(package)
+    }
+
+    fn framebuffer_inner(&mut self) -> Result<image::ImageBuffer<image::Rgba<u8>, Vec<u8>>> {
+        self.framebuffer_inner()
+    }
+}

adb_client/src/device/adb_tcp_device.rs

@@ -0,0 +1,123 @@
+use std::io::Write;
+use std::path::Path;
+use std::{io::Read, net::SocketAddr};
+
+use super::ADBTransportMessage;
+use super::adb_message_device::ADBMessageDevice;
+use super::models::MessageCommand;
+use crate::{ADBDeviceExt, ADBMessageTransport, ADBTransport, Result, TcpTransport};
+
+/// Represent a device reached and available over USB.
+#[derive(Debug)]
+pub struct ADBTcpDevice {
+    inner: ADBMessageDevice<TcpTransport>,
+}
+
+impl ADBTcpDevice {
+    /// Instantiate a new [`ADBTcpDevice`]
+    pub fn new(address: SocketAddr) -> Result<Self> {
+        let mut device = Self {
+            inner: ADBMessageDevice::new(TcpTransport::new(address)?),
+        };
+
+        device.connect()?;
+
+        Ok(device)
+    }
+
+    /// Send initial connect
+    pub fn connect(&mut self) -> Result<()> {
+        self.get_transport_mut().connect()?;
+
+        let message = ADBTransportMessage::new(
+            MessageCommand::Cnxn,
+            0x01000000,
+            1048576,
+            format!("host::{}\0", env!("CARGO_PKG_NAME")).as_bytes(),
+        );
+
+        self.get_transport_mut().write_message(message)?;
+
+        let message = self.get_transport_mut().read_message()?;
+
+        // Check if client is requesting a secure connection and upgrade it if necessary
+        match message.header().command() {
+            MessageCommand::Stls => {
+                self.get_transport_mut()
+                    .write_message(ADBTransportMessage::new(MessageCommand::Stls, 1, 0, &[]))?;
+                self.get_transport_mut().upgrade_connection()?;
+                log::debug!("Connection successfully upgraded from TCP to TLS");
+            }
+            MessageCommand::Cnxn => {
+                log::debug!("Unencrypted connection established");
+            }
+            _ => {
+                return Err(crate::RustADBError::WrongResponseReceived(
+                    "Expected CNXN or STLS command".to_string(),
+                    message.header().command().to_string(),
+                ));
+            }
+        }
+
+        Ok(())
+    }
+
+    #[inline]
+    fn get_transport_mut(&mut self) -> &mut TcpTransport {
+        self.inner.get_transport_mut()
+    }
+}
+
+impl ADBDeviceExt for ADBTcpDevice {
+    #[inline]
+    fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()> {
+        self.inner.shell_command(command, output)
+    }
+
+    #[inline]
+    fn shell(&mut self, reader: &mut dyn Read, writer: Box<(dyn Write + Send)>) -> Result<()> {
+        self.inner.shell(reader, writer)
+    }
+
+    #[inline]
+    fn stat(&mut self, remote_path: &str) -> Result<crate::AdbStatResponse> {
+        self.inner.stat(remote_path)
+    }
+
+    #[inline]
+    fn pull(&mut self, source: &dyn AsRef<str>, output: &mut dyn Write) -> Result<()> {
+        self.inner.pull(source, output)
+    }
+
+    #[inline]
+    fn push(&mut self, stream: &mut dyn Read, path: &dyn AsRef<str>) -> Result<()> {
+        self.inner.push(stream, path)
+    }
+
+    #[inline]
+    fn reboot(&mut self, reboot_type: crate::RebootType) -> Result<()> {
+        self.inner.reboot(reboot_type)
+    }
+
+    #[inline]
+    fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()> {
+        self.inner.install(apk_path)
+    }
+
+    #[inline]
+    fn uninstall(&mut self, package: &str) -> Result<()> {
+        self.inner.uninstall(package)
+    }
+
+    #[inline]
+    fn framebuffer_inner(&mut self) -> Result<image::ImageBuffer<image::Rgba<u8>, Vec<u8>>> {
+        self.inner.framebuffer_inner()
+    }
+}
+
+impl Drop for ADBTcpDevice {
+    fn drop(&mut self) {
+        // Best effort here
+        let _ = self.get_transport_mut().disconnect();
+    }
+}

adb_client/src/device/adb_transport_message.rs

@@ -0,0 +1,122 @@
+use serde::{Deserialize, Serialize};
+
+use crate::{Result, RustADBError};
+
+use super::models::MessageCommand;
+
+pub const AUTH_TOKEN: u32 = 1;
+pub const AUTH_SIGNATURE: u32 = 2;
+pub const AUTH_RSAPUBLICKEY: u32 = 3;
+
+#[derive(Debug)]
+pub struct ADBTransportMessage {
+    header: ADBTransportMessageHeader,
+    payload: Vec<u8>,
+}
+
+#[derive(Debug, Serialize, Deserialize)]
+#[repr(C)]
+pub struct ADBTransportMessageHeader {
+    command: MessageCommand, /* command identifier constant      */
+    arg0: u32,               /* first argument                   */
+    arg1: u32,               /* second argument                  */
+    data_length: u32,        /* length of payload (0 is allowed) */
+    data_crc32: u32,         /* crc32 of data payload            */
+    magic: u32,              /* command ^ 0xffffffff             */
+}
+
+impl ADBTransportMessageHeader {
+    pub fn new(command: MessageCommand, arg0: u32, arg1: u32, data: &[u8]) -> Self {
+        Self {
+            command,
+            arg0,
+            arg1,
+            data_length: data.len() as u32,
+            data_crc32: Self::compute_crc32(data),
+            magic: Self::compute_magic(command),
+        }
+    }
+
+    pub fn command(&self) -> MessageCommand {
+        self.command
+    }
+
+    pub fn arg0(&self) -> u32 {
+        self.arg0
+    }
+
+    pub fn arg1(&self) -> u32 {
+        self.arg1
+    }
+
+    pub fn data_length(&self) -> u32 {
+        self.data_length
+    }
+
+    pub fn data_crc32(&self) -> u32 {
+        self.data_crc32
+    }
+
+    pub(crate) fn compute_crc32(data: &[u8]) -> u32 {
+        data.iter().map(|&x| x as u32).sum()
+    }
+
+    fn compute_magic(command: MessageCommand) -> u32 {
+        let command_u32 = command as u32;
+        command_u32 ^ 0xFFFFFFFF
+    }
+
+    pub fn as_bytes(&self) -> Result<Vec<u8>> {
+        bincode::serialize(&self).map_err(|_e| RustADBError::ConversionError)
+    }
+}
+
+impl ADBTransportMessage {
+    pub fn new(command: MessageCommand, arg0: u32, arg1: u32, data: &[u8]) -> Self {
+        Self {
+            header: ADBTransportMessageHeader::new(command, arg0, arg1, data),
+            payload: data.to_vec(),
+        }
+    }
+
+    pub fn from_header_and_payload(header: ADBTransportMessageHeader, payload: Vec<u8>) -> Self {
+        Self { header, payload }
+    }
+
+    pub fn check_message_integrity(&self) -> bool {
+        ADBTransportMessageHeader::compute_magic(self.header.command) == self.header.magic
+            && ADBTransportMessageHeader::compute_crc32(&self.payload) == self.header.data_crc32
+    }
+
+    pub fn assert_command(&self, expected_command: MessageCommand) -> Result<()> {
+        let our_command = self.header().command();
+        if expected_command == our_command {
+            return Ok(());
+        }
+
+        Err(RustADBError::WrongResponseReceived(
+            our_command.to_string(),
+            expected_command.to_string(),
+        ))
+    }
+
+    pub fn header(&self) -> &ADBTransportMessageHeader {
+        &self.header
+    }
+
+    pub fn payload(&self) -> &Vec<u8> {
+        &self.payload
+    }
+
+    pub fn into_payload(self) -> Vec<u8> {
+        self.payload
+    }
+}
+
+impl TryFrom<[u8; 24]> for ADBTransportMessageHeader {
+    type Error = RustADBError;
+
+    fn try_from(value: [u8; 24]) -> Result<Self> {
+        bincode::deserialize(&value).map_err(|_e| RustADBError::ConversionError)
+    }
+}

adb_client/src/device/adb_usb_device.rs

@@ -0,0 +1,292 @@
+use rusb::Device;
+use rusb::DeviceDescriptor;
+use rusb::UsbContext;
+use rusb::constants::LIBUSB_CLASS_VENDOR_SPEC;
+use std::fs::read_to_string;
+use std::io::Read;
+use std::io::Write;
+use std::path::Path;
+use std::path::PathBuf;
+use std::time::Duration;
+
+use super::adb_message_device::ADBMessageDevice;
+use super::models::MessageCommand;
+use super::{ADBRsaKey, ADBTransportMessage};
+use crate::ADBDeviceExt;
+use crate::ADBMessageTransport;
+use crate::ADBTransport;
+use crate::device::adb_transport_message::{AUTH_RSAPUBLICKEY, AUTH_SIGNATURE, AUTH_TOKEN};
+use crate::{Result, RustADBError, USBTransport};
+
+pub fn read_adb_private_key<P: AsRef<Path>>(private_key_path: P) -> Result<Option<ADBRsaKey>> {
+    Ok(read_to_string(private_key_path.as_ref()).map(|pk| {
+        match ADBRsaKey::new_from_pkcs8(&pk) {
+            Ok(pk) => Some(pk),
+            Err(e) => {
+                log::error!("Error while create RSA private key: {e}");
+                None
+            }
+        }
+    })?)
+}
+
+/// Search for adb devices with known interface class and subclass values
+fn search_adb_devices() -> Result<Option<(u16, u16)>> {
+    let mut found_devices = vec![];
+    for device in rusb::devices()?.iter() {
+        let Ok(des) = device.device_descriptor() else {
+            continue;
+        };
+        if is_adb_device(&device, &des) {
+            log::debug!(
+                "Autodetect device {:04x}:{:04x}",
+                des.vendor_id(),
+                des.product_id()
+            );
+            found_devices.push((des.vendor_id(), des.product_id()));
+        }
+    }
+
+    match (found_devices.first(), found_devices.get(1)) {
+        (None, _) => Ok(None),
+        (Some(identifiers), None) => Ok(Some(*identifiers)),
+        (Some((vid1, pid1)), Some((vid2, pid2))) => Err(RustADBError::DeviceNotFound(format!(
+            "Found two Android devices {:04x}:{:04x} and {:04x}:{:04x}",
+            vid1, pid1, vid2, pid2
+        ))),
+    }
+}
+
+fn is_adb_device<T: UsbContext>(device: &Device<T>, des: &DeviceDescriptor) -> bool {
+    const ADB_SUBCLASS: u8 = 0x42;
+    const ADB_PROTOCOL: u8 = 0x1;
+
+    // Some devices require choosing the file transfer mode
+    // for usb debugging to take effect.
+    const BULK_CLASS: u8 = 0xdc;
+    const BULK_ADB_SUBCLASS: u8 = 2;
+
+    for n in 0..des.num_configurations() {
+        let Ok(config_des) = device.config_descriptor(n) else {
+            continue;
+        };
+        for interface in config_des.interfaces() {
+            for interface_des in interface.descriptors() {
+                let proto = interface_des.protocol_code();
+                let class = interface_des.class_code();
+                let subcl = interface_des.sub_class_code();
+                if proto == ADB_PROTOCOL
+                    && ((class == LIBUSB_CLASS_VENDOR_SPEC && subcl == ADB_SUBCLASS)
+                        || (class == BULK_CLASS && subcl == BULK_ADB_SUBCLASS))
+                {
+                    return true;
+                }
+            }
+        }
+    }
+    false
+}
+
+pub fn get_default_adb_key_path() -> Result<PathBuf> {
+    homedir::my_home()
+        .ok()
+        .flatten()
+        .map(|home| home.join(".android").join("adbkey"))
+        .ok_or(RustADBError::NoHomeDirectory)
+}
+
+/// Represent a device reached and available over USB.
+#[derive(Debug)]
+pub struct ADBUSBDevice {
+    private_key: ADBRsaKey,
+    inner: ADBMessageDevice<USBTransport>,
+}
+
+impl ADBUSBDevice {
+    /// Instantiate a new [`ADBUSBDevice`]
+    pub fn new(vendor_id: u16, product_id: u16) -> Result<Self> {
+        Self::new_with_custom_private_key(vendor_id, product_id, get_default_adb_key_path()?)
+    }
+
+    /// Instantiate a new [`ADBUSBDevice`] using a custom private key path
+    pub fn new_with_custom_private_key(
+        vendor_id: u16,
+        product_id: u16,
+        private_key_path: PathBuf,
+    ) -> Result<Self> {
+        Self::new_from_transport_inner(USBTransport::new(vendor_id, product_id)?, private_key_path)
+    }
+
+    /// Instantiate a new [`ADBUSBDevice`] from a [`USBTransport`] and an optional private key path.
+    pub fn new_from_transport(
+        transport: USBTransport,
+        private_key_path: Option<PathBuf>,
+    ) -> Result<Self> {
+        let private_key_path = match private_key_path {
+            Some(private_key_path) => private_key_path,
+            None => get_default_adb_key_path()?,
+        };
+
+        Self::new_from_transport_inner(transport, private_key_path)
+    }
+
+    fn new_from_transport_inner(
+        transport: USBTransport,
+        private_key_path: PathBuf,
+    ) -> Result<Self> {
+        let private_key = match read_adb_private_key(private_key_path)? {
+            Some(pk) => pk,
+            None => ADBRsaKey::new_random()?,
+        };
+
+        let mut s = Self {
+            private_key,
+            inner: ADBMessageDevice::new(transport),
+        };
+
+        s.connect()?;
+
+        Ok(s)
+    }
+
+    /// autodetect connected ADB devices and establish a connection with the first device found
+    pub fn autodetect() -> Result<Self> {
+        Self::autodetect_with_custom_private_key(get_default_adb_key_path()?)
+    }
+
+    /// autodetect connected ADB devices and establish a connection with the first device found using a custom private key path
+    pub fn autodetect_with_custom_private_key(private_key_path: PathBuf) -> Result<Self> {
+        match search_adb_devices()? {
+            Some((vendor_id, product_id)) => {
+                ADBUSBDevice::new_with_custom_private_key(vendor_id, product_id, private_key_path)
+            }
+            _ => Err(RustADBError::DeviceNotFound(
+                "cannot find USB devices matching the signature of an ADB device".into(),
+            )),
+        }
+    }
+
+    /// Send initial connect
+    pub fn connect(&mut self) -> Result<()> {
+        self.get_transport_mut().connect()?;
+
+        let message = ADBTransportMessage::new(
+            MessageCommand::Cnxn,
+            0x01000000,
+            1048576,
+            format!("host::{}\0", env!("CARGO_PKG_NAME")).as_bytes(),
+        );
+
+        self.get_transport_mut().write_message(message)?;
+
+        let message = self.get_transport_mut().read_message()?;
+        message.assert_command(MessageCommand::Auth)?;
+
+        // At this point, we should have receive an AUTH message with arg0 == 1
+        let auth_message = match message.header().arg0() {
+            AUTH_TOKEN => message,
+            v => {
+                return Err(RustADBError::ADBRequestFailed(format!(
+                    "Received AUTH message with type != 1 ({v})"
+                )));
+            }
+        };
+
+        let sign = self.private_key.sign(auth_message.into_payload())?;
+
+        let message = ADBTransportMessage::new(MessageCommand::Auth, AUTH_SIGNATURE, 0, &sign);
+
+        self.get_transport_mut().write_message(message)?;
+
+        let received_response = self.get_transport_mut().read_message()?;
+
+        if received_response.header().command() == MessageCommand::Cnxn {
+            log::info!(
+                "Authentication OK, device info {}",
+                String::from_utf8(received_response.into_payload())?
+            );
+            return Ok(());
+        }
+
+        let mut pubkey = self.private_key.android_pubkey_encode()?.into_bytes();
+        pubkey.push(b'\0');
+
+        let message = ADBTransportMessage::new(MessageCommand::Auth, AUTH_RSAPUBLICKEY, 0, &pubkey);
+
+        self.get_transport_mut().write_message(message)?;
+
+        let response = self
+            .get_transport_mut()
+            .read_message_with_timeout(Duration::from_secs(10))
+            .and_then(|message| {
+                message.assert_command(MessageCommand::Cnxn)?;
+                Ok(message)
+            })?;
+
+        log::info!(
+            "Authentication OK, device info {}",
+            String::from_utf8(response.into_payload())?
+        );
+
+        Ok(())
+    }
+
+    #[inline]
+    fn get_transport_mut(&mut self) -> &mut USBTransport {
+        self.inner.get_transport_mut()
+    }
+}
+
+impl ADBDeviceExt for ADBUSBDevice {
+    #[inline]
+    fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()> {
+        self.inner.shell_command(command, output)
+    }
+
+    #[inline]
+    fn shell<'a>(&mut self, reader: &mut dyn Read, writer: Box<(dyn Write + Send)>) -> Result<()> {
+        self.inner.shell(reader, writer)
+    }
+
+    #[inline]
+    fn stat(&mut self, remote_path: &str) -> Result<crate::AdbStatResponse> {
+        self.inner.stat(remote_path)
+    }
+
+    #[inline]
+    fn pull(&mut self, source: &dyn AsRef<str>, output: &mut dyn Write) -> Result<()> {
+        self.inner.pull(source, output)
+    }
+
+    #[inline]
+    fn push(&mut self, stream: &mut dyn Read, path: &dyn AsRef<str>) -> Result<()> {
+        self.inner.push(stream, path)
+    }
+
+    #[inline]
+    fn reboot(&mut self, reboot_type: crate::RebootType) -> Result<()> {
+        self.inner.reboot(reboot_type)
+    }
+
+    #[inline]
+    fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()> {
+        self.inner.install(apk_path)
+    }
+
+    #[inline]
+    fn uninstall(&mut self, package: &str) -> Result<()> {
+        self.inner.uninstall(package)
+    }
+
+    #[inline]
+    fn framebuffer_inner(&mut self) -> Result<image::ImageBuffer<image::Rgba<u8>, Vec<u8>>> {
+        self.inner.framebuffer_inner()
+    }
+}
+
+impl Drop for ADBUSBDevice {
+    fn drop(&mut self) {
+        // Best effort here
+        let _ = self.get_transport_mut().disconnect();
+    }
+}

adb_client/src/device/commands/framebuffer.rs

@@ -0,0 +1,98 @@
+use std::io::{Cursor, Read};
+
+use byteorder::{LittleEndian, ReadBytesExt};
+use image::{ImageBuffer, Rgba};
+
+use crate::{
+    ADBMessageTransport, Result, RustADBError,
+    device::{MessageCommand, adb_message_device::ADBMessageDevice},
+    models::{FrameBufferInfoV1, FrameBufferInfoV2},
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn framebuffer_inner(&mut self) -> Result<ImageBuffer<Rgba<u8>, Vec<u8>>> {
+        let session = self.open_session(b"framebuffer:\0")?;
+
+        let response = self.recv_and_reply_okay(session)?;
+
+        let mut payload_cursor = Cursor::new(response.payload());
+
+        let version = payload_cursor.read_u32::<LittleEndian>()?;
+
+        let img = match version {
+            // RGBA_8888
+            1 => {
+                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV1>()];
+
+                payload_cursor.read_exact(&mut buf)?;
+
+                let framebuffer_info: FrameBufferInfoV1 = buf.try_into()?;
+
+                let mut framebuffer_data = Vec::new();
+                payload_cursor.read_to_end(&mut framebuffer_data)?;
+
+                loop {
+                    if framebuffer_data.len() as u32 == framebuffer_info.size {
+                        break;
+                    }
+
+                    let response = self.recv_and_reply_okay(session)?;
+
+                    framebuffer_data.extend_from_slice(&response.into_payload());
+
+                    log::debug!(
+                        "received framebuffer data. new size {}",
+                        framebuffer_data.len()
+                    );
+                }
+
+                ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(
+                    framebuffer_info.width,
+                    framebuffer_info.height,
+                    framebuffer_data,
+                )
+                .ok_or_else(|| RustADBError::FramebufferConversionError)?
+            }
+            // RGBX_8888
+            2 => {
+                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV2>()];
+
+                payload_cursor.read_exact(&mut buf)?;
+
+                let framebuffer_info: FrameBufferInfoV2 = buf.try_into()?;
+
+                let mut framebuffer_data = Vec::new();
+                payload_cursor.read_to_end(&mut framebuffer_data)?;
+
+                loop {
+                    if framebuffer_data.len() as u32 == framebuffer_info.size {
+                        break;
+                    }
+
+                    let response = self.recv_and_reply_okay(session)?;
+
+                    framebuffer_data.extend_from_slice(&response.into_payload());
+
+                    log::debug!(
+                        "received framebuffer data. new size {}",
+                        framebuffer_data.len()
+                    );
+                }
+
+                ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(
+                    framebuffer_info.width,
+                    framebuffer_info.height,
+                    framebuffer_data,
+                )
+                .ok_or_else(|| RustADBError::FramebufferConversionError)?
+            }
+            v => return Err(RustADBError::UnimplementedFramebufferImageVersion(v)),
+        };
+
+        self.get_transport_mut()
+            .read_message()
+            .and_then(|message| message.assert_command(MessageCommand::Clse))?;
+
+        Ok(img)
+    }
+}

adb_client/src/device/commands/install.rs

@@ -0,0 +1,41 @@
+use std::{fs::File, path::Path};
+
+use crate::{
+    ADBMessageTransport, Result,
+    device::{MessageWriter, adb_message_device::ADBMessageDevice},
+    utils::check_extension_is_apk,
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()> {
+        let mut apk_file = File::open(apk_path)?;
+
+        check_extension_is_apk(apk_path)?;
+
+        let file_size = apk_file.metadata()?.len();
+
+        let session =
+            self.open_session(format!("exec:cmd package 'install' -S {}\0", file_size).as_bytes())?;
+
+        let transport = self.get_transport().clone();
+
+        let mut writer = MessageWriter::new(transport, session.local_id, session.remote_id);
+
+        std::io::copy(&mut apk_file, &mut writer)?;
+
+        let final_status = self.get_transport_mut().read_message()?;
+
+        match final_status.into_payload().as_slice() {
+            b"Success\n" => {
+                log::info!(
+                    "APK file {} successfully installed",
+                    apk_path.as_ref().display()
+                );
+                Ok(())
+            }
+            d => Err(crate::RustADBError::ADBRequestFailed(String::from_utf8(
+                d.to_vec(),
+            )?)),
+        }
+    }
+}

adb_client/src/device/commands/mod.rs

@@ -0,0 +1,8 @@
+mod framebuffer;
+mod install;
+mod pull;
+mod push;
+mod reboot;
+mod shell;
+mod stat;
+mod uninstall;

adb_client/src/device/commands/pull.rs

@@ -0,0 +1,54 @@
+use std::io::Write;
+
+use crate::{
+    ADBMessageTransport, Result, RustADBError,
+    device::{
+        ADBTransportMessage, MessageCommand, adb_message_device::ADBMessageDevice,
+        models::MessageSubcommand,
+    },
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn pull<A: AsRef<str>, W: Write>(&mut self, source: A, output: W) -> Result<()> {
+        let session = self.begin_synchronization()?;
+        let source = source.as_ref();
+
+        let adb_stat_response = self.stat_with_explicit_ids(session, source)?;
+
+        if adb_stat_response.file_perm == 0 {
+            return Err(RustADBError::UnknownResponseType(
+                "mode is 0: source file does not exist".to_string(),
+            ));
+        }
+
+        self.get_transport_mut().write_message_with_timeout(
+            ADBTransportMessage::new(
+                MessageCommand::Okay,
+                session.local_id,
+                session.remote_id,
+                &[],
+            ),
+            std::time::Duration::from_secs(4),
+        )?;
+
+        let recv_buffer = MessageSubcommand::Recv.with_arg(source.len() as u32);
+        let recv_buffer =
+            bincode::serialize(&recv_buffer).map_err(|_e| RustADBError::ConversionError)?;
+        self.send_and_expect_okay(ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            &recv_buffer,
+        ))?;
+        self.send_and_expect_okay(ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            source.as_bytes(),
+        ))?;
+
+        self.recv_file(session, output)?;
+        self.end_transaction(session)?;
+        Ok(())
+    }
+}

adb_client/src/device/commands/push.rs

@@ -0,0 +1,34 @@
+use std::io::Read;
+
+use crate::{
+    ADBMessageTransport, Result, RustADBError,
+    device::{
+        ADBTransportMessage, MessageCommand, MessageSubcommand,
+        adb_message_device::ADBMessageDevice,
+    },
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn push<R: Read, A: AsRef<str>>(&mut self, stream: R, path: A) -> Result<()> {
+        let session = self.begin_synchronization()?;
+
+        let path_header = format!("{},0777", path.as_ref());
+
+        let send_buffer = MessageSubcommand::Send.with_arg(path_header.len() as u32);
+        let mut send_buffer =
+            bincode::serialize(&send_buffer).map_err(|_e| RustADBError::ConversionError)?;
+        send_buffer.append(&mut path_header.as_bytes().to_vec());
+
+        self.send_and_expect_okay(ADBTransportMessage::new(
+            MessageCommand::Write,
+            session.local_id,
+            session.remote_id,
+            &send_buffer,
+        ))?;
+
+        self.push_file(session, stream)?;
+        self.end_transaction(session)?;
+
+        Ok(())
+    }
+}

adb_client/src/device/commands/reboot.rs

@@ -0,0 +1,14 @@
+use crate::{
+    ADBMessageTransport, RebootType, Result,
+    device::{MessageCommand, adb_message_device::ADBMessageDevice},
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn reboot(&mut self, reboot_type: RebootType) -> Result<()> {
+        self.open_session(format!("reboot:{}\0", reboot_type).as_bytes())?;
+
+        self.get_transport_mut()
+            .read_message()
+            .and_then(|message| message.assert_command(MessageCommand::Okay))
+    }
+}

adb_client/src/device/commands/shell.rs

@@ -0,0 +1,77 @@
+use std::io::{ErrorKind, Read, Write};
+
+use crate::Result;
+use crate::device::ShellMessageWriter;
+use crate::{
+    ADBMessageTransport, RustADBError,
+    device::{ADBMessageDevice, ADBTransportMessage, MessageCommand},
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    /// Runs 'command' in a shell on the device, and write its output and error streams into output.
+    pub(crate) fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()> {
+        let session = self.open_session(format!("shell:{}\0", command.join(" "),).as_bytes())?;
+
+        loop {
+            let response = self.get_transport_mut().read_message()?;
+            if response.header().command() != MessageCommand::Write {
+                break;
+            }
+
+            output.write_all(&response.into_payload())?;
+        }
+
+        Ok(())
+    }
+
+    /// Starts an interactive shell session on the device.
+    /// Input data is read from [reader] and write to [writer].
+    pub(crate) fn shell(
+        &mut self,
+        mut reader: &mut dyn Read,
+        mut writer: Box<(dyn Write + Send)>,
+    ) -> Result<()> {
+        let session = self.open_session(b"shell:\0")?;
+
+        let mut transport = self.get_transport().clone();
+
+        // Reading thread, reads response from adbd
+        std::thread::spawn(move || -> Result<()> {
+            loop {
+                let message = transport.read_message()?;
+
+                // Acknowledge for more data
+                let response = ADBTransportMessage::new(
+                    MessageCommand::Okay,
+                    session.local_id,
+                    session.remote_id,
+                    &[],
+                );
+                transport.write_message(response)?;
+
+                match message.header().command() {
+                    MessageCommand::Write => {
+                        writer.write_all(&message.into_payload())?;
+                        writer.flush()?;
+                    }
+                    MessageCommand::Okay => continue,
+                    _ => return Err(RustADBError::ADBShellNotSupported),
+                }
+            }
+        });
+
+        let transport = self.get_transport().clone();
+        let mut shell_writer =
+            ShellMessageWriter::new(transport, session.local_id, session.remote_id);
+
+        // Read from given reader (that could be stdin e.g), and write content to device adbd
+        if let Err(e) = std::io::copy(&mut reader, &mut shell_writer) {
+            match e.kind() {
+                ErrorKind::BrokenPipe => return Ok(()),
+                _ => return Err(RustADBError::IOError(e)),
+            }
+        }
+
+        Ok(())
+    }
+}

adb_client/src/device/commands/stat.rs

@@ -0,0 +1,12 @@
+use crate::{
+    ADBMessageTransport, AdbStatResponse, Result, device::adb_message_device::ADBMessageDevice,
+};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn stat(&mut self, remote_path: &str) -> Result<AdbStatResponse> {
+        let session = self.begin_synchronization()?;
+        let adb_stat_response = self.stat_with_explicit_ids(session, remote_path)?;
+        self.end_transaction(session)?;
+        Ok(adb_stat_response)
+    }
+}

adb_client/src/device/commands/uninstall.rs

@@ -0,0 +1,19 @@
+use crate::{ADBMessageTransport, Result, device::adb_message_device::ADBMessageDevice};
+
+impl<T: ADBMessageTransport> ADBMessageDevice<T> {
+    pub(crate) fn uninstall(&mut self, package_name: &str) -> Result<()> {
+        self.open_session(format!("exec:cmd package 'uninstall' {}\0", package_name).as_bytes())?;
+
+        let final_status = self.get_transport_mut().read_message()?;
+
+        match final_status.into_payload().as_slice() {
+            b"Success\n" => {
+                log::info!("Package {} successfully uninstalled", package_name);
+                Ok(())
+            }
+            d => Err(crate::RustADBError::ADBRequestFailed(String::from_utf8(
+                d.to_vec(),
+            )?)),
+        }
+    }
+}

adb_client/src/device/message_writer.rs

@@ -0,0 +1,48 @@
+use std::io::{Error, ErrorKind, Result, Write};
+
+use crate::ADBMessageTransport;
+
+use super::{ADBTransportMessage, MessageCommand};
+
+/// [`Write`] trait implementation to hide underlying ADB protocol write logic.
+///
+/// Read received responses to check that message has been correctly received.
+pub struct MessageWriter<T: ADBMessageTransport> {
+    transport: T,
+    local_id: u32,
+    remote_id: u32,
+}
+
+impl<T: ADBMessageTransport> MessageWriter<T> {
+    pub fn new(transport: T, local_id: u32, remote_id: u32) -> Self {
+        Self {
+            transport,
+            local_id,
+            remote_id,
+        }
+    }
+}
+
+impl<T: ADBMessageTransport> Write for MessageWriter<T> {
+    fn write(&mut self, buf: &[u8]) -> Result<usize> {
+        let message =
+            ADBTransportMessage::new(MessageCommand::Write, self.local_id, self.remote_id, buf);
+        self.transport
+            .write_message(message)
+            .map_err(|e| Error::new(ErrorKind::InvalidData, e))?;
+
+        match self.transport.read_message() {
+            Ok(response) => {
+                response
+                    .assert_command(MessageCommand::Okay)
+                    .map_err(|e| Error::new(ErrorKind::Other, e))?;
+                Ok(buf.len())
+            }
+            Err(e) => Err(Error::new(ErrorKind::Other, e)),
+        }
+    }
+
+    fn flush(&mut self) -> Result<()> {
+        Ok(())
+    }
+}

adb_client/src/device/mod.rs

@@ -0,0 +1,17 @@
+mod adb_message_device;
+mod adb_message_device_commands;
+mod adb_tcp_device;
+mod adb_transport_message;
+mod adb_usb_device;
+mod commands;
+mod message_writer;
+mod models;
+mod shell_message_writer;
+
+use adb_message_device::ADBMessageDevice;
+pub use adb_tcp_device::ADBTcpDevice;
+pub use adb_transport_message::{ADBTransportMessage, ADBTransportMessageHeader};
+pub use adb_usb_device::{ADBUSBDevice, get_default_adb_key_path};
+pub use message_writer::MessageWriter;
+pub use models::{ADBRsaKey, MessageCommand, MessageSubcommand};
+pub use shell_message_writer::ShellMessageWriter;

adb_client/src/device/models/adb_rsa_key.rs

@@ -0,0 +1,174 @@
+use crate::{Result, RustADBError};
+use base64::{Engine, engine::general_purpose::STANDARD};
+use num_bigint::{BigUint, ModInverse};
+use num_traits::FromPrimitive;
+use num_traits::cast::ToPrimitive;
+use rsa::pkcs8::DecodePrivateKey;
+use rsa::traits::PublicKeyParts;
+use rsa::{Pkcs1v15Sign, RsaPrivateKey};
+
+const ADB_PRIVATE_KEY_SIZE: usize = 2048;
+const ANDROID_PUBKEY_MODULUS_SIZE_WORDS: u32 = 64;
+
+#[repr(C)]
+#[derive(Debug, Default)]
+/// Internal ADB representation of a public key
+struct ADBRsaInternalPublicKey {
+    pub modulus_size_words: u32,
+    pub n0inv: u32,
+    pub modulus: BigUint,
+    pub rr: Vec<u8>,
+    pub exponent: u32,
+}
+
+impl ADBRsaInternalPublicKey {
+    pub fn new(exponent: &BigUint, modulus: &BigUint) -> Result<Self> {
+        Ok(Self {
+            modulus_size_words: ANDROID_PUBKEY_MODULUS_SIZE_WORDS,
+            exponent: exponent.to_u32().ok_or(RustADBError::ConversionError)?,
+            modulus: modulus.clone(),
+            ..Default::default()
+        })
+    }
+
+    pub fn into_bytes(mut self) -> Vec<u8> {
+        let mut bytes: Vec<u8> = Vec::new();
+        bytes.append(&mut self.modulus_size_words.to_le_bytes().to_vec());
+        bytes.append(&mut self.n0inv.to_le_bytes().to_vec());
+        bytes.append(&mut self.modulus.to_bytes_le());
+        bytes.append(&mut self.rr);
+        bytes.append(&mut self.exponent.to_le_bytes().to_vec());
+
+        bytes
+    }
+}
+
+#[derive(Debug, Clone)]
+pub struct ADBRsaKey {
+    private_key: RsaPrivateKey,
+}
+
+impl ADBRsaKey {
+    pub fn new_random() -> Result<Self> {
+        Ok(Self {
+            private_key: RsaPrivateKey::new(&mut rsa::rand_core::OsRng, ADB_PRIVATE_KEY_SIZE)?,
+        })
+    }
+
+    pub fn new_from_pkcs8(pkcs8_content: &str) -> Result<Self> {
+        Ok(ADBRsaKey {
+            private_key: RsaPrivateKey::from_pkcs8_pem(pkcs8_content)?,
+        })
+    }
+
+    pub fn android_pubkey_encode(&self) -> Result<String> {
+        // Helped from project: https://github.com/hajifkd/webadb
+        // Source code: https://android.googlesource.com/platform/system/core/+/refs/heads/main/libcrypto_utils/android_pubkey.cpp
+        // Useful function `android_pubkey_encode()`
+        let mut adb_rsa_pubkey =
+            ADBRsaInternalPublicKey::new(self.private_key.e(), self.private_key.n())?;
+
+        // r32 = 2 ^ 32
+        let r32 = BigUint::from_u64(1 << 32).ok_or(RustADBError::ConversionError)?;
+
+        // r = 2 ^ rsa_size = 2 ^ 2048
+        let r = set_bit(ADB_PRIVATE_KEY_SIZE)?;
+
+        // rr = r ^ 2 mod N
+        let rr = r.modpow(&BigUint::from(2u32), &adb_rsa_pubkey.modulus);
+        adb_rsa_pubkey.rr = rr.to_bytes_le();
+
+        // rem = N[0]
+        let rem = &adb_rsa_pubkey.modulus % &r32;
+
+        // n0inv = -1 / rem mod r32
+        let n0inv = rem
+            .mod_inverse(&r32)
+            .and_then(|v| v.to_biguint())
+            .ok_or(RustADBError::ConversionError)?;
+
+        // BN_sub(n0inv, r32, n0inv)
+        adb_rsa_pubkey.n0inv = (r32 - n0inv)
+            .to_u32()
+            .ok_or(RustADBError::ConversionError)?;
+
+        Ok(self.encode_public_key(adb_rsa_pubkey.into_bytes()))
+    }
+
+    fn encode_public_key(&self, pub_key: Vec<u8>) -> String {
+        let mut encoded = STANDARD.encode(pub_key);
+        encoded.push(' ');
+        encoded.push_str(&format!("adb_client@{}", env!("CARGO_PKG_VERSION")));
+
+        encoded
+    }
+
+    pub fn sign(&self, msg: impl AsRef<[u8]>) -> Result<Vec<u8>> {
+        Ok(self
+            .private_key
+            .sign(Pkcs1v15Sign::new::<sha1::Sha1>(), msg.as_ref())?)
+    }
+}
+
+fn set_bit(n: usize) -> Result<BigUint> {
+    BigUint::parse_bytes(
+        &{
+            let mut bits = vec![b'1'];
+            bits.append(&mut vec![b'0'; n]);
+            bits
+        }[..],
+        2,
+    )
+    .ok_or(RustADBError::ConversionError)
+}
+
+#[test]
+fn test_pubkey_gen() {
+    const DEFAULT_PRIV_KEY: &'static str = r"-----BEGIN PRIVATE KEY-----
+MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQC4Dyn85cxDJnjM
+uYXQl/w469MDKdlGdviLfmFMWeYLVfL2Mz1AVyvKqscrtlhbbgMQ/M+3lDvEdHS0
+14RIGAwWRtrlTTmhLvM2/IO+eSKSYeCrCVc4KLG3E3WRryUXbs2ynA29xjTJVw+Z
+xYxDyn/tAYPEyMm4v+HIJHcOtRzxtO2vjMJ2vBT/ywYxjhncXbFSO09q2E4XrHli
+SIPyO82hZgCkpzTZRp+nyA17TYuV9++mvUr9lWH9RbC+o8EF3yitlBsE2uXr97EV
+i2Qy8CE7FIxsihXlukppwKRuz+1rJrvmZPTn49ZS+sIS99WE9GoCpsyQvTpvehrM
+SIDRsVZPAgMBAAECggEAWNXAzzXeS36zCSR1yILCknqHotw86Pyc4z7BGUe+dzQp
+itiaNIaeNTgN3zQoGyDSzA0o+BLMcfo/JdVrHBy3IL1cAxYtvXTaoGxp7bGrlPk2
+pXZhqVJCy/jRYtokzdWF5DHbk/+pFJA3kGE/XKzM54g2n/DFI61A/QdUiz2w1ZtI
+vc5cM08EM8B/TSI3SeWB8zkh5SlIuLsFO2J2+tCak6PdFfKOVIrFv9dKJYLxx+59
++edZamw2EvNlnl/sewgUk0gaZvQKVf4ivHyM+KSHuV4RFfiLvGuVcyA6XhSjztsG
+EA++jDHP5ib/Izes7UK09v9y7kow+z6vUtnDDQOvgQKBgQD8WWAn7FQt9aziCw19
+gZynzHG1bXI7uuEVSneuA3UwJImmDu8W+Qb9YL9Dc2nV0M5pGGdXKi2jzq8gPar6
+GPAmy7TOlov6Nm0pbMXTAfuovG+gIXxelp3US3FvyRupi0/7UQRRwvetFYbDFwJX
+ydF5uEtZdGSHAjPeU5FLq6tBwQKBgQC6uN0JwwZn+eaxguyKOXvp0KykhFI0HI1A
+MBDZ1uuKt6OW5+r9NeQtTLctGlNKVQ8wz+Wr0C/nLGIIv4lySS9WFyc5/FnFhDdy
+LsEi6whcca4vq3jsMOukvQGFnERsou4LqBEI1Es7jjeeEq+/8WnNTi6Y1flZ6UAp
+YAOeFI98DwKBgQDvyfHgHeajwZalOQF5qGb24AOQ9c4dyefGNnvhA/IgbCfMftZc
+iwhETuGQM6R3A7KQFRtlrXOu+2BYD6Ffg8D37IwD3vRmL7+tJGoapwC/B0g+7nLi
+4tZY+9Nv+LbrdbDry8GB+/UkKJdk3IFicCk4M5KOD1bTH5mwAtLHB/p1QQKBgDHi
+k8M45GxA+p4wMUvYgb987bLiWyfq/N3KOaZJYhJkb4MwoLpXfIeRuFqHbvsr8GwF
+DwIxE6s6U1KtAWaUIN5qPyOhxMYdRcbusNDIZCp2gKfhsuO/SiVwDYkJr8oqWVip
+5SsrtJHLtBY6PdQVBkRAf/h7KiwYQfkL2suQCKmHAoGBAJAkYImBYPHuRcnSXikn
+xGDK/moPvzs0CjdPlRcEN+Myy/G0FUrOaC0FcpNoJOdQSYz3F6URA4nX+zj6Ie7G
+CNkECiepaGyquQaffwR1CAi8dH6biJjlTQWQPFcCLA0hvernWo3eaSfiL7fHyym+
+ile69MHFENUePSpuRSiF3Z02
+-----END PRIVATE KEY-----";
+    let priv_key =
+        ADBRsaKey::new_from_pkcs8(DEFAULT_PRIV_KEY).expect("cannot create rsa key from data");
+    let pub_key = priv_key
+        .android_pubkey_encode()
+        .expect("cannot encode public key");
+    let pub_key_adb = "\
+QAAAAFH/pU9PVrHRgEjMGnpvOr2QzKYCavSE1fcSwvpS1uPn9GTmuyZr7c9up\
+MBpSrrlFYpsjBQ7IfAyZIsVsffr5doEG5StKN8FwaO+sEX9YZX9Sr2m7/eVi0\
+17Dcinn0bZNKekAGahzTvyg0hieawXTthqTztSsV3cGY4xBsv/FLx2woyv7bT\
+xHLUOdyTI4b+4ycjEgwHtf8pDjMWZD1fJNMa9DZyyzW4XJa+RdRO3sSg4Vwmr\
+4GGSInm+g/w28y6hOU3l2kYWDBhIhNe0dHTEO5S3z/wQA25bWLYrx6rKK1dAP\
+TP28lUL5llMYX6L+HZG2SkD0+s4/JfQhbnMeCZDzOX8KQ+4ThLy/gDTqCSTjj\
+ic8BykdUIqYPwAjBMgQwLOLY5WNJMpjGlFINRcCGhvFFZ73sJTLerECuV/Oae\
+nFRcORwnGIRgMrYXj4tjmxJC7sq3cfNX96YIcSCDE9SZFdlKXVK8Jc4YMLGF3\
+MI8k1KoTby34uaIyxPJvwM1WR4Rdj60fwMyikFXNaOR2fPteZ3UMBA7CMrOEm\
+9iYjntyEppA4hQXIO1TWTzkA/Kfl1i67k5NuLIQdhPFEc5ox5IYVHusauPQ7d\
+Awu6BlgK37TUn0JdK0Z6Z4RaEIaNiEI0d5CoP6zQKV2QQnlscYpdsaUW5t9/F\
+LioVXPwrz0tx35JyIUZPPYwEAAQA= ";
+    assert_eq!(&pub_key[..pub_key_adb.len()], pub_key_adb);
+}

adb_client/src/device/models/message_commands.rs

@@ -4,43 +4,43 @@ use std::fmt::Display;
 
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Serialize_repr, Deserialize_repr)]
 #[repr(u32)]
-pub enum USBCommand {
+pub enum MessageCommand {
     /// Connect to a device
-    Cnxn = 0x4e584e43,
+    Cnxn = 0x4E584E43,
     /// Close connection to a device
-    Clse = 0x45534c43,
+    Clse = 0x45534C43,
     /// Device ask for authentication
     Auth = 0x48545541,
     /// Open a data connection
-    Open = 0x4e45504f,
+    Open = 0x4E45504F,
     /// Write data to connection
     Write = 0x45545257,
     /// Server understood the message
-    Okay = 0x59414b4f,
-    // Sync 0x434e5953
-    // Stls 0x534C5453
+    Okay = 0x59414B4F,
+    /// Start a connection using TLS
+    Stls = 0x534C5453,
 }
 
 #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize_repr, Deserialize_repr)]
 #[repr(u32)]
-pub enum USBSubcommand {
+pub enum MessageSubcommand {
     Stat = 0x54415453,
     Send = 0x444E4553,
     Recv = 0x56434552,
     Quit = 0x54495551,
-    Fail = 0x4c494146,
-    Done = 0x454e4f44,
+    Fail = 0x4C494146,
+    Done = 0x454E4F44,
     Data = 0x41544144,
-    List = 0x5453494c,
+    List = 0x5453494C,
 }
 
 #[derive(Debug, Serialize, Deserialize)]
 pub struct SubcommandWithArg {
-    subcommand: USBSubcommand,
+    subcommand: MessageSubcommand,
     arg: u32,
 }
 
-impl USBSubcommand {
+impl MessageSubcommand {
     pub fn with_arg(self, arg: u32) -> SubcommandWithArg {
         SubcommandWithArg {
             subcommand: self,
@@ -49,15 +49,16 @@ impl USBSubcommand {
     }
 }
 
-impl Display for USBCommand {
+impl Display for MessageCommand {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            USBCommand::Cnxn => write!(f, "CNXN"),
-            USBCommand::Clse => write!(f, "CLSE"),
-            USBCommand::Auth => write!(f, "AUTH"),
-            USBCommand::Open => write!(f, "OPEN"),
-            USBCommand::Write => write!(f, "WRTE"),
-            USBCommand::Okay => write!(f, "OKAY"),
+            MessageCommand::Cnxn => write!(f, "CNXN"),
+            MessageCommand::Clse => write!(f, "CLSE"),
+            MessageCommand::Auth => write!(f, "AUTH"),
+            MessageCommand::Open => write!(f, "OPEN"),
+            MessageCommand::Write => write!(f, "WRTE"),
+            MessageCommand::Okay => write!(f, "OKAY"),
+            MessageCommand::Stls => write!(f, "STLS"),
         }
     }
 }

adb_client/src/device/models/mod.rs

@@ -0,0 +1,5 @@
+mod adb_rsa_key;
+mod message_commands;
+
+pub use adb_rsa_key::ADBRsaKey;
+pub use message_commands::{MessageCommand, MessageSubcommand};

adb_client/src/device/shell_message_writer.rs

@@ -0,0 +1,37 @@
+use std::io::Write;
+
+use crate::ADBMessageTransport;
+
+use super::{ADBTransportMessage, models::MessageCommand};
+
+/// [`Write`] trait implementation to hide underlying ADB protocol write logic for shell commands.
+pub struct ShellMessageWriter<T: ADBMessageTransport> {
+    transport: T,
+    local_id: u32,
+    remote_id: u32,
+}
+
+impl<T: ADBMessageTransport> ShellMessageWriter<T> {
+    pub fn new(transport: T, local_id: u32, remote_id: u32) -> Self {
+        Self {
+            transport,
+            local_id,
+            remote_id,
+        }
+    }
+}
+
+impl<T: ADBMessageTransport> Write for ShellMessageWriter<T> {
+    fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
+        let message =
+            ADBTransportMessage::new(MessageCommand::Write, self.local_id, self.remote_id, buf);
+        self.transport
+            .write_message(message)
+            .map_err(|e| std::io::Error::new(std::io::ErrorKind::InvalidData, e))?;
+        Ok(buf.len())
+    }
+
+    fn flush(&mut self) -> std::io::Result<()> {
+        Ok(())
+    }
+}

adb_client/src/emulator/rotate.rs

@@ -1,10 +0,0 @@
-use crate::{models::ADBEmulatorCommand, ADBEmulatorDevice, Result};
-
-impl ADBEmulatorDevice {
-    /// Send a SMS to this emulator with given content with given phone number
-    pub fn rotate(&mut self) -> Result<()> {
-        let transport = self.connect()?;
-        transport.send_command(ADBEmulatorCommand::Rotate)?;
-        Ok(())
-    }
-}

adb_client/src/emulator_device/adb_emulator_device.rs

@@ -1,15 +1,14 @@
-use std::net::{Ipv4Addr, SocketAddrV4};
+use std::{
+    net::{Ipv4Addr, SocketAddrV4},
+    sync::LazyLock,
+};
 
-use crate::{ADBTransport, Result, RustADBError, TCPEmulatorTransport};
-use lazy_static::lazy_static;
+use crate::{ADBServerDevice, ADBTransport, Result, RustADBError, TCPEmulatorTransport};
 use regex::Regex;
 
-use super::ADBServerDevice;
-
-lazy_static! {
-    pub static ref EMULATOR_REGEX: Regex =
-        Regex::new("^emulator-(?P<port>\\d+)$").expect("wrong syntax for emulator regex");
-}
+static EMULATOR_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new("^emulator-(?P<port>\\d+)$").expect("wrong syntax for emulator regex")
+});
 
 /// Represents an emulator connected to the ADB server.
 #[derive(Debug)]
@@ -66,10 +65,15 @@ impl TryFrom<ADBServerDevice> for ADBEmulatorDevice {
     type Error = RustADBError;
 
     fn try_from(value: ADBServerDevice) -> std::result::Result<Self, Self::Error> {
-        ADBEmulatorDevice::new(
-            value.identifier.clone(),
-            Some(*value.get_transport().get_socketaddr().ip()),
-        )
+        match &value.identifier {
+            Some(device_identifier) => ADBEmulatorDevice::new(
+                device_identifier.clone(),
+                Some(*value.transport.get_socketaddr().ip()),
+            ),
+            None => Err(RustADBError::DeviceNotFound(
+                "cannot connect to an emulator device without knowing its identifier".to_string(),
+            )),
+        }
     }
 }
 

adb_client/src/emulator_device/commands/rotate.rs

@@ -0,0 +1,8 @@
+use crate::{ADBEmulatorDevice, Result, emulator_device::ADBEmulatorCommand};
+
+impl ADBEmulatorDevice {
+    /// Send a SMS to this emulator with given content with given phone number
+    pub fn rotate(&mut self) -> Result<()> {
+        self.connect()?.send_command(ADBEmulatorCommand::Rotate)
+    }
+}

adb_client/src/emulator_device/commands/sms.rs

@@ -1,13 +1,11 @@
-use crate::{models::ADBEmulatorCommand, ADBEmulatorDevice, Result};
+use crate::{ADBEmulatorDevice, Result, emulator_device::ADBEmulatorCommand};
 
 impl ADBEmulatorDevice {
     /// Send a SMS to this emulator with given content with given phone number
     pub fn send_sms(&mut self, phone_number: &str, content: &str) -> Result<()> {
-        let transport = self.connect()?;
-        transport.send_command(ADBEmulatorCommand::Sms(
+        self.connect()?.send_command(ADBEmulatorCommand::Sms(
             phone_number.to_string(),
             content.to_string(),
-        ))?;
-        Ok(())
+        ))
     }
 }

adb_client/src/emulator_device/mod.rs

@@ -0,0 +1,5 @@
+mod adb_emulator_device;
+mod commands;
+mod models;
+pub use adb_emulator_device::ADBEmulatorDevice;
+pub(crate) use models::ADBEmulatorCommand;

adb_client/src/emulator_device/models/adb_emulator_command.rs

@@ -1,6 +1,6 @@
 use std::fmt::Display;
 
-pub(crate) enum ADBEmulatorCommand {
+pub enum ADBEmulatorCommand {
     Authenticate(String),
     Sms(String, String),
     Rotate,

adb_client/src/emulator_device/models/mod.rs

@@ -0,0 +1,2 @@
+mod adb_emulator_command;
+pub use adb_emulator_command::ADBEmulatorCommand;

adb_client/src/error.rs

@@ -15,6 +15,9 @@ pub enum RustADBError {
     /// Indicates that ADB server responded an unknown response type.
     #[error("Unknown response type {0}")]
     UnknownResponseType(String),
+    /// Indicated that an unexpected command has been received
+    #[error("Wrong response command received: {0}. Expected {1}")]
+    WrongResponseReceived(String, String),
     /// Indicates that ADB server responses an unknown device state.
     #[error("Unknown device state {0}")]
     UnknownDeviceState(String),
@@ -64,7 +67,7 @@ pub enum RustADBError {
     #[error("Cannot get home directory")]
     NoHomeDirectory,
     /// Generic USB error
-    #[error(transparent)]
+    #[error("USB Error: {0}")]
     UsbError(#[from] rusb::Error),
     /// USB device not found
     #[error("USB Device not found: {0} {1}")]
@@ -87,4 +90,40 @@ pub enum RustADBError {
     /// Cannot convert given data from slice
     #[error(transparent)]
     TryFromSliceError(#[from] std::array::TryFromSliceError),
+    /// Given path does not represent an APK
+    #[error("wrong file extension: {0}")]
+    WrongFileExtension(String),
+    /// An error occurred with PKCS8 data
+    #[error("error with pkcs8: {0}")]
+    RsaPkcs8Error(#[from] rsa::pkcs8::Error),
+    /// Error during certificate generation
+    #[error(transparent)]
+    CertificateGenerationError(#[from] rcgen::Error),
+    /// TLS Error
+    #[error(transparent)]
+    TLSError(#[from] rustls::Error),
+    /// PEM certificate error
+    #[error(transparent)]
+    PemCertError(#[from] rustls_pki_types::pem::Error),
+    /// Error while locking mutex
+    #[error("error while locking data")]
+    PoisonError,
+    /// Cannot upgrade connection from TCP to TLS
+    #[error("upgrade error: {0}")]
+    UpgradeError(String),
+    /// An error occurred while getting mdns devices
+    #[error(transparent)]
+    MDNSError(#[from] mdns_sd::Error),
+    /// An error occurred while sending data to channel
+    #[error(transparent)]
+    SendError(#[from] std::sync::mpsc::SendError<crate::MDNSDevice>),
+    /// An unknown transport has been provided
+    #[error("unknown transport: {0}")]
+    UnknownTransport(String),
+}
+
+impl<T> From<std::sync::PoisonError<T>> for RustADBError {
+    fn from(_err: std::sync::PoisonError<T>) -> Self {
+        Self::PoisonError
+    }
 }

adb_client/src/lib.rs

@@ -6,17 +6,22 @@
 
 mod adb_device_ext;
 mod constants;
-mod emulator;
+mod device;
+mod emulator_device;
 mod error;
+mod mdns;
 mod models;
 mod server;
+mod server_device;
 mod transports;
-mod usb;
 mod utils;
 
 pub use adb_device_ext::ADBDeviceExt;
+pub use device::{ADBTcpDevice, ADBUSBDevice};
+pub use emulator_device::ADBEmulatorDevice;
 pub use error::{Result, RustADBError};
-pub use models::{AdbVersion, DeviceLong, DeviceShort, DeviceState, RebootType};
+pub use mdns::*;
+pub use models::{AdbStatResponse, RebootType};
 pub use server::*;
+pub use server_device::ADBServerDevice;
 pub use transports::*;
-pub use usb::ADBUSBDevice;

adb_client/src/mdns/mdns_device.rs

@@ -0,0 +1,19 @@
+use std::{collections::HashSet, net::IpAddr};
+
+/// Represent a device found from mdns search
+#[derive(Debug)]
+pub struct MDNSDevice {
+    /// Full device address when resolved
+    pub fullname: String,
+    /// Device IP addresses
+    pub addresses: HashSet<IpAddr>,
+}
+
+impl From<mdns_sd::ServiceInfo> for MDNSDevice {
+    fn from(value: mdns_sd::ServiceInfo) -> Self {
+        Self {
+            fullname: value.get_fullname().to_string(),
+            addresses: value.get_addresses().to_owned(),
+        }
+    }
+}

adb_client/src/mdns/mdns_discovery.rs

@@ -0,0 +1,75 @@
+use mdns_sd::{ServiceDaemon, ServiceEvent};
+use std::{sync::mpsc::Sender, thread::JoinHandle};
+
+use crate::{MDNSDevice, Result, RustADBError};
+
+const ADB_SERVICE_NAME: &str = "_adb-tls-connect._tcp.local.";
+
+/// Structure holding responsibility over mdns discovery
+pub struct MDNSDiscoveryService {
+    daemon: ServiceDaemon,
+    thread_handle: Option<JoinHandle<Result<()>>>,
+}
+
+impl std::fmt::Debug for MDNSDiscoveryService {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("MDNSDiscoveryService")
+            .field("daemon", &self.daemon.get_metrics())
+            .field("handle", &self.thread_handle)
+            .finish()
+    }
+}
+
+impl MDNSDiscoveryService {
+    /// Instantiate a new discovery service to find devices over mdns
+    pub fn new() -> Result<Self> {
+        Ok(MDNSDiscoveryService {
+            daemon: ServiceDaemon::new()?,
+            thread_handle: None,
+        })
+    }
+
+    /// Start discovery by spawning a new thread responsible of getting events.
+    pub fn start(&mut self, sender: Sender<MDNSDevice>) -> Result<()> {
+        let receiver = self.daemon.browse(ADB_SERVICE_NAME)?;
+
+        let handle: JoinHandle<Result<()>> = std::thread::spawn(move || {
+            loop {
+                while let Ok(event) = receiver.recv() {
+                    match event {
+                        ServiceEvent::SearchStarted(_)
+                        | ServiceEvent::ServiceRemoved(_, _)
+                        | ServiceEvent::ServiceFound(_, _)
+                        | ServiceEvent::SearchStopped(_) => {
+                            // Ignoring these events. We are only interesting in found devices
+                            continue;
+                        }
+                        ServiceEvent::ServiceResolved(service_info) => {
+                            if let Err(e) = sender.send(MDNSDevice::from(service_info)) {
+                                return Err(e.into());
+                            }
+                        }
+                    }
+                }
+            }
+        });
+
+        self.thread_handle = Some(handle);
+
+        Ok(())
+    }
+
+    /// Shutdown discovery engines.
+    pub fn shutdown(&mut self) -> Result<()> {
+        match self.daemon.shutdown() {
+            Ok(_) => Ok(()),
+            Err(e) => match e {
+                mdns_sd::Error::Again => {
+                    self.daemon.shutdown()?;
+                    Ok(())
+                }
+                e => Err(RustADBError::MDNSError(e)),
+            },
+        }
+    }
+}

adb_client/src/mdns/mod.rs

@@ -0,0 +1,5 @@
+mod mdns_device;
+mod mdns_discovery;
+
+pub use mdns_device::MDNSDevice;
+pub use mdns_discovery::MDNSDiscoveryService;

adb_client/src/models/adb_server_command.rs

@@ -1,5 +1,7 @@
 use std::fmt::Display;
 
+use crate::{WaitForDeviceState, WaitForDeviceTransport};
+
 use super::RebootType;
 use std::net::SocketAddrV4;
 
@@ -16,14 +18,26 @@ pub(crate) enum AdbServerCommand {
     Pair(SocketAddrV4, String),
     TransportAny,
     TransportSerial(String),
+    MDNSCheck,
+    MDNSServices,
+    ServerStatus,
+    ReconnectOffline,
+    Uninstall(String),
+    Install(u64),
+    WaitForDevice(WaitForDeviceState, WaitForDeviceTransport),
     // Local commands
     ShellCommand(String),
     Shell,
     FrameBuffer,
     Sync,
     Reboot(RebootType),
-    Forward(String, String, String),
+    Forward(String, String),
+    ForwardRemoveAll,
     Reverse(String, String),
+    ReverseRemoveAll,
+    Reconnect,
+    TcpIp(u16),
+    Usb,
 }
 
 impl Display for AdbServerCommand {
@@ -55,12 +69,33 @@ impl Display for AdbServerCommand {
                 write!(f, "host:pair:{code}:{addr}")
             }
             AdbServerCommand::FrameBuffer => write!(f, "framebuffer:"),
-            AdbServerCommand::Forward(serial, remote, local) => {
-                write!(f, "host-serial:{serial}:forward:{local};{remote}")
+            AdbServerCommand::Forward(remote, local) => {
+                write!(f, "host:forward:{local};{remote}")
             }
+            AdbServerCommand::ForwardRemoveAll => write!(f, "host:killforward-all"),
             AdbServerCommand::Reverse(remote, local) => {
                 write!(f, "reverse:forward:{remote};{local}")
             }
+            AdbServerCommand::ReverseRemoveAll => write!(f, "reverse:killforward-all"),
+            AdbServerCommand::MDNSCheck => write!(f, "host:mdns:check"),
+            AdbServerCommand::MDNSServices => write!(f, "host:mdns:services"),
+            AdbServerCommand::ServerStatus => write!(f, "host:server-status"),
+            AdbServerCommand::Reconnect => write!(f, "reconnect"),
+            AdbServerCommand::ReconnectOffline => write!(f, "host:reconnect-offline"),
+            AdbServerCommand::TcpIp(port) => {
+                write!(f, "tcpip:{port}")
+            }
+            AdbServerCommand::Usb => write!(f, "usb:"),
+            AdbServerCommand::Install(size) => write!(f, "exec:cmd package 'install' -S {size}"),
+            AdbServerCommand::Uninstall(package) => {
+                write!(f, "exec:cmd package 'uninstall' {package}")
+            }
+            AdbServerCommand::WaitForDevice(wait_for_device_state, wait_for_device_transport) => {
+                write!(
+                    f,
+                    "host:wait-for-{wait_for_device_transport}-{wait_for_device_state}"
+                )
+            }
         }
     }
 }

adb_client/src/models/adb_stat_response.rs

@@ -8,10 +8,14 @@ use std::{
 use byteorder::LittleEndian;
 use serde::{Deserialize, Serialize};
 
+/// Represents a `stat` response
 #[derive(Debug, Deserialize, Serialize)]
 pub struct AdbStatResponse {
+    /// File permissions
     pub file_perm: u32,
+    /// File size, in bytes
     pub file_size: u32,
+    /// File modification time
     pub mod_time: u32,
 }
 

adb_client/src/models/framebuffer_info.rs

@@ -0,0 +1,97 @@
+use std::{iter::Map, slice::ChunksExact};
+
+use byteorder::{ByteOrder, LittleEndian};
+
+use crate::{Result, RustADBError};
+
+type U32ChunkIter<'a> = Map<ChunksExact<'a, u8>, fn(&[u8]) -> Result<u32>>;
+
+fn read_next(chunks: &mut U32ChunkIter) -> Result<u32> {
+    chunks
+        .next()
+        .ok_or(RustADBError::FramebufferConversionError)?
+}
+
+#[derive(Debug)]
+pub(crate) struct FrameBufferInfoV1 {
+    pub _bpp: u32,
+    pub size: u32,
+    pub width: u32,
+    pub height: u32,
+    pub _red_offset: u32,
+    pub _red_length: u32,
+    pub _blue_offset: u32,
+    pub _blue_length: u32,
+    pub _green_offset: u32,
+    pub _green_length: u32,
+    pub _alpha_offset: u32,
+    pub _alpha_length: u32,
+}
+
+impl TryFrom<[u8; std::mem::size_of::<Self>()]> for FrameBufferInfoV1 {
+    type Error = RustADBError;
+
+    fn try_from(
+        value: [u8; std::mem::size_of::<Self>()],
+    ) -> std::result::Result<Self, Self::Error> {
+        let mut chunks: U32ChunkIter = value.chunks_exact(4).map(|v| Ok(LittleEndian::read_u32(v)));
+
+        Ok(Self {
+            _bpp: read_next(&mut chunks)?,
+            size: read_next(&mut chunks)?,
+            width: read_next(&mut chunks)?,
+            height: read_next(&mut chunks)?,
+            _red_offset: read_next(&mut chunks)?,
+            _red_length: read_next(&mut chunks)?,
+            _blue_offset: read_next(&mut chunks)?,
+            _blue_length: read_next(&mut chunks)?,
+            _green_offset: read_next(&mut chunks)?,
+            _green_length: read_next(&mut chunks)?,
+            _alpha_offset: read_next(&mut chunks)?,
+            _alpha_length: read_next(&mut chunks)?,
+        })
+    }
+}
+
+#[derive(Debug)]
+pub(crate) struct FrameBufferInfoV2 {
+    pub _bpp: u32,
+    pub _color_space: u32,
+    pub size: u32,
+    pub width: u32,
+    pub height: u32,
+    pub _red_offset: u32,
+    pub _red_length: u32,
+    pub _blue_offset: u32,
+    pub _blue_length: u32,
+    pub _green_offset: u32,
+    pub _green_length: u32,
+    pub _alpha_offset: u32,
+    pub _alpha_length: u32,
+}
+
+impl TryFrom<[u8; std::mem::size_of::<Self>()]> for FrameBufferInfoV2 {
+    type Error = RustADBError;
+
+    fn try_from(
+        value: [u8; std::mem::size_of::<Self>()],
+    ) -> std::result::Result<Self, Self::Error> {
+        let mut chunks: U32ChunkIter = value.chunks_exact(4).map(|v| Ok(LittleEndian::read_u32(v)));
+
+        Ok(Self {
+            _bpp: read_next(&mut chunks)?,
+            _color_space: read_next(&mut chunks)?,
+            size: read_next(&mut chunks)?,
+            width: read_next(&mut chunks)?,
+            height: read_next(&mut chunks)?,
+            _red_offset: read_next(&mut chunks)?,
+            _red_length: read_next(&mut chunks)?,
+            _blue_offset: read_next(&mut chunks)?,
+            _blue_length: read_next(&mut chunks)?,
+            _green_offset: read_next(&mut chunks)?,
+            _green_length: read_next(&mut chunks)?,
+            _alpha_offset: read_next(&mut chunks)?,
+            _alpha_length: read_next(&mut chunks)?,
+        })
+    }
+}

adb_client/src/models/mod.rs

@@ -1,23 +1,15 @@
-mod adb_emulator_command;
 mod adb_request_status;
 mod adb_server_command;
 mod adb_stat_response;
-mod adb_version;
-mod device_long;
-mod device_short;
-mod device_state;
+mod framebuffer_info;
 mod host_features;
 mod reboot_type;
 mod sync_command;
 
-pub(crate) use adb_emulator_command::ADBEmulatorCommand;
 pub use adb_request_status::AdbRequestStatus;
 pub(crate) use adb_server_command::AdbServerCommand;
 pub use adb_stat_response::AdbStatResponse;
-pub use adb_version::AdbVersion;
-pub use device_long::DeviceLong;
-pub use device_short::DeviceShort;
-pub use device_state::DeviceState;
+pub(crate) use framebuffer_info::{FrameBufferInfoV1, FrameBufferInfoV2};
 pub use host_features::HostFeatures;
 pub use reboot_type::RebootType;
 pub use sync_command::SyncCommand;

adb_client/src/models/reboot_type.rs

@@ -13,6 +13,8 @@ pub enum RebootType {
     Sideload,
     /// Same as `Sideload` but reboots after sideloading
     SideloadAutoReboot,
+    /// Reboots to fastboot
+    Fastboot,
 }
 
 impl Display for RebootType {
@@ -23,6 +25,7 @@ impl Display for RebootType {
             RebootType::Recovery => write!(f, "recovery"),
             RebootType::Sideload => write!(f, "sideload"),
             RebootType::SideloadAutoReboot => write!(f, "sideload-auto-reboot"),
+            RebootType::Fastboot => write!(f, "fastboot"),
         }
     }
 }

adb_client/src/server/adb_server.rs

@@ -2,6 +2,7 @@ use crate::ADBTransport;
 use crate::Result;
 use crate::RustADBError;
 use crate::TCPServerTransport;
+use std::collections::HashMap;
 use std::net::SocketAddrV4;
 use std::process::Command;
 
@@ -12,6 +13,11 @@ pub struct ADBServer {
     pub(crate) transport: Option<TCPServerTransport>,
     /// Address to connect to
     pub(crate) socket_addr: Option<SocketAddrV4>,
+    /// adb-server start envs
+    pub(crate) envs: HashMap<String, String>,
+    /// Path to adb binary
+    /// If not set, will use adb from PATH
+    pub(crate) adb_path: Option<String>,
 }
 
 impl ADBServer {
@@ -20,6 +26,45 @@ impl ADBServer {
         Self {
             transport: None,
             socket_addr: Some(address),
+            envs: HashMap::new(),
+            adb_path: None,
+        }
+    }
+
+    /// Instantiates a new [ADBServer] with a custom adb path
+    pub fn new_from_path(address: SocketAddrV4, adb_path: Option<String>) -> Self {
+        Self {
+            transport: None,
+            socket_addr: Some(address),
+            envs: HashMap::new(),
+            adb_path,
+        }
+    }
+
+    /// Start an instance of `adb-server`
+    pub fn start(envs: &HashMap<String, String>, adb_path: &Option<String>) {
+        // ADB Server is local, we start it if not already running
+        let mut command = Command::new(adb_path.as_deref().unwrap_or("adb"));
+        command.arg("start-server");
+        for (env_k, env_v) in envs.iter() {
+            command.env(env_k, env_v);
+        }
+
+        #[cfg(target_os = "windows")]
+        {
+            use std::os::windows::process::CommandExt;
+            // Do not show a prompt on Windows
+            command.creation_flags(0x08000000);
+        }
+
+        let child = command.spawn();
+        match child {
+            Ok(mut child) => {
+                if let Err(e) = child.wait() {
+                    log::error!("error while starting adb server: {e}")
+                }
+            }
+            Err(e) => log::error!("error while starting adb server: {e}"),
         }
     }
 
@@ -48,16 +93,7 @@ impl ADBServer {
         };
 
         if is_local_ip {
-            // ADB Server is local, we start it if not already running
-            let child = Command::new("adb").arg("start-server").spawn();
-            match child {
-                Ok(mut child) => {
-                    if let Err(e) = child.wait() {
-                        log::error!("error while starting adb server: {e}")
-                    }
-                }
-                Err(e) => log::error!("error while starting adb server: {e}"),
-            }
+            Self::start(&self.envs, &self.adb_path);
         }
 
         transport.connect()?;
@@ -69,7 +105,7 @@ impl ADBServer {
 
 impl Drop for ADBServer {
     fn drop(&mut self) {
-        if let Some(ref mut transport) = &mut self.transport {
+        if let Some(transport) = &mut self.transport {
             let _ = transport.disconnect();
         }
     }

adb_client/src/server/adb_server_device.rs

@@ -1,49 +0,0 @@
-use crate::{ADBTransport, Result, TCPServerTransport};
-use std::net::SocketAddrV4;
-
-/// Represents a device connected to the ADB server.
-#[derive(Debug)]
-pub struct ADBServerDevice {
-    /// Unique device identifier.
-    pub identifier: String,
-    /// Internal [TCPServerTransport]
-    transport: TCPServerTransport,
-}
-
-impl ADBServerDevice {
-    /// Instantiates a new [ADBServerDevice]
-    pub fn new(identifier: String, socket_addr: Option<SocketAddrV4>) -> Self {
-        let transport = if let Some(addr) = socket_addr {
-            TCPServerTransport::new(addr)
-        } else {
-            TCPServerTransport::default()
-        };
-
-        Self {
-            identifier,
-            transport,
-        }
-    }
-
-    pub(crate) fn get_transport(&self) -> &TCPServerTransport {
-        &self.transport
-    }
-
-    pub(crate) fn get_transport_mut(&mut self) -> &mut TCPServerTransport {
-        &mut self.transport
-    }
-
-    /// Connect to underlying transport
-    pub(crate) fn connect(&mut self) -> Result<&mut TCPServerTransport> {
-        self.transport.connect()?;
-
-        Ok(self.get_transport_mut())
-    }
-}
-
-impl Drop for ADBServerDevice {
-    fn drop(&mut self) {
-        // Best effort here
-        let _ = self.transport.disconnect();
-    }
-}

adb_client/src/server/commands/connect.rs

@@ -1,4 +1,4 @@
-use crate::{models::AdbServerCommand, ADBServer, Result, RustADBError};
+use crate::{ADBServer, Result, RustADBError, models::AdbServerCommand};
 use std::net::SocketAddrV4;
 
 impl ADBServer {

adb_client/src/server/commands/devices.rs

@@ -1,8 +1,8 @@
 use std::io::Read;
 
 use crate::{
-    models::{AdbServerCommand, DeviceShort},
-    ADBEmulatorDevice, ADBServer, ADBServerDevice, DeviceLong, Result, RustADBError,
+    ADBEmulatorDevice, ADBServer, ADBServerDevice, DeviceLong, DeviceShort, Result, RustADBError,
+    models::AdbServerCommand,
 };
 
 impl ADBServer {
@@ -36,7 +36,7 @@ impl ADBServer {
                 break;
             }
 
-            vec_devices.push(DeviceLong::try_from(device.to_vec())?);
+            vec_devices.push(DeviceLong::try_from(device)?);
         }
 
         Ok(vec_devices)
@@ -97,7 +97,12 @@ impl ADBServer {
                     .get_raw_connection()?
                     .read_exact(&mut body)?;
 
-                callback(DeviceShort::try_from(body)?)?;
+                for device in body.split(|x| x.eq(&b'\n')) {
+                    if device.is_empty() {
+                        break;
+                    }
+                    callback(DeviceShort::try_from(device.to_vec())?)?;
+                }
             }
         }
     }

adb_client/src/server/commands/disconnect.rs

@@ -1,4 +1,4 @@
-use crate::{models::AdbServerCommand, ADBServer, Result, RustADBError};
+use crate::{ADBServer, Result, RustADBError, models::AdbServerCommand};
 use std::net::SocketAddrV4;
 
 impl ADBServer {

adb_client/src/server/commands/kill.rs

@@ -1,4 +1,4 @@
-use crate::{models::AdbServerCommand, ADBServer, Result};
+use crate::{ADBServer, Result, models::AdbServerCommand};
 
 impl ADBServer {
     /// Asks the ADB server to quit immediately.

adb_client/src/server/commands/mdns.rs

@@ -0,0 +1,61 @@
+use std::io::BufRead;
+
+use crate::{
+    ADBServer, MDNSServices, Result, models::AdbServerCommand, server::models::MDNSBackend,
+};
+
+const OPENSCREEN_MDNS_BACKEND: &str = "ADB_MDNS_OPENSCREEN";
+
+impl ADBServer {
+    /// Check if mdns discovery is available
+    pub fn mdns_check(&mut self) -> Result<bool> {
+        let response = self
+            .connect()?
+            .proxy_connection(AdbServerCommand::MDNSCheck, true)?;
+
+        match String::from_utf8(response) {
+            Ok(s) if s.starts_with("mdns daemon version") => Ok(true),
+            Ok(_) => Ok(false),
+            Err(e) => Err(e.into()),
+        }
+    }
+
+    /// List all discovered mdns services
+    pub fn mdns_services(&mut self) -> Result<Vec<MDNSServices>> {
+        let services = self
+            .connect()?
+            .proxy_connection(AdbServerCommand::MDNSServices, true)?;
+
+        let mut vec_services: Vec<MDNSServices> = vec![];
+        for service in services.lines() {
+            match service {
+                Ok(service) => {
+                    vec_services.push(MDNSServices::try_from(service.as_bytes())?);
+                }
+                Err(e) => log::error!("{}", e),
+            }
+        }
+
+        Ok(vec_services)
+    }
+
+    /// Check if specified backend mdns service is used, otherwise restart adb server with envs
+    pub fn mdns_force_backend(&mut self, backend: MDNSBackend) -> Result<()> {
+        let server_status = self.server_status()?;
+        if server_status.mdns_backend != backend {
+            self.kill()?;
+            self.envs.insert(
+                OPENSCREEN_MDNS_BACKEND.to_string(),
+                (if backend == MDNSBackend::OpenScreen {
+                    "1"
+                } else {
+                    "0"
+                })
+                .to_string(),
+            );
+            self.connect()?;
+        }
+
+        Ok(())
+    }
+}

adb_client/src/server/commands/mod.rs

@@ -2,5 +2,9 @@ mod connect;
 mod devices;
 mod disconnect;
 mod kill;
+mod mdns;
 mod pair;
+mod reconnect;
+mod server_status;
 mod version;
+mod wait_for_device;

adb_client/src/server/commands/reconnect.rs

@@ -0,0 +1,10 @@
+use crate::{ADBServer, Result, models::AdbServerCommand};
+
+impl ADBServer {
+    /// Reconnect the device
+    pub fn reconnect_offline(&mut self) -> Result<()> {
+        self.connect()?
+            .proxy_connection(AdbServerCommand::ReconnectOffline, false)
+            .map(|_| ())
+    }
+}

adb_client/src/server/commands/server_status.rs

@@ -0,0 +1,12 @@
+use crate::{ADBServer, Result, models::AdbServerCommand, server::models::ServerStatus};
+
+impl ADBServer {
+    /// Check ADB server status
+    pub fn server_status(&mut self) -> Result<ServerStatus> {
+        let status = self
+            .connect()?
+            .proxy_connection(AdbServerCommand::ServerStatus, true)?;
+
+        ServerStatus::try_from(status)
+    }
+}

adb_client/src/server/commands/version.rs

@@ -1,4 +1,4 @@
-use crate::{models::AdbServerCommand, ADBServer, AdbVersion, Result};
+use crate::{ADBServer, AdbVersion, Result, models::AdbServerCommand};
 
 impl ADBServer {
     /// Gets server's internal version number.

adb_client/src/server/commands/wait_for_device.rs

@@ -0,0 +1,20 @@
+use crate::{
+    ADBServer, Result, WaitForDeviceState, WaitForDeviceTransport, models::AdbServerCommand,
+};
+
+impl ADBServer {
+    /// Wait for a device in a given state to be connected
+    pub fn wait_for_device(
+        &mut self,
+        state: WaitForDeviceState,
+        transport: Option<WaitForDeviceTransport>,
+    ) -> Result<()> {
+        let transport = transport.unwrap_or_default();
+
+        self.connect()?
+            .send_adb_request(AdbServerCommand::WaitForDevice(state, transport))?;
+
+        // Server should respond with an "OKAY" response
+        self.get_transport()?.read_adb_response()
+    }
+}

adb_client/src/server/device_commands/forward.rs

@@ -1,14 +0,0 @@
-use crate::{models::AdbServerCommand, ADBServerDevice, Result};
-
-impl ADBServerDevice {
-    /// Forward socket connection
-    pub fn forward(&mut self, remote: String, local: String) -> Result<()> {
-        let serial = self.identifier.clone();
-        self.connect()?
-            .send_adb_request(AdbServerCommand::TransportSerial(serial.clone()))?;
-
-        self.get_transport_mut()
-            .proxy_connection(AdbServerCommand::Forward(serial, remote, local), false)
-            .map(|_| ())
-    }
-}

adb_client/src/server/device_commands/framebuffer.rs

@@ -1,176 +0,0 @@
-use std::{io::Read, iter::Map, path::Path, slice::ChunksExact};
-
-use byteorder::{LittleEndian, ReadBytesExt};
-use image::{ImageBuffer, Rgba};
-
-use crate::{models::AdbServerCommand, utils, ADBServerDevice, Result, RustADBError};
-
-type U32ChunkIter<'a> = Map<ChunksExact<'a, u8>, fn(&[u8]) -> Result<u32>>;
-
-fn read_next(chunks: &mut U32ChunkIter) -> Result<u32> {
-    chunks
-        .next()
-        .ok_or(RustADBError::FramebufferConversionError)?
-}
-
-#[derive(Debug)]
-struct FrameBufferInfoV1 {
-    pub _bpp: u32,
-    pub size: u32,
-    pub width: u32,
-    pub height: u32,
-    pub _red_offset: u32,
-    pub _red_length: u32,
-    pub _blue_offset: u32,
-    pub _blue_length: u32,
-    pub _green_offset: u32,
-    pub _green_length: u32,
-    pub _alpha_offset: u32,
-    pub _alpha_length: u32,
-}
-
-impl TryFrom<[u8; std::mem::size_of::<Self>()]> for FrameBufferInfoV1 {
-    type Error = RustADBError;
-
-    fn try_from(
-        value: [u8; std::mem::size_of::<Self>()],
-    ) -> std::result::Result<Self, Self::Error> {
-        let mut chunks: U32ChunkIter = value.chunks_exact(4).map(utils::u32_from_le);
-
-        Ok(Self {
-            _bpp: read_next(&mut chunks)?,
-            size: read_next(&mut chunks)?,
-            width: read_next(&mut chunks)?,
-            height: read_next(&mut chunks)?,
-            _red_offset: read_next(&mut chunks)?,
-            _red_length: read_next(&mut chunks)?,
-            _blue_offset: read_next(&mut chunks)?,
-            _blue_length: read_next(&mut chunks)?,
-            _green_offset: read_next(&mut chunks)?,
-            _green_length: read_next(&mut chunks)?,
-            _alpha_offset: read_next(&mut chunks)?,
-            _alpha_length: read_next(&mut chunks)?,
-        })
-    }
-}
-
-#[derive(Debug)]
-struct FrameBufferInfoV2 {
-    pub _bpp: u32,
-    pub _color_space: u32,
-    pub size: u32,
-    pub width: u32,
-    pub height: u32,
-    pub _red_offset: u32,
-    pub _red_length: u32,
-    pub _blue_offset: u32,
-    pub _blue_length: u32,
-    pub _green_offset: u32,
-    pub _green_length: u32,
-    pub _alpha_offset: u32,
-    pub _alpha_length: u32,
-}
-
-impl TryFrom<[u8; std::mem::size_of::<Self>()]> for FrameBufferInfoV2 {
-    type Error = RustADBError;
-
-    fn try_from(
-        value: [u8; std::mem::size_of::<Self>()],
-    ) -> std::result::Result<Self, Self::Error> {
-        let mut chunks: U32ChunkIter = value.chunks_exact(4).map(utils::u32_from_le);
-
-        Ok(Self {
-            _bpp: read_next(&mut chunks)?,
-            _color_space: read_next(&mut chunks)?,
-            size: read_next(&mut chunks)?,
-            width: read_next(&mut chunks)?,
-            height: read_next(&mut chunks)?,
-            _red_offset: read_next(&mut chunks)?,
-            _red_length: read_next(&mut chunks)?,
-            _blue_offset: read_next(&mut chunks)?,
-            _blue_length: read_next(&mut chunks)?,
-            _green_offset: read_next(&mut chunks)?,
-            _green_length: read_next(&mut chunks)?,
-            _alpha_offset: read_next(&mut chunks)?,
-            _alpha_length: read_next(&mut chunks)?,
-        })
-    }
-}
-
-impl ADBServerDevice {
-    /// Dump framebuffer of this device
-    /// Big help from source code (https://android.googlesource.com/platform/system/adb/+/refs/heads/main/framebuffer_service.cpp)
-    pub fn framebuffer<P: AsRef<Path>>(&mut self, path: P) -> Result<()> {
-        let img = self.framebuffer_inner()?;
-        Ok(img.save(path.as_ref())?)
-    }
-
-    /// Inner method requesting framebuffer from Android device
-    fn framebuffer_inner(&mut self) -> Result<ImageBuffer<Rgba<u8>, Vec<u8>>> {
-        let serial: String = self.identifier.clone();
-        self.connect()?
-            .send_adb_request(AdbServerCommand::TransportSerial(serial))?;
-
-        self.get_transport_mut()
-            .send_adb_request(AdbServerCommand::FrameBuffer)?;
-
-        let version = self
-            .get_transport_mut()
-            .get_raw_connection()?
-            .read_u32::<LittleEndian>()?;
-
-        match version {
-            // RGBA_8888
-            1 => {
-                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV1>()];
-
-                self.get_transport_mut()
-                    .get_raw_connection()?
-                    .read_exact(&mut buf)?;
-
-                let h: FrameBufferInfoV1 = buf.try_into()?;
-
-                let mut data = vec![
-                    0_u8;
-                    h.size
-                        .try_into()
-                        .map_err(|_| RustADBError::ConversionError)?
-                ];
-                self.get_transport_mut()
-                    .get_raw_connection()?
-                    .read_exact(&mut data)?;
-
-                Ok(
-                    ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(h.width, h.height, data)
-                        .ok_or_else(|| RustADBError::FramebufferConversionError)?,
-                )
-            }
-            // RGBX_8888
-            2 => {
-                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV2>()];
-
-                self.get_transport_mut()
-                    .get_raw_connection()?
-                    .read_exact(&mut buf)?;
-
-                let h: FrameBufferInfoV2 = buf.try_into()?;
-
-                let mut data = vec![
-                    0_u8;
-                    h.size
-                        .try_into()
-                        .map_err(|_| RustADBError::ConversionError)?
-                ];
-                self.get_transport_mut()
-                    .get_raw_connection()?
-                    .read_exact(&mut data)?;
-
-                Ok(
-                    ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(h.width, h.height, data)
-                        .ok_or_else(|| RustADBError::FramebufferConversionError)?,
-                )
-            }
-            v => Err(RustADBError::UnimplementedFramebufferImageVersion(v)),
-        }
-    }
-}

adb_client/src/server/device_commands/reverse.rs

@@ -1,14 +0,0 @@
-use crate::{models::AdbServerCommand, ADBServerDevice, Result};
-
-impl ADBServerDevice {
-    /// Reverse socket connection
-    pub fn reverse(&mut self, remote: String, local: String) -> Result<()> {
-        let serial = self.identifier.clone();
-        self.connect()?
-            .send_adb_request(AdbServerCommand::TransportSerial(serial))?;
-
-        self.get_transport_mut()
-            .proxy_connection(AdbServerCommand::Reverse(remote, local), false)
-            .map(|_| ())
-    }
-}

adb_client/src/server/mod.rs

@@ -1,10 +1,6 @@
-mod adb_emulator_device;
 mod adb_server;
-mod adb_server_device;
-mod adb_server_device_commands;
-mod device_commands;
-mod server_commands;
+mod commands;
+mod models;
 
-pub use adb_emulator_device::ADBEmulatorDevice;
 pub use adb_server::ADBServer;
-pub use adb_server_device::ADBServerDevice;
+pub use models::*;

adb_client/src/server/models/device_long.rs

@@ -1,16 +1,15 @@
-use lazy_static::lazy_static;
 use std::str::FromStr;
+use std::sync::LazyLock;
 use std::{fmt::Display, str};
 
 use crate::{DeviceState, RustADBError};
 use regex::bytes::Regex;
 
-lazy_static! {
-    static ref DEVICES_LONG_REGEX: Regex = Regex::new("^(?P<identifier>\\S+)\\s+(?P<state>\\w+) ((usb:(?P<usb1>.*)|(?P<usb2>\\d-\\d)) )?(product:(?P<product>\\w+) model:(?P<model>\\w+) device:(?P<device>\\w+) )?transport_id:(?P<transport_id>\\d+)$").expect("cannot build devices long regex");
+static DEVICES_LONG_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new(r"^(?P<identifier>\S+)\s+(?P<state>\w+)\s+(usb:(?P<usb1>\S+)|(?P<usb2>\S+))?\s*(product:(?P<product>\S+)\s+model:(?P<model>\w+)\s+device:(?P<device>\S+)\s+)?transport_id:(?P<transport_id>\d+)$").expect("cannot build devices long regex")
+});
 
-}
-
-/// Represents a new device with more informations helded.
+/// Represents a new device with more informations.
 #[derive(Debug)]
 pub struct DeviceLong {
     /// Unique device identifier.
@@ -45,12 +44,12 @@ impl Display for DeviceLong {
     }
 }
 
-impl TryFrom<Vec<u8>> for DeviceLong {
+impl TryFrom<&[u8]> for DeviceLong {
     type Error = RustADBError;
 
-    fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> {
+    fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
         let groups = DEVICES_LONG_REGEX
-            .captures(&value)
+            .captures(value)
             .ok_or(RustADBError::RegexParsingError)?;
 
         Ok(DeviceLong {
@@ -99,3 +98,17 @@ impl TryFrom<Vec<u8>> for DeviceLong {
         })
     }
 }
+
+#[test]
+fn test_static_devices_long() {
+    let inputs = [
+        "7a5158f05122195aa       device 1-5 product:gts210vewifixx model:SM_T813 device:gts210vewifi transport_id:4",
+        "n311r05e               device usb:0-1.5 product:alioth model:M2012K11AC device:alioth transport_id:58",
+        "192.168.100.192:5555   device product:alioth model:M2012K11AC device:alioth transport_id:97",
+        "emulator-5554          device product:sdk_gphone64_arm64 model:sdk_gphone64_arm64 device:emu64a transport_id:101",
+        "QQ20131020250511       device 20-4 product:NOH-AN00 model:NOH_AN00 device:HWNOH transport_id:3",
+    ];
+    for input in inputs {
+        DeviceLong::try_from(input.as_bytes()).expect(&format!("cannot parse input: '{input}'"));
+    }
+}

adb_client/src/server/models/device_short.rs

@@ -1,13 +1,10 @@
-use lazy_static::lazy_static;
 use regex::bytes::Regex;
-use std::{fmt::Display, str::FromStr};
+use std::{fmt::Display, str::FromStr, sync::LazyLock};
 
 use crate::{DeviceState, RustADBError};
 
-lazy_static! {
-    static ref DEVICES_REGEX: Regex =
-        Regex::new("^(\\S+)\t(\\w+)\n?$").expect("Cannot build devices regex");
-}
+static DEVICES_REGEX: LazyLock<Regex> =
+    LazyLock::new(|| Regex::new("^(\\S+)\t(\\w+)\n?$").expect("Cannot build devices regex"));
 
 /// Represents a device connected to the ADB server.
 #[derive(Debug, Clone)]

adb_client/src/server/models/device_state.rs

@@ -15,6 +15,22 @@ pub enum DeviceState {
     Authorizing,
     /// The device is unauthorized.
     Unauthorized,
+    /// Haven't received a response from the device yet.
+    Connecting,
+    /// Insufficient permissions to communicate with the device.
+    NoPerm,
+    /// USB device detached from the adb server (known but not opened/claimed).
+    Detached,
+    /// Device running fastboot OS (fastboot) or userspace fastboot (fastbootd).
+    Bootloader,
+    /// What a device sees from its end of a Transport (adb host).
+    Host,
+    /// Device with bootloader loaded but no ROM OS loaded (adbd).
+    Recovery,
+    /// Device running Android OS Sideload mode (minadbd sideload mode).
+    Sideload,
+    /// Device running Android OS Rescue mode (minadbd rescue mode).
+    Rescue,
 }
 
 impl Display for DeviceState {
@@ -25,6 +41,14 @@ impl Display for DeviceState {
             DeviceState::NoDevice => write!(f, "no device"),
             DeviceState::Authorizing => write!(f, "authorizing"),
             DeviceState::Unauthorized => write!(f, "unauthorized"),
+            DeviceState::Connecting => write!(f, "connecting"),
+            DeviceState::NoPerm => write!(f, "noperm"),
+            DeviceState::Detached => write!(f, "detached"),
+            DeviceState::Bootloader => write!(f, "bootloader"),
+            DeviceState::Host => write!(f, "host"),
+            DeviceState::Recovery => write!(f, "recovery"),
+            DeviceState::Sideload => write!(f, "sideload"),
+            DeviceState::Rescue => write!(f, "rescue"),
         }
     }
 }
@@ -40,6 +64,14 @@ impl FromStr for DeviceState {
             "no device" => Ok(Self::NoDevice),
             "authorizing" => Ok(Self::Authorizing),
             "unauthorized" => Ok(Self::Unauthorized),
+            "connecting" => Ok(Self::Connecting),
+            "noperm" => Ok(Self::NoPerm),
+            "detached" => Ok(Self::Detached),
+            "bootloader" => Ok(Self::Bootloader),
+            "host" => Ok(Self::Host),
+            "recovery" => Ok(Self::Recovery),
+            "sideload" => Ok(Self::Sideload),
+            "rescue" => Ok(Self::Rescue),
             _ => Err(RustADBError::UnknownDeviceState(lowercased)),
         }
     }

adb_client/src/server/models/mdns_services.rs

@@ -0,0 +1,64 @@
+use regex::bytes::Regex;
+use std::net::SocketAddrV4;
+use std::sync::LazyLock;
+use std::{fmt::Display, str::FromStr};
+
+use crate::RustADBError;
+
+static MDNS_SERVICES_REGEX: LazyLock<Regex> = LazyLock::new(|| {
+    Regex::new("^(\\S+)\t(\\S+)\t([\\d\\.]+:\\d+)\n?$").expect("Cannot build mdns services regex")
+});
+
+/// Represents MDNS Services
+#[derive(Debug, Clone)]
+pub struct MDNSServices {
+    /// Service name
+    pub service_name: String,
+    /// Reg type
+    pub reg_type: String,
+    /// IP addr with port
+    pub socket_v4: SocketAddrV4,
+}
+
+impl Display for MDNSServices {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "{}\t{}\t{}",
+            self.service_name, self.reg_type, self.socket_v4
+        )
+    }
+}
+
+impl TryFrom<&[u8]> for MDNSServices {
+    type Error = RustADBError;
+
+    fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
+        let groups = MDNS_SERVICES_REGEX
+            .captures(value)
+            .ok_or(RustADBError::RegexParsingError)?;
+        Ok(MDNSServices {
+            service_name: String::from_utf8(
+                groups
+                    .get(1)
+                    .ok_or(RustADBError::RegexParsingError)?
+                    .as_bytes()
+                    .to_vec(),
+            )?,
+            reg_type: String::from_utf8(
+                groups
+                    .get(2)
+                    .ok_or(RustADBError::RegexParsingError)?
+                    .as_bytes()
+                    .to_vec(),
+            )?,
+            socket_v4: SocketAddrV4::from_str(&String::from_utf8(
+                groups
+                    .get(3)
+                    .ok_or(RustADBError::RegexParsingError)?
+                    .as_bytes()
+                    .to_vec(),
+            )?)?,
+        })
+    }
+}

adb_client/src/server/models/mod.rs

@@ -0,0 +1,15 @@
+mod adb_version;
+mod device_long;
+mod device_short;
+mod device_state;
+mod mdns_services;
+mod server_status;
+mod wait_for_device;
+
+pub use adb_version::AdbVersion;
+pub use device_long::DeviceLong;
+pub use device_short::DeviceShort;
+pub use device_state::DeviceState;
+pub use mdns_services::MDNSServices;
+pub use server_status::{MDNSBackend, ServerStatus};
+pub use wait_for_device::{WaitForDeviceState, WaitForDeviceTransport};

adb_client/src/server/models/server_status.rs

@@ -0,0 +1,167 @@
+use quick_protobuf::{BytesReader, MessageRead};
+
+use std::fmt::Display;
+
+use crate::RustADBError;
+
+#[derive(Debug, PartialEq, Default, Eq, Clone, Copy)]
+pub enum UsbBackend {
+    #[default]
+    Unknown = 0,
+    Native = 1,
+    LibUSB = 2,
+}
+
+impl From<i32> for UsbBackend {
+    fn from(i: i32) -> Self {
+        match i {
+            0 => UsbBackend::Unknown,
+            1 => UsbBackend::Native,
+            2 => UsbBackend::LibUSB,
+            _ => Self::default(),
+        }
+    }
+}
+
+impl<'a> From<&'a str> for UsbBackend {
+    fn from(s: &'a str) -> Self {
+        match s {
+            "UNKNOWN_USB" => UsbBackend::Unknown,
+            "NATIVE" => UsbBackend::Native,
+            "LIBUSB" => UsbBackend::LibUSB,
+            _ => Self::default(),
+        }
+    }
+}
+
+impl Display for UsbBackend {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            UsbBackend::Unknown => write!(f, "UNKNOWN_USB"),
+            UsbBackend::Native => write!(f, "NATIVE"),
+            UsbBackend::LibUSB => write!(f, "LIBUSB"),
+        }
+    }
+}
+
+/// MDNS Backend Status
+#[derive(Debug, Clone, PartialEq, Default)]
+pub enum MDNSBackend {
+    #[default]
+    /// Unknown
+    Unknown = 0,
+    /// Bonjour
+    Bonjour = 1,
+    /// OpenScreen
+    OpenScreen = 2,
+}
+
+impl From<i32> for MDNSBackend {
+    fn from(i: i32) -> Self {
+        match i {
+            0 => MDNSBackend::Unknown,
+            1 => MDNSBackend::Bonjour,
+            2 => MDNSBackend::OpenScreen,
+            _ => Self::default(),
+        }
+    }
+}
+
+impl<'a> From<&'a str> for MDNSBackend {
+    fn from(s: &'a str) -> Self {
+        match s {
+            "UNKNOWN_MDNS" => MDNSBackend::Unknown,
+            "BONJOUR" => MDNSBackend::Bonjour,
+            "OPENSCREEN" => MDNSBackend::OpenScreen,
+            _ => Self::default(),
+        }
+    }
+}
+
+impl Display for MDNSBackend {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            MDNSBackend::Unknown => write!(f, "UNKNOWN_MDNS"),
+            MDNSBackend::Bonjour => write!(f, "BONJOUR"),
+            MDNSBackend::OpenScreen => write!(f, "OPENSCREEN"),
+        }
+    }
+}
+
+/// Structure representing current server status
+#[derive(Debug, Clone, Default, PartialEq)]
+pub struct ServerStatus {
+    /// Currently active USB backend
+    pub usb_backend: UsbBackend,
+    /// Is USB backend forced ?
+    pub usb_backend_forced: bool,
+    /// Currently active MDNS backend
+    pub mdns_backend: MDNSBackend,
+    /// Is MDNS backend forced ?
+    pub mdns_backend_forced: bool,
+    /// Server version
+    pub version: String,
+    /// Server build information
+    pub build: String,
+    /// Server executable absolute path
+    pub executable_absolute_path: String,
+    /// Server logs absolute path
+    pub log_absolute_path: String,
+    /// OS server is running on
+    pub os: String,
+}
+
+impl<'a> MessageRead<'a> for ServerStatus {
+    fn from_reader(r: &mut BytesReader, bytes: &'a [u8]) -> quick_protobuf::Result<Self> {
+        let mut msg = Self::default();
+        while !r.is_eof() {
+            match r.next_tag(bytes) {
+                Ok(8) => msg.usb_backend = r.read_enum(bytes)?,
+                Ok(16) => msg.usb_backend_forced = r.read_bool(bytes)?,
+                Ok(24) => msg.mdns_backend = r.read_enum(bytes)?,
+                Ok(32) => msg.mdns_backend_forced = r.read_bool(bytes)?,
+                Ok(42) => msg.version = r.read_string(bytes)?.to_string(),
+                Ok(50) => msg.build = r.read_string(bytes)?.to_string(),
+                Ok(58) => msg.executable_absolute_path = r.read_string(bytes)?.to_string(),
+                Ok(66) => msg.log_absolute_path = r.read_string(bytes)?.to_string(),
+                Ok(74) => msg.os = r.read_string(bytes)?.to_string(),
+                Ok(t) => {
+                    r.read_unknown(bytes, t)?;
+                }
+                Err(e) => return Err(e),
+            }
+        }
+        Ok(msg)
+    }
+}
+
+impl Display for ServerStatus {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        writeln!(f, "usb_backend: {}", self.usb_backend)?;
+        if self.usb_backend_forced {
+            writeln!(f, "usb_backend_forced: {}", self.usb_backend_forced)?;
+        }
+        writeln!(f, "mdns_backend: {}", self.mdns_backend)?;
+        if self.mdns_backend_forced {
+            writeln!(f, "mdns_backend_forced: {}", self.mdns_backend_forced)?;
+        }
+        writeln!(f, "version: \"{}\"", self.version)?;
+        writeln!(f, "build: \"{}\"", self.build)?;
+        writeln!(
+            f,
+            "executable_absolute_path: \"{}\"",
+            self.executable_absolute_path
+        )?;
+        writeln!(f, "log_absolute_path: \"{}\"", self.log_absolute_path)?;
+        writeln!(f, "os: \"{}\"", self.os)
+    }
+}
+
+impl TryFrom<Vec<u8>> for ServerStatus {
+    type Error = RustADBError;
+
+    fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> {
+        let mut reader = BytesReader::from_bytes(&value);
+        ServerStatus::from_reader(&mut reader, &value).map_err(|_| RustADBError::ConversionError)
+    }
+}

adb_client/src/server/models/wait_for_device.rs

@@ -0,0 +1,67 @@
+use std::fmt::Display;
+
+use crate::RustADBError;
+
+#[derive(Clone, Debug)]
+/// List of available transports to wait for.
+pub enum WaitForDeviceTransport {
+    /// USB transport
+    Usb,
+    /// Local transport
+    Local,
+    /// Any transport (default value)
+    Any,
+}
+
+impl Default for WaitForDeviceTransport {
+    fn default() -> Self {
+        Self::Any
+    }
+}
+
+impl Display for WaitForDeviceTransport {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            WaitForDeviceTransport::Usb => write!(f, "usb"),
+            WaitForDeviceTransport::Local => write!(f, "local"),
+            WaitForDeviceTransport::Any => write!(f, "any"),
+        }
+    }
+}
+
+impl TryFrom<&str> for WaitForDeviceTransport {
+    type Error = RustADBError;
+
+    fn try_from(value: &str) -> Result<Self, Self::Error> {
+        match value {
+            "usb" => Ok(Self::Usb),
+            "local" => Ok(Self::Local),
+            "any" => Ok(Self::Any),
+            t => Err(RustADBError::UnknownTransport(t.to_string())),
+        }
+    }
+}
+
+#[derive(Debug)]
+/// List of available states to wait for.
+pub enum WaitForDeviceState {
+    /// Device in "device" state
+    Device,
+    /// Device in "recovery" state
+    Recovery,
+    /// Device in "sideload" state
+    Sideload,
+    /// Device in "bootloader" state
+    Bootloader,
+}
+
+impl Display for WaitForDeviceState {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        match self {
+            WaitForDeviceState::Device => write!(f, "device"),
+            WaitForDeviceState::Recovery => write!(f, "recovery"),
+            WaitForDeviceState::Sideload => write!(f, "sideload"),
+            WaitForDeviceState::Bootloader => write!(f, "bootloader"),
+        }
+    }
+}

adb_client/src/server_device/adb_server_device.rs

@@ -0,0 +1,60 @@
+use crate::{ADBTransport, Result, TCPServerTransport, models::AdbServerCommand};
+use std::net::SocketAddrV4;
+
+/// Represents a device connected to the ADB server.
+#[derive(Debug)]
+pub struct ADBServerDevice {
+    /// Unique device identifier.
+    pub identifier: Option<String>,
+    /// Internal [TCPServerTransport]
+    pub(crate) transport: TCPServerTransport,
+}
+
+impl ADBServerDevice {
+    /// Instantiates a new [ADBServerDevice], knowing its ADB identifier (as returned by `adb devices` command).
+    pub fn new(identifier: String, server_addr: Option<SocketAddrV4>) -> Self {
+        let transport = TCPServerTransport::new_or_default(server_addr);
+
+        Self {
+            identifier: Some(identifier),
+            transport,
+        }
+    }
+
+    /// Instantiates a new [ADBServerDevice], assuming only one is currently connected.
+    pub fn autodetect(server_addr: Option<SocketAddrV4>) -> Self {
+        let transport = TCPServerTransport::new_or_default(server_addr);
+
+        Self {
+            identifier: None,
+            transport,
+        }
+    }
+
+    /// Connect to underlying transport
+    pub(crate) fn connect(&mut self) -> Result<&mut TCPServerTransport> {
+        self.transport.connect()?;
+
+        Ok(&mut self.transport)
+    }
+
+    /// Set device connection to use serial transport
+    pub(crate) fn set_serial_transport(&mut self) -> Result<()> {
+        let identifier = self.identifier.clone();
+        let transport = self.connect()?;
+        if let Some(serial) = identifier {
+            transport.send_adb_request(AdbServerCommand::TransportSerial(serial))?;
+        } else {
+            transport.send_adb_request(AdbServerCommand::TransportAny)?;
+        }
+
+        Ok(())
+    }
+}
+
+impl Drop for ADBServerDevice {
+    fn drop(&mut self) {
+        // Best effort here
+        let _ = self.transport.disconnect();
+    }
+}

adb_client/src/server_device/adb_server_device_commands.rs

@@ -1,17 +1,18 @@
-use std::io::{Read, Write};
-
-use crate::{
-    constants::BUFFER_SIZE,
-    models::{AdbServerCommand, AdbStatResponse, HostFeatures},
-    ADBDeviceExt, ADBServerDevice, Result, RustADBError,
+use std::{
+    io::{ErrorKind, Read, Write},
+    path::Path,
 };
 
+use crate::{
+    ADBDeviceExt, Result, RustADBError,
+    constants::BUFFER_SIZE,
+    models::{AdbServerCommand, AdbStatResponse, HostFeatures},
+};
+
+use super::ADBServerDevice;
+
 impl ADBDeviceExt for ADBServerDevice {
-    fn shell_command<S: ToString, W: Write>(
-        &mut self,
-        command: impl IntoIterator<Item = S>,
-        mut output: W,
-    ) -> Result<()> {
+    fn shell_command(&mut self, command: &[&str], output: &mut dyn Write) -> Result<()> {
         let supported_features = self.host_features()?;
         if !supported_features.contains(&HostFeatures::ShellV2)
             && !supported_features.contains(&HostFeatures::Cmd)
@@ -19,26 +20,14 @@ impl ADBDeviceExt for ADBServerDevice {
             return Err(RustADBError::ADBShellNotSupported);
         }
 
-        let serial = self.identifier.clone();
-        self.connect()?
-            .send_adb_request(AdbServerCommand::TransportSerial(serial))?;
-        self.get_transport_mut()
-            .send_adb_request(AdbServerCommand::ShellCommand(
-                command
-                    .into_iter()
-                    .map(|v| v.to_string())
-                    .collect::<Vec<_>>()
-                    .join(" "),
-            ))?;
+        self.set_serial_transport()?;
+
+        self.transport
+            .send_adb_request(AdbServerCommand::ShellCommand(command.join(" ")))?;
 
-        const BUFFER_SIZE: usize = 4096;
         loop {
             let mut buffer = [0; BUFFER_SIZE];
-            match self
-                .get_transport_mut()
-                .get_raw_connection()?
-                .read(&mut buffer)
-            {
+            match self.transport.get_raw_connection()?.read(&mut buffer) {
                 Ok(size) => {
                     if size == 0 {
                         return Ok(());
@@ -57,10 +46,10 @@ impl ADBDeviceExt for ADBServerDevice {
         self.stat(remote_path)
     }
 
-    fn shell<R: Read, W: Write + Send + 'static>(
+    fn shell(
         &mut self,
-        mut reader: R,
-        mut writer: W,
+        mut reader: &mut dyn Read,
+        mut writer: Box<(dyn Write + Send)>,
     ) -> Result<()> {
         let supported_features = self.host_features()?;
         if !supported_features.contains(&HostFeatures::ShellV2)
@@ -69,13 +58,10 @@ impl ADBDeviceExt for ADBServerDevice {
             return Err(RustADBError::ADBShellNotSupported);
         }
 
-        let serial = self.identifier.clone();
-        self.connect()?
-            .send_adb_request(AdbServerCommand::TransportSerial(serial))?;
-        self.get_transport_mut()
-            .send_adb_request(AdbServerCommand::Shell)?;
+        self.set_serial_transport()?;
+        self.transport.send_adb_request(AdbServerCommand::Shell)?;
 
-        let mut read_stream = self.get_transport_mut().get_raw_connection()?.try_clone()?;
+        let mut read_stream = self.transport.get_raw_connection()?.try_clone()?;
 
         let mut write_stream = read_stream.try_clone()?;
 
@@ -102,7 +88,7 @@ impl ADBDeviceExt for ADBServerDevice {
         // Read from given reader (that could be stdin e.g), and write content to server socket
         if let Err(e) = std::io::copy(&mut reader, &mut write_stream) {
             match e.kind() {
-                std::io::ErrorKind::BrokenPipe => return Ok(()),
+                ErrorKind::BrokenPipe => return Ok(()),
                 _ => return Err(RustADBError::IOError(e)),
             }
         }
@@ -110,7 +96,7 @@ impl ADBDeviceExt for ADBServerDevice {
         Ok(())
     }
 
-    fn pull<A: AsRef<str>, W: Write>(&mut self, source: A, mut output: W) -> Result<()> {
+    fn pull(&mut self, source: &dyn AsRef<str>, mut output: &mut dyn Write) -> Result<()> {
         self.pull(source, &mut output)
     }
 
@@ -118,7 +104,19 @@ impl ADBDeviceExt for ADBServerDevice {
         self.reboot(reboot_type)
     }
 
-    fn push<R: Read, A: AsRef<str>>(&mut self, stream: R, path: A) -> Result<()> {
+    fn push(&mut self, stream: &mut dyn Read, path: &dyn AsRef<str>) -> Result<()> {
         self.push(stream, path)
     }
+
+    fn install(&mut self, apk_path: &dyn AsRef<Path>) -> Result<()> {
+        self.install(apk_path)
+    }
+
+    fn uninstall(&mut self, package: &str) -> Result<()> {
+        self.uninstall(package)
+    }
+
+    fn framebuffer_inner(&mut self) -> Result<image::ImageBuffer<image::Rgba<u8>, Vec<u8>>> {
+        self.framebuffer_inner()
+    }
 }

adb_client/src/server_device/commands/forward.rs

@@ -0,0 +1,21 @@
+use crate::{ADBServerDevice, Result, models::AdbServerCommand};
+
+impl ADBServerDevice {
+    /// Forward socket connection
+    pub fn forward(&mut self, remote: String, local: String) -> Result<()> {
+        self.set_serial_transport()?;
+
+        self.transport
+            .proxy_connection(AdbServerCommand::Forward(remote, local), false)
+            .map(|_| ())
+    }
+
+    /// Remove all previously applied forward rules
+    pub fn forward_remove_all(&mut self) -> Result<()> {
+        self.set_serial_transport()?;
+
+        self.transport
+            .proxy_connection(AdbServerCommand::ForwardRemoveAll, false)
+            .map(|_| ())
+    }
+}

adb_client/src/server_device/commands/framebuffer.rs

@@ -0,0 +1,76 @@
+use std::io::Read;
+
+use byteorder::{LittleEndian, ReadBytesExt};
+use image::{ImageBuffer, Rgba};
+
+use crate::{
+    ADBServerDevice, Result, RustADBError,
+    models::{AdbServerCommand, FrameBufferInfoV1, FrameBufferInfoV2},
+};
+
+impl ADBServerDevice {
+    /// Inner method requesting framebuffer from Android device
+    pub(crate) fn framebuffer_inner(&mut self) -> Result<ImageBuffer<Rgba<u8>, Vec<u8>>> {
+        self.set_serial_transport()?;
+
+        self.transport
+            .send_adb_request(AdbServerCommand::FrameBuffer)?;
+
+        let version = self
+            .transport
+            .get_raw_connection()?
+            .read_u32::<LittleEndian>()?;
+
+        match version {
+            // RGBA_8888
+            1 => {
+                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV1>()];
+
+                self.transport.get_raw_connection()?.read_exact(&mut buf)?;
+
+                let framebuffer_info: FrameBufferInfoV1 = buf.try_into()?;
+
+                let mut data = vec![
+                    0_u8;
+                    framebuffer_info
+                        .size
+                        .try_into()
+                        .map_err(|_| RustADBError::ConversionError)?
+                ];
+                self.transport.get_raw_connection()?.read_exact(&mut data)?;
+
+                Ok(ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(
+                    framebuffer_info.width,
+                    framebuffer_info.height,
+                    data,
+                )
+                .ok_or_else(|| RustADBError::FramebufferConversionError)?)
+            }
+            // RGBX_8888
+            2 => {
+                let mut buf = [0u8; std::mem::size_of::<FrameBufferInfoV2>()];
+
+                self.transport.get_raw_connection()?.read_exact(&mut buf)?;
+
+                let framebuffer_info: FrameBufferInfoV2 = buf.try_into()?;
+
+                let mut data = vec![
+                    0_u8;
+                    framebuffer_info
+                        .size
+                        .try_into()
+                        .map_err(|_| RustADBError::ConversionError)?
+                ];
+                self.transport.get_raw_connection()?.read_exact(&mut data)?;
+
+                Ok(ImageBuffer::<Rgba<u8>, Vec<u8>>::from_vec(
+                    framebuffer_info.width,
+                    framebuffer_info.height,
+                    data,
+                )
+                .ok_or_else(|| RustADBError::FramebufferConversionError)?)
+            }
+            v => Err(RustADBError::UnimplementedFramebufferImageVersion(v)),
+        }
+    }
+}