71 Commits
v0.12 ... v0.16

Author SHA1 Message Date
Peter Fajdiga
7d0e83ca2f Bump version to 0.16 2026-03-15 09:51:14 +01:00
Jin Liu
b8650a2e1f Add "Increase column width to maximum/minimum" actions (#148)
The width is set to the maximum/minimum of preset widths.
2026-03-15 09:13:17 +01:00
Peter Fajdiga
19f275325d config.ui: Reword layering options (issue 155) 2026-03-09 20:21:30 +01:00
Peter Fajdiga
9a5a28db82 Add wl-clipboard to default window rules (issue 161) 2026-03-07 22:15:01 +01:00
Peter Fajdiga
6c698c9c82 Fix frameGeometry, clientGeometry, minSize problems (issue 152) 2026-02-22 07:28:41 +01:00
Peter Fajdiga
973956ed5e MockKwinClient: Add some jitter to frameGeometry, clientGeometry, minSize 2026-02-22 00:05:13 +01:00
Peter Fajdiga
f05ae6686d Remove uses of QmlRect.left, right, top, bottom 2026-02-21 23:52:40 +01:00
Peter Fajdiga
3a47fef028 tests: presetWidths: Include column width actions 2026-02-21 20:03:07 +01:00
Peter Fajdiga
ccf0626795 tests: presetWidths: Add test "Preset Widths custom percentages" 2026-02-21 14:53:32 +01:00
Peter Fajdiga
9ba3bc6b0b Fix formatting in Actions.ts 2026-02-14 13:22:37 +01:00
Peter Fajdiga
99c6a39ac5 Update node_modules/js-yaml 2025-12-26 09:46:33 +01:00
Peter Fajdiga
85d7bbe777 Rename make test 2025-12-26 09:45:47 +01:00
Peter Fajdiga
6f69252001 set focus after scrolling with the touchpad gesture
Co-authored-by: Grafcube <grafcube@disroot.org>
2025-12-20 22:20:38 +01:00
Peter Fajdiga
60bee26e29 remove unused fullyVisible parameters 2025-12-20 13:48:38 +01:00
Peter Fajdiga
7d4eab03b9 bump version to 0.15 2025-11-09 20:57:31 +01:00
Peter Fajdiga
7070e59044 mark cursorFollowsFocus setting as experimental 2025-10-22 21:53:09 +02:00
Peter Fajdiga
7f5745b2cf fix cursorFollowsFocus setting after c7effc8913 2025-10-22 21:01:06 +02:00
Peter Fajdiga
c7752bf20a add error notification for invalid tiled desktops regex 2025-10-21 23:01:00 +02:00
Peter Fajdiga
8149100aac DesktopManager: remove addDesktop call in constructor 2025-10-21 22:57:02 +02:00
Peter Fajdiga
99bf71f0b9 config.ui: shorten tooltip for kcfg_tiledDesktops 2025-10-21 22:48:13 +02:00
Peter Fajdiga
2b882768d9 config.ui: don't use monospace font for kcfg_tiledDesktops editbox 2025-10-21 22:45:42 +02:00
Peter Fajdiga
bb42e4d3ad clean whitespace 2025-10-21 22:16:12 +02:00
SR_team
c7effc8913 Add Desktops settings tab to control which virtual desktops Karousel operates on (#133)
* Add Desktops settings tab to control which virtual desktops Karousel operates on

* Fix cursor follow focus to only work on matched desktops

* Resolve review comments

- Implement a RegExp-based DesktopFilter.
- Add new config key tiledDesktops (String) with default ".*" (match all).
- Make DesktopManager return undefined for desktops that should not be tiled.
- Mark KWinDesktop.name as readonly.
- Replace multiline desktop editor in settings UI with a single-line QLineEdit (moved to top of Window Rules tab), shorten label to "Tiled desktops:" and add a tooltip with examples.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
2025-10-21 21:06:25 +02:00
Peter Fajdiga
2c433867f3 bump package to 0.14 2025-09-28 09:39:17 +02:00
Peter Fajdiga
e995555074 tests: passFocus: remove assertion for null activeWindow 2025-09-13 17:31:12 +02:00
Peter Fajdiga
6a1e018df1 tests: MockWorkspace: only focus a different window if none is focused 2025-09-13 16:58:44 +02:00
Peter Fajdiga
872a67e6e1 clear Focus Passer if another window is focused by anyone 2025-09-13 15:32:19 +02:00
Peter Fajdiga
5a57ba76d8 only clear Focus Passer if another window is focused by Karousel 2025-09-13 15:31:44 +02:00
Peter Fajdiga
55c6932338 always pass Window to Focus Passer 2025-09-13 15:02:27 +02:00
Peter Fajdiga
b1d6193e48 tests: make mocks more accurately mimic kwin behaviour 2025-09-13 12:42:22 +02:00
Peter Fajdiga
456bbf30b4 fix focus passing when moving a column to another desktop 2025-09-13 12:41:21 +02:00
Peter Fajdiga
24c1fa0a38 uncomment passFocus test 2025-09-13 12:26:57 +02:00
Peter Fajdiga
ac7566d2cf fix focus passing when closing windows 2025-09-07 20:37:00 +02:00
Peter Fajdiga
195f4e6d30 don't pass focus when window is moved and followed to a different desktop (issue 116) 2025-09-07 20:37:00 +02:00
Peter Fajdiga
e8f2a50420 tests: add test for kwin shortucts for moving windows to adjacent desktops 2025-09-07 20:37:00 +02:00
Peter Fajdiga
9910bc7041 tests: MockWorkspace.removeWindow: unfocus before focusing 2025-09-07 20:37:00 +02:00
Peter Fajdiga
1b592c5b4b fix detection of full-screen windows for apps that manage their own window decorations 2025-09-07 19:45:36 +02:00
Peter Fajdiga
75384d9fb4 tests: make runOneOf functions optionally return a value 2025-09-07 19:45:36 +02:00
Peter Fajdiga
dba92d3826 upgrade node modules 2025-09-07 19:45:36 +02:00
Peter Fajdiga
dbb95e0470 enable eslint comma-dangle 2025-09-07 19:45:34 +02:00
Peter Fajdiga
056149440d readme: add mention of npm requirement 2025-05-14 21:22:05 +02:00
Peter Fajdiga
33be23c6dc bump version to 0.13 2025-05-03 21:54:42 +02:00
Peter Fajdiga
e31669e499 config.ui: gestureScroll: add note regarding disabling KDE workspace switching gestures 2025-04-30 20:25:36 +02:00
Peter Fajdiga
caf2b5a146 Makefile: add ability to skip the linter 2025-04-17 21:11:24 +02:00
Peter Fajdiga
b7f1876a84 Makefile: add lint 2025-04-17 21:08:29 +02:00
Peter Fajdiga
f108c4a45e require indent of 4 spaces 2025-04-17 21:02:49 +02:00
Peter Fajdiga
0aa5d8c3fa require semicolons 2025-04-17 20:55:03 +02:00
Peter Fajdiga
1674d14453 eslint: allow empty functions 2025-04-17 20:45:39 +02:00
Peter Fajdiga
ca8b78ef04 configure eslint 2025-04-17 20:45:39 +02:00
Peter Fajdiga
877767cea3 add eslint 2025-04-17 20:45:39 +02:00
Peter Fajdiga
f1a18b8276 World: simplify addExistingClients 2025-04-17 20:45:09 +02:00
Peter Fajdiga
8725bc84e0 use interface instead of type 2025-04-17 20:44:59 +02:00
Peter Fajdiga
8c23535e86 use as type assertions 2025-04-17 20:44:56 +02:00
Peter Fajdiga
c0e7234fec remove type annotations for trivially inferred types 2025-04-17 20:44:50 +02:00
Peter Fajdiga
03acbe1280 use const where possible 2025-04-17 20:44:28 +02:00
Peter Fajdiga
7ef0c60cb8 un-maximize when swithing to another window in the same column (issue 93) 2025-04-04 13:59:39 +02:00
Peter Fajdiga
7e1517bbcb tests: maximization: simplify test cases' code by passing functions with fewer parameters 2025-04-04 13:48:30 +02:00
Peter Fajdiga
a23acd056b tests: maximization: combine files 2025-04-04 13:37:45 +02:00
Peter Fajdiga
e908f7fe8a tests: combine re-maximize tests 2025-04-04 13:02:04 +02:00
Peter Fajdiga
ba63c1d4e7 tests: re-maximize: simplify and add another window to column 2025-04-04 12:48:36 +02:00
Peter Fajdiga
bf060cef17 tests: "Re-maximize enabled": simplify and add another window to column 2025-04-04 12:11:11 +02:00
Peter Fajdiga
0f21f94d02 add test for cursorFollowsFocus and add check whether cursor already within focused client 2025-04-04 11:36:04 +02:00
Himadri Bhattacharjee
6dd356dc53 add option for moving cursor to the focused window (#89) 2025-04-04 11:33:39 +02:00
Himadri Bhattacharjee
c99cad96c3 add swipe gesture scrolling support (Wayland only) (#90) 2025-04-04 09:56:07 +02:00
Peter Fajdiga
b4fe71f91b ClientWrapper: set maximizedMode to Unmaximized for non-maximizable clients (issue 79) 2025-04-03 20:25:03 +02:00
Peter Fajdiga
099b9f5d6a tests: "Start full-screen (force tiling)": add case where full-screen exit is initiated by the client 2025-04-03 17:04:04 +02:00
Peter Fajdiga
92f6942eef tests: add debug function runReorderDebug 2025-04-03 16:58:47 +02:00
Peter Fajdiga
9621c2a75b tests: "Start full-screen (force tiling)": add assert for windowed client 2025-04-03 16:58:47 +02:00
Peter Fajdiga
36bc1be8c0 tests: enable passing different column widths to Assert.grid 2025-04-03 16:58:47 +02:00
Peter Fajdiga
68b659744c MockKwinClient: when switching out of full-screen mode, remember the target windowed frame geometry throughout all the steps 2025-04-03 16:58:20 +02:00
Peter Fajdiga
c715289282 fix keepBelow and keepAbove properties for windows that start in full-screen mode (issue 79) 2025-04-03 12:23:24 +02:00
76 changed files with 3250 additions and 655 deletions

2
.gitignore vendored
View File

@@ -2,4 +2,6 @@
/package/contents/config/main.xml /package/contents/config/main.xml
/karousel*.tar.gz /karousel*.tar.gz
run-ts-tmp.js run-ts-tmp.js
/node_modules
/.idea /.idea

View File

@@ -1,15 +1,26 @@
VERSION = $(shell grep '"Version":' ./package/metadata.json | grep -o '[0-9\.]*') VERSION = $(shell grep '"Version":' ./package/metadata.json | grep -o '[0-9\.]*')
TESTS := true CHECKS := true
.PHONY: * .PHONY: *
build: tests build: lint test
tsc -p ./src/main --outFile ./package/contents/code/main.js tsc -p ./src/main --outFile ./package/contents/code/main.js
mkdir -p ./package/contents/config mkdir -p ./package/contents/config
./run-ts.sh ./src/generators/config > ./package/contents/config/main.xml ./run-ts.sh ./src/generators/config > ./package/contents/config/main.xml
tests: npm-install:
ifeq (${TESTS}, true) npm install
lint: npm-install
ifeq (${CHECKS}, true)
npx eslint ./src
endif
lint-fix: npm-install
npx eslint ./src --fix
test:
ifeq (${CHECKS}, true)
./run-ts.sh ./src/tests ./run-ts.sh ./src/tests
endif endif

View File

@@ -27,7 +27,7 @@ First install the _org.kde.notification_ QML module (_qml-module-org-kde-notific
Then download the [latest release](https://github.com/peterfajdiga/karousel/releases/latest) and extract it into _~/.local/share/kwin/scripts/_. Then download the [latest release](https://github.com/peterfajdiga/karousel/releases/latest) and extract it into _~/.local/share/kwin/scripts/_.
Or clone the repo and run `make install` (requires node and tsc). Or clone the repo and run `make install` (requires npm, node, and tsc).
## Key bindings ## Key bindings
The key bindings can be configured in KDE System Settings among KWin's own keyboard shortcuts. The key bindings can be configured in KDE System Settings among KWin's own keyboard shortcuts.

15
eslint.config.mjs Normal file
View File

@@ -0,0 +1,15 @@
// @ts-check
import tseslint from "typescript-eslint";
export default tseslint.config(
{
extends: [tseslint.configs.stylistic],
rules: {
"@typescript-eslint/no-empty-function": "off",
"semi": "error",
"comma-dangle": ["error", "always-multiline"],
"indent": ["error", 4],
},
}
);

1466
package-lock.json generated Normal file

File diff suppressed because it is too large Load Diff

6
package.json Normal file
View File

@@ -0,0 +1,6 @@
{
"devDependencies": {
"eslint": "^9.24.0",
"typescript-eslint": "^8.30.1"
}
}

View File

@@ -29,6 +29,16 @@
</property> </property>
</widget> </widget>
</item> </item>
<item>
<widget class="QCheckBox" name="kcfg_cursorFollowsFocus">
<property name="text">
<string>Cursor follows focus (experimental)</string>
</property>
<property name="toolTip">
<string>When a window gains focus, move the cursor to it</string>
</property>
</widget>
</item>
<item> <item>
<widget class="QCheckBox" name="kcfg_stackColumnsByDefault"> <widget class="QCheckBox" name="kcfg_stackColumnsByDefault">
<property name="text"> <property name="text">
@@ -101,6 +111,35 @@
</widget> </widget>
</item> </item>
<item>
<widget class="QGroupBox">
<property name="title">
<string>Touchpad scrolling (Wayland only)</string>
</property>
<layout class="QVBoxLayout">
<item>
<widget class="QCheckBox" name="kcfg_gestureScroll">
<property name="text">
<string>Enable scrolling with touchpad gestures
(please don't forget to disable KDE's workspace switching gestures)</string>
</property>
<property name="toolTip">
<string>Scroll with a three-finger horizontal swipe gesture</string>
</property>
</widget>
</item>
<item>
<widget class="QCheckBox" name="kcfg_gestureScrollInvert">
<property name="text">
<string>Invert scroll direction (Natural scrolling)</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
<item> <item>
<widget class="QGroupBox"> <widget class="QGroupBox">
<property name="title"> <property name="title">
@@ -110,14 +149,14 @@
<item> <item>
<widget class="QRadioButton" name="kcfg_tiledKeepBelow"> <widget class="QRadioButton" name="kcfg_tiledKeepBelow">
<property name="text"> <property name="text">
<string>Keep tiled windows below</string> <string>Set "Keep Below" for tiled windows</string>
</property> </property>
</widget> </widget>
</item> </item>
<item> <item>
<widget class="QRadioButton" name="kcfg_floatingKeepAbove"> <widget class="QRadioButton" name="kcfg_floatingKeepAbove">
<property name="text"> <property name="text">
<string>Keep floating windows above</string> <string>Set "Keep Above" for floating windows</string>
</property> </property>
</widget> </widget>
</item> </item>
@@ -343,6 +382,36 @@
</item> </item>
<item row="9" column="0"> <item row="9" column="0">
<widget class="QLabel" name="label_gestureScrollStep">
<property name="text">
<string>Touchpad gesture scrolling speed:</string>
</property>
<property name="toolTip">
<string>The amount to scroll per edge-to-edge gesture</string>
</property>
</widget>
</item>
<item row="9" column="1">
<widget class="QSpinBox" name="kcfg_gestureScrollStep">
<property name="suffix">
<string> px</string>
</property>
<property name="maximum">
<number>10000</number>
</property>
<property name="minimum">
<number>100</number>
</property>
<property name="singleStep">
<number>100</number>
</property>
<property name="value">
<number>1920</number>
</property>
</widget>
</item>
<item row="10" column="0">
<widget class="QLabel" name="label_presetWidths"> <widget class="QLabel" name="label_presetWidths">
<property name="text"> <property name="text">
<string>Preset widths:</string> <string>Preset widths:</string>
@@ -352,7 +421,7 @@
</property> </property>
</widget> </widget>
</item> </item>
<item row="9" column="1"> <item row="10" column="1">
<widget class="QLineEdit" name="kcfg_presetWidths"> <widget class="QLineEdit" name="kcfg_presetWidths">
<property name="toolTip"> <property name="toolTip">
<string>Comma-separated list of widths. Supported units: "px" and "%".</string> <string>Comma-separated list of widths. Supported units: "px" and "%".</string>
@@ -360,14 +429,14 @@
</widget> </widget>
</item> </item>
<item row="10" column="0"> <item row="11" column="0">
<widget class="QLabel" name="label_offScreenOpacity"> <widget class="QLabel" name="label_offScreenOpacity">
<property name="text"> <property name="text">
<string>Obscured window opacity:</string> <string>Obscured window opacity:</string>
</property> </property>
</widget> </widget>
</item> </item>
<item row="10" column="1"> <item row="11" column="1">
<widget class="QSpinBox" name="kcfg_offScreenOpacity"> <widget class="QSpinBox" name="kcfg_offScreenOpacity">
<property name="suffix"> <property name="suffix">
<string> %</string> <string> %</string>
@@ -380,6 +449,7 @@
</property> </property>
</widget> </widget>
</item> </item>
</layout> </layout>
</widget> </widget>
@@ -388,6 +458,27 @@
<string>Window Rules</string> <string>Window Rules</string>
</attribute> </attribute>
<layout class="QVBoxLayout"> <layout class="QVBoxLayout">
<item>
<layout class="QHBoxLayout">
<item>
<widget class="QLabel" name="label_desktops">
<property name="text">
<string>Tiled desktops:</string>
</property>
<property name="wordWrap">
<bool>true</bool>
</property>
</widget>
</item>
<item>
<widget class="QLineEdit" name="kcfg_tiledDesktops">
<property name="toolTip">
<string>Regex string to match desktops by desktop name"</string>
</property>
</widget>
</item>
</layout>
</item>
<item> <item>
<widget class="QPlainTextEdit" name="kcfg_windowRules"> <widget class="QPlainTextEdit" name="kcfg_windowRules">
<property name="tabChangesFocus"> <property name="tabChangesFocus">

View File

@@ -16,6 +16,16 @@ Item {
qmlBase.karouselInstance.destroy(); qmlBase.karouselInstance.destroy();
} }
Notification {
id: notificationInvalidTiledDesktops
componentName: "plasma_workspace"
eventId: "notification"
title: "Karousel"
text: "Your Tiled Desktops regex is malformed, please review your Karousel configuration"
flags: Notification.Persistent
urgency: Notification.HighUrgency
}
Notification { Notification {
id: notificationInvalidWindowRules id: notificationInvalidWindowRules
componentName: "plasma_workspace" componentName: "plasma_workspace"
@@ -35,4 +45,29 @@ Item {
flags: Notification.Persistent flags: Notification.Persistent
urgency: Notification.HighUrgency urgency: Notification.HighUrgency
} }
SwipeGestureHandler {
direction: SwipeGestureHandler.Direction.Left
fingerCount: 3
onActivated: qmlBase.karouselInstance.gestureScrollFinish()
onCancelled: qmlBase.karouselInstance.gestureScrollFinish()
onProgressChanged: qmlBase.karouselInstance.gestureScroll(-progress)
}
SwipeGestureHandler {
direction: SwipeGestureHandler.Direction.Right
fingerCount: 3
onActivated: qmlBase.karouselInstance.gestureScrollFinish()
onCancelled: qmlBase.karouselInstance.gestureScrollFinish()
onProgressChanged: qmlBase.karouselInstance.gestureScroll(progress)
}
DBusCall {
id: moveCursorToFocus
service: "org.kde.kglobalaccel"
path: "/component/kwin"
method: "invokeShortcut"
arguments: ["MoveMouseToFocus"]
}
} }

View File

@@ -9,7 +9,7 @@
"Name": "Peter Fajdiga" "Name": "Peter Fajdiga"
}], }],
"Id": "karousel", "Id": "karousel",
"Version": "0.12", "Version": "0.16",
"License": "GPLv3", "License": "GPLv3",
"Website": "https://github.com/peterfajdiga/karousel", "Website": "https://github.com/peterfajdiga/karousel",
"BugReportUrl": "https://github.com/peterfajdiga/karousel/issues" "BugReportUrl": "https://github.com/peterfajdiga/karousel/issues"

View File

@@ -2,5 +2,7 @@ declare const Qt: Qt;
declare const KWin: KWin; declare const KWin: KWin;
declare const Workspace: Workspace; declare const Workspace: Workspace;
declare const qmlBase: QmlObject; declare const qmlBase: QmlObject;
declare const notificationInvalidTiledDesktops: Notification;
declare const notificationInvalidWindowRules: Notification; declare const notificationInvalidWindowRules: Notification;
declare const notificationInvalidPresetWidths: Notification; declare const notificationInvalidPresetWidths: Notification;
declare const moveCursorToFocus: DBusCall;

View File

@@ -1,7 +1,7 @@
type DocsKeyBinding = { interface DocsKeyBinding {
description: string; description: string;
keySequence: string; keySequence: string;
}; }
function formatDescription(item: {description: string, comment?: string}) { function formatDescription(item: {description: string, comment?: string}) {
const suffix = item.comment === undefined ? "" : ` (${item.comment})`; const suffix = item.comment === undefined ? "" : ` (${item.comment})`;
@@ -15,9 +15,9 @@ function printCols(...columns: (string[] | string)[]) {
} }
let nRows = Math.min(...columns.filter( let nRows = Math.min(...columns.filter(
(column: string[] | string) => column instanceof Array (column: string[] | string) => column instanceof Array,
).map( ).map(
(column: string[] | string) => column.length (column: string[] | string) => column.length,
)); ));
if (nRows === Infinity) { if (nRows === Infinity) {
// we only have single string columns // we only have single string columns
@@ -28,12 +28,12 @@ function printCols(...columns: (string[] | string)[]) {
(column: string[] | string) => { (column: string[] | string) => {
if (column instanceof Array) { if (column instanceof Array) {
return Math.max(...column.map( return Math.max(...column.map(
(cell: string) => cell.length (cell: string) => cell.length,
)) ));
} else { } else {
return column.length; return column.length;
} }
} },
); );
function getCell(col: number, row: number) { function getCell(col: number, row: number) {

View File

@@ -13,8 +13,8 @@ class ContextualResizer {
return; return;
} }
let leftVisibleColumn = grid.getLeftmostVisibleColumn(visibleRange, true); const leftVisibleColumn = grid.getLeftmostVisibleColumn(visibleRange);
let rightVisibleColumn = grid.getRightmostVisibleColumn(visibleRange, true); const rightVisibleColumn = grid.getRightmostVisibleColumn(visibleRange);
if (leftVisibleColumn === null || rightVisibleColumn === null) { if (leftVisibleColumn === null || rightVisibleColumn === null) {
console.assert(false); // should at least see self console.assert(false); // should at least see self
return; return;
@@ -31,7 +31,7 @@ class ContextualResizer {
...this.presetWidths.getWidths(minWidth, maxWidth), ...this.presetWidths.getWidths(minWidth, maxWidth),
], ],
width => width - column.getWidth(), width => width - column.getWidth(),
) );
if (newWidth === undefined) { if (newWidth === undefined) {
return; return;
} }
@@ -50,8 +50,8 @@ class ContextualResizer {
return; return;
} }
const leftVisibleColumn = grid.getLeftmostVisibleColumn(visibleRange, true); const leftVisibleColumn = grid.getLeftmostVisibleColumn(visibleRange);
const rightVisibleColumn = grid.getRightmostVisibleColumn(visibleRange, true); const rightVisibleColumn = grid.getRightmostVisibleColumn(visibleRange);
if (leftVisibleColumn === null || rightVisibleColumn === null) { if (leftVisibleColumn === null || rightVisibleColumn === null) {
console.assert(false); // should at least see self console.assert(false); // should at least see self
return; return;
@@ -78,7 +78,7 @@ class ContextualResizer {
...this.presetWidths.getWidths(minWidth, maxWidth), ...this.presetWidths.getWidths(minWidth, maxWidth),
], ],
width => column.getWidth() - width, width => column.getWidth() - width,
) );
if (newWidth === undefined) { if (newWidth === undefined) {
return; return;
} }
@@ -86,4 +86,22 @@ class ContextualResizer {
column.setWidth(newWidth, true); column.setWidth(newWidth, true);
desktop.scrollCenterVisible(column); desktop.scrollCenterVisible(column);
} }
public maximizeWidth(column: Column) {
const grid = column.grid;
const desktop = grid.desktop;
const presetWidths = this.presetWidths.getWidths(column.getMinWidth(), column.getMaxWidth());
const maxWidth = presetWidths[presetWidths.length-1];
column.setWidth(maxWidth, true);
desktop.scrollCenterVisible(column);
}
public minimizeWidth(column: Column) {
const grid = column.grid;
const desktop = grid.desktop;
const presetWidths = this.presetWidths.getWidths(column.getMinWidth(), column.getMaxWidth());
const minWidth = presetWidths[0];
column.setWidth(minWidth, true);
desktop.scrollCenterVisible(column);
}
} }

View File

@@ -28,4 +28,16 @@ class RawResizer {
} }
column.setWidth(newWidth, true); column.setWidth(newWidth, true);
} }
public maximizeWidth(column: Column) {
const presetWidths = this.presetWidths.getWidths(column.getMinWidth(), column.getMaxWidth());
const maxWidth = presetWidths[presetWidths.length-1];
column.setWidth(maxWidth, true);
}
public minimizeWidth(column: Column) {
const presetWidths = this.presetWidths.getWidths(column.getMinWidth(), column.getMaxWidth());
const minWidth = presetWidths[0];
column.setWidth(minWidth, true);
}
} }

View File

@@ -6,8 +6,8 @@ class CenterClamper {
} }
const lastColumn = desktop.grid.getLastColumn()!; const lastColumn = desktop.grid.getLastColumn()!;
let minScroll = Math.round((firstColumn.getWidth() - desktop.tilingArea.width) / 2); const minScroll = Math.round((firstColumn.getWidth() - desktop.tilingArea.width) / 2);
let maxScroll = Math.round(desktop.grid.getWidth() - (desktop.tilingArea.width + lastColumn.getWidth()) / 2); const maxScroll = Math.round(desktop.grid.getWidth() - (desktop.tilingArea.width + lastColumn.getWidth()) / 2);
return clamp(x, minScroll, maxScroll); return clamp(x, minScroll, maxScroll);
} }
} }

View File

@@ -1,7 +1,7 @@
class EdgeClamper { class EdgeClamper {
public clampScrollX(desktop: Desktop, x: number) { public clampScrollX(desktop: Desktop, x: number) {
let minScroll = 0; const minScroll = 0;
let maxScroll = desktop.grid.getWidth() - desktop.tilingArea.width; const maxScroll = desktop.grid.getWidth() - desktop.tilingArea.width;
if (maxScroll < 0) { if (maxScroll < 0) {
return Math.round(maxScroll / 2); return Math.round(maxScroll / 2);
} }

View File

@@ -1,4 +1,4 @@
type Config = { interface Config {
gapsOuterTop: number; gapsOuterTop: number;
gapsOuterBottom: number; gapsOuterBottom: number;
gapsOuterLeft: number; gapsOuterLeft: number;
@@ -11,6 +11,7 @@ type Config = {
presetWidths: string; presetWidths: string;
offScreenOpacity: number; offScreenOpacity: number;
untileOnDrag: boolean; untileOnDrag: boolean;
cursorFollowsFocus: boolean;
stackColumnsByDefault: boolean; stackColumnsByDefault: boolean;
resizeNeighborColumn: boolean; resizeNeighborColumn: boolean;
reMaximize: boolean; reMaximize: boolean;
@@ -18,7 +19,11 @@ type Config = {
scrollingLazy: boolean; scrollingLazy: boolean;
scrollingCentered: boolean; scrollingCentered: boolean;
scrollingGrouped: boolean; scrollingGrouped: boolean;
gestureScroll: boolean;
gestureScrollInvert: boolean;
gestureScrollStep: number;
tiledKeepBelow: boolean; tiledKeepBelow: boolean;
floatingKeepAbove: boolean; floatingKeepAbove: boolean;
windowRules: string; windowRules: string;
}; tiledDesktops: string;
}

View File

@@ -31,6 +31,11 @@ const defaultWindowRules = `[
"class": "(org\\\\.kde\\\\.)?yakuake", "class": "(org\\\\.kde\\\\.)?yakuake",
"tile": false "tile": false
}, },
{
"class": "wl-copy|wl-paste",
"caption": "wl-clipboard",
"tile": false
},
{ {
"class": "steam", "class": "steam",
"caption": "Steam Big Picture Mode", "caption": "Steam Big Picture Mode",
@@ -114,6 +119,11 @@ const configDef = [
type: "Bool", type: "Bool",
default: true, default: true,
}, },
{
name: "cursorFollowsFocus",
type: "Bool",
default: false,
},
{ {
name: "stackColumnsByDefault", name: "stackColumnsByDefault",
type: "Bool", type: "Bool",
@@ -149,6 +159,21 @@ const configDef = [
type: "Bool", type: "Bool",
default: false, default: false,
}, },
{
name: "gestureScroll",
type: "Bool",
default: false,
},
{
name: "gestureScrollInvert",
type: "Bool",
default: false,
},
{
name: "gestureScrollStep",
type: "UInt",
default: 1920,
},
{ {
name: "tiledKeepBelow", name: "tiledKeepBelow",
type: "Bool", type: "Bool",
@@ -168,5 +193,10 @@ const configDef = [
name: "windowRules", name: "windowRules",
type: "String", type: "String",
default: defaultWindowRules, default: defaultWindowRules,
} },
{
name: "tiledDesktops",
type: "String",
default: ".*",
},
]; ];

3
src/lib/extern/dbuscall.ts vendored Normal file
View File

@@ -0,0 +1,3 @@
interface DBusCall extends QmlObject {
call(): void;
}

View File

@@ -1,10 +1,10 @@
type KWin = { interface KWin {
__brand: "KWin"; __brand: "KWin";
readConfig(key: string, defaultValue: any): any; readConfig(key: string, defaultValue: any): any;
}; }
type Workspace = { interface Workspace {
__brand: "Workspace"; __brand: "Workspace";
readonly activities: string[]; readonly activities: string[];
@@ -28,7 +28,7 @@ type Workspace = {
readonly virtualScreenSizeChanged: QSignal<[]>; readonly virtualScreenSizeChanged: QSignal<[]>;
clientArea(option: ClientAreaOption, output: Output, kwinDesktop: KwinDesktop): QmlRect; clientArea(option: ClientAreaOption, output: Output, kwinDesktop: KwinDesktop): QmlRect;
}; }
const enum ClientAreaOption { const enum ClientAreaOption {
PlacementArea, PlacementArea,
@@ -48,10 +48,10 @@ const enum MaximizedMode {
Maximized, Maximized,
} }
type Tile = { __brand: "Tile" }; interface Tile { __brand: "Tile" }
type Output = { __brand: "Output" }; interface Output { __brand: "Output" }
type KwinClient = { interface KwinClient {
__brand: "KwinClient"; __brand: "KwinClient";
readonly caption: string; readonly caption: string;
@@ -96,15 +96,16 @@ type KwinClient = {
readonly frameGeometryChanged: QSignal<[oldGeometry: QmlRect]>; readonly frameGeometryChanged: QSignal<[oldGeometry: QmlRect]>;
setMaximize(vertically: boolean, horizontally: boolean): void; setMaximize(vertically: boolean, horizontally: boolean): void;
}; }
type KwinDesktop = { interface KwinDesktop {
__brand: "KwinDesktop"; __brand: "KwinDesktop";
readonly id: string; readonly id: string;
}; readonly name: string;
}
type ShortcutHandler = QmlObject & { interface ShortcutHandler extends QmlObject {
readonly activated: QSignal<[]>; readonly activated: QSignal<[]>;
destroy(): void; destroy(): void;
}; }

View File

@@ -1,3 +1,3 @@
type Notification = QmlObject & { interface Notification extends QmlObject {
sendEvent(): void; sendEvent(): void;
}; }

34
src/lib/extern/qt.ts vendored
View File

@@ -1,56 +1,52 @@
type Console = { interface Console {
__brand: "Console"; __brand: "Console";
log(...args: any[]): void; log(...args: any[]): void;
assert(assertion: boolean, message?: string): void; assert(assertion: boolean, message?: string): void;
}; }
type Qt = { interface Qt {
__brand: "Qt"; __brand: "Qt";
rect(x: number, y: number, width: number, height: number): QmlRect; rect(x: number, y: number, width: number, height: number): QmlRect;
createQmlObject(qml: string, parent: QmlObject): QmlObject; createQmlObject(qml: string, parent: QmlObject): QmlObject;
}; }
type QmlObject = { __brand: "QmlObject" }; interface QmlObject { __brand: "QmlObject" }
type QmlPoint = { interface QmlPoint {
__brand: "QmlPoint"; __brand: "QmlPoint";
x: number; x: number;
y: number; y: number;
}; }
type QmlRect = { interface QmlRect {
__brand: "QmlRect"; __brand: "QmlRect";
x: number; x: number;
y: number; y: number;
width: number; width: number;
height: number; height: number;
readonly top: number; }
readonly bottom: number; // top + height
readonly left: number;
readonly right: number; // left + width
};
type QmlSize = { interface QmlSize {
__brand: "QmlSize"; __brand: "QmlSize";
width: number; width: number;
height: number; height: number;
}; }
type QSignal<T extends unknown[]> = { interface QSignal<T extends unknown[]> {
__brand: "QSignal"; __brand: "QSignal";
connect(handler: (...args: [...T]) => void): void; connect(handler: (...args: [...T]) => void): void;
disconnect(handler: (...args: [...T]) => void): void; disconnect(handler: (...args: [...T]) => void): void;
}; }
type QmlTimer = QmlObject & { interface QmlTimer extends QmlObject {
interval: number; interval: number;
readonly triggered: QSignal<[]>; readonly triggered: QSignal<[]>;
restart(): void; restart(): void;
destroy(): void; destroy(): void;
}; }

View File

@@ -8,16 +8,16 @@ class Actions {
if (leftColumn === null) { if (leftColumn === null) {
return; return;
} }
leftColumn.focus(); leftColumn.getWindowToFocus().focus();
} };
public readonly focusRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly focusRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const rightColumn = grid.getRightColumn(column); const rightColumn = grid.getRightColumn(column);
if (rightColumn === null) { if (rightColumn === null) {
return; return;
} }
rightColumn.focus(); rightColumn.getWindowToFocus().focus();
} };
public readonly focusUp = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly focusUp = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const aboveWindow = column.getAboveWindow(window); const aboveWindow = column.getAboveWindow(window);
@@ -25,7 +25,7 @@ class Actions {
return; return;
} }
aboveWindow.focus(); aboveWindow.focus();
} };
public readonly focusDown = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly focusDown = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const belowWindow = column.getBelowWindow(window); const belowWindow = column.getBelowWindow(window);
@@ -33,7 +33,7 @@ class Actions {
return; return;
} }
belowWindow.focus(); belowWindow.focus();
} };
public readonly focusNext = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly focusNext = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const belowWindow = column.getBelowWindow(window); const belowWindow = column.getBelowWindow(window);
@@ -46,7 +46,7 @@ class Actions {
} }
rightColumn.getFirstWindow().focus(); rightColumn.getFirstWindow().focus();
} }
} };
public readonly focusPrevious = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly focusPrevious = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const aboveWindow = column.getAboveWindow(window); const aboveWindow = column.getAboveWindow(window);
@@ -59,25 +59,33 @@ class Actions {
} }
leftColumn.getLastWindow().focus(); leftColumn.getLastWindow().focus();
} }
} };
public readonly focusStart = (cm: ClientManager, dm: DesktopManager) => { public readonly focusStart = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const firstColumn = grid.getFirstColumn(); const firstColumn = grid.getFirstColumn();
if (firstColumn === null) { if (firstColumn === null) {
return; return;
} }
firstColumn.focus(); firstColumn.getWindowToFocus().focus();
} };
public readonly focusEnd = (cm: ClientManager, dm: DesktopManager) => { public readonly focusEnd = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const lastColumn = grid.getLastColumn(); const lastColumn = grid.getLastColumn();
if (lastColumn === null) { if (lastColumn === null) {
return; return;
} }
lastColumn.focus(); lastColumn.getWindowToFocus().focus();
} };
public readonly windowMoveLeft = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveLeft = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
if (column.getWindowCount() === 1) { if (column.getWindowCount() === 1) {
@@ -86,40 +94,40 @@ class Actions {
if (leftColumn === null) { if (leftColumn === null) {
return; return;
} }
window.moveToColumn(leftColumn, true); window.moveToColumn(leftColumn, true, FocusPassing.Type.None);
grid.desktop.autoAdjustScroll(); grid.desktop.autoAdjustScroll();
} else { } else {
// move from shared column into own column // move from shared column into own column
const newColumn = new Column(grid, grid.getLeftColumn(column)); const newColumn = new Column(grid, grid.getLeftColumn(column));
window.moveToColumn(newColumn, true); window.moveToColumn(newColumn, true, FocusPassing.Type.None);
} }
} };
public readonly windowMoveRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid, bottom: boolean = true) => { public readonly windowMoveRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid, bottom = true) => {
if (column.getWindowCount() === 1) { if (column.getWindowCount() === 1) {
// move from own column into existing column // move from own column into existing column
const rightColumn = grid.getRightColumn(column); const rightColumn = grid.getRightColumn(column);
if (rightColumn === null) { if (rightColumn === null) {
return; return;
} }
window.moveToColumn(rightColumn, bottom); window.moveToColumn(rightColumn, bottom, FocusPassing.Type.None);
grid.desktop.autoAdjustScroll(); grid.desktop.autoAdjustScroll();
} else { } else {
// move from shared column into own column // move from shared column into own column
const newColumn = new Column(grid, column); const newColumn = new Column(grid, column);
window.moveToColumn(newColumn, true); window.moveToColumn(newColumn, true, FocusPassing.Type.None);
} }
} };
// TODO (optimization): only arrange moved windows // TODO (optimization): only arrange moved windows
public readonly windowMoveUp = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveUp = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
column.moveWindowUp(window); column.moveWindowUp(window);
} };
// TODO (optimization): only arrange moved windows // TODO (optimization): only arrange moved windows
public readonly windowMoveDown = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveDown = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
column.moveWindowDown(window); column.moveWindowDown(window);
} };
public readonly windowMoveNext = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveNext = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const canMoveDown = window !== column.getLastWindow(); const canMoveDown = window !== column.getLastWindow();
@@ -128,7 +136,7 @@ class Actions {
} else { } else {
this.windowMoveRight(cm, dm, window, column, grid, false); this.windowMoveRight(cm, dm, window, column, grid, false);
} }
} };
public readonly windowMovePrevious = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMovePrevious = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const canMoveUp = window !== column.getFirstWindow(); const canMoveUp = window !== column.getFirstWindow();
@@ -137,67 +145,79 @@ class Actions {
} else { } else {
this.windowMoveLeft(cm, dm, window, column, grid); this.windowMoveLeft(cm, dm, window, column, grid);
} }
} };
public readonly windowMoveStart = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveStart = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const newColumn = new Column(grid, null); const newColumn = new Column(grid, null);
window.moveToColumn(newColumn, true); window.moveToColumn(newColumn, true, FocusPassing.Type.None);
} };
public readonly windowMoveEnd = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveEnd = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const newColumn = new Column(grid, grid.getLastColumn()); const newColumn = new Column(grid, grid.getLastColumn());
window.moveToColumn(newColumn, true); window.moveToColumn(newColumn, true, FocusPassing.Type.None);
} };
public readonly windowToggleFloating = (cm: ClientManager, dm: DesktopManager) => { public readonly windowToggleFloating = (cm: ClientManager, dm: DesktopManager) => {
if (Workspace.activeWindow === null) { if (Workspace.activeWindow === null) {
return; return;
} }
cm.toggleFloatingClient(Workspace.activeWindow); cm.toggleFloatingClient(Workspace.activeWindow);
} };
public readonly columnMoveLeft = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnMoveLeft = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
grid.moveColumnLeft(column); grid.moveColumnLeft(column);
} };
public readonly columnMoveRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnMoveRight = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
grid.moveColumnRight(column); grid.moveColumnRight(column);
} };
public readonly columnMoveStart = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnMoveStart = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
grid.moveColumn(column, null); grid.moveColumn(column, null);
} };
public readonly columnMoveEnd = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnMoveEnd = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
grid.moveColumn(column, grid.getLastColumn()); grid.moveColumn(column, grid.getLastColumn());
} };
public readonly columnToggleStacked = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnToggleStacked = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
column.toggleStacked(); column.toggleStacked();
} };
public readonly columnWidthIncrease = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnWidthIncrease = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
this.config.columnResizer.increaseWidth(column); this.config.columnResizer.increaseWidth(column);
} };
public readonly columnWidthDecrease = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly columnWidthDecrease = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
this.config.columnResizer.decreaseWidth(column); this.config.columnResizer.decreaseWidth(column);
} };
public readonly columnWidthMaximize = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
this.config.columnResizer.maximizeWidth(column);
};
public readonly columnWidthMinimize = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
this.config.columnResizer.minimizeWidth(column);
};
public readonly cyclePresetWidths = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly cyclePresetWidths = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const nextWidth = this.config.presetWidths.next(column.getWidth(), column.getMinWidth(), column.getMaxWidth()); const nextWidth = this.config.presetWidths.next(column.getWidth(), column.getMinWidth(), column.getMaxWidth());
column.setWidth(nextWidth, true); column.setWidth(nextWidth, true);
} };
public readonly cyclePresetWidthsReverse = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly cyclePresetWidthsReverse = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const nextWidth = this.config.presetWidths.prev(column.getWidth(), column.getMinWidth(), column.getMaxWidth()); const nextWidth = this.config.presetWidths.prev(column.getWidth(), column.getMinWidth(), column.getMaxWidth());
column.setWidth(nextWidth, true); column.setWidth(nextWidth, true);
} };
public readonly columnsWidthEqualize = (cm: ClientManager, dm: DesktopManager) => { public readonly columnsWidthEqualize = (cm: ClientManager, dm: DesktopManager) => {
const desktop = dm.getCurrentDesktop(); const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const visibleRange = desktop.getCurrentVisibleRange(); const visibleRange = desktop.getCurrentVisibleRange();
const visibleColumns = Array.from(desktop.grid.getVisibleColumns(visibleRange, true)); const visibleColumns = Array.from(desktop.grid.getVisibleColumns(visibleRange));
const availableSpace = desktop.tilingArea.width; const availableSpace = desktop.tilingArea.width;
const gapsWidth = desktop.grid.config.gapsInnerHorizontal * (visibleColumns.length-1); const gapsWidth = desktop.grid.config.gapsInnerHorizontal * (visibleColumns.length-1);
@@ -211,7 +231,7 @@ class Actions {
visibleColumns[0], visibleColumns[0],
visibleColumns[visibleColumns.length - 1], visibleColumns[visibleColumns.length - 1],
)); ));
} };
public readonly columnsSqueezeLeft = (cm: ClientManager, dm: DesktopManager, window: Window, focusedColumn: Column, grid: Grid) => { public readonly columnsSqueezeLeft = (cm: ClientManager, dm: DesktopManager, window: Window, focusedColumn: Column, grid: Grid) => {
const visibleRange = grid.desktop.getCurrentVisibleRange(); const visibleRange = grid.desktop.getCurrentVisibleRange();
@@ -219,7 +239,7 @@ class Actions {
return; return;
} }
const currentVisibleColumns = Array.from(grid.getVisibleColumns(visibleRange, true)); const currentVisibleColumns = Array.from(grid.getVisibleColumns(visibleRange));
console.assert(currentVisibleColumns.includes(focusedColumn), "should at least contain the focused column"); console.assert(currentVisibleColumns.includes(focusedColumn), "should at least contain the focused column");
const targetColumn = grid.getLeftColumn(currentVisibleColumns[0]); const targetColumn = grid.getLeftColumn(currentVisibleColumns[0]);
@@ -238,7 +258,7 @@ class Actions {
break; // don't scroll past the currently focused column break; // don't scroll past the currently focused column
} }
} }
} };
public readonly columnsSqueezeRight = (cm: ClientManager, dm: DesktopManager, window: Window, focusedColumn: Column, grid: Grid) => { public readonly columnsSqueezeRight = (cm: ClientManager, dm: DesktopManager, window: Window, focusedColumn: Column, grid: Grid) => {
const visibleRange = grid.desktop.getCurrentVisibleRange(); const visibleRange = grid.desktop.getCurrentVisibleRange();
@@ -246,7 +266,7 @@ class Actions {
return; return;
} }
const currentVisibleColumns = Array.from(grid.getVisibleColumns(visibleRange, true)); const currentVisibleColumns = Array.from(grid.getVisibleColumns(visibleRange));
console.assert(currentVisibleColumns.includes(focusedColumn), "should at least contain the focused column"); console.assert(currentVisibleColumns.includes(focusedColumn), "should at least contain the focused column");
const targetColumn = grid.getRightColumn(currentVisibleColumns[currentVisibleColumns.length-1]); const targetColumn = grid.getRightColumn(currentVisibleColumns[currentVisibleColumns.length-1]);
@@ -265,7 +285,7 @@ class Actions {
break; // don't scroll past the currently focused column break; // don't scroll past the currently focused column
} }
} }
} };
private readonly squeezeColumns = (columns: Column[]) => { private readonly squeezeColumns = (columns: Column[]) => {
const firstColumn = columns[0]; const firstColumn = columns[0];
@@ -286,37 +306,48 @@ class Actions {
columns.forEach((column, index) => column.setWidth(widths[index], true)); columns.forEach((column, index) => column.setWidth(widths[index], true));
desktop.scrollCenterRange(Range.fromRanges(firstColumn, lastColumn)); desktop.scrollCenterRange(Range.fromRanges(firstColumn, lastColumn));
return true; return true;
} };
public readonly gridScrollLeft = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollLeft = (cm: ClientManager, dm: DesktopManager) => {
this.gridScroll(dm, -this.config.manualScrollStep); this.gridScroll(dm, -this.config.manualScrollStep);
} };
public readonly gridScrollRight = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollRight = (cm: ClientManager, dm: DesktopManager) => {
this.gridScroll(dm, this.config.manualScrollStep); this.gridScroll(dm, this.config.manualScrollStep);
} };
private readonly gridScroll = (desktopManager: DesktopManager, amount: number) => { private readonly gridScroll = (desktopManager: DesktopManager, amount: number) => {
desktopManager.getCurrentDesktop().adjustScroll(amount, false); const desktop = desktopManager.getCurrentDesktop();
} if (desktop !== undefined) {
desktop.adjustScroll(amount, false);
}
};
public readonly gridScrollStart = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollStart = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const firstColumn = grid.getFirstColumn(); const firstColumn = grid.getFirstColumn();
if (firstColumn === null) { if (firstColumn === null) {
return; return;
} }
grid.desktop.scrollToColumn(firstColumn, false); grid.desktop.scrollToColumn(firstColumn, false);
} };
public readonly gridScrollEnd = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollEnd = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const lastColumn = grid.getLastColumn(); const lastColumn = grid.getLastColumn();
if (lastColumn === null) { if (lastColumn === null) {
return; return;
} }
grid.desktop.scrollToColumn(lastColumn, false); grid.desktop.scrollToColumn(lastColumn, false);
} };
public readonly gridScrollFocused = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly gridScrollFocused = (cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
const scrollAmount = Range.minus(column, grid.desktop.getCurrentVisibleRange()); const scrollAmount = Range.minus(column, grid.desktop.getCurrentVisibleRange());
@@ -325,11 +356,15 @@ class Actions {
} else { } else {
grid.desktop.scrollToColumn(column, true); grid.desktop.scrollToColumn(column, true);
} }
} };
public readonly gridScrollLeftColumn = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollLeftColumn = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
const column = grid.getLeftmostVisibleColumn(grid.desktop.getCurrentVisibleRange(), true); if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const column = grid.getLeftmostVisibleColumn(grid.desktop.getCurrentVisibleRange());
if (column === null) { if (column === null) {
return; return;
} }
@@ -340,11 +375,15 @@ class Actions {
} }
grid.desktop.scrollToColumn(leftColumn, false); grid.desktop.scrollToColumn(leftColumn, false);
} };
public readonly gridScrollRightColumn = (cm: ClientManager, dm: DesktopManager) => { public readonly gridScrollRightColumn = (cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
const column = grid.getRightmostVisibleColumn(grid.desktop.getCurrentVisibleRange(), true); if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const column = grid.getRightmostVisibleColumn(grid.desktop.getCurrentVisibleRange());
if (column === null) { if (column === null) {
return; return;
} }
@@ -355,19 +394,23 @@ class Actions {
} }
grid.desktop.scrollToColumn(rightColumn, false); grid.desktop.scrollToColumn(rightColumn, false);
} };
public readonly screenSwitch = (cm: ClientManager, dm: DesktopManager) => { public readonly screenSwitch = (cm: ClientManager, dm: DesktopManager) => {
dm.selectScreen(Workspace.activeScreen); dm.selectScreen(Workspace.activeScreen);
} };
public readonly focus = (columnIndex: number, cm: ClientManager, dm: DesktopManager) => { public readonly focus = (columnIndex: number, cm: ClientManager, dm: DesktopManager) => {
const grid = dm.getCurrentDesktop().grid; const desktop = dm.getCurrentDesktop();
if (desktop === undefined) {
return;
}
const grid = desktop.grid;
const targetColumn = grid.getColumnAtIndex(columnIndex); const targetColumn = grid.getColumnAtIndex(columnIndex);
if (targetColumn === null) { if (targetColumn === null) {
return; return;
} }
targetColumn.focus(); targetColumn.getWindowToFocus().focus();
}; };
public readonly windowMoveToColumn = (columnIndex: number, cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => { public readonly windowMoveToColumn = (columnIndex: number, cm: ClientManager, dm: DesktopManager, window: Window, column: Column, grid: Grid) => {
@@ -375,7 +418,7 @@ class Actions {
if (targetColumn === null) { if (targetColumn === null) {
return; return;
} }
window.moveToColumn(targetColumn, true); window.moveToColumn(targetColumn, true, FocusPassing.Type.None);
grid.desktop.autoAdjustScroll(); grid.desktop.autoAdjustScroll();
}; };
@@ -396,7 +439,11 @@ class Actions {
if (kwinDesktop === undefined) { if (kwinDesktop === undefined) {
return; return;
} }
const newGrid = dm.getDesktopInCurrentActivity(kwinDesktop).grid; const newDesktop = dm.getDesktopInCurrentActivity(kwinDesktop);
if (newDesktop === undefined) {
return;
}
const newGrid = newDesktop.grid;
if (newGrid === null || newGrid === oldGrid) { if (newGrid === null || newGrid === oldGrid) {
return; return;
} }
@@ -408,7 +455,11 @@ class Actions {
if (kwinDesktop === undefined) { if (kwinDesktop === undefined) {
return; return;
} }
const newGrid = dm.getDesktopInCurrentActivity(kwinDesktop).grid; const newDesktop = dm.getDesktopInCurrentActivity(kwinDesktop);
if (newDesktop === undefined) {
return;
}
const newGrid = newDesktop.grid;
if (newGrid === null || newGrid === oldGrid) { if (newGrid === null || newGrid === oldGrid) {
return; return;
} }
@@ -417,17 +468,19 @@ class Actions {
} }
namespace Actions { namespace Actions {
export type Config = { export interface Config {
manualScrollStep: number; manualScrollStep: number;
presetWidths: { presetWidths: {
next: (currentWidth: number, minWidth: number, maxWidth: number) => number; next: (currentWidth: number, minWidth: number, maxWidth: number) => number;
prev: (currentWidth: number, minWidth: number, maxWidth: number) => number prev: (currentWidth: number, minWidth: number, maxWidth: number) => number
}; };
columnResizer: ColumnResizer; columnResizer: ColumnResizer;
}; }
export type ColumnResizer = { export interface ColumnResizer {
increaseWidth(column: Column): void; increaseWidth(column: Column): void;
decreaseWidth(column: Column): void; decreaseWidth(column: Column): void;
}; maximizeWidth(column: Column): void;
minimizeWidth(column: Column): void;
}
} }

View File

@@ -146,6 +146,16 @@ function getKeyBindings(world: World, actions: Actions): KeyBinding[] {
defaultKeySequence: "Meta+Ctrl+-", defaultKeySequence: "Meta+Ctrl+-",
action: () => world.doIfTiledFocused(actions.columnWidthDecrease), action: () => world.doIfTiledFocused(actions.columnWidthDecrease),
}, },
{
name: "column-width-maximize",
description: "Increase column width to maximum",
action: () => world.doIfTiledFocused(actions.columnWidthMaximize),
},
{
name: "column-width-minimize",
description: "Decrease column width to minimum",
action: () => world.doIfTiledFocused(actions.columnWidthMinimize),
},
{ {
name: "cycle-preset-widths", name: "cycle-preset-widths",
description: "Cycle through preset column widths", description: "Cycle through preset column widths",

View File

@@ -1,19 +1,19 @@
type KeyBinding = { interface KeyBinding {
name: string; name: string;
description: string; description: string;
comment?: string; comment?: string;
defaultKeySequence?: string; defaultKeySequence?: string;
action: () => void; action: () => void;
}; }
type NumKeyBinding = { interface NumKeyBinding {
name: string; name: string;
description: string; description: string;
comment?: string; comment?: string;
defaultModifiers: string; defaultModifiers: string;
fKeys: boolean; fKeys: boolean;
action: (i: number) => void; action: (i: number) => void;
}; }
function catchWrap(f: () => void) { function catchWrap(f: () => void) {
return () => { return () => {

View File

@@ -21,7 +21,7 @@ class Column {
if (targetGrid === this.grid) { if (targetGrid === this.grid) {
this.grid.moveColumn(this, leftColumn); this.grid.moveColumn(this, leftColumn);
} else { } else {
this.grid.onColumnRemoved(this, this.isFocused()); this.grid.onColumnRemoved(this, this.isFocused() ? FocusPassing.Type.Immediate : FocusPassing.Type.None);
this.grid = targetGrid; this.grid = targetGrid;
targetGrid.onColumnAdded(this, leftColumn); targetGrid.onColumnAdded(this, leftColumn);
for (const window of this.windows.iterator()) { for (const window of this.windows.iterator()) {
@@ -79,7 +79,7 @@ class Column {
public getMinWidth() { public getMinWidth() {
let maxMinWidth = Column.minWidth; let maxMinWidth = Column.minWidth;
for (const window of this.windows.iterator()) { for (const window of this.windows.iterator()) {
const minWidth = window.client.kwinClient.minSize.width; const minWidth = window.client.kwinClient.minSize.width.ceil();
if (minWidth > maxMinWidth) { if (minWidth > maxMinWidth) {
maxMinWidth = minWidth; maxMinWidth = minWidth;
} }
@@ -195,12 +195,8 @@ class Column {
return this.focusTaker; return this.focusTaker;
} }
public focus() { public getWindowToFocus() {
const window = this.getFocusTaker() ?? this.windows.getFirst(); return this.getFocusTaker() ?? this.windows.getFirst()!;
if (window === null) {
return;
}
window.focus();
} }
public isFocused() { public isFocused() {
@@ -273,7 +269,7 @@ class Column {
this.grid.desktop.onLayoutChanged(); this.grid.desktop.onLayoutChanged();
} }
public onWindowRemoved(window: Window, passFocus: boolean) { public onWindowRemoved(window: Window, passFocus: FocusPassing.Type) {
const lastWindow = this.windows.length() === 1; const lastWindow = this.windows.length() === 1;
const windowToFocus = this.getAboveWindow(window) ?? this.getBelowWindow(window); const windowToFocus = this.getAboveWindow(window) ?? this.getBelowWindow(window);
@@ -288,8 +284,15 @@ class Column {
this.destroy(passFocus); this.destroy(passFocus);
} else { } else {
this.resizeWindows(); this.resizeWindows();
if (passFocus && windowToFocus !== null) { if (windowToFocus !== null) {
windowToFocus.focus(); switch (passFocus) {
case FocusPassing.Type.Immediate:
windowToFocus.focus();
break;
case FocusPassing.Type.OnUnfocus:
this.grid.focusPasser.request(windowToFocus.client.kwinClient);
break;
}
} }
} }
@@ -297,18 +300,18 @@ class Column {
} }
public onWindowFocused(window: Window) { public onWindowFocused(window: Window) {
this.grid.onColumnFocused(this); this.grid.onColumnFocused(this, window);
this.focusTaker = window; this.focusTaker = window;
} }
public restoreToTiled() { public restoreToTiled(focusedWindow: Window) {
const lastFocusedWindow = this.getFocusTaker(); const lastFocusedWindow = this.getFocusTaker();
if (lastFocusedWindow !== null) { if (lastFocusedWindow !== null && lastFocusedWindow !== focusedWindow) {
lastFocusedWindow.restoreToTiled(); lastFocusedWindow.restoreToTiled();
} }
} }
private destroy(passFocus: boolean) { private destroy(passFocus: FocusPassing.Type) {
this.grid.onColumnRemoved(this, passFocus); this.grid.onColumnRemoved(this, passFocus);
} }
} }

View File

@@ -1,6 +1,7 @@
class Desktop { class Desktop {
public readonly grid: Grid; public readonly grid: Grid;
private scrollX: number; private scrollX: number;
private gestureScrollXInitial: number | null;
private dirty: boolean; private dirty: boolean;
private dirtyScroll: boolean; private dirtyScroll: boolean;
private dirtyPins: boolean; private dirtyPins: boolean;
@@ -13,12 +14,14 @@ class Desktop {
private readonly config: Desktop.Config, private readonly config: Desktop.Config,
private readonly getScreen: () => Output, private readonly getScreen: () => Output,
layoutConfig: LayoutConfig, layoutConfig: LayoutConfig,
focusPasser: FocusPassing.Passer,
) { ) {
this.scrollX = 0; this.scrollX = 0;
this.gestureScrollXInitial = null;
this.dirty = true; this.dirty = true;
this.dirtyScroll = true; this.dirtyScroll = true;
this.dirtyPins = true; this.dirtyPins = true;
this.grid = new Grid(this, layoutConfig); this.grid = new Grid(this, layoutConfig, focusPasser);
this.clientArea = Desktop.getClientArea(this.getScreen(), kwinDesktop); this.clientArea = Desktop.getClientArea(this.getScreen(), kwinDesktop);
this.tilingArea = Desktop.getTilingArea(this.clientArea, kwinDesktop, pinManager, config); this.tilingArea = Desktop.getTilingArea(this.clientArea, kwinDesktop, pinManager, config);
} }
@@ -52,7 +55,7 @@ class Desktop {
top, top,
right - left, right - left,
bottom - top, bottom - top,
) );
} }
public scrollIntoView(range: Range) { public scrollIntoView(range: Range) {
@@ -124,6 +127,36 @@ class Desktop {
this.setScroll(this.scrollX + dx, force); this.setScroll(this.scrollX + dx, force);
} }
public gestureScroll(amount: number) {
if (!this.config.gestureScroll) {
return;
}
if (this.gestureScrollXInitial === null) {
this.gestureScrollXInitial = this.scrollX;
}
if (this.config.gestureScrollInvert) {
amount = -amount;
}
this.setScroll(this.gestureScrollXInitial + this.config.gestureScrollStep * amount, false);
}
public gestureScrollFinish(focusedWindow: Window|null) {
const scrolledRight = this.scrollX > this.gestureScrollXInitial!;
this.gestureScrollXInitial = null;
const visibleRange = this.getCurrentVisibleRange();
if (focusedWindow !== null && !Range.contains(visibleRange, focusedWindow.column)) {
// the focused window is no longer visible, find a new window to focus
const focusTargetColumn = scrolledRight ?
this.grid.getLeftmostVisibleColumn(visibleRange) :
this.grid.getRightmostVisibleColumn(visibleRange);
if (focusTargetColumn !== null) {
focusTargetColumn.getWindowToFocus().focus();
}
}
}
public arrange() { public arrange() {
// TODO (optimization): only arrange visible windows // TODO (optimization): only arrange visible windows
this.updateArea(); this.updateArea();
@@ -155,14 +188,17 @@ class Desktop {
} }
namespace Desktop { namespace Desktop {
export type Config = { export interface Config {
marginTop: number; marginTop: number;
marginBottom: number; marginBottom: number;
marginLeft: number; marginLeft: number;
marginRight: number; marginRight: number;
gestureScroll: boolean;
gestureScrollInvert: boolean;
gestureScrollStep: number;
scroller: Desktop.Scroller; scroller: Desktop.Scroller;
clamper: Desktop.Clamper; clamper: Desktop.Clamper;
}; }
export class ColumnRange { export class ColumnRange {
private left: Column; private left: Column;
@@ -236,11 +272,11 @@ namespace Desktop {
} }
} }
export type Scroller = { export interface Scroller {
scrollToColumn(desktop: Desktop, column: Column): void; scrollToColumn(desktop: Desktop, column: Column): void;
}; }
export type Clamper = { export interface Clamper {
clampScrollX(desktop: Desktop, x: number): number; clampScrollX(desktop: Desktop, x: number): number;
}; }
} }

View File

@@ -1,15 +1,17 @@
class Grid { class Grid {
public readonly desktop: Desktop; public readonly desktop: Desktop;
public readonly config: LayoutConfig; public readonly config: LayoutConfig;
public readonly focusPasser: FocusPassing.Passer;
private readonly columns: LinkedList<Column>; private readonly columns: LinkedList<Column>;
private lastFocusedColumn: Column|null; private lastFocusedColumn: Column|null;
private width: number; private width: number;
private userResize: boolean; // is any part of the grid being resized by the user private userResize: boolean; // is any part of the grid being resized by the user
private readonly userResizeFinishedDelayer: Delayer; private readonly userResizeFinishedDelayer: Delayer;
constructor(desktop: Desktop, config: LayoutConfig) { constructor(desktop: Desktop, config: LayoutConfig, focusPasser: FocusPassing.Passer) {
this.desktop = desktop; this.desktop = desktop;
this.config = config; this.config = config;
this.focusPasser = focusPasser;
this.columns = new LinkedList(); this.columns = new LinkedList();
this.lastFocusedColumn = null; this.lastFocusedColumn = null;
this.width = 0; this.width = 0;
@@ -104,7 +106,7 @@ class Grid {
this.width = x - this.config.gapsInnerHorizontal; this.width = x - this.config.gapsInnerHorizontal;
} }
public getLeftmostVisibleColumn(visibleRange: Range, fullyVisible: boolean) { public getLeftmostVisibleColumn(visibleRange: Range) {
for (const column of this.columns.iterator()) { for (const column of this.columns.iterator()) {
if (Range.contains(visibleRange, column)) { if (Range.contains(visibleRange, column)) {
return column; return column;
@@ -113,7 +115,7 @@ class Grid {
return null; return null;
} }
public getRightmostVisibleColumn(visibleRange: Range, fullyVisible: boolean) { public getRightmostVisibleColumn(visibleRange: Range) {
let last = null; let last = null;
for (const column of this.columns.iterator()) { for (const column of this.columns.iterator()) {
if (Range.contains(visibleRange, column)) { if (Range.contains(visibleRange, column)) {
@@ -125,7 +127,7 @@ class Grid {
return last; return last;
} }
public *getVisibleColumns(visibleRange: Range, fullyVisible: boolean) { public *getVisibleColumns(visibleRange: Range) {
for (const column of this.columns.iterator()) { for (const column of this.columns.iterator()) {
if (Range.contains(visibleRange, column)) { if (Range.contains(visibleRange, column)) {
yield column; yield column;
@@ -156,7 +158,7 @@ class Grid {
this.desktop.autoAdjustScroll(); this.desktop.autoAdjustScroll();
} }
public onColumnRemoved(column: Column, passFocus: boolean) { public onColumnRemoved(column: Column, passFocus: FocusPassing.Type) {
const isLastColumn = this.columns.length() === 1; const isLastColumn = this.columns.length() === 1;
const rightColumn = this.getRightColumn(column); const rightColumn = this.getRightColumn(column);
const columnToFocus = isLastColumn ? null : this.getLeftColumn(column) ?? rightColumn; const columnToFocus = isLastColumn ? null : this.getLeftColumn(column) ?? rightColumn;
@@ -168,11 +170,17 @@ class Grid {
this.columnsSetX(rightColumn); this.columnsSetX(rightColumn);
this.desktop.onLayoutChanged(); this.desktop.onLayoutChanged();
if (passFocus && columnToFocus !== null) { if (columnToFocus !== null) {
columnToFocus.focus(); switch (passFocus) {
} else { case FocusPassing.Type.Immediate:
this.desktop.autoAdjustScroll(); columnToFocus.getWindowToFocus().focus();
return;
case FocusPassing.Type.OnUnfocus:
this.focusPasser.request(columnToFocus.getWindowToFocus().client.kwinClient);
return;
}
} }
this.desktop.autoAdjustScroll();
} }
public onColumnWidthChanged(column: Column) { public onColumnWidthChanged(column: Column) {
@@ -184,10 +192,10 @@ class Grid {
} }
} }
public onColumnFocused(column: Column) { public onColumnFocused(column: Column, window: Window) {
const lastFocusedColumn = this.getLastFocusedColumn(); const lastFocusedColumn = this.getLastFocusedColumn();
if (lastFocusedColumn !== null && lastFocusedColumn !== column) { if (lastFocusedColumn !== null) {
lastFocusedColumn.restoreToTiled(); lastFocusedColumn.restoreToTiled(window);
} }
this.lastFocusedColumn = column; this.lastFocusedColumn = column;
this.desktop.scrollToColumn(column, false); this.desktop.scrollToColumn(column, false);

View File

@@ -1,4 +1,4 @@
type LayoutConfig = { interface LayoutConfig {
gapsInnerHorizontal: number; gapsInnerHorizontal: number;
gapsInnerVertical: number; gapsInnerVertical: number;
stackOffsetX: number; stackOffsetX: number;
@@ -11,4 +11,4 @@ type LayoutConfig = {
tiledKeepBelow: boolean; tiledKeepBelow: boolean;
maximizedKeepAbove: boolean; maximizedKeepAbove: boolean;
untileOnDrag: boolean; untileOnDrag: boolean;
}; }

View File

@@ -1,8 +1,8 @@
type Range = { interface Range {
getLeft(): number; getLeft(): number;
getRight(): number; getRight(): number;
getWidth(): number; getWidth(): number;
}; }
namespace Range { namespace Range {
export function create(x: number, width: number) { export function create(x: number, width: number) {

View File

@@ -7,7 +7,7 @@ class Window {
constructor(client: ClientWrapper, column: Column) { constructor(client: ClientWrapper, column: Column) {
this.client = client; this.client = client;
this.height = client.kwinClient.frameGeometry.height; this.height = client.kwinClient.frameGeometry.height.round();
let maximizedMode = this.client.getMaximizedMode(); let maximizedMode = this.client.getMaximizedMode();
if (maximizedMode === undefined) { if (maximizedMode === undefined) {
@@ -23,11 +23,11 @@ class Window {
column.onWindowAdded(this, true); column.onWindowAdded(this, true);
} }
public moveToColumn(targetColumn: Column, bottom: boolean) { public moveToColumn(targetColumn: Column, bottom: boolean, passFocus: FocusPassing.Type) {
if (targetColumn === this.column) { if (targetColumn === this.column) {
return; return;
} }
this.column.onWindowRemoved(this, this.isFocused() && targetColumn.grid !== this.column.grid); this.column.onWindowRemoved(this, passFocus);
this.column = targetColumn; this.column = targetColumn;
targetColumn.onWindowAdded(this, bottom); targetColumn.onWindowAdded(this, bottom);
} }
@@ -61,6 +61,11 @@ class Window {
public focus() { public focus() {
this.client.focus(); this.client.focus();
const kwinClient = this.client.kwinClient;
if (!this.isFocused()) {
// in some situations focus assignment just doesn't work, let's do it later
this.column.grid.focusPasser.request(kwinClient);
}
} }
public isFocused() { public isFocused() {
@@ -118,18 +123,18 @@ class Window {
public onFrameGeometryChanged() { public onFrameGeometryChanged() {
const newGeometry = this.client.kwinClient.frameGeometry; const newGeometry = this.client.kwinClient.frameGeometry;
this.column.setWidth(newGeometry.width, true); this.column.setWidth(newGeometry.width.round(), true);
this.column.grid.desktop.onLayoutChanged(); this.column.grid.desktop.onLayoutChanged();
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.column.onWindowRemoved(this, passFocus); this.column.onWindowRemoved(this, passFocus);
} }
} }
namespace Window { namespace Window {
export type State = { export interface State {
fullScreen: boolean; fullScreen: boolean;
maximizedMode: MaximizedMode; maximizedMode: MaximizedMode;
}; }
} }

View File

@@ -0,0 +1,30 @@
class DesktopFilter {
private readonly desktopRegex: RegExp | null; // null means all desktops
constructor(desktopsConfig: string) {
this.desktopRegex = DesktopFilter.parseDesktopConfig(desktopsConfig);
}
public shouldWorkOnDesktop(kwinDesktop: KwinDesktop): boolean {
if (this.desktopRegex === null) {
return true; // Work on all desktops
}
return this.desktopRegex.test(kwinDesktop.name);
}
private static parseDesktopConfig(config: string): RegExp | null {
const trimmed = config.trim();
if (trimmed.length === 0) {
return null; // Empty config means work on all desktops
}
try {
return new RegExp(`^${trimmed}$`);
} catch (e) {
notificationInvalidTiledDesktops.sendEvent();
log(`Invalid regex pattern in tiledDesktops config: ${trimmed}. Working on all desktops.`);
return null; // Invalid regex means work on all desktops as fallback
}
}
}

View File

@@ -1,5 +1,5 @@
type WindowRule = { interface WindowRule {
class: string | undefined; class: string | undefined;
caption: string | undefined; caption: string | undefined;
tile: boolean; tile: boolean;
}; }

View File

@@ -52,7 +52,7 @@ class WindowRuleEnforcer {
const ruleCaption = WindowRuleEnforcer.parseRegex(windowRule.caption); const ruleCaption = WindowRuleEnforcer.parseRegex(windowRule.caption);
const ruleString = ClientMatcher.getRuleString( const ruleString = ClientMatcher.getRuleString(
WindowRuleEnforcer.wrapParens(ruleClass), WindowRuleEnforcer.wrapParens(ruleClass),
WindowRuleEnforcer.wrapParens(ruleCaption) WindowRuleEnforcer.wrapParens(ruleCaption),
); );
(windowRule.tile ? tileRegexes : floatRegexes).push(ruleString); (windowRule.tile ? tileRegexes : floatRegexes).push(ruleString);

View File

@@ -17,9 +17,9 @@ class Delayer {
} }
function initQmlTimer() { function initQmlTimer() {
return <QmlTimer>Qt.createQmlObject( return Qt.createQmlObject(
`import QtQuick 6.0 `import QtQuick 6.0
Timer {}`, Timer {}`,
qmlBase qmlBase,
); ) as QmlTimer;
} }

View File

@@ -16,7 +16,7 @@ class ShortcutAction {
` : ` :
""; "";
return <ShortcutHandler>Qt.createQmlObject( return Qt.createQmlObject(
`import QtQuick 6.0 `import QtQuick 6.0
import org.kde.kwin 3.0 import org.kde.kwin 3.0
ShortcutHandler { ShortcutHandler {
@@ -24,14 +24,14 @@ ShortcutHandler {
text: "Karousel: ${keyBinding.description}"; text: "Karousel: ${keyBinding.description}";
${sequenceLine}}`, ${sequenceLine}}`,
qmlBase, qmlBase,
); ) as ShortcutHandler;
} }
} }
namespace ShortcutAction { namespace ShortcutAction {
export type KeyBinding = { export interface KeyBinding {
name: string; name: string;
description: string; description: string;
defaultKeySequence?: string; defaultKeySequence?: string;
}; }
} }

View File

@@ -84,13 +84,13 @@ function fillSpace(availableSpace: number, items: { min: number, max: number }[]
} }
} }
type Range = { interface Range {
start: number, start: number,
end: number, end: number,
n: number, n: number,
}; }
type Fencepost = { interface Fencepost {
value: number, value: number,
nMin: number, nMin: number,
nMax: number, nMax: number,

View File

@@ -1,3 +1,21 @@
interface Number {
round(this: number): number;
floor(this: number): number;
ceil(this: number): number;
}
Number.prototype.round = function() {
return Math.round(this);
};
Number.prototype.floor = function() {
return Math.floor(this);
};
Number.prototype.ceil = function() {
return Math.ceil(this);
};
interface Function { interface Function {
partial<H extends any[], T extends any[], R>( partial<H extends any[], T extends any[], R>(
this: (...args: [...H, ...T]) => R, this: (...args: [...H, ...T]) => R,
@@ -7,4 +25,4 @@ interface Function {
Function.prototype.partial = function<H extends any[], T extends any[]>(...head: H) { Function.prototype.partial = function<H extends any[], T extends any[]>(...head: H) {
return (...tail: T) => this(...head, ...tail); return (...tail: T) => this(...head, ...tail);
} };

View File

@@ -18,3 +18,40 @@ function rectEquals(a: QmlRect, b: QmlRect) {
a.width === b.width && a.width === b.width &&
a.height === b.height; a.height === b.height;
} }
function pointEquals(a: QmlPoint, b: QmlPoint) {
return a.x === b.x &&
a.y === b.y;
}
function rectRight(rect: QmlRect) {
return rect.x + rect.width;
}
function rectBottom(rect: QmlRect) {
return rect.y + rect.height;
}
function rectContainsPoint(rect: QmlRect, point: QmlPoint) {
return rect.x <= point.x &&
rectRight(rect) >= point.x &&
rect.y <= point.y &&
rectBottom(rect) >= point.y;
}
function roundQtRect(rect: QmlRect) {
return Qt.rect(
rect.x.round(),
rect.y.round(),
rect.width.round(),
rect.height.round(),
);
}
function rectRightRound(rect: QmlRect) {
return rect.x.round() + rect.width.round();
}
function rectBottomRound(rect: QmlRect) {
return rect.y.round() + rect.height.round();
}

View File

@@ -1,25 +1,27 @@
function initWorkspaceSignalHandlers(world: World) { function initWorkspaceSignalHandlers(world: World, focusPasser: FocusPassing.Passer) {
const manager = new SignalManager(); const manager = new SignalManager();
manager.connect(Workspace.windowAdded, (kwinClient: KwinClient) => { manager.connect(Workspace.windowAdded, (kwinClient: KwinClient) => {
world.do((clientManager, desktopManager) => { world.do((clientManager, desktopManager) => {
clientManager.addClient(kwinClient) clientManager.addClient(kwinClient);
}); });
}); });
manager.connect(Workspace.windowRemoved, (kwinClient: KwinClient) => { manager.connect(Workspace.windowRemoved, (kwinClient: KwinClient) => {
world.do((clientManager, desktopManager) => { world.do((clientManager, desktopManager) => {
clientManager.removeClient(kwinClient, true); clientManager.removeClient(kwinClient, FocusPassing.Type.Immediate);
}); });
}); });
manager.connect(Workspace.windowActivated, (kwinClient: KwinClient|null) => { manager.connect(Workspace.windowActivated, (kwinClient: KwinClient|null) => {
if (kwinClient === null) { if (kwinClient === null) {
return; focusPasser.activate();
} else {
focusPasser.clearIfDifferent(kwinClient);
world.do((clientManager, desktopManager) => {
clientManager.onClientFocused(kwinClient);
});
} }
world.do((clientManager, desktopManager) => {
clientManager.onClientFocused(kwinClient);
});
}); });
manager.connect(Workspace.currentDesktopChanged, () => { manager.connect(Workspace.currentDesktopChanged, () => {

View File

@@ -31,16 +31,16 @@ class ClientManager {
console.assert(!this.hasClient(kwinClient)); console.assert(!this.hasClient(kwinClient));
let constructState: (client: ClientWrapper) => ClientState.State; let constructState: (client: ClientWrapper) => ClientState.State;
let desktop: Desktop | undefined;
if (kwinClient.dock) { if (kwinClient.dock) {
constructState = () => new ClientState.Docked(this.world, kwinClient); constructState = () => new ClientState.Docked(this.world, kwinClient);
} else if ( } else if (
Clients.canTileEver(kwinClient) && Clients.canTileEver(kwinClient) &&
this.windowRuleEnforcer.shouldTile(kwinClient) this.windowRuleEnforcer.shouldTile(kwinClient) &&
(desktop = this.desktopManager.getDesktopForClient(kwinClient)) !== undefined
) { ) {
Clients.makeTileable(kwinClient); Clients.makeTileable(kwinClient);
console.assert(Clients.canTileNow(kwinClient)); console.assert(Clients.canTileNow(kwinClient));
const desktop = this.desktopManager.getDesktopForClient(kwinClient);
console.assert(desktop !== undefined);
constructState = (client: ClientWrapper) => new ClientState.Tiled(this.world, client, desktop!.grid); constructState = (client: ClientWrapper) => new ClientState.Tiled(this.world, client, desktop!.grid);
} else { } else {
constructState = (client: ClientWrapper) => new ClientState.Floating(this.world, client, this.config, false); constructState = (client: ClientWrapper) => new ClientState.Floating(this.world, client, this.config, false);
@@ -55,13 +55,16 @@ class ClientManager {
this.clientMap.set(kwinClient, client); this.clientMap.set(kwinClient, client);
} }
public removeClient(kwinClient: KwinClient, passFocus: boolean) { public removeClient(kwinClient: KwinClient, passFocus: FocusPassing.Type) {
console.assert(this.hasClient(kwinClient)); console.assert(this.hasClient(kwinClient));
const client = this.clientMap.get(kwinClient); const client = this.clientMap.get(kwinClient);
if (client === undefined) { if (client === undefined) {
return; return;
} }
client.destroy(passFocus && kwinClient === this.lastFocusedClient); if (kwinClient !== this.lastFocusedClient) {
passFocus = FocusPassing.Type.None;
}
client.destroy(passFocus);
this.clientMap.delete(kwinClient); this.clientMap.delete(kwinClient);
} }
@@ -84,9 +87,10 @@ class ClientManager {
return; return;
} }
if (client.stateManager.getState() instanceof ClientState.Tiled) { if (client.stateManager.getState() instanceof ClientState.Tiled) {
const passFocus = kwinClient === this.lastFocusedClient ? FocusPassing.Type.Immediate : FocusPassing.Type.None;
client.stateManager.setState( client.stateManager.setState(
() => new ClientState.TiledMinimized(this.world, client), () => new ClientState.TiledMinimized(this.world, client),
kwinClient === this.lastFocusedClient, passFocus,
); );
} }
} }
@@ -95,14 +99,14 @@ class ClientManager {
if (client.stateManager.getState() instanceof ClientState.Tiled) { if (client.stateManager.getState() instanceof ClientState.Tiled) {
return; return;
} }
client.stateManager.setState(() => new ClientState.Tiled(this.world, client, grid), false); client.stateManager.setState(() => new ClientState.Tiled(this.world, client, grid), FocusPassing.Type.None);
} }
public floatClient(client: ClientWrapper) { public floatClient(client: ClientWrapper) {
if (client.stateManager.getState() instanceof ClientState.Floating) { if (client.stateManager.getState() instanceof ClientState.Floating) {
return; return;
} }
client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, true), false); client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, true), FocusPassing.Type.None);
} }
public tileKwinClient(kwinClient: KwinClient, grid: Grid) { public tileKwinClient(kwinClient: KwinClient, grid: Grid) {
@@ -131,7 +135,7 @@ class ClientManager {
kwinClient.tile = null; kwinClient.tile = null;
return; return;
} }
client.stateManager.setState(() => new ClientState.Pinned(this.world, this.pinManager, this.desktopManager, kwinClient, this.config), false); client.stateManager.setState(() => new ClientState.Pinned(this.world, this.pinManager, this.desktopManager, kwinClient, this.config), FocusPassing.Type.None);
this.pinManager.addClient(kwinClient); this.pinManager.addClient(kwinClient);
for (const desktop of this.desktopManager.getDesktopsForClient(kwinClient)) { for (const desktop of this.desktopManager.getDesktopsForClient(kwinClient)) {
desktop.onPinsChanged(); desktop.onPinsChanged();
@@ -144,7 +148,7 @@ class ClientManager {
return; return;
} }
console.assert(client.stateManager.getState() instanceof ClientState.Pinned); console.assert(client.stateManager.getState() instanceof ClientState.Pinned);
client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, false), false); client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, false), FocusPassing.Type.None);
this.pinManager.removeClient(kwinClient); this.pinManager.removeClient(kwinClient);
for (const desktop of this.desktopManager.getDesktopsForClient(kwinClient)) { for (const desktop of this.desktopManager.getDesktopsForClient(kwinClient)) {
desktop.onPinsChanged(); desktop.onPinsChanged();
@@ -164,9 +168,9 @@ class ClientManager {
if (desktop === undefined) { if (desktop === undefined) {
return; return;
} }
client.stateManager.setState(() => new ClientState.Tiled(this.world, client, desktop.grid), false); client.stateManager.setState(() => new ClientState.Tiled(this.world, client, desktop.grid), FocusPassing.Type.None);
} else if (clientState instanceof ClientState.Tiled) { } else if (clientState instanceof ClientState.Tiled) {
client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, true), false); client.stateManager.setState(() => new ClientState.Floating(this.world, client, this.config, true), FocusPassing.Type.None);
} }
} }
@@ -204,7 +208,7 @@ class ClientManager {
private removeAllClients() { private removeAllClients() {
for (const kwinClient of Array.from(this.clientMap.keys())) { for (const kwinClient of Array.from(this.clientMap.keys())) {
this.removeClient(kwinClient, false); this.removeClient(kwinClient, FocusPassing.Type.None);
} }
} }
@@ -214,7 +218,7 @@ class ClientManager {
} }
namespace ClientManager { namespace ClientManager {
export type Config = { export interface Config {
floatingKeepAbove: boolean; floatingKeepAbove: boolean;
}; }
} }

View File

@@ -21,7 +21,7 @@ class ClientWrapper {
} }
this.signalManager = ClientWrapper.initSignalManager(this); this.signalManager = ClientWrapper.initSignalManager(this);
this.rulesSignalManager = rulesSignalManager; this.rulesSignalManager = rulesSignalManager;
this.preferredWidth = kwinClient.frameGeometry.width; this.preferredWidth = kwinClient.frameGeometry.width.round();
this.manipulatingGeometry = new Doer(); this.manipulatingGeometry = new Doer();
this.lastPlacement = null; this.lastPlacement = null;
this.stateManager = new ClientState.Manager(constructInitialState(this)); this.stateManager = new ClientState.Manager(constructInitialState(this));
@@ -49,10 +49,10 @@ class ClientWrapper {
if (Clients.isOnOneOfVirtualDesktops(this.kwinClient, kwinDesktops)) { if (Clients.isOnOneOfVirtualDesktops(this.kwinClient, kwinDesktops)) {
const frame = this.kwinClient.frameGeometry; const frame = this.kwinClient.frameGeometry;
this.kwinClient.frameGeometry = Qt.rect( this.kwinClient.frameGeometry = Qt.rect(
frame.x + dx, frame.x.round() + dx,
frame.y + dy, frame.y.round() + dy,
frame.width, frame.width.round(),
frame.height, frame.height.round(),
); );
} }
@@ -78,6 +78,7 @@ class ClientWrapper {
public setMaximize(horizontally: boolean, vertically: boolean) { public setMaximize(horizontally: boolean, vertically: boolean) {
if (!this.kwinClient.maximizable) { if (!this.kwinClient.maximizable) {
this.maximizedMode = MaximizedMode.Unmaximized;
return; return;
} }
@@ -141,15 +142,15 @@ class ClientWrapper {
if (!Clients.isOnVirtualDesktop(this.kwinClient, Workspace.currentDesktop)) { if (!Clients.isOnVirtualDesktop(this.kwinClient, Workspace.currentDesktop)) {
return; return;
} }
const frame = this.kwinClient.frameGeometry; const frame = roundQtRect(this.kwinClient.frameGeometry);
if (frame.left < screenSize.left) { if (frame.x < screenSize.x) {
frame.x = screenSize.left; frame.x = screenSize.x;
} else if (frame.right > screenSize.right) { } else if (rectRight(frame) > rectRight(screenSize)) {
frame.x = screenSize.right - frame.width; frame.x = rectRight(screenSize) - frame.width;
} }
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.stateManager.destroy(passFocus); this.stateManager.destroy(passFocus);
this.signalManager.destroy(); this.signalManager.destroy();
if (this.rulesSignalManager !== null) { if (this.rulesSignalManager !== null) {

View File

@@ -32,23 +32,23 @@ namespace Clients {
export function getKwinDesktopApprox(kwinClient: KwinClient) { export function getKwinDesktopApprox(kwinClient: KwinClient) {
switch (kwinClient.desktops.length) { switch (kwinClient.desktops.length) {
case 0: case 0:
return Workspace.currentDesktop;
case 1:
return kwinClient.desktops[0];
default:
if (kwinClient.desktops.includes(Workspace.currentDesktop)) {
return Workspace.currentDesktop; return Workspace.currentDesktop;
case 1: } else {
return kwinClient.desktops[0]; return kwinClient.desktops[0];
default: }
if (kwinClient.desktops.includes(Workspace.currentDesktop)) {
return Workspace.currentDesktop;
} else {
return kwinClient.desktops[0];
}
} }
} }
export function isFullScreenGeometry(kwinClient: KwinClient) { export function isFullScreenGeometry(kwinClient: KwinClient) {
const fullScreenArea = Workspace.clientArea(ClientAreaOption.FullScreenArea, kwinClient.output, getKwinDesktopApprox(kwinClient)); const fullScreenArea = Workspace.clientArea(ClientAreaOption.FullScreenArea, kwinClient.output, getKwinDesktopApprox(kwinClient));
return kwinClient.clientGeometry.width === fullScreenArea.width && return kwinClient.clientGeometry.width.round() >= fullScreenArea.width &&
kwinClient.clientGeometry.height === fullScreenArea.height; kwinClient.clientGeometry.height.round() >= fullScreenArea.height;
} }
export function isOnVirtualDesktop(kwinClient: KwinClient, kwinDesktop: KwinDesktop) { export function isOnVirtualDesktop(kwinClient: KwinClient, kwinDesktop: KwinDesktop) {

View File

@@ -7,9 +7,9 @@ class DesktopManager {
constructor( constructor(
private readonly pinManager: PinManager, private readonly pinManager: PinManager,
private readonly config: Desktop.Config, private readonly config: Desktop.Config,
public readonly layoutConfig: LayoutConfig, private readonly layoutConfig: LayoutConfig,
currentActivity: string, private readonly focusPasser: FocusPassing.Passer,
currentDesktop: KwinDesktop, private readonly desktopFilter: DesktopFilter,
) { ) {
this.pinManager = pinManager; this.pinManager = pinManager;
this.config = config; this.config = config;
@@ -18,10 +18,12 @@ class DesktopManager {
this.selectedScreen = Workspace.activeScreen; this.selectedScreen = Workspace.activeScreen;
this.kwinActivities = new Set(Workspace.activities); this.kwinActivities = new Set(Workspace.activities);
this.kwinDesktops = new Set(Workspace.desktops); this.kwinDesktops = new Set(Workspace.desktops);
this.addDesktop(currentActivity, currentDesktop);
} }
public getDesktop(activity: string, kwinDesktop: KwinDesktop) { public getDesktop(activity: string, kwinDesktop: KwinDesktop) {
if (!this.desktopFilter.shouldWorkOnDesktop(kwinDesktop)) {
return undefined;
}
const desktopKey = DesktopManager.getDesktopKey(activity, kwinDesktop); const desktopKey = DesktopManager.getDesktopKey(activity, kwinDesktop);
const desktop = this.desktops.get(desktopKey); const desktop = this.desktops.get(desktopKey);
if (desktop !== undefined) { if (desktop !== undefined) {
@@ -54,6 +56,7 @@ class DesktopManager {
this.config, this.config,
() => this.selectedScreen, () => this.selectedScreen,
this.layoutConfig, this.layoutConfig,
this.focusPasser,
); );
this.desktops.set(desktopKey, desktop); this.desktops.set(desktopKey, desktop);
return desktop; return desktop;

View File

@@ -0,0 +1,51 @@
namespace FocusPassing {
export const enum Type {
None,
Immediate,
OnUnfocus,
}
export class Passer {
private currentRequest: Request | null = null;
public request(target: KwinClient) {
this.currentRequest = new Request(target, Date.now());
}
public clear() {
this.currentRequest = null;
}
public clearIfDifferent(kwinClient: KwinClient) {
if (this.currentRequest !== null && this.currentRequest.target !== kwinClient) {
this.clear();
}
}
public activate() {
if (this.currentRequest === null) {
return;
}
if (this.currentRequest.isExpired()) {
this.clear();
return;
}
Workspace.activeWindow = this.currentRequest.target;
}
}
class Request {
private static readonly validMs = 200;
constructor(
public readonly target: KwinClient,
private readonly time: number,
) {}
public isExpired() {
return Date.now() - this.time > Request.validMs;
}
}
}

View File

@@ -14,7 +14,7 @@ class PinManager {
} }
public getAvailableSpace(kwinDesktop: KwinDesktop, screen: QmlRect) { public getAvailableSpace(kwinDesktop: KwinDesktop, screen: QmlRect) {
const baseLot = new PinManager.Lot(screen.top, screen.bottom, screen.left, screen.right); const baseLot = new PinManager.Lot(screen.y, rectBottom(screen), screen.x, rectRight(screen));
let lots = [baseLot]; let lots = [baseLot];
for (const client of this.pinnedClients) { for (const client of this.pinnedClients) {
if (!Clients.isOnVirtualDesktop(client, kwinDesktop) || client.minimized) { if (!Clients.isOnVirtualDesktop(client, kwinDesktop) || client.minimized) {
@@ -23,7 +23,7 @@ class PinManager {
const newLots: PinManager.Lot[] = []; const newLots: PinManager.Lot[] = [];
for (const lot of lots) { for (const lot of lots) {
lot.split(newLots, client.frameGeometry); lot.split(newLots, roundQtRect(client.frameGeometry));
} }
lots = newLots; lots = newLots;
} }
@@ -60,23 +60,23 @@ namespace PinManager {
return; return;
} }
if (obstacle.top - this.top >= Lot.minHeight) { if (obstacle.y - this.top >= Lot.minHeight) {
destLots.push(new Lot(this.top, obstacle.top, this.left, this.right)); destLots.push(new Lot(this.top, obstacle.y, this.left, this.right));
} }
if (this.bottom - obstacle.bottom >= Lot.minHeight) { if (this.bottom - rectBottom(obstacle) >= Lot.minHeight) {
destLots.push(new Lot(obstacle.bottom, this.bottom, this.left, this.right)); destLots.push(new Lot(rectBottom(obstacle), this.bottom, this.left, this.right));
} }
if (obstacle.left - this.left >= Lot.minWidth) { if (obstacle.x - this.left >= Lot.minWidth) {
destLots.push(new Lot(this.top, this.bottom, this.left, obstacle.left)); destLots.push(new Lot(this.top, this.bottom, this.left, obstacle.x));
} }
if (this.right - obstacle.right >= Lot.minWidth) { if (this.right - rectRight(obstacle) >= Lot.minWidth) {
destLots.push(new Lot(this.top, this.bottom, obstacle.right, this.right)); destLots.push(new Lot(this.top, this.bottom, rectRight(obstacle), this.right));
} }
} }
private contains(obstacle: QmlRect) { private contains(obstacle: QmlRect) {
return obstacle.right > this.left && obstacle.left < this.right && return rectRight(obstacle) > this.left && obstacle.x < this.right &&
obstacle.bottom > this.top && obstacle.top < this.bottom; rectBottom(obstacle) > this.top && obstacle.y < this.bottom;
} }
public area() { public area() {

View File

@@ -5,9 +5,12 @@ class World {
private readonly workspaceSignalManager: SignalManager; private readonly workspaceSignalManager: SignalManager;
private readonly shortcutActions: ShortcutAction[]; private readonly shortcutActions: ShortcutAction[];
private readonly screenResizedDelayer: Delayer; private readonly screenResizedDelayer: Delayer;
private readonly cursorFollowsFocus: boolean;
constructor(config: Config) { constructor(config: Config) {
this.workspaceSignalManager = initWorkspaceSignalHandlers(this); const focusPasser = new FocusPassing.Passer();
this.workspaceSignalManager = initWorkspaceSignalHandlers(this, focusPasser);
this.cursorFollowsFocus = config.cursorFollowsFocus;
let presetWidths = { let presetWidths = {
next: (currentWidth: number, minWidth: number, maxWidth: number) => currentWidth, next: (currentWidth: number, minWidth: number, maxWidth: number) => currentWidth,
@@ -61,10 +64,13 @@ class World {
marginRight: config.gapsOuterRight, marginRight: config.gapsOuterRight,
scroller: World.createScroller(config), scroller: World.createScroller(config),
clamper: config.scrollingLazy ? new EdgeClamper() : new CenterClamper(), clamper: config.scrollingLazy ? new EdgeClamper() : new CenterClamper(),
gestureScroll: config.gestureScroll,
gestureScrollInvert: config.gestureScrollInvert,
gestureScrollStep: config.gestureScrollStep,
}, },
layoutConfig, layoutConfig,
Workspace.currentActivity, focusPasser,
Workspace.currentDesktop, new DesktopFilter(config.tiledDesktops),
); );
this.clientManager = new ClientManager(config, this, this.desktopManager, this.pinManager); this.clientManager = new ClientManager(config, this, this.desktopManager, this.pinManager);
this.addExistingClients(); this.addExistingClients();
@@ -85,15 +91,32 @@ class World {
} }
private addExistingClients() { private addExistingClients() {
const kwinClients = Workspace.windows; for (const kwinClient of Workspace.windows) {
for (let i = 0; i < kwinClients.length; i++) {
const kwinClient = kwinClients[i];
this.clientManager.addClient(kwinClient); this.clientManager.addClient(kwinClient);
} }
} }
private update() { private update() {
this.desktopManager.getCurrentDesktop().arrange(); const currentDesktop = this.desktopManager.getCurrentDesktop();
if (currentDesktop !== undefined) {
currentDesktop.arrange();
this.moveCursorToFocus();
}
}
private moveCursorToFocus() {
if (this.cursorFollowsFocus && Workspace.activeWindow !== null) {
// Only move cursor for tiled windows
const tiledWindow = this.clientManager.findTiledWindow(Workspace.activeWindow);
if (tiledWindow === null) {
return;
}
const cursorAlreadyInFocus = rectContainsPoint(roundQtRect(Workspace.activeWindow.frameGeometry), Workspace.cursorPos);
if (cursorAlreadyInFocus) {
return;
}
moveCursorToFocus.call();
}
} }
public do(f: (clientManager: ClientManager, desktopManager: DesktopManager) => void) { public do(f: (clientManager: ClientManager, desktopManager: DesktopManager) => void) {
@@ -124,6 +147,26 @@ class World {
this.doIfTiled(Workspace.activeWindow, f); this.doIfTiled(Workspace.activeWindow, f);
} }
public gestureScroll(amount: number) {
this.do((clientManager, desktopManager) => {
const currentDesktop = desktopManager.getCurrentDesktop();
if (currentDesktop !== undefined) {
currentDesktop.gestureScroll(amount);
}
});
}
public gestureScrollFinish() {
this.do((clientManager, desktopManager) => {
const focusedWindow = Workspace.activeWindow === null ? null : clientManager.findTiledWindow(Workspace.activeWindow);
const currentDesktop = desktopManager.getCurrentDesktop();
if (currentDesktop !== undefined) {
console.assert(focusedWindow === null || focusedWindow.column.grid.desktop === currentDesktop);
currentDesktop.gestureScrollFinish(focusedWindow);
}
});
}
public destroy() { public destroy() {
this.workspaceSignalManager.destroy(); this.workspaceSignalManager.destroy();
for (const shortcutAction of this.shortcutActions) { for (const shortcutAction of this.shortcutActions) {

View File

@@ -9,7 +9,7 @@ namespace ClientState {
world.onScreenResized(); world.onScreenResized();
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.signalManager.destroy(); this.signalManager.destroy();
this.world.onScreenResized(); this.world.onScreenResized();
} }

View File

@@ -16,7 +16,7 @@ namespace ClientState {
this.signalManager = Floating.initSignalManager(world, client.kwinClient); this.signalManager = Floating.initSignalManager(world, client.kwinClient);
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.signalManager.destroy(); this.signalManager.destroy();
} }
@@ -30,10 +30,10 @@ namespace ClientState {
const clientRect = client.kwinClient.frameGeometry; const clientRect = client.kwinClient.frameGeometry;
const width = client.preferredWidth; const width = client.preferredWidth;
client.place( client.place(
clientRect.x, clientRect.x.round(),
clientRect.y, clientRect.y.round(),
width, width,
Math.min(clientRect.height, Math.round(placementArea.height / 2)), Math.min(clientRect.height.round(), Math.round(placementArea.height / 2)),
); );
} }

View File

@@ -6,7 +6,7 @@ namespace ClientState {
this.state = initialState; this.state = initialState;
} }
public setState(constructNewState: () => State, passFocus: boolean) { public setState(constructNewState: () => State, passFocus: FocusPassing.Type) {
this.state.destroy(passFocus); this.state.destroy(passFocus);
this.state = constructNewState(); this.state = constructNewState();
} }
@@ -15,12 +15,12 @@ namespace ClientState {
return this.state; return this.state;
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.state.destroy(passFocus); this.state.destroy(passFocus);
} }
} }
export type State = { export interface State {
destroy(passFocus: boolean): void; destroy(passFocus: FocusPassing.Type): void;
}; }
} }

View File

@@ -17,7 +17,7 @@ namespace ClientState {
this.signalManager = Pinned.initSignalManager(world, pinManager, kwinClient); this.signalManager = Pinned.initSignalManager(world, pinManager, kwinClient);
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.signalManager.destroy(); this.signalManager.destroy();
this.pinManager.removeClient(this.kwinClient); this.pinManager.removeClient(this.kwinClient);
for (const desktop of this.desktopManager.getDesktopsForClient(this.kwinClient)) { for (const desktop of this.desktopManager.getDesktopsForClient(this.kwinClient)) {

View File

@@ -16,7 +16,7 @@ namespace ClientState {
this.signalManager = Tiled.initSignalManager(world, window, grid.config); this.signalManager = Tiled.initSignalManager(world, window, grid.config);
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.signalManager.destroy(); this.signalManager.destroy();
const window = this.window; const window = this.window;
@@ -54,7 +54,7 @@ namespace ClientState {
} }
Tiled.moveWindowToGrid(window, desktop.grid); Tiled.moveWindowToGrid(window, desktop.grid);
}); });
}) });
manager.connect(kwinClient.minimizedChanged, () => { manager.connect(kwinClient.minimizedChanged, () => {
console.assert(kwinClient.minimized); console.assert(kwinClient.minimized);
@@ -113,7 +113,7 @@ namespace ClientState {
} }
}); });
let externalFrameGeometryChangedRateLimiter = new RateLimiter(4, Tiled.maxExternalFrameGeometryChangedIntervalMs); const externalFrameGeometryChangedRateLimiter = new RateLimiter(4, Tiled.maxExternalFrameGeometryChangedIntervalMs);
manager.connect(kwinClient.frameGeometryChanged, (oldGeometry: QmlRect) => { manager.connect(kwinClient.frameGeometryChanged, (oldGeometry: QmlRect) => {
// on Wayland, this fires after `tileChanged` // on Wayland, this fires after `tileChanged`
if (kwinClient.tile !== null) { if (kwinClient.tile !== null) {
@@ -123,7 +123,12 @@ namespace ClientState {
return; return;
} }
const newGeometry = client.kwinClient.frameGeometry; const newGeometry = roundQtRect(client.kwinClient.frameGeometry);
if (rectEquals(oldGeometry, newGeometry)) {
// no real changes, nothing to do
return;
}
const oldCenterX = oldGeometry.x + oldGeometry.width/2; const oldCenterX = oldGeometry.x + oldGeometry.width/2;
const oldCenterY = oldGeometry.y + oldGeometry.height/2; const oldCenterY = oldGeometry.y + oldGeometry.height/2;
const newCenterX = newGeometry.x + newGeometry.width/2; const newCenterX = newGeometry.x + newGeometry.width/2;
@@ -142,7 +147,7 @@ namespace ClientState {
window.column.onUserResizeWidth( window.column.onUserResizeWidth(
resizeStartWidth, resizeStartWidth,
newGeometry.width - resizeStartWidth, newGeometry.width - resizeStartWidth,
newGeometry.left !== oldGeometry.left, newGeometry.x !== oldGeometry.x,
resizeNeighbor, resizeNeighbor,
); );
} }
@@ -193,9 +198,9 @@ namespace ClientState {
private static getResizeNeighborColumn(window: Window) { private static getResizeNeighborColumn(window: Window) {
const kwinClient = window.client.kwinClient; const kwinClient = window.client.kwinClient;
const column = window.column; const column = window.column;
if (Workspace.cursorPos.x > kwinClient.clientGeometry.right) { if (Workspace.cursorPos.x > rectRightRound(kwinClient.clientGeometry)) {
return column.grid.getRightColumn(column); return column.grid.getRightColumn(column);
} else if (Workspace.cursorPos.x < kwinClient.clientGeometry.left) { } else if (Workspace.cursorPos.x < kwinClient.clientGeometry.x.round()) {
return column.grid.getLeftColumn(column); return column.grid.getLeftColumn(column);
} else { } else {
return null; return null;
@@ -209,17 +214,26 @@ namespace ClientState {
} }
const newColumn = new Column(grid, grid.getLastFocusedColumn() ?? grid.getLastColumn()); const newColumn = new Column(grid, grid.getLastFocusedColumn() ?? grid.getLastColumn());
window.moveToColumn(newColumn, true); const passFocus = window.isFocused() ? FocusPassing.Type.OnUnfocus : FocusPassing.Type.None;
window.moveToColumn(newColumn, true, passFocus);
} }
private static prepareClientForTiling(client: ClientWrapper, config: LayoutConfig) { private static prepareClientForTiling(client: ClientWrapper, config: LayoutConfig) {
if (config.skipSwitcher) { if (config.skipSwitcher) {
client.kwinClient.skipSwitcher = true; client.kwinClient.skipSwitcher = true;
} }
if (config.tiledKeepBelow) {
client.kwinClient.keepBelow = true; if (client.kwinClient.fullScreen) {
if (config.maximizedKeepAbove) {
client.kwinClient.keepAbove = true;
}
} else {
if (config.tiledKeepBelow) {
client.kwinClient.keepBelow = true;
}
client.kwinClient.keepAbove = false;
} }
client.kwinClient.keepAbove = false;
if (client.kwinClient.tile !== null) { if (client.kwinClient.tile !== null) {
client.setMaximize(false, true); // disable quick tile mode client.setMaximize(false, true); // disable quick tile mode
} }
@@ -245,8 +259,8 @@ namespace ClientState {
} }
namespace Tiled { namespace Tiled {
export type WindowState = { export interface WindowState {
skipSwitcher: boolean; skipSwitcher: boolean;
}; }
} }
} }

View File

@@ -6,7 +6,7 @@ namespace ClientState {
this.signalManager = TiledMinimized.initSignalManager(world, client); this.signalManager = TiledMinimized.initSignalManager(world, client);
} }
public destroy(passFocus: boolean) { public destroy(passFocus: FocusPassing.Type) {
this.signalManager.destroy(); this.signalManager.destroy();
} }

View File

@@ -1,4 +1,4 @@
tests.register("Center focused", 1, () => { tests.register("Center focused", 5, () => {
const config = getDefaultConfig(); const config = getDefaultConfig();
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
@@ -14,8 +14,8 @@ tests.register("Center focused", 1, () => {
// center client2 // center client2
qtMock.fireShortcut("karousel-grid-scroll-focused"); qtMock.fireShortcut("karousel-grid-scroll-focused");
Assert.centered(config, tilingArea, client2); Assert.centered(config, tilingArea, client2);
Assert.fullyVisible(client1.frameGeometry); Assert.fullyVisible(client1.getActualFrameGeometry());
Assert.fullyVisible(client2.frameGeometry); Assert.fullyVisible(client2.getActualFrameGeometry());
// undo center client2 // undo center client2
qtMock.fireShortcut("karousel-grid-scroll-focused"); qtMock.fireShortcut("karousel-grid-scroll-focused");
@@ -24,14 +24,14 @@ tests.register("Center focused", 1, () => {
// center client2 // center client2
qtMock.fireShortcut("karousel-grid-scroll-focused"); qtMock.fireShortcut("karousel-grid-scroll-focused");
Assert.centered(config, tilingArea, client2); Assert.centered(config, tilingArea, client2);
Assert.fullyVisible(client1.frameGeometry); Assert.fullyVisible(client1.getActualFrameGeometry());
Assert.fullyVisible(client2.frameGeometry); Assert.fullyVisible(client2.getActualFrameGeometry());
// focus client1 (no scrolling should occur) // focus client1 (no scrolling should occur)
qtMock.fireShortcut("karousel-focus-left"); qtMock.fireShortcut("karousel-focus-left");
Assert.centered(config, tilingArea, client2, { message: "No scrolling should have occured" }); Assert.centered(config, tilingArea, client2, { message: "No scrolling should have occured" });
Assert.fullyVisible(client1.frameGeometry); Assert.fullyVisible(client1.getActualFrameGeometry());
Assert.fullyVisible(client2.frameGeometry); Assert.fullyVisible(client2.getActualFrameGeometry());
// center client1 // center client1
qtMock.fireShortcut("karousel-grid-scroll-focused"); qtMock.fireShortcut("karousel-grid-scroll-focused");

View File

@@ -1,4 +1,4 @@
tests.register("columns squeeze side", 1, () => { tests.register("columns squeeze side", 5, () => {
const baseTestCases = [ const baseTestCases = [
{ widths: [500, 500], blocked: [false, false], possible: true }, { widths: [500, 500], blocked: [false, false], possible: true },
{ widths: [500, 768], blocked: [false, false], possible: true }, { widths: [500, 768], blocked: [false, false], possible: true },
@@ -46,21 +46,21 @@ tests.register("columns squeeze side", 1, () => {
Assert.columnsFillTilingArea(clients, assertOpt); Assert.columnsFillTilingArea(clients, assertOpt);
for (let i = 0; i < clients.length; i++) { for (let i = 0; i < clients.length; i++) {
if (testCase.blocked[i]) { if (testCase.blocked[i]) {
Assert.equal(clients[i].frameGeometry.width, testCase.widths[i], assertOpt); Assert.equal(clients[i].getActualFrameGeometry().width, testCase.widths[i], assertOpt);
} }
} }
} }
const frames = clients.map(client => client.frameGeometry); const frames = clients.map(client => client.getActualFrameGeometry());
qtMock.fireShortcut(testCase.action); qtMock.fireShortcut(testCase.action);
const newFrames = clients.map(client => client.frameGeometry); const newFrames = clients.map(client => client.getActualFrameGeometry());
for (let i = 0; i < clients.length; i++) { for (let i = 0; i < clients.length; i++) {
Assert.equalRects(frames[i], newFrames[i], assertOpt); Assert.equalRects(frames[i], newFrames[i], assertOpt);
} }
} }
}); });
tests.register("columns squeeze side (just scroll)", 1, () => { tests.register("columns squeeze side (just scroll)", 5, () => {
const baseTestCases = [ const baseTestCases = [
{ focus: 0, startVisible: [true, true, false], endVisible: [true, true, false] }, { focus: 0, startVisible: [true, true, false], endVisible: [true, true, false] },
{ focus: 1, startVisible: [false, true, true], endVisible: [true, true, false] }, { focus: 1, startVisible: [false, true, true], endVisible: [true, true, false] },
@@ -91,12 +91,12 @@ tests.register("columns squeeze side (just scroll)", 1, () => {
const config = getDefaultConfig(); const config = getDefaultConfig();
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
function assertVisible(clients: KwinClient[], visible: boolean[]) { function assertVisible(clients: MockKwinClient[], visible: boolean[]) {
for (let i = 0; i < clients.length; i++) { for (let i = 0; i < clients.length; i++) {
if (visible[i]) { if (visible[i]) {
Assert.fullyVisible(clients[i].frameGeometry, { message: assertMsg, skip: 1 }); Assert.fullyVisible(clients[i].getActualFrameGeometry(), { message: assertMsg, skip: 1 });
} else { } else {
Assert.notFullyVisible(clients[i].frameGeometry, { message: assertMsg, skip: 1 }); Assert.notFullyVisible(clients[i].getActualFrameGeometry(), { message: assertMsg, skip: 1 });
} }
} }
} }
@@ -114,9 +114,9 @@ tests.register("columns squeeze side (just scroll)", 1, () => {
qtMock.fireShortcut(testCase.action); qtMock.fireShortcut(testCase.action);
assertVisible(clients, testCase.endVisible); assertVisible(clients, testCase.endVisible);
const frames = clients.map(client => client.frameGeometry); const frames = clients.map(client => client.getActualFrameGeometry());
qtMock.fireShortcut(testCase.action); qtMock.fireShortcut(testCase.action);
const newFrames = clients.map(client => client.frameGeometry); const newFrames = clients.map(client => client.getActualFrameGeometry());
for (let i = 0; i < clients.length; i++) { for (let i = 0; i < clients.length; i++) {
Assert.equalRects(frames[i], newFrames[i], { message: assertMsg }); Assert.equalRects(frames[i], newFrames[i], { message: assertMsg });
} }

View File

@@ -0,0 +1,82 @@
tests.register("Drag tiled window, untile", 10, () => {
const config = getDefaultConfig();
config.cursorFollowsFocus = true;
const { qtMock, workspaceMock, world } = init(config);
const [client1, client2] = workspaceMock.createClients(2);
const initialCursorPos = new MockQmlPoint(380, 20);
Assert.assert(rectContainsPoint(client1.getActualFrameGeometry(), initialCursorPos), { message: "invalid test setup" });
workspaceMock.cursorPos = initialCursorPos.clone();
runOneOf(
() => { Workspace.activeWindow = client1; },
() => { qtMock.fireShortcut("karousel-focus-1"); },
);
Assert.assert(rectContainsPoint(client1.getActualFrameGeometry(), Workspace.cursorPos));
Assert.assert(!rectContainsPoint(client2.getActualFrameGeometry(), Workspace.cursorPos));
Assert.assert(pointEquals(Workspace.cursorPos, initialCursorPos), { message: "Cursor should not have been moved because it was already within the focused client" });
runOneOf(
() => { Workspace.activeWindow = client2; },
() => { qtMock.fireShortcut("karousel-focus-2"); },
);
Assert.assert(!rectContainsPoint(client1.getActualFrameGeometry(), Workspace.cursorPos));
Assert.assert(rectContainsPoint(client2.getActualFrameGeometry(), Workspace.cursorPos));
runOneOf(
() => { Workspace.activeWindow = client1; },
() => { qtMock.fireShortcut("karousel-focus-1"); },
);
Assert.assert(rectContainsPoint(client1.getActualFrameGeometry(), Workspace.cursorPos));
Assert.assert(!rectContainsPoint(client2.getActualFrameGeometry(), Workspace.cursorPos));
const lastCursorPos = workspaceMock.cursorPos.clone();
Workspace.activeWindow = null;
Assert.assert(pointEquals(Workspace.cursorPos, lastCursorPos), { message: "Cursor should not have been moved" });
});
tests.register("Cursor follows focus only on matched desktops", 1, () => {
// Test that cursor follow focus only works for windows on matched desktops (tiled windows)
const config = getDefaultConfig();
config.cursorFollowsFocus = true;
config.tiledDesktops = "^Desktop 1$"; // Only work on Desktop 1
const { workspaceMock, world } = init(config);
// Create a client on Desktop 1 (matched desktop) - should be tiled
const client1 = new MockKwinClient();
client1.desktops = [workspaceMock.desktops[0]]; // Desktop 1
workspaceMock.createWindows(client1);
// Create a client on Desktop 2 (non-matched desktop) - should be floating
const client2 = new MockKwinClient();
client2.desktops = [workspaceMock.desktops[1]]; // Desktop 2
workspaceMock.createWindows(client2);
// Set initial cursor position outside both windows
const initialCursorPos = new MockQmlPoint(10, 10);
workspaceMock.cursorPos = initialCursorPos.clone();
// Test 1: Focus client1 on matched desktop (Desktop 1) - cursor should move
workspaceMock.currentDesktop = workspaceMock.desktops[0]; // Switch to Desktop 1
Workspace.activeWindow = client1;
world.do(() => {});
Assert.assert(rectContainsPoint(client1.getActualFrameGeometry(), Workspace.cursorPos),
{ message: "Cursor should have moved to tiled window on matched desktop" });
// Test 2: Switch to non-matched desktop (Desktop 2) and focus client2 - cursor should NOT move
workspaceMock.cursorPos = initialCursorPos.clone();
workspaceMock.currentDesktop = workspaceMock.desktops[1]; // Switch to Desktop 2
Workspace.activeWindow = client2;
world.do(() => {});
Assert.assert(pointEquals(Workspace.cursorPos, initialCursorPos),
{ message: "Cursor should NOT move on non-matched desktop" });
// Test 3: Even if we focus client1 (tiled) while on Desktop 2, cursor should NOT move
// because the current desktop is not matched
workspaceMock.cursorPos = initialCursorPos.clone();
workspaceMock.currentDesktop = workspaceMock.desktops[1]; // Stay on Desktop 2
Workspace.activeWindow = client1;
world.do(() => {});
Assert.assert(pointEquals(Workspace.cursorPos, initialCursorPos),
{ message: "Cursor should NOT move even for tiled window when current desktop is not matched" });
});

View File

@@ -0,0 +1,73 @@
tests.register("Desktop filtering", 1, () => {
// Test 1: Default config should work on all desktops
const config1 = getDefaultConfig();
const { workspaceMock: wm1, world: world1 } = init(config1);
const client1 = new MockKwinClient();
client1.desktops = [wm1.desktops[0]];
wm1.createWindows(client1);
world1.do((clientManager) => {
Assert.tiledClient(clientManager, client1, { message: "Client should be tiled on desktop1 with default config (*)" });
});
});
tests.register("Desktop filtering - specific desktop", 1, () => {
// Test 2: Specific desktop name - should work only on matching desktop
const config2 = getDefaultConfig();
config2.tiledDesktops = "^Desktop 1$";
const { workspaceMock: wm2, world: world2 } = init(config2);
const client1 = new MockKwinClient();
client1.desktops = [wm2.desktops[0]]; // Desktop 1
wm2.createWindows(client1);
world2.do((clientManager) => {
Assert.tiledClient(clientManager, client1, { message: "Client should be tiled on Desktop 1" });
});
wm2.removeWindow(client1);
const client2 = new MockKwinClient();
client2.desktops = [wm2.desktops[1]]; // Desktop 2
wm2.createWindows(client2);
world2.do((clientManager) => {
Assert.notTiledClient(clientManager, client2, { message: "Client should NOT be tiled on Desktop 2" });
});
});
tests.register("Desktop filtering - multiple desktops", 1, () => {
// Test 3: Multiple desktop names using regex alternation
const config3 = getDefaultConfig();
config3.tiledDesktops = "^Desktop [12]$";
const { workspaceMock: wm3, world: world3 } = init(config3);
const client1 = new MockKwinClient();
client1.desktops = [wm3.desktops[0]]; // Desktop 1
wm3.createWindows(client1);
world3.do((clientManager) => {
Assert.tiledClient(clientManager, client1, { message: "Client should be tiled on Desktop 1" });
});
wm3.removeWindow(client1);
const client2 = new MockKwinClient();
client2.desktops = [wm3.desktops[1]]; // Desktop 2
wm3.createWindows(client2);
world3.do((clientManager) => {
Assert.tiledClient(clientManager, client2, { message: "Client should be tiled on Desktop 2" });
});
});
tests.register("Desktop filtering - windows on multiple desktops", 1, () => {
// Test 4: Windows on multiple desktops should not be tiled (fallback to floating)
const config4 = getDefaultConfig();
config4.tiledDesktops = ".*";
const { workspaceMock: wm4, world: world4 } = init(config4);
const client1 = new MockKwinClient();
client1.desktops = [wm4.desktops[0], wm4.desktops[1]]; // Multiple desktops
wm4.createWindows(client1);
world4.do((clientManager) => {
Assert.notTiledClient(clientManager, client1, { message: "Client on multiple desktops should not be tiled" });
});
});

View File

@@ -8,31 +8,31 @@ tests.register("External resize", 1, () => {
function getTiledFrame(width: number) { function getTiledFrame(width: number) {
return new MockQmlRect( return new MockQmlRect(
tilingArea.left + Math.round((tilingArea.width - width) / 2), tilingArea.x + Math.round((tilingArea.width - width) / 2),
tilingArea.top, tilingArea.y,
width, width,
tilingArea.height, tilingArea.height,
); );
} }
const [client] = workspaceMock.createClientsWithFrames(getClientDesiredFrame(100)); const [client] = workspaceMock.createClientsWithFrames(getClientDesiredFrame(100));
Assert.equalRects(client.frameGeometry, getTiledFrame(100), { message: "We should tile the window, respecting its desired width" }); Assert.equalRects(client.getActualFrameGeometry(), getTiledFrame(100), { message: "We should tile the window, respecting its desired width" });
function testExternalResizing() { function testExternalResizing() {
client.frameGeometry = getClientDesiredFrame(110); client.frameGeometry = getClientDesiredFrame(110);
Assert.equalRects(client.frameGeometry, getTiledFrame(110), { message: "We should re-arrange the window, respecting its new desired width" }); Assert.equalRects(client.getActualFrameGeometry(), getTiledFrame(110), { message: "We should re-arrange the window, respecting its new desired width" });
client.frameGeometry = getClientDesiredFrame(120); client.frameGeometry = getClientDesiredFrame(120);
Assert.equalRects(client.frameGeometry, getTiledFrame(120), { message: "We should re-arrange the window, respecting its new desired width" }); Assert.equalRects(client.getActualFrameGeometry(), getTiledFrame(120), { message: "We should re-arrange the window, respecting its new desired width" });
client.frameGeometry = getClientDesiredFrame(130); client.frameGeometry = getClientDesiredFrame(130);
Assert.equalRects(client.frameGeometry, getTiledFrame(130), { message: "We should re-arrange the window, respecting its new desired width" }); Assert.equalRects(client.getActualFrameGeometry(), getTiledFrame(130), { message: "We should re-arrange the window, respecting its new desired width" });
client.frameGeometry = getClientDesiredFrame(140); client.frameGeometry = getClientDesiredFrame(140);
Assert.equalRects(client.frameGeometry, getTiledFrame(140), { message: "We should re-arrange the window, respecting its new desired width" }); Assert.equalRects(client.getActualFrameGeometry(), getTiledFrame(140), { message: "We should re-arrange the window, respecting its new desired width" });
client.frameGeometry = getClientDesiredFrame(200); client.frameGeometry = getClientDesiredFrame(200);
Assert.equalRects(client.frameGeometry, getClientDesiredFrame(200), { message: "We should give up and let the client have its desired frame" }); Assert.equalRects(client.getActualFrameGeometry(), getClientDesiredFrame(200), { message: "We should give up and let the client have its desired frame" });
} }
timeControl(addTime => { timeControl(addTime => {

View File

@@ -0,0 +1,10 @@
tests.register("Move and follow window to desktop", 20, () => {
// This tests the Kwin shortcuts for moving windows to adjacent desktops.
const config = getDefaultConfig();
const { qtMock, workspaceMock, world } = init(config);
const [client0, client1] = workspaceMock.createClients(2);
client1.moveAndFollowToDesktop(workspaceMock.desktops[1], workspaceMock);
Assert.equal(workspaceMock.activeWindow, client1);
});

View File

@@ -10,7 +10,7 @@ tests.register("Focus and move windows", 1, () => {
}); });
Assert.assert(workspaceMock.activeWindow === client3); Assert.assert(workspaceMock.activeWindow === client3);
function testLayout(shortcutName: string, grid: KwinClient[][]) { function testLayout(shortcutName: string, grid: MockKwinClient[][]) {
qtMock.fireShortcut(shortcutName); qtMock.fireShortcut(shortcutName);
Assert.grid(config, tilingArea, 100, grid, true, [], { skip: 1 }); Assert.grid(config, tilingArea, 100, grid, true, [], { skip: 1 });
} }

View File

@@ -13,35 +13,35 @@ tests.register("LazyScroller", 20, () => {
const [client3] = workspaceMock.createClientsWithWidths(300); const [client3] = workspaceMock.createClientsWithWidths(300);
Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false); Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false);
Assert.equal(client3.frameGeometry.right, tilingArea.right); Assert.equal(rectRight(client3.getActualFrameGeometry()), rectRight(tilingArea));
runOneOf( runOneOf(
() => workspaceMock.activeWindow = client2, () => { workspaceMock.activeWindow = client2; },
() => qtMock.fireShortcut("karousel-focus-2"), () => { qtMock.fireShortcut("karousel-focus-2"); },
() => qtMock.fireShortcut("karousel-focus-left"), () => { qtMock.fireShortcut("karousel-focus-left"); },
); );
Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false); Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false);
Assert.equal(client3.frameGeometry.right, tilingArea.right); Assert.equal(rectRight(client3.getActualFrameGeometry()), rectRight(tilingArea));
runOneOf( runOneOf(
() => workspaceMock.activeWindow = client1, () => { workspaceMock.activeWindow = client1; },
() => qtMock.fireShortcut("karousel-focus-1"), () => { qtMock.fireShortcut("karousel-focus-1"); },
() => qtMock.fireShortcut("karousel-focus-left"), () => { qtMock.fireShortcut("karousel-focus-left"); },
() => qtMock.fireShortcut("karousel-focus-start"), () => { qtMock.fireShortcut("karousel-focus-start"); },
); );
workspaceMock.activeWindow = client1; workspaceMock.activeWindow = client1;
Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false); Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false);
Assert.equal(client1.frameGeometry.left, tilingArea.left); Assert.equal(client1.getActualFrameGeometry().x, tilingArea.x);
qtMock.fireShortcut("karousel-grid-scroll-focused"); qtMock.fireShortcut("karousel-grid-scroll-focused");
Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false); Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false);
Assert.grid(config, tilingArea, 300, [[client1]], true); Assert.grid(config, tilingArea, 300, [[client1]], true);
runOneOf( runOneOf(
() => workspaceMock.activeWindow = client2, () => { workspaceMock.activeWindow = client2; },
() => qtMock.fireShortcut("karousel-focus-2"), () => { qtMock.fireShortcut("karousel-focus-2"); },
() => qtMock.fireShortcut("karousel-focus-right"), () => { qtMock.fireShortcut("karousel-focus-right"); },
); );
Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false); Assert.grid(config, tilingArea, 300, [[client1], [client2], [client3]], false);
Assert.equal(client1.frameGeometry.left, tilingArea.left); Assert.equal(client1.getActualFrameGeometry().x, tilingArea.x);
}); });

View File

@@ -1,214 +1,341 @@
tests.register("Maximization", 100, () => { {
const config = getDefaultConfig(); function registerTests(
const { qtMock, workspaceMock, world } = init(config); suffix: string,
getConfig: () => Config,
shouldKeepBelow: (tiled: boolean) => boolean,
shouldKeepAbove: (tiled: boolean) => boolean,
) {
tests.register("Maximization " + suffix, 100, () => {
const config = getConfig();
const { qtMock, workspaceMock, world } = init(config);
const [kwinClient] = workspaceMock.createClientsWithWidths(300); const [kwinClient] = workspaceMock.createClientsWithWidths(300);
world.do((clientManager, desktopManager) => { world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(kwinClient)); Assert.assert(clientManager.hasClient(kwinClient));
}); });
const columnLeftX = tilingArea.left + tilingArea.width/2 - 300/2; const columnLeftX = tilingArea.x + tilingArea.width/2 - 300/2;
const columnTopY = tilingArea.top; const columnTopY = tilingArea.y;
const columnHeight = tilingArea.height; const columnHeight = tilingArea.height;
Assert.rect(kwinClient.frameGeometry, columnLeftX, columnTopY, 300, columnHeight); Assert.assert(!kwinClient.fullScreen);
Assert.equal(kwinClient.keepBelow, shouldKeepBelow(true));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(true));
Assert.rect(kwinClient.getActualFrameGeometry(), columnLeftX, columnTopY, 300, columnHeight);
kwinClient.fullScreen = true; kwinClient.fullScreen = true;
Assert.equalRects(kwinClient.frameGeometry, screen); Assert.assert(kwinClient.fullScreen);
Assert.equal(kwinClient.keepBelow, shouldKeepBelow(false));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(kwinClient.getActualFrameGeometry(), screen);
kwinClient.fullScreen = false; kwinClient.fullScreen = false;
Assert.rect(kwinClient.frameGeometry, columnLeftX, columnTopY, 300, columnHeight); Assert.assert(!kwinClient.fullScreen);
Assert.equal(kwinClient.keepBelow, shouldKeepBelow(true));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(true));
Assert.rect(kwinClient.getActualFrameGeometry(), columnLeftX, columnTopY, 300, columnHeight);
kwinClient.setMaximize(true, true); kwinClient.setMaximize(true, true);
Assert.equalRects(kwinClient.frameGeometry, screen); Assert.assert(!kwinClient.fullScreen);
Assert.equal(kwinClient.keepBelow, shouldKeepBelow(false));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(kwinClient.getActualFrameGeometry(), screen);
kwinClient.setMaximize(true, false); kwinClient.setMaximize(true, false);
Assert.rect(kwinClient.frameGeometry, columnLeftX, 0, 300, screen.height); Assert.assert(!kwinClient.fullScreen);
Assert.equal(kwinClient.keepBelow, shouldKeepBelow(false));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(false));
Assert.rect(kwinClient.getActualFrameGeometry(), columnLeftX, 0, 300, screen.height);
kwinClient.setMaximize(false, false); kwinClient.setMaximize(false, false);
Assert.rect(kwinClient.frameGeometry, columnLeftX, columnTopY, 300, columnHeight); Assert.assert(!kwinClient.fullScreen);
}); Assert.equal(kwinClient.keepBelow, shouldKeepBelow(true));
Assert.equal(kwinClient.keepAbove, shouldKeepAbove(true));
Assert.rect(kwinClient.getActualFrameGeometry(), columnLeftX, columnTopY, 300, columnHeight);
});
tests.register("Maximize with transient", 100, () => { tests.register("Maximize with transient " + suffix, 100, () => {
const config = getDefaultConfig(); const config = getConfig();
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
const parent = new MockKwinClient(new MockQmlRect(10, 20, 300, 200)); const parent = new MockKwinClient(new MockQmlRect(10, 20, 300, 200));
const child = new MockKwinClient(new MockQmlRect(14, 24, 50, 50), parent); const child = new MockKwinClient(new MockQmlRect(14, 24, 50, 50), parent);
workspaceMock.createWindows(parent); workspaceMock.createWindows(parent);
world.do((clientManager, desktopManager) => { world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(parent)); Assert.assert(clientManager.hasClient(parent));
}); });
runOneOf( runOneOf(
() => parent.fullScreen = true, () => { parent.fullScreen = true; },
() => parent.setMaximize(true, true), () => { parent.setMaximize(true, true); },
); );
Assert.equalRects(parent.frameGeometry, screen); Assert.equal(parent.keepBelow, shouldKeepBelow(false));
Assert.equal(parent.keepAbove, shouldKeepAbove(false));
Assert.equalRects(parent.getActualFrameGeometry(), screen);
workspaceMock.createWindows(child); workspaceMock.createWindows(child);
world.do((clientManager, desktopManager) => { world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(child)); Assert.assert(clientManager.hasClient(child));
}); });
Assert.rect(child.frameGeometry, 14, 24, 50, 50); Assert.assert(!child.fullScreen);
Assert.equalRects(parent.frameGeometry, screen); Assert.equal(child.keepBelow, shouldKeepBelow(false));
}); Assert.equal(child.keepAbove, shouldKeepAbove(false));
Assert.rect(child.getActualFrameGeometry(), 14, 24, 50, 50);
Assert.equal(parent.keepBelow, shouldKeepBelow(false));
Assert.equal(parent.keepAbove, shouldKeepAbove(false));
Assert.equalRects(parent.getActualFrameGeometry(), screen);
});
tests.register("Re-maximize disabled", 100, () => { {
const config = getDefaultConfig(); function assertWindowed(config: Config, clients: MockKwinClient[]) {
config.reMaximize = false; Assert.assert(!clients[0].fullScreen);
const { qtMock, workspaceMock, world } = init(config); Assert.equal(clients[0].keepBelow, shouldKeepBelow(true));
Assert.equal(clients[0].keepAbove, shouldKeepAbove(true));
Assert.assert(!clients[1].fullScreen);
Assert.equal(clients[1].keepBelow, shouldKeepBelow(true));
Assert.equal(clients[1].keepAbove, shouldKeepAbove(true));
Assert.assert(!clients[2].fullScreen);
Assert.equal(clients[2].keepBelow, shouldKeepBelow(true));
Assert.equal(clients[2].keepAbove, shouldKeepAbove(true));
Assert.grid(config, tilingArea, [300, 400], [[clients[0]], [clients[1], clients[2]]], true);
}
const [client1, client2] = workspaceMock.createClientsWithWidths(300, 400); function assertFullScreenOrMaximized(clients: MockKwinClient[]) {
world.do((clientManager, desktopManager) => { Assert.assert(!clients[0].fullScreen);
Assert.assert(clientManager.hasClient(client1)); Assert.equal(clients[0].keepBelow, shouldKeepBelow(true));
Assert.assert(clientManager.hasClient(client2)); Assert.equal(clients[0].keepAbove, shouldKeepAbove(true));
}); Assert.assert(!clients[1].fullScreen);
Assert.equal(clients[1].keepBelow, shouldKeepBelow(true));
Assert.equal(clients[1].keepAbove, shouldKeepAbove(true));
Assert.equal(clients[2].keepBelow, shouldKeepBelow(false));
Assert.equal(clients[2].keepAbove, shouldKeepAbove(false));
Assert.equalRects(clients[2].getActualFrameGeometry(), screen);
}
const columnsWidth = 300 + 400 + config.gapsInnerHorizontal; tests.register("Re-maximize disabled " + suffix, 100, () => {
const column1LeftX = tilingArea.left + tilingArea.width/2 - columnsWidth/2; const config = getConfig();
const column2LeftX = column1LeftX + 300 + config.gapsInnerHorizontal; config.reMaximize = false;
const columnTopY = tilingArea.top; const { qtMock, workspaceMock, world } = init(config);
const columnHeight = tilingArea.height;
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.rect(client2.frameGeometry, column2LeftX, columnTopY, 400, columnHeight);
runOneOf( const clients = workspaceMock.createClientsWithWidths(300, 400, 400);
() => client2.fullScreen = true, qtMock.fireShortcut("karousel-window-move-left");
() => client2.setMaximize(true, true),
);
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.equalRects(client2.frameGeometry, screen);
runOneOf( assertWindowed(config, clients);
() => workspaceMock.activeWindow = client1,
() => qtMock.fireShortcut("karousel-focus-1"),
() => qtMock.fireShortcut("karousel-focus-left"),
() => qtMock.fireShortcut("karousel-focus-start"),
);
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.rect(client2.frameGeometry, column2LeftX, columnTopY, 400, columnHeight);
runOneOf( runOneOf(
() => workspaceMock.activeWindow = client2, () => { clients[2].fullScreen = true; },
() => qtMock.fireShortcut("karousel-focus-2"), () => { clients[2].setMaximize(true, true); },
() => qtMock.fireShortcut("karousel-focus-right"), );
() => qtMock.fireShortcut("karousel-focus-end"), assertFullScreenOrMaximized(clients);
);
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.rect(client2.frameGeometry, column2LeftX, columnTopY, 400, columnHeight);
});
tests.register("Re-maximize enabled", 100, () => { runOneOf(
const config = getDefaultConfig(); () => { workspaceMock.activeWindow = clients[0]; },
config.reMaximize = true; () => { qtMock.fireShortcut("karousel-focus-1"); },
const { qtMock, workspaceMock, world } = init(config); () => { qtMock.fireShortcut("karousel-focus-left"); },
() => { qtMock.fireShortcut("karousel-focus-start"); },
);
assertWindowed(config, clients);
const [client1, client2] = workspaceMock.createClientsWithWidths(300, 400); runOneOf(
world.do((clientManager, desktopManager) => { () => { workspaceMock.activeWindow = clients[2]; },
Assert.assert(clientManager.hasClient(client1)); () => { qtMock.fireShortcut("karousel-focus-2"); },
Assert.assert(clientManager.hasClient(client2)); () => { qtMock.fireShortcut("karousel-focus-right"); },
}); () => { qtMock.fireShortcut("karousel-focus-end"); },
);
assertWindowed(config, clients);
const columnsWidth = 300 + 400 + config.gapsInnerHorizontal; runOneOf(
const column1LeftX = tilingArea.left + tilingArea.width/2 - columnsWidth/2; () => { clients[2].fullScreen = true; },
const column2LeftX = column1LeftX + 300 + config.gapsInnerHorizontal; () => { clients[2].setMaximize(true, true); },
const columnTopY = tilingArea.top; );
const columnHeight = tilingArea.height; assertFullScreenOrMaximized(clients);
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.rect(client2.frameGeometry, column2LeftX, columnTopY, 400, columnHeight);
runOneOf( runOneOf(
() => client2.fullScreen = true, () => { workspaceMock.activeWindow = clients[1]; },
() => client2.setMaximize(true, true), () => { qtMock.fireShortcut("karousel-focus-up"); },
); );
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight); assertWindowed(config, clients);
Assert.equalRects(client2.frameGeometry, screen);
runOneOf( runOneOf(
() => workspaceMock.activeWindow = client1, () => { workspaceMock.activeWindow = clients[2]; },
() => qtMock.fireShortcut("karousel-focus-1"), () => { qtMock.fireShortcut("karousel-focus-down"); },
() => qtMock.fireShortcut("karousel-focus-left"), );
() => qtMock.fireShortcut("karousel-focus-start"), assertWindowed(config, clients);
); });
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.rect(client2.frameGeometry, column2LeftX, columnTopY, 400, columnHeight);
runOneOf( tests.register("Re-maximize enabled " + suffix, 100, () => {
() => workspaceMock.activeWindow = client2, const config = getConfig();
() => qtMock.fireShortcut("karousel-focus-2"), config.reMaximize = true;
() => qtMock.fireShortcut("karousel-focus-right"), const { qtMock, workspaceMock, world } = init(config);
() => qtMock.fireShortcut("karousel-focus-end"),
);
Assert.rect(client1.frameGeometry, column1LeftX, columnTopY, 300, columnHeight);
Assert.equalRects(client2.frameGeometry, screen);
});
tests.register("Start full-screen", 100, () => { const clients = workspaceMock.createClientsWithWidths(300, 400, 400);
const config = getDefaultConfig(); qtMock.fireShortcut("karousel-window-move-left");
config.reMaximize = true;
const { qtMock, workspaceMock, world } = init(config);
const [windowedClient] = workspaceMock.createClientsWithWidths(300); assertWindowed(config, clients);
const fullScreenClient = new MockKwinClient(new MockQmlRect(0, 0, 400, 200));
fullScreenClient.resourceClass = "full-screen-app";
fullScreenClient.fullScreen = true;
workspaceMock.createWindows(fullScreenClient);
world.do((clientManager, desktopManager) => { runOneOf(
Assert.assert(clientManager.hasClient(windowedClient)); () => { clients[2].fullScreen = true; },
Assert.assert(clientManager.hasClient(fullScreenClient)); () => { clients[2].setMaximize(true, true); },
}); );
assertFullScreenOrMaximized(clients);
Assert.centered(config, tilingArea, windowedClient); runOneOf(
Assert.equalRects(fullScreenClient.frameGeometry, screen); () => { workspaceMock.activeWindow = clients[0]; },
Assert.equal(Workspace.activeWindow, fullScreenClient); () => { qtMock.fireShortcut("karousel-focus-1"); },
() => { qtMock.fireShortcut("karousel-focus-left"); },
() => { qtMock.fireShortcut("karousel-focus-start"); },
);
assertWindowed(config, clients);
{ runOneOf(
qtMock.fireShortcut("karousel-focus-left"); () => { workspaceMock.activeWindow = clients[2]; },
const opts = { message: "fullScreenClient is not in the grid, so we can't move focus directionally" }; () => { qtMock.fireShortcut("karousel-focus-2"); },
Assert.centered(config, tilingArea, windowedClient, opts); () => { qtMock.fireShortcut("karousel-focus-right"); },
Assert.equalRects(fullScreenClient.frameGeometry, screen, opts); () => { qtMock.fireShortcut("karousel-focus-end"); },
Assert.equal(Workspace.activeWindow, fullScreenClient, opts); );
assertFullScreenOrMaximized(clients);
runOneOf(
() => { workspaceMock.activeWindow = clients[1]; },
() => { qtMock.fireShortcut("karousel-focus-up"); },
);
assertWindowed(config, clients);
runOneOf(
() => { workspaceMock.activeWindow = clients[2]; },
() => { qtMock.fireShortcut("karousel-focus-down"); },
);
assertFullScreenOrMaximized(clients);
});
}
tests.register("Start full-screen " + suffix, 100, () => {
const config = getConfig();
config.reMaximize = true;
const { qtMock, workspaceMock, world } = init(config);
const [windowedClient] = workspaceMock.createClientsWithWidths(300);
const fullScreenClient = new MockKwinClient(new MockQmlRect(0, 0, 400, 200));
fullScreenClient.resourceClass = "full-screen-app";
fullScreenClient.fullScreen = true;
workspaceMock.createWindows(fullScreenClient);
world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(windowedClient));
Assert.assert(clientManager.hasClient(fullScreenClient));
});
Assert.assert(!windowedClient.fullScreen);
Assert.equal(windowedClient.keepBelow, shouldKeepBelow(true));
Assert.equal(windowedClient.keepAbove, shouldKeepAbove(true));
Assert.centered(config, tilingArea, windowedClient);
Assert.assert(fullScreenClient.fullScreen);
Assert.equal(fullScreenClient.keepBelow, shouldKeepBelow(false));
Assert.equal(fullScreenClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(fullScreenClient.getActualFrameGeometry(), screen);
Assert.equal(Workspace.activeWindow, fullScreenClient);
{
qtMock.fireShortcut("karousel-focus-left");
const opts = { message: "fullScreenClient is not in the grid, so we can't move focus directionally" };
Assert.assert(!windowedClient.fullScreen);
Assert.equal(windowedClient.keepBelow, shouldKeepBelow(true));
Assert.equal(windowedClient.keepAbove, shouldKeepAbove(true));
Assert.centered(config, tilingArea, windowedClient);
Assert.assert(fullScreenClient.fullScreen);
Assert.equal(fullScreenClient.keepBelow, shouldKeepBelow(false));
Assert.equal(fullScreenClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(fullScreenClient.getActualFrameGeometry(), screen);
Assert.equal(Workspace.activeWindow, fullScreenClient, opts);
}
{
qtMock.fireShortcut("karousel-focus-1");
const opts = { message: "fullScreenClient is not in grid, so it should stay full-screen" };
Assert.assert(!windowedClient.fullScreen);
Assert.equal(windowedClient.keepBelow, shouldKeepBelow(true));
Assert.equal(windowedClient.keepAbove, shouldKeepAbove(true));
Assert.centered(config, tilingArea, windowedClient);
Assert.assert(fullScreenClient.fullScreen);
Assert.equal(fullScreenClient.keepBelow, shouldKeepBelow(false));
Assert.equal(fullScreenClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(fullScreenClient.getActualFrameGeometry(), screen);
Assert.equal(Workspace.activeWindow, windowedClient);
}
});
tests.register("Start full-screen (force tiling) " + suffix, 100, () => {
const config = getConfig();
config.reMaximize = true;
config.windowRules = '[{ "class": "full-screen-app", "tile": true }]';
const { qtMock, workspaceMock, world } = init(config);
const column1Width = 300;
const [windowedClient] = workspaceMock.createClientsWithWidths(column1Width);
const fullScreenClient = new MockKwinClient(new MockQmlRect(0, 0, 400, 200));
fullScreenClient.resourceClass = "full-screen-app";
fullScreenClient.fullScreen = true;
workspaceMock.createWindows(fullScreenClient);
world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(windowedClient));
Assert.assert(clientManager.hasClient(fullScreenClient));
});
Assert.assert(!windowedClient.fullScreen);
Assert.equal(windowedClient.keepBelow, shouldKeepBelow(true));
Assert.equal(windowedClient.keepAbove, shouldKeepAbove(true));
Assert.grid(config, tilingArea, [column1Width], [[windowedClient]], false);
Assert.assert(fullScreenClient.fullScreen);
Assert.equal(fullScreenClient.keepBelow, shouldKeepBelow(false));
Assert.equal(fullScreenClient.keepAbove, shouldKeepAbove(false));
Assert.equalRects(fullScreenClient.getActualFrameGeometry(), screen);
Assert.equal(Workspace.activeWindow, fullScreenClient);
let expectedColumn2Width = 0;
let expectedActiveWindow;
runOneOf(
() => {
fullScreenClient.fullScreen = false;
expectedColumn2Width = 400;
expectedActiveWindow = fullScreenClient;
},
() => {
qtMock.fireShortcut("karousel-focus-left");
expectedColumn2Width = tilingArea.width;
expectedActiveWindow = windowedClient;
},
);
const opts = { message: "fullScreenClient should be restored from full-screen mode to tiled mode" };
Assert.assert(!windowedClient.fullScreen);
Assert.equal(windowedClient.keepBelow, shouldKeepBelow(true));
Assert.equal(windowedClient.keepAbove, shouldKeepAbove(true));
Assert.assert(!fullScreenClient.fullScreen);
Assert.equal(fullScreenClient.keepBelow, shouldKeepBelow(true));
Assert.equal(fullScreenClient.keepAbove, shouldKeepAbove(true));
Assert.grid(config, tilingArea, [column1Width, expectedColumn2Width], [[windowedClient], [fullScreenClient]], false, [], opts);
Assert.equal(Workspace.activeWindow, expectedActiveWindow);
});
} }
{ function getConfig(floatingKeepAbove: boolean) {
qtMock.fireShortcut("karousel-focus-1"); const config = getDefaultConfig();
const opts = { message: "fullScreenClient is not in grid, so it should stay full-screen" }; config.tiledKeepBelow = !floatingKeepAbove;
Assert.centered(config, tilingArea, windowedClient, opts); config.floatingKeepAbove = floatingKeepAbove;
Assert.equalRects(fullScreenClient.frameGeometry, screen, opts); return config;
Assert.equal(Workspace.activeWindow, windowedClient);
} }
});
tests.register("Start full-screen (force tiling)", 100, () => { registerTests(
const config = getDefaultConfig(); "(tiled below)",
config.reMaximize = true; getConfig.partial(false),
config.windowRules = '[{ "class": "full-screen-app", "tile": true }]'; tiled => tiled,
const { qtMock, workspaceMock, world } = init(config); tiled => false,
);
const column1Width = 300; registerTests(
const [windowedClient] = workspaceMock.createClientsWithWidths(column1Width); "(floating above)",
const fullScreenClient = new MockKwinClient(new MockQmlRect(0, 0, 400, 200)); getConfig.partial(true),
fullScreenClient.resourceClass = "full-screen-app"; tiled => false,
fullScreenClient.fullScreen = true; tiled => !tiled,
workspaceMock.createWindows(fullScreenClient); );
}
world.do((clientManager, desktopManager) => {
Assert.assert(clientManager.hasClient(windowedClient));
Assert.assert(clientManager.hasClient(fullScreenClient));
});
Assert.equalRects(fullScreenClient.frameGeometry, screen);
Assert.equal(Workspace.activeWindow, fullScreenClient);
const column2Width = tilingArea.width;
const column1LeftX = tilingArea.left;
const column2LeftX = column1LeftX + column1Width + gapH;
const columnTopY = tilingArea.top;
const columnHeight = tilingArea.height;
qtMock.fireShortcut("karousel-focus-left");
const opts = { message: "fullScreenClient should be restored from full-screen mode to tiled mode" };
Assert.rect(windowedClient.frameGeometry, column1LeftX, columnTopY, column1Width, columnHeight, opts);
Assert.rect(fullScreenClient.frameGeometry, column2LeftX, columnTopY, column2Width, columnHeight, opts);
Assert.equal(Workspace.activeWindow, windowedClient);
});

View File

@@ -1,4 +1,4 @@
tests.register("Pass focus", 20, () => { tests.register("Pass focus", 100, () => {
const config = getDefaultConfig(); const config = getDefaultConfig();
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
@@ -34,7 +34,4 @@ tests.register("Pass focus", 20, () => {
removeWindow(client0); removeWindow(client0);
Assert.equal(workspaceMock.activeWindow, client6); Assert.equal(workspaceMock.activeWindow, client6);
removeWindow(client6);
Assert.equal(workspaceMock.activeWindow, null);
}); });

View File

@@ -22,26 +22,26 @@ tests.register("Pin", 20, () => {
Assert.grid(config, tilingArea, 100, [ [pinned], [tiled1], [tiled2] ], true); Assert.grid(config, tilingArea, 100, [ [pinned], [tiled1], [tiled2] ], true);
pinned.pin(screenHalfLeft); pinned.pin(screenHalfLeft);
Assert.equalRects(pinned.frameGeometry, screenHalfLeft); Assert.equalRects(pinned.getActualFrameGeometry(), screenHalfLeft);
Assert.grid(config, tilingAreaHalfRight, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingAreaHalfRight, 100, [ [tiled1], [tiled2] ], true);
pinned.pin(screenHalfRight); pinned.pin(screenHalfRight);
Assert.equalRects(pinned.frameGeometry, screenHalfRight); Assert.equalRects(pinned.getActualFrameGeometry(), screenHalfRight);
Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true);
pinned.unpin(); pinned.unpin();
Assert.equalRects(pinned.frameGeometry, screenHalfRight); Assert.equalRects(pinned.getActualFrameGeometry(), screenHalfRight);
Assert.grid(config, tilingArea, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingArea, 100, [ [tiled1], [tiled2] ], true);
pinned.pin(screenHalfRight); pinned.pin(screenHalfRight);
Assert.equalRects(pinned.frameGeometry, screenHalfRight); Assert.equalRects(pinned.getActualFrameGeometry(), screenHalfRight);
Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true);
pinned.minimized = true; pinned.minimized = true;
Assert.grid(config, tilingArea, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingArea, 100, [ [tiled1], [tiled2] ], true);
pinned.minimized = false; pinned.minimized = false;
Assert.equalRects(pinned.frameGeometry, screenHalfRight); Assert.equalRects(pinned.getActualFrameGeometry(), screenHalfRight);
Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true); Assert.grid(config, tilingAreaHalfLeft, 100, [ [tiled1], [tiled2] ], true);
workspaceMock.activeWindow = pinned; workspaceMock.activeWindow = pinned;

View File

@@ -1,4 +1,4 @@
tests.register("Preset Widths default", 1, () => { tests.register("Preset Widths default", 5, () => {
const config = getDefaultConfig(); const config = getDefaultConfig();
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
@@ -7,33 +7,48 @@ tests.register("Preset Widths default", 1, () => {
function getRect(columnWidth: number) { function getRect(columnWidth: number) {
return new MockQmlRect( return new MockQmlRect(
tilingArea.left + (tilingArea.width - columnWidth) / 2, tilingArea.x + (tilingArea.width - columnWidth) / 2,
tilingArea.top, tilingArea.y,
columnWidth, columnWidth,
tilingArea.height, tilingArea.height,
); );
} }
const [kwinClient] = workspaceMock.createClientsWithWidths(300); const [kwinClient] = workspaceMock.createClientsWithWidths(300);
Assert.equalRects(kwinClient.frameGeometry, getRect(300)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(300));
qtMock.fireShortcut("karousel-cycle-preset-widths"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(halfWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(halfWidth));
qtMock.fireShortcut("karousel-cycle-preset-widths"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(maxWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(maxWidth));
qtMock.fireShortcut("karousel-cycle-preset-widths"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(halfWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(halfWidth));
qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(maxWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(maxWidth));
qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(halfWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(halfWidth));
}); });
tests.register("Preset Widths custom", 1, () => { tests.register("Preset Widths custom", 5, () => {
const config = getDefaultConfig(); const config = getDefaultConfig();
config.presetWidths = "500px, 250px, 100px, 50%"; config.presetWidths = "500px, 250px, 100px, 50%";
const { qtMock, workspaceMock, world } = init(config); const { qtMock, workspaceMock, world } = init(config);
@@ -43,39 +58,122 @@ tests.register("Preset Widths custom", 1, () => {
function getRect(columnWidth: number) { function getRect(columnWidth: number) {
return new MockQmlRect( return new MockQmlRect(
tilingArea.left + (tilingArea.width - columnWidth) / 2, tilingArea.x + (tilingArea.width - columnWidth) / 2,
tilingArea.top, tilingArea.y,
columnWidth, columnWidth,
tilingArea.height, tilingArea.height,
); );
} }
const [kwinClient] = workspaceMock.createClientsWithWidths(200); const [kwinClient] = workspaceMock.createClientsWithWidths(200);
Assert.equalRects(kwinClient.frameGeometry, getRect(200)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(200));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(250));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(halfWidth));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(500));
qtMock.fireShortcut("karousel-cycle-preset-widths"); qtMock.fireShortcut("karousel-cycle-preset-widths");
Assert.equalRects(kwinClient.frameGeometry, getRect(250)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(100));
qtMock.fireShortcut("karousel-cycle-preset-widths"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(halfWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(250));
qtMock.fireShortcut("karousel-cycle-preset-widths"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(500)); () => qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
qtMock.fireShortcut("karousel-cycle-preset-widths"); );
Assert.equalRects(kwinClient.frameGeometry, getRect(100)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(100));
qtMock.fireShortcut("karousel-cycle-preset-widths");
Assert.equalRects(kwinClient.frameGeometry, getRect(250));
qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"); qtMock.fireShortcut("karousel-cycle-preset-widths-reverse");
Assert.equalRects(kwinClient.frameGeometry, getRect(100)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(500));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(halfWidth));
});
tests.register("Preset Widths custom percentages", 5, () => {
const config = getDefaultConfig();
config.presetWidths = "25%, 50%, 75%, 100%";
const { qtMock, workspaceMock, world } = init(config);
const width100 = tilingArea.width;
const width75 = width100*0.75 - config.gapsInnerHorizontal*0.25;
const width50 = width100*0.50 - config.gapsInnerHorizontal*0.50;
const width25 = width100*0.25 - config.gapsInnerHorizontal*0.75;
function getRect(columnWidth: number) {
return new MockQmlRect(
tilingArea.x + (tilingArea.width - columnWidth) / 2,
tilingArea.y,
columnWidth,
tilingArea.height,
);
}
const [kwinClient] = workspaceMock.createClientsWithWidths(200);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(200));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width50));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width75));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths"),
() => qtMock.fireShortcut("karousel-column-width-increase"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width100));
qtMock.fireShortcut("karousel-cycle-preset-widths");
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width25));
qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"); qtMock.fireShortcut("karousel-cycle-preset-widths-reverse");
Assert.equalRects(kwinClient.frameGeometry, getRect(500)); Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width100));
qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"); runOneOf(
Assert.equalRects(kwinClient.frameGeometry, getRect(halfWidth)); () => qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width75));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width50));
runOneOf(
() => qtMock.fireShortcut("karousel-cycle-preset-widths-reverse"),
() => qtMock.fireShortcut("karousel-column-width-decrease"),
);
Assert.equalRects(kwinClient.getActualFrameGeometry(), getRect(width25));
}); });
tests.register("Preset Widths fill screen uniform", 1, () => { tests.register("Preset Widths fill screen uniform", 1, () => {
@@ -96,12 +194,12 @@ tests.register("Preset Widths fill screen uniform", 1, () => {
qtMock.fireShortcut("karousel-cycle-preset-widths"); qtMock.fireShortcut("karousel-cycle-preset-widths");
} }
const left = tilingArea.left; const left = tilingArea.x;
const right = tilingArea.right; const right = rectRight(tilingArea);
const maxLeftoverPx = nColumns - 1; const maxLeftoverPx = nColumns - 1;
const eps = Math.ceil(maxLeftoverPx / 2); const eps = Math.ceil(maxLeftoverPx / 2);
Assert.between(firstClient!.frameGeometry.left, left, left+eps, { message: `nColumns: ${nColumns}` }); Assert.between(firstClient!.getActualFrameGeometry().x, left, left+eps, { message: `nColumns: ${nColumns}` });
Assert.between(lastClient!.frameGeometry.right, right-eps, right, { message: `nColumns: ${nColumns}` }); Assert.between(rectRight(lastClient!.getActualFrameGeometry()), right-eps, right, { message: `nColumns: ${nColumns}` });
} }
}); });
@@ -123,12 +221,12 @@ tests.register("Preset Widths fill screen non-uniform", 1, () => {
const halfWidth = maxWidth/2 - config.gapsInnerHorizontal/2; const halfWidth = maxWidth/2 - config.gapsInnerHorizontal/2;
const quarterWidth = halfWidth/2 - config.gapsInnerHorizontal/2; const quarterWidth = halfWidth/2 - config.gapsInnerHorizontal/2;
const height = tilingArea.height; const height = tilingArea.height;
const left1 = tilingArea.left; const left1 = tilingArea.x;
const left2 = left1 + config.gapsInnerHorizontal + quarterWidth; const left2 = left1 + config.gapsInnerHorizontal + quarterWidth;
const left3 = left2 + config.gapsInnerHorizontal + quarterWidth; const left3 = left2 + config.gapsInnerHorizontal + quarterWidth;
Assert.rect(clientThin1.frameGeometry, left1, tilingArea.top, quarterWidth, height); Assert.rect(clientThin1.getActualFrameGeometry(), left1, tilingArea.y, quarterWidth, height);
Assert.rect(clientThin2.frameGeometry, left2, tilingArea.top, quarterWidth, height); Assert.rect(clientThin2.getActualFrameGeometry(), left2, tilingArea.y, quarterWidth, height);
Assert.rect(clientWide.frameGeometry, left3, tilingArea.top, halfWidth, height); Assert.rect(clientWide.getActualFrameGeometry(), left3, tilingArea.y, halfWidth, height);
Assert.equal(clientWide.frameGeometry.right, tilingArea.right); Assert.equal(rectRight(clientWide.getActualFrameGeometry()), rectRight(tilingArea));
}); });

View File

@@ -6,9 +6,9 @@ tests.register("User resize", 10, () => {
let clientLeft: MockKwinClient, clientRightTop: MockKwinClient, clientRightBottom: MockKwinClient; let clientLeft: MockKwinClient, clientRightTop: MockKwinClient, clientRightBottom: MockKwinClient;
function assertSizes(leftWidth: number, rightWidth: number, topHeight: number, bottomHeight: number) { function assertSizes(leftWidth: number, rightWidth: number, topHeight: number, bottomHeight: number) {
const { left, right } = getGridBounds(clientLeft, clientRightTop); const { left, right } = getGridBounds(clientLeft, clientRightTop);
Assert.rect(clientLeft.frameGeometry, left, tilingArea.top, leftWidth, tilingArea.height); Assert.rect(clientLeft.getActualFrameGeometry(), left, tilingArea.y, leftWidth, tilingArea.height);
Assert.rect(clientRightTop.frameGeometry, left+leftWidth+gapH, tilingArea.top, rightWidth, topHeight); Assert.rect(clientRightTop.getActualFrameGeometry(), left+leftWidth+gapH, tilingArea.y, rightWidth, topHeight);
Assert.rect(clientRightBottom.frameGeometry, left+leftWidth+gapH, tilingArea.top+topHeight+gapV, rightWidth, bottomHeight); Assert.rect(clientRightBottom.getActualFrameGeometry(), left+leftWidth+gapH, tilingArea.y+topHeight+gapV, rightWidth, bottomHeight);
} }
{ {
@@ -89,9 +89,9 @@ tests.register("User resize", 10, () => {
function assertSizes(leftWidth: number, rightWidth: number, topHeight: number, bottomHeight: number) { function assertSizes(leftWidth: number, rightWidth: number, topHeight: number, bottomHeight: number) {
const { left, right } = getGridBounds(clientLeftTop, clientRight); const { left, right } = getGridBounds(clientLeftTop, clientRight);
Assert.rect(clientLeftTop.frameGeometry, left, tilingArea.top, leftWidth, topHeight); Assert.rect(clientLeftTop.getActualFrameGeometry(), left, tilingArea.y, leftWidth, topHeight);
Assert.rect(clientLeftBottom.frameGeometry, left, tilingArea.top+topHeight+gapV, leftWidth, bottomHeight); Assert.rect(clientLeftBottom.getActualFrameGeometry(), left, tilingArea.y+topHeight+gapV, leftWidth, bottomHeight);
Assert.rect(clientRight.frameGeometry, left+leftWidth+gapH, tilingArea.top, rightWidth, tilingArea.height); Assert.rect(clientRight.getActualFrameGeometry(), left+leftWidth+gapH, tilingArea.y, rightWidth, tilingArea.height);
} }
workspaceMock.activeWindow = clientLeftBottom; workspaceMock.activeWindow = clientLeftBottom;

View File

@@ -0,0 +1,41 @@
tests.register("DesktopFilter", 1, () => {
const desktop1 = { __brand: "KwinDesktop" as const, id: "1", name: "Desktop 1" };
const desktop2 = { __brand: "KwinDesktop" as const, id: "2", name: "Work" };
const desktop3 = { __brand: "KwinDesktop" as const, id: "3", name: "Desktop 2" };
// Test 1: Empty config means all desktops
let filter = new DesktopFilter("");
Assert.assert(filter.shouldWorkOnDesktop(desktop1), { message: "Empty config should work on desktop1" });
Assert.assert(filter.shouldWorkOnDesktop(desktop2), { message: "Empty config should work on desktop2" });
// Test 2: Whitespace only means all desktops
filter = new DesktopFilter(" \n \n ");
Assert.assert(filter.shouldWorkOnDesktop(desktop1), { message: "Whitespace only should work on desktop1" });
Assert.assert(filter.shouldWorkOnDesktop(desktop2), { message: "Whitespace only should work on desktop2" });
// Test 3: Match all regex pattern
filter = new DesktopFilter(".*");
Assert.assert(filter.shouldWorkOnDesktop(desktop1), { message: "Regex '.*' should work on desktop1" });
Assert.assert(filter.shouldWorkOnDesktop(desktop2), { message: "Regex '.*' should work on desktop2" });
// Test 4: Partial match without anchors
filter = new DesktopFilter("Work");
Assert.assert(!filter.shouldWorkOnDesktop(desktop1), { message: "Should not work on desktop1" });
Assert.assert(filter.shouldWorkOnDesktop(desktop2), { message: "Should work on desktop2 containing 'Work'" });
// Test 5: Regex alternation for multiple desktops
filter = new DesktopFilter("Desktop 1|Work");
Assert.assert(filter.shouldWorkOnDesktop(desktop1), { message: "Should work on desktop1" });
Assert.assert(filter.shouldWorkOnDesktop(desktop2), { message: "Should work on desktop2" });
Assert.assert(!filter.shouldWorkOnDesktop(desktop3), { message: "Should not work on desktop3" });
// Test 6: Regex pattern with character class
filter = new DesktopFilter("Desktop [12]");
Assert.assert(filter.shouldWorkOnDesktop(desktop1), { message: "Should work on desktop1" });
Assert.assert(!filter.shouldWorkOnDesktop(desktop2), { message: "Should not work on desktop2" });
Assert.assert(filter.shouldWorkOnDesktop(desktop3), { message: "Should work on desktop3" });
// Test 7: Case-sensitive matching
filter = new DesktopFilter("work");
Assert.assert(!filter.shouldWorkOnDesktop(desktop2), { message: "Should not work on desktop2 (case mismatch)" });
});

View File

@@ -0,0 +1,53 @@
tests.register("math", 1, () => {
const rect = new MockQmlRect(100, 200, 10, 20);
const testCases: {
rect: QmlRect,
point: QmlPoint,
contained: boolean,
}[] = [
{
rect: rect,
point: new MockQmlPoint(100, 200),
contained: true,
},
{
rect: rect,
point: new MockQmlPoint(110, 220),
contained: true,
},
{
rect: rect,
point: new MockQmlPoint(105, 205),
contained: true,
},
{
rect: rect,
point: new MockQmlPoint(110.01, 205),
contained: false,
},
{
rect: rect,
point: new MockQmlPoint(105, 220.01),
contained: false,
},
{
rect: rect,
point: new MockQmlPoint(16, 205),
contained: false,
},
{
rect: rect,
point: new MockQmlPoint(105, 16),
contained: false,
},
];
for (const testCase of testCases) {
const result = rectContainsPoint(testCase.rect, testCase.point);
Assert.equal(
result,
testCase.contained,
{ message: JSON.stringify(testCase) },
);
}
});

View File

@@ -1,5 +1,5 @@
namespace Assert { namespace Assert {
type Options = { interface Options {
message?: string, message?: string,
skip?: number, skip?: number,
} }
@@ -126,23 +126,61 @@ namespace Assert {
export function grid( export function grid(
config: Config, config: Config,
tilingArea: QmlRect, tilingArea: QmlRect,
columnWidth: number, columnWidths: number[] | number,
grid: KwinClient[][], grid: MockKwinClient[][],
centered: boolean, centered: boolean,
stackedColumns: number[] = [], stackedColumns: number[] = [],
{ message, skip=0 }: Options = {}, { message, skip=0 }: Options = {},
) { ) {
const nColumns = grid.length; const nColumns = grid.length;
const columnsWidth = nColumns * columnWidth + (nColumns-1) * config.gapsInnerHorizontal; function getGridWidth() {
function getColumnsWidth() {
if (columnWidths instanceof Array) {
let columnsWidth = 0;
for (const columnWidth of columnWidths) {
columnsWidth += columnWidth;
}
return columnsWidth;
} else {
return nColumns * columnWidths;
}
}
const gapsWidth = (nColumns-1) * config.gapsInnerHorizontal;
return getColumnsWidth() + gapsWidth;
}
function getColumnWidth(column: number) {
if (columnWidths instanceof Array) {
return columnWidths[column];
} else {
return columnWidths;
}
}
const gridWidth = getGridWidth();
const startX = centered ? const startX = centered ?
tilingArea.x + (tilingArea.width - columnsWidth) / 2 : tilingArea.x + (tilingArea.width - gridWidth) / 2 :
grid[0][0].frameGeometry.x; grid[0][0].getActualFrameGeometry().x;
function getColumnX(column: number) {
if (columnWidths instanceof Array) {
let x = startX;
for (let i = 0; i < column; i++) {
x += columnWidths[i] + config.gapsInnerHorizontal;
}
return x;
} else {
return startX + column * (columnWidths + config.gapsInnerHorizontal);
}
}
// assumes uniformly sized windows within columns of uniform width // assumes uniformly sized windows within columns of uniform width
function getRectInGrid(column: number, window: number, nColumns: number, nWindows: number) { function getRectInGrid(column: number, window: number, nColumns: number, nWindows: number) {
const columnWidth = getColumnWidth(column);
const windowHeight = (tilingArea.height - config.gapsInnerVertical * (nWindows-1)) / nWindows; const windowHeight = (tilingArea.height - config.gapsInnerVertical * (nWindows-1)) / nWindows;
return new MockQmlRect( return new MockQmlRect(
startX + column * (columnWidth + config.gapsInnerHorizontal), getColumnX(column),
tilingArea.y + (windowHeight + config.gapsInnerVertical) * window, tilingArea.y + (windowHeight + config.gapsInnerVertical) * window,
columnWidth, columnWidth,
(tilingArea.height - config.gapsInnerVertical * (nWindows-1)) / nWindows, (tilingArea.height - config.gapsInnerVertical * (nWindows-1)) / nWindows,
@@ -150,9 +188,9 @@ namespace Assert {
} }
function getRectInGridStacked(column: number, window: number, nColumns: number, nWindows: number) { function getRectInGridStacked(column: number, window: number, nColumns: number, nWindows: number) {
const columnX = startX + column * (columnWidth + config.gapsInnerHorizontal); const columnWidth = getColumnWidth(column);
return new MockQmlRect( return new MockQmlRect(
columnX + window * config.stackOffsetX, getColumnX(column) + window * config.stackOffsetX,
tilingArea.y + window * config.stackOffsetY, tilingArea.y + window * config.stackOffsetY,
columnWidth - (nWindows-1) * config.stackOffsetX, columnWidth - (nWindows-1) * config.stackOffsetX,
tilingArea.height - (nWindows-1) * config.stackOffsetY, tilingArea.height - (nWindows-1) * config.stackOffsetY,
@@ -167,7 +205,7 @@ namespace Assert {
for (let iWindow = 0; iWindow < nWindows; iWindow++) { for (let iWindow = 0; iWindow < nWindows; iWindow++) {
const window = column[iWindow]; const window = column[iWindow];
equalRects( equalRects(
window.frameGeometry, window.getActualFrameGeometry(),
getRect(iColumn, iWindow, nColumns, nWindows), getRect(iColumn, iWindow, nColumns, nWindows),
{ message: appendMessage(`column ${iColumn}, window ${iWindow}`, message), skip: skip+1 }, { message: appendMessage(`column ${iColumn}, window ${iWindow}`, message), skip: skip+1 },
); );
@@ -178,13 +216,13 @@ namespace Assert {
export function centered( export function centered(
config: Config, config: Config,
tilingArea: QmlRect, tilingArea: QmlRect,
client:KwinClient, client:MockKwinClient,
{ message, skip=0 }: Options = {}, { message, skip=0 }: Options = {},
) { ) {
grid( grid(
config, config,
tilingArea, tilingArea,
client.frameGeometry.width, client.getActualFrameGeometry().width,
[[client]], [[client]],
true, true,
[], [],
@@ -197,7 +235,7 @@ namespace Assert {
{ message, skip=0 }: Options = {}, { message, skip=0 }: Options = {},
) { ) {
assert( assert(
rect.left >= tilingArea.left && rect.right <= tilingArea.right, rect.x >= tilingArea.x && rectRight(rect) <= rectRight(tilingArea),
{ {
message: appendMessage(`Rect ${rect} not fully visible`, message), message: appendMessage(`Rect ${rect} not fully visible`, message),
skip: skip + 1, skip: skip + 1,
@@ -210,7 +248,7 @@ namespace Assert {
{ message, skip=0 }: Options = {}, { message, skip=0 }: Options = {},
) { ) {
assert( assert(
rect.left < tilingArea.left || rect.right > tilingArea.right, rect.x < tilingArea.x || rectRight(rect) > rectRight(tilingArea),
{ {
message: appendMessage(`Rect ${rect} is fully visible, but shouldn't be`, message), message: appendMessage(`Rect ${rect} is fully visible, but shouldn't be`, message),
skip: skip + 1, skip: skip + 1,
@@ -219,18 +257,18 @@ namespace Assert {
} }
export function columnsFillTilingArea( export function columnsFillTilingArea(
columns: KwinClient[], columns: MockKwinClient[],
{ message, skip=0 }: Options = {}, { message, skip=0 }: Options = {},
) { ) {
const options = { message: message, skip: skip+1 }; const options = { message: message, skip: skip+1 };
let x = tilingArea.left; let x = tilingArea.x;
for (const column of columns) { for (const column of columns) {
const width = column.frameGeometry.width; const width = column.getActualFrameGeometry().width;
fullyVisible(column.frameGeometry, options); fullyVisible(column.getActualFrameGeometry(), options);
rect(column.frameGeometry, x, tilingArea.top, width, tilingArea.height, options); rect(column.getActualFrameGeometry(), x, tilingArea.y, width, tilingArea.height, options);
x += width + gapH; x += width + gapH;
} }
equal(columns[columns.length-1].frameGeometry.right, tilingArea.right, options); equal(rectRight(columns[columns.length-1].getActualFrameGeometry()), rectRight(tilingArea), options);
} }
export function tiledClient( export function tiledClient(

View File

@@ -16,7 +16,7 @@ class TestRunner {
} }
namespace TestRunner { namespace TestRunner {
export type Test = { export interface Test {
name: string, name: string,
count: number, count: number,
f: () => void, f: () => void,

View File

@@ -2,8 +2,10 @@ let Qt: Qt;
let KWin: KWin; let KWin: KWin;
let Workspace: Workspace; let Workspace: Workspace;
let qmlBase: QmlObject; let qmlBase: QmlObject;
let notificationInvalidTiledDesktops: Notification;
let notificationInvalidWindowRules: Notification; let notificationInvalidWindowRules: Notification;
let notificationInvalidPresetWidths: Notification; let notificationInvalidPresetWidths: Notification;
let moveCursorToFocus: DBusCall;
let screen: MockQmlRect; let screen: MockQmlRect;
let tilingArea: MockQmlRect; let tilingArea: MockQmlRect;
@@ -28,14 +30,23 @@ function init(config: Config) {
Qt = qtMock; Qt = qtMock;
Workspace = workspaceMock; Workspace = workspaceMock;
moveCursorToFocus = {
__brand: "QmlObject",
call: () => {
Assert.assert(Workspace.activeWindow !== null, { message: "moveCursorToFocus should never be called if there's no focused window" });
const frame = (Workspace.activeWindow! as MockKwinClient).getActualFrameGeometry();
workspaceMock.cursorPos.x = Math.floor(frame.x + frame.width/2);
workspaceMock.cursorPos.y = Math.floor(frame.y + frame.height/2);
},
};
const world = new World(config); const world = new World(config);
return { qtMock, workspaceMock, world }; return { qtMock, workspaceMock, world };
} }
function getGridBounds(clientLeft: KwinClient, clientRight: KwinClient) { function getGridBounds(clientLeft: MockKwinClient, clientRight: MockKwinClient) {
const columnsWidth = clientRight.frameGeometry.right - clientLeft.frameGeometry.left; const columnsWidth = rectRight(clientRight.getActualFrameGeometry()) - clientLeft.getActualFrameGeometry().x;
const left = tilingArea.left + Math.floor((tilingArea.width - columnsWidth) / 2); const left = tilingArea.x + Math.floor((tilingArea.width - columnsWidth) / 2);
const right = left + columnsWidth; const right = left + columnsWidth;
return { left, right }; return { left, right };
} }
@@ -51,3 +62,10 @@ function getClientManager(world: World): ClientManager {
world.do((cm, dm) => clientManager = cm); world.do((cm, dm) => clientManager = cm);
return clientManager!; return clientManager!;
} }
function activateRandomWindowOnDesktop(desktop: KwinDesktop) {
const windows = Workspace.windows.filter(w => w.desktops.includes(desktop));
if (windows.length > 0) {
Workspace.activeWindow = randomItem(windows);
}
}

View File

@@ -4,10 +4,10 @@ class MockKwinClient {
private static readonly borderThickness = 10; private static readonly borderThickness = 10;
public caption = "App"; public caption = "App";
public minSize: Readonly<QmlSize> = new MockQmlSize(0, 0); public minSize: Readonly<QmlSize> = new MockQmlSize(randomJitter(), randomJitter());
public readonly transient: boolean; public readonly transient: boolean;
public move: boolean = false; public move = false;
public resize: boolean = false; public resize = false;
public readonly fullScreenable: boolean = true; public readonly fullScreenable: boolean = true;
public readonly maximizable: boolean = true; public readonly maximizable: boolean = true;
public readonly output: Output = { __brand: "Output" }; public readonly output: Output = { __brand: "Output" };
@@ -18,17 +18,17 @@ class MockKwinClient {
public readonly popupWindow: boolean = false; public readonly popupWindow: boolean = false;
public readonly pid = 1; public readonly pid = 1;
private _maximizedVertically: boolean = false; private _maximizedVertically = false;
private _maximizedHorizontally: boolean = false; private _maximizedHorizontally = false;
private _fullScreen: boolean = false; private _fullScreen = false;
public activities: string[] = []; public activities: string[] = [];
public skipSwitcher: boolean = false; public skipSwitcher = false;
public keepAbove: boolean = false; public keepAbove = false;
public keepBelow: boolean = false; public keepBelow = false;
private _minimized: boolean = false; private _minimized = false;
private _desktops: KwinDesktop[] = []; private _desktops: KwinDesktop[] = [];
private _tile: Tile|null = null; private _tile: Tile|null = null;
public opacity: number = 1.0; public opacity = 1.0;
public readonly fullScreenChanged = new MockQSignal<[]>(); public readonly fullScreenChanged = new MockQSignal<[]>();
public readonly desktopsChanged = new MockQSignal<[]>(); public readonly desktopsChanged = new MockQSignal<[]>();
@@ -42,8 +42,8 @@ class MockKwinClient {
public readonly frameGeometryChanged = new MockQSignal<[oldGeometry: QmlRect]>(); public readonly frameGeometryChanged = new MockQSignal<[oldGeometry: QmlRect]>();
private windowedFrameGeometry: MockQmlRect; private windowedFrameGeometry: MockQmlRect;
private windowed: boolean = true; private windowed = true;
private hasBorder: boolean = true; private hasBorder = true;
constructor( constructor(
private _frameGeometry: MockQmlRect = new MockQmlRect(10, 10, 100, 200), private _frameGeometry: MockQmlRect = new MockQmlRect(10, 10, 100, 200),
@@ -52,6 +52,7 @@ class MockKwinClient {
this.windowedFrameGeometry = _frameGeometry.clone(); this.windowedFrameGeometry = _frameGeometry.clone();
this.transient = transientFor !== null; this.transient = transientFor !== null;
this._desktops = [Workspace.currentDesktop]; this._desktops = [Workspace.currentDesktop];
this.activities = [Workspace.currentActivity];
} }
setMaximize(vertically: boolean, horizontally: boolean) { setMaximize(vertically: boolean, horizontally: boolean) {
@@ -68,7 +69,7 @@ class MockKwinClient {
horizontally ? MaximizedMode.Maximized : MaximizedMode.Vertically horizontally ? MaximizedMode.Maximized : MaximizedMode.Vertically
) : ( ) : (
horizontally ? MaximizedMode.Horizontally : MaximizedMode.Unmaximized horizontally ? MaximizedMode.Horizontally : MaximizedMode.Unmaximized
) ),
); );
this.frameGeometry = new MockQmlRect( this.frameGeometry = new MockQmlRect(
@@ -88,7 +89,15 @@ class MockKwinClient {
this.frameGeometry.height - 2 * MockKwinClient.borderThickness, this.frameGeometry.height - 2 * MockKwinClient.borderThickness,
); );
} else { } else {
return this.frameGeometry; return runOneOf(
() => this.frameGeometry,
() => new MockQmlRect(
this.frameGeometry.x - 20,
this.frameGeometry.y - 20,
this.frameGeometry.width + 40,
this.frameGeometry.height + 40,
), // some full-screen windows that manage their own window decorations can temporarily have a client geometry bigger than the screen
);
} }
} }
@@ -107,6 +116,7 @@ class MockKwinClient {
public set fullScreen(fullScreen: boolean) { public set fullScreen(fullScreen: boolean) {
const oldFullScreen = this._fullScreen; const oldFullScreen = this._fullScreen;
this.hasBorder = !fullScreen; this.hasBorder = !fullScreen;
const targetFrameGeometry = fullScreen ? screen : this.windowedFrameGeometry;
runReorder( runReorder(
() => { () => {
@@ -118,42 +128,54 @@ class MockKwinClient {
() => { () => {
if (oldFullScreen && !fullScreen) { if (oldFullScreen && !fullScreen) {
// when switching from full-screen to windowed, Kwin sometimes first adds the frame before changing the frameGeometry to the final value // when switching from full-screen to windowed, Kwin sometimes first adds the frame before changing the frameGeometry to the final value
if (rectEquals(this.frameGeometry, this.windowedFrameGeometry)) { if (!rectEquals(this.frameGeometry, screen)) {
// already has windowed frame geometry, don't undo that // already has windowed frame geometry, don't undo that
return; return;
} }
runOneOf( runOneOf(
() => this.frameGeometry = new MockQmlRect( () => {
0, this.frameGeometry = new MockQmlRect(
0, 0,
screen.width + 2 * MockKwinClient.borderThickness, 0,
screen.height + 2 * MockKwinClient.borderThickness, screen.width + 2 * MockKwinClient.borderThickness,
), screen.height + 2 * MockKwinClient.borderThickness,
() => this.frameGeometry = new MockQmlRect( );
-MockKwinClient.borderThickness, },
-MockKwinClient.borderThickness, () => {
screen.width + 2 * MockKwinClient.borderThickness, this.frameGeometry = new MockQmlRect(
screen.height + 2 * MockKwinClient.borderThickness, -MockKwinClient.borderThickness,
), -MockKwinClient.borderThickness,
screen.width + 2 * MockKwinClient.borderThickness,
screen.height + 2 * MockKwinClient.borderThickness,
);
},
() => {}, () => {},
); );
} }
}, },
() => { () => {
this.windowed = !fullScreen; this.windowed = !fullScreen;
if (fullScreen) { this.frameGeometry = targetFrameGeometry;
this.frameGeometry = screen;
} else {
this.frameGeometry = this.windowedFrameGeometry;
}
}, },
); );
} }
public get frameGeometry() { // for assertions
public getActualFrameGeometry() {
return this._frameGeometry; return this._frameGeometry;
} }
// for Karousel
public get frameGeometry() {
return new MockQmlRect(
this._frameGeometry.x + randomJitter(),
this._frameGeometry.y + randomJitter(),
this._frameGeometry.width + randomJitter(),
this._frameGeometry.height + randomJitter(),
this.frameGeometryChanged.fire.bind(this.frameGeometryChanged),
);
}
public set frameGeometry(frameGeometry: MockQmlRect) { public set frameGeometry(frameGeometry: MockQmlRect) {
const oldFrameGeometry = this._frameGeometry; const oldFrameGeometry = this._frameGeometry;
this._frameGeometry = new MockQmlRect( this._frameGeometry = new MockQmlRect(
@@ -189,9 +211,20 @@ class MockKwinClient {
this.desktopsChanged.fire(); this.desktopsChanged.fire();
if (Workspace.activeWindow === this && !desktops.includes(Workspace.currentDesktop)) { if (Workspace.activeWindow === this && !desktops.includes(Workspace.currentDesktop)) {
Workspace.activeWindow = null; Workspace.activeWindow = null;
runMaybe(() => Workspace.activeWindow = null); // fired again for some reason
if (Workspace.activeWindow === null) {
activateRandomWindowOnDesktop(Workspace.currentDesktop);
}
}; };
} }
public moveAndFollowToDesktop(desktop: KwinDesktop, workspaceMock: MockWorkspace) {
Assert.assert(workspaceMock.activeWindow === this);
this._desktops = [desktop];
this.desktopsChanged.fire();
workspaceMock.currentDesktop = desktop;
}
public get tile() { public get tile() {
return this._tile; return this._tile;
} }

View File

@@ -1,7 +1,7 @@
class MockQSignal<T extends unknown[]> { class MockQSignal<T extends unknown[]> {
public readonly __brand = "QSignal"; public readonly __brand = "QSignal";
private readonly handlers: Set<(...args: [...T]) => void> = new Set(); private readonly handlers = new Set<(...args: [...T]) => void>();
public connect(handler: (...args: [...T]) => void) { public connect(handler: (...args: [...T]) => void) {
this.handlers.add(handler); this.handlers.add(handler);

View File

@@ -5,4 +5,11 @@ class MockQmlPoint {
public x: number, public x: number,
public y: number, public y: number,
) {} ) {}
public clone() {
return new MockQmlPoint(
this.x,
this.y,
);
}
} }

View File

@@ -49,22 +49,6 @@ class MockQmlRect {
this.onChanged(oldRect); this.onChanged(oldRect);
} }
public get top() {
return this.y;
}
public get bottom() {
return this.y + this.height;
}
public get left() {
return this.x;
}
public get right() {
return this.x + this.width;
}
public set(target: QmlRect) { public set(target: QmlRect) {
const oldRect = this.clone(); const oldRect = this.clone();
this._x = target.x; this._x = target.x;

View File

@@ -3,15 +3,15 @@ class MockWorkspace {
public activities = ["test-activity"]; public activities = ["test-activity"];
public desktops: KwinDesktop[] = [ public desktops: KwinDesktop[] = [
{ __brand: "KwinDesktop", id: "desktop1" }, { __brand: "KwinDesktop", id: "desktop1", name: "Desktop 1" },
{ __brand: "KwinDesktop", id: "desktop2" } { __brand: "KwinDesktop", id: "desktop2", name: "Desktop 2" },
]; ];
public currentDesktop = this.desktops[0];
public currentActivity = this.activities[0]; public currentActivity = this.activities[0];
public activeScreen: Output = { __brand: "Output" }; public activeScreen: Output = { __brand: "Output" };
public readonly windows: MockKwinClient[] = []; public readonly windows: MockKwinClient[] = [];
public cursorPos = new MockQmlPoint(0, 0); public cursorPos = new MockQmlPoint(0, 0);
private _currentDesktop = this.desktops[0];
private _activeWindow: KwinClient|null = null; private _activeWindow: KwinClient|null = null;
public readonly currentDesktopChanged = new MockQSignal<[]>(); public readonly currentDesktopChanged = new MockQSignal<[]>();
@@ -52,13 +52,13 @@ class MockWorkspace {
} }
public removeWindow(window: MockKwinClient) { public removeWindow(window: MockKwinClient) {
this.activeWindow = null;
runReorder( runReorder(
() => this.windows.splice(this.windows.indexOf(window), 1), () => this.windows.splice(this.windows.indexOf(window), 1),
() => this.windowRemoved.fire(window), () => this.windowRemoved.fire(window),
); );
if (window === this.activeWindow) { if (this.activeWindow === null) {
const windows = this.windows.filter(w => w.desktops.includes(this.currentDesktop)); activateRandomWindowOnDesktop(this.currentDesktop);
Workspace.activeWindow = windows.length > 0 ? randomItem(windows) : null;
}; };
} }
@@ -75,7 +75,7 @@ class MockWorkspace {
frame.y += delta.y; frame.y += delta.y;
} }
runOneOf( runOneOf(
() => window.frameGeometry.set(frame), () => window.getActualFrameGeometry().set(frame),
() => window.frameGeometry = frame, () => window.frameGeometry = frame,
); );
} }
@@ -88,8 +88,8 @@ class MockWorkspace {
const frame = window.getFrameGeometryCopy(); const frame = window.getFrameGeometryCopy();
if (edgeResize) { if (edgeResize) {
this.cursorPos = new MockQmlPoint( this.cursorPos = new MockQmlPoint(
leftEdge ? frame.left : frame.right, leftEdge ? frame.x : rectRight(frame),
topEdge ? frame.top : frame.bottom, topEdge ? frame.y : rectBottom(frame),
); );
} else { } else {
this.cursorPos = new MockQmlPoint( this.cursorPos = new MockQmlPoint(
@@ -114,7 +114,7 @@ class MockWorkspace {
} }
} }
runOneOf( runOneOf(
() => window.frameGeometry.set(frame), () => window.getActualFrameGeometry().set(frame),
() => window.frameGeometry = frame, () => window.frameGeometry = frame,
); );
} }
@@ -123,6 +123,15 @@ class MockWorkspace {
window.interactiveMoveResizeFinished.fire(); window.interactiveMoveResizeFinished.fire();
} }
public get currentDesktop() {
return this._currentDesktop;
}
public set currentDesktop(currentDesktop: KwinDesktop) {
this._currentDesktop = currentDesktop;
this.currentDesktopChanged.fire();
}
public get activeWindow() { public get activeWindow() {
return this._activeWindow; return this._activeWindow;
} }

View File

@@ -4,10 +4,10 @@ function runMaybe(f: () => void) {
} }
} }
function runOneOf(...fs: (() => void)[]) { function runOneOf<T>(...fs: (() => T)[]) {
const index = randomInt(fs.length); const index = randomInt(fs.length);
runLog.push(`${getStackFrame(1)} - Chose ${index}`); runLog.push(`${getStackFrame(1)} - Chose ${index}`);
fs[index](); return fs[index]();
} }
function runReorder(...fs: (() => void)[]) { function runReorder(...fs: (() => void)[]) {
@@ -22,6 +22,20 @@ function runReorder(...fs: (() => void)[]) {
} }
} }
function runReorderDebug(order: number[], ...fs: (() => void)[]) {
for (const index of order) {
fs[index]();
}
}
function randomJitter() {
if (Math.random() < 0.25) {
return (Math.random() - 0.5) * 0.5;
} else {
return 0;
}
}
function randomInt(n: number) { function randomInt(n: number) {
return Math.floor(Math.random() * n); return Math.floor(Math.random() * n);
} }