mirror of
https://github.com/fish-shell/fish-shell.git
synced 2026-06-30 07:01:22 -03:00
ce631fd2fb
Add a new underline-color option to set_color (instead of adding an optional color argument to --underline); this allows to set the underline color independently of underline style (line, curly, etc.). I don't think this flexibility is very important but this approach is probably the least hacky. Note that there are two variants: 1. \e[58:5:1m 2. \e[58;5;1m Variant 1 breaks: breakage from colon-variant for colored underlines - cool-retro-term makes text blink - GNU screen (goes into bold mode) - terminology (goes into bold mode) Variant 2 would break: - mintty (Cygwin terminal) -- it enables bold font instead. - Windows Terminal (where it paints the foreground yellow) - JetBrains terminals echo the colons instead of consuming them - putty - GNU screen (goes into bold mode) - st - urxvt - xterm - etc. So choose variant 1. Closes #11388 Closes #7619