mirror of
https://github.com/fish-shell/fish-shell.git
synced 2026-05-11 02:51:15 -03:00
781791c00c
By default, we make every rustup user use our pinned version. This might not be ideal at this point, for a few reasons: 1. we don't have automatic Rust updates yet (see the parent commit), so this might unnecessarily install an old version. As a contributor, this feels irritating (newer versions are usually strictly better). 2. it will use more bandwidth and perhaps other resources during "git-bisect" scenarios 3. somehow rustup will download things redundantly; it will download "1.89.0" and "stable" even if they are identical. The user will need to clean those up at some point, even if they didn't add them explicitly. See also https://github.com/fish-shell/fish-shell/pull/11712#issuecomment-3165388330 Part of the motivation for rust-toolchain.toml is probably the regular (every 6 weeks) failures due to the update check, but that failure has been removed in the parent commit. The other motivation ("fix the issue of local compiles running into lint warnings from newer compilers") is a fair point but I think we should rather fix warnings quickly. Let's remove rust-toolchain.toml again until we have more agreement on what we should do. This reverts commits *f806d35af8(Ignore rust-toolchain.toml in CI, 2025-08-07) *9714b98262(Explicitly use fully qualified rust version numbers, 2025-08-07) *921aaa0786(Add rust-toolchain.toml, 2025-08-07) Closes #11718
23 lines
531 B
YAML
23 lines
531 B
YAML
name: Oldest Supported Rust Toolchain
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
targets:
|
|
description: Comma-separated list of target triples to install for this toolchain
|
|
required: false
|
|
components:
|
|
description: Comma-separated list of components to be additionally installed
|
|
required: false
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- uses: dtolnay/rust-toolchain@1.70
|
|
with:
|
|
targets: ${{ inputs.targets }}
|
|
components: ${{ inputs.components}}
|