mirror of
https://github.com/fish-shell/fish-shell.git
synced 2026-05-18 17:11:15 -03:00
3e7e57945c
Replace the `build_tools/style.fish` script by an xtask. This eliminates the need for a fish binary for performing the formatting/checking. The `fish_indent` binary is still needed. Eventually, this should be made available as a library function, so the xtask can use that instead of requiring a `fish_indent` binary in the `$PATH`. The new xtask is called `format` rather than `style`, because that's a more fitting description of what it does (and what the script it replaces did). The old script's behavior is not replicated exactly: - Specifying `--all` and explicit paths is supported within a single invocation. - Explicit arguments no longer have to be files. If a directory is specified, all files within it will be considered. - The git check for un-staged changes is no longer filtered by file names, mainly to simplify the implementation. - A warning is now printed if neither the `--all` flag nor a path are provided as arguments. The reason for this is that one might assume that omitting these arguments would default to formatting everything in the current directory, but instead no formatting will happen in this case. - The wording of some messages is different. The design of the new code tries to make it easy to add formatters for additional languages, or change the ones we already have. This is achieved by separating the code into one function per language, which can be modified without touching the code for the other languages. Adding support for a new formatter/language only requires adding a function which builds the formatter command line based on the arguments to the xtask, and calling that function from the main `format` function. Closes #12467