h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-16 10:11:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

finish cleanup of signal blocking code

Browse Source 
PR #3691 made most calls to `signal_block()` and `signal_unblock()`
no-ops unless a magic env var is set when fish starts running. It's
been seven months since that change was made and no problems have been
reported. This finishes that work by removing those no-op function calls
and support for the magic env var in our next major release (which won't
happen till at least six months from now).
This commit is contained in:
Kurtis Rader
2017-07-26 13:51:00 -07:00
parent 34c2bf0f55
commit fb08fe5f47
8 changed files with 18 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/fish.cpp
View File

@@ -387,13 +387,6 @@ int main(int argc, char **argv) {
const io_chain_t empty_ios;
if (read_init(paths)) {
// TODO: Remove this once we're confident that not blocking/unblocking every signal around
// some critical sections is no longer necessary.
env_var_t fish_no_signal_block = env_get_string(L"FISH_NO_SIGNAL_BLOCK");
if (!fish_no_signal_block.missing_or_empty() && !from_string<bool>(fish_no_signal_block)) {
ignore_signal_block = false;
}
// Stomp the exit status of any initialization commands (issue #635).
proc_set_last_status(STATUS_CMD_OK);