From f7d9c92820a684eb0c7e7354ee17cead9c8d03cb Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Mon, 12 Jan 2026 10:44:01 +0100 Subject: [PATCH] git_version_gen: don't silence stderr This should never fail, and error output doesn't hurt here. --- build_tools/make_macos_pkg.sh | 2 +- build_tools/make_tarball.sh | 2 +- build_tools/make_vendor_tarball.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build_tools/make_macos_pkg.sh b/build_tools/make_macos_pkg.sh index f9b73003d..55500e4bd 100755 --- a/build_tools/make_macos_pkg.sh +++ b/build_tools/make_macos_pkg.sh @@ -49,7 +49,7 @@ if [ -n "$NOTARIZE" ] && [ -z "$API_KEY_FILE" ]; then usage fi -VERSION=$(build_tools/git_version_gen.sh 2>/dev/null) +VERSION=$(build_tools/git_version_gen.sh) echo "Version is $VERSION" diff --git a/build_tools/make_tarball.sh b/build_tools/make_tarball.sh index da288178f..b610d7b93 100755 --- a/build_tools/make_tarball.sh +++ b/build_tools/make_tarball.sh @@ -7,7 +7,7 @@ set -e # Get the version -VERSION=$(build_tools/git_version_gen.sh 2>/dev/null) +VERSION=$(build_tools/git_version_gen.sh) prefix=fish-$VERSION path=${FISH_ARTEFACT_PATH:-~/fish_built}/$prefix.tar.xz diff --git a/build_tools/make_vendor_tarball.sh b/build_tools/make_vendor_tarball.sh index a80c7504b..0d3f7a28f 100755 --- a/build_tools/make_vendor_tarball.sh +++ b/build_tools/make_vendor_tarball.sh @@ -26,7 +26,7 @@ fi wd="$PWD" # Get the version from git-describe -VERSION=$(build_tools/git_version_gen.sh 2>/dev/null) +VERSION=$(build_tools/git_version_gen.sh) # The name of the prefix, which is the directory that you get when you untar prefix="fish-$VERSION"