h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-07-02 09:11:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Introduce get_by_sorted_name

Browse Source 
Given that we have several lists of things sorted by name, replace a
bunch of ad-hoc lower_bound calls with a single function.
This commit is contained in:
ridiculousfish
2021-08-26 13:40:02 -07:00
parent ee2d2caeaa
commit f577c221eb
6 changed files with 39 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/fish_tests.cpp
View File

@@ -1705,6 +1705,18 @@ static void test_is_sorted_by_name() {
{L"a"}, {L"aa"}, {L"aaa"}, {L"aaa"}, {L"aaa"}, {L"aazz"}, {L"aazzzz"},
};
static_assert(is_sorted_by_name(sorted), "is_sorted_by_name failure");
do_test(get_by_sorted_name(L"", sorted) == nullptr);
do_test(get_by_sorted_name(L"nope", sorted) == nullptr);
do_test(get_by_sorted_name(L"aaaaaaaaaaa", sorted) == nullptr);
wcstring last;
for (const auto &v : sorted) {
// We have multiple items with the same name; only test the first.
if (last != v.name) {
last = v.name;
do_test(get_by_sorted_name(last, sorted) == &v);
}
}
static constexpr named_t not_sorted[] = {
{L"a"}, {L"aa"}, {L"aaa"}, {L"q"}, {L"aazz"}, {L"aazz"}, {L"aazz"}, {L"aazzzz"},
};