From f407ca18a4695eda5be2b251e355329854d3e4e1 Mon Sep 17 00:00:00 2001 From: Daniel Rainer Date: Mon, 19 Jan 2026 17:46:58 +0100 Subject: [PATCH] docs: fix doc dir computation `FISH_CMAKE_BINARY_DIR` is the top-level CMake output directory, not its subdirectory used as the target directory by Cargo. So far, this has not caused issues because CMake builds explicitly call `sphinx-build` to build the man pages, instead of using the Rust crate for embedding them. Closes #12354 --- crates/build-helper/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/build-helper/src/lib.rs b/crates/build-helper/src/lib.rs index ec675d182..4c3667068 100644 --- a/crates/build-helper/src/lib.rs +++ b/crates/build-helper/src/lib.rs @@ -35,7 +35,7 @@ pub fn fish_build_dir() -> Cow<'static, Path> { } pub fn fish_doc_dir() -> Cow<'static, Path> { - fish_build_dir().join("fish-docs").into() + cargo_target_dir().join("fish-docs").into() } // TODO Move this to rsconf