From f24f952991465a852fe9d23767eef11ca0632f9c Mon Sep 17 00:00:00 2001 From: ridiculousfish Date: Sat, 22 Aug 2020 12:04:47 -0700 Subject: [PATCH] Use in-line initialization for page_renderint_t's constructor --- src/pager.cpp | 11 +---------- src/pager.h | 22 +++++++++++----------- 2 files changed, 12 insertions(+), 21 deletions(-) diff --git a/src/pager.cpp b/src/pager.cpp index 006062036..1132467bb 100644 --- a/src/pager.cpp +++ b/src/pager.cpp @@ -856,13 +856,4 @@ size_t pager_t::cursor_position() const { } // Constructor -page_rendering_t::page_rendering_t() - : term_width(-1), - term_height(-1), - rows(0), - cols(0), - row_start(0), - row_end(0), - selected_completion_idx(-1), - remaining_to_disclose(0), - search_field_shown(false) {} +page_rendering_t::page_rendering_t() = default; diff --git a/src/pager.h b/src/pager.h index 8160df1ce..426dd61a4 100644 --- a/src/pager.h +++ b/src/pager.h @@ -19,19 +19,19 @@ /// Represents rendering from the pager. class page_rendering_t { public: - size_t term_width; - size_t term_height; - size_t rows; - size_t cols; - size_t row_start; - size_t row_end; - size_t selected_completion_idx; - screen_data_t screen_data; + size_t term_width{size_t(-1)}; + size_t term_height{size_t(-1)}; + size_t rows{0}; + size_t cols{0}; + size_t row_start{0}; + size_t row_end{0}; + size_t selected_completion_idx{size_t(-1)}; + screen_data_t screen_data{}; - size_t remaining_to_disclose; + size_t remaining_to_disclose{0}; - bool search_field_shown; - editable_line_t search_field_line; + bool search_field_shown{false}; + editable_line_t search_field_line{}; // Returns a rendering with invalid data, useful to indicate "no rendering". page_rendering_t();