From e628ba51e7ba42325b194373a0972e7d9ce805ce Mon Sep 17 00:00:00 2001
From: Mahmoud Al-Qudsi <mqudsi@neosmart.net>
Date: Sat, 4 Jul 2020 20:38:06 -0500
Subject: [PATCH] Remove repeated calculation of fixed string's length in a
 loop

---
 src/output.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/output.cpp b/src/output.cpp
index 8b35dd877..5b9a295b7 100644
--- a/src/output.cpp
+++ b/src/output.cpp
@@ -474,14 +474,17 @@ rgb_color_t parse_color(const env_var_t &var, bool is_background) {
 
     std::vector<rgb_color_t> candidates;
 
+    static const wchar_t *prefix = L"--background=";
+    // wcslen is not available as constexpr
+    static auto prefix_len = wcslen(prefix);
+
     wcstring color_name;
     for (const wcstring &next : var.as_list()) {
         color_name.clear();
         if (is_background) {
             // Look for something like "--background=red".
-            const wchar_t *prefix = L"--background=";
             if (string_prefixes_string(prefix, next)) {
-                color_name = wcstring(next, wcslen(prefix));
+                color_name = wcstring(next, prefix_len);
             }
             // Reverse should be meaningful in either context
             if (next == L"--reverse" || next == L"-r") {