From e2a0b0e2b8899f88d2c0073c9e6a1e1381522217 Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Wed, 19 Feb 2025 10:17:41 +0100 Subject: [PATCH] Fix off-by-one error in new commandline --column parse_util_lineno() returns 1-based line numbers but parse_util_get_offset_from_line() expects zero based line offsets. Fixes #11162 (cherry picked from commit afbdb9f268fe369343142632013869a7e18a25d4) --- src/builtins/commandline.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/builtins/commandline.rs b/src/builtins/commandline.rs index 464ead432..2a84743df 100644 --- a/src/builtins/commandline.rs +++ b/src/builtins/commandline.rs @@ -475,7 +475,7 @@ pub fn commandline(parser: &Parser, streams: &mut IoStreams, args: &mut [&wstr]) rstate.cursor_pos + 1 - parse_util_get_offset_from_line( &rstate.text, - i32::try_from(parse_util_lineno(&rstate.text, rstate.cursor_pos)) + i32::try_from(parse_util_lineno(&rstate.text, rstate.cursor_pos) - 1) .unwrap(), ) .unwrap_or_default()