h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-15 14:41:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary string copy

Browse Source 
This called function_exists_no_autoload with a c_str().

Only that takes a wcstring, so the constructor gets called which
copies that.
This commit is contained in:
Fabian Homborg
2019-02-04 17:10:53 +01:00
parent eb8a93f499
commit ddfad001eb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/complete.cpp
View File

@@ -898,7 +898,7 @@ bool completer_t::complete_param(const wcstring &cmd_orig, const wcstring &popt,
bool head_exists = builtin_exists(cmd);
// Only reload environment variables if builtin_exists returned false, as an optimization
if (head_exists == false) {
head_exists = function_exists_no_autoload(cmd.c_str(), vars);
head_exists = function_exists_no_autoload(cmd, vars);
// While it may seem like first testing `path_get_path` before resorting to an env lookup
// may be faster, path_get_path can potentially do a lot of FS/IO access, so env.get() +
// function_exists() should still be faster.