From dd8e59db03767a1dc0722eb0ee599c48c5a02638 Mon Sep 17 00:00:00 2001 From: Daniel Rainer Date: Wed, 15 Apr 2026 02:05:41 +0200 Subject: [PATCH] fix: check if `system_tests` args are empty When `system_tests` is called without arguments, `[ -n "$@" ]` becomes `[ -n ]`, which is true, resulting in running `export`, which lists all exported variables, unnecessarily cluttering the output. If `system_tests` is called with more than one argument, the check would fail because having more than one argument after `-n` is invalid syntax. Fix this by using `$*`, which concatenates all positional arguments to `system_tests` into a single value. Part of #12636 --- build_tools/check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_tools/check.sh b/build_tools/check.sh index 14d444cac..c788e158f 100755 --- a/build_tools/check.sh +++ b/build_tools/check.sh @@ -124,7 +124,7 @@ fi # Using "()" not "{}" because we do want a subshell (for the export) system_tests() ( - [ -n "$@" ] && export "$@" + [ -n "$*" ] && export "$@" export FISH_GETTEXT_EXTRACTION_DIR="$gettext_template_dir" "$workspace_root/tests/test_driver.py" "$build_dir" )