h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-21 03:21:16 -03:00
Code Issues Packages Projects Releases Wiki Activity

bg/fg/wait/disown/function: check for negative PID argument

Browse Source 
While at it, extract a function.

Seems to have regressed in 4.0.0 (fc47d9fa1d (Use strongly typed
`Pid` for job control, 2024-11-11)).

Fixes #11929
This commit is contained in:
Johannes Altmanninger
2025-10-11 08:26:42 +02:00
parent 8fe402e9f7
commit da411f6fa7
25 changed files with 182 additions and 181 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/checks/function.fish
View File

@@ -147,7 +147,7 @@ rm -r $tmpdir
functions -e foo
function foo -p bar; end
# CHECKERR: {{.*}}function.fish (line {{\d+}}): function: bar: invalid process ID
# CHECKERR: {{.*}}function.fish (line {{\d+}}): function: 'bar' is not a valid process ID
# CHECKERR: function foo -p bar; end
# CHECKERR: ^~~~~~~~~~~~~~~~~~~^
@@ -214,4 +214,29 @@ end
outer 1 2 3
#CHECK: 1 2 3
for flag in --on-process-exit --on-job-exit
for invalid_pid in (math 2 ^ 31) -1 -(math 2 ^ 31)
function invalid $flag=$invalid_pid
end
end
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '2147483648' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '-1' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '-2147483648' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '2147483648' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '-1' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
# CHECKERR: {{.*}}/function.fish (line {{\d+}}): function: '-2147483648' is not a valid process ID
# CHECKERR: function invalid $flag=$invalid_pid
# CHECKERR: ^
end
exit 0