From d7581dbaa4aeaa361b142c78c337293a5ae332a3 Mon Sep 17 00:00:00 2001
From: Johannes Altmanninger <aclopte@gmail.com>
Date: Sat, 8 Nov 2025 11:05:44 +0100
Subject: [PATCH] CONTRIBUTING: remove Git pre-push hook

- this is not specific to fish and only relevant to people who push
  directly to master
- we don't push directly to master as often anymore
- I don't think we used it much in practice (when we should have).
- a good portion of contributions is pushed with jj which probably
  does this differently

Let's remove it even though this is a nice piece of documentation.
I guess we could add it back to doc_internal/ if we have the capacity
to maintain it.
---
 CONTRIBUTING.rst            | 38 -------------------------------------
 share/completions/help.fish |  2 --
 2 files changed, 40 deletions(-)

diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
index 52ea453f4..80d5f2fcd 100644
--- a/CONTRIBUTING.rst
+++ b/CONTRIBUTING.rst
@@ -236,44 +236,6 @@ Or you can run them on a fish, without involving cmake::
 Here, the first argument to test_driver.py refers to a directory with ``fish``, ``fish_indent`` and ``fish_key_reader`` in it.
 In this example we're in the root of the git repo and have run ``cargo build`` without ``--release``, so it's a debug build.
 
-Git hooks
----------
-
-Since developers sometimes forget to run the tests, it can be helpful to
-use git hooks (see githooks(5)) to automate it.
-
-One possibility is a pre-push hook script like this one:
-
-.. code:: sh
-
-   #!/bin/sh
-   #### A pre-push hook for the fish-shell project
-   # This will run the tests when a push to master is detected, and will stop that if the tests fail
-   # Save this as .git/hooks/pre-push and make it executable
-
-   protected_branch='master'
-
-   # Git gives us lines like "refs/heads/frombranch SOMESHA1 refs/heads/tobranch SOMESHA1"
-   # We're only interested in the branches
-   isprotected=false
-   while read from _ to _; do
-       if [ "$to" = "refs/heads/$protected_branch" ]; then
-           isprotected=true
-       fi
-   done
-   if "$isprotected"; then
-       echo "Running checks before push to master"
-       build_tools/check.sh
-   fi
-
-This will check if the push is to the master branch and, if it is, only
-allow the push if running ``build_tools/check.sh`` succeeds. In some circumstances
-it may be advisable to circumvent this check with
-``git push --no-verify``, but usually that isn’t necessary.
-
-To install the hook, place the code in a new file
-``.git/hooks/pre-push`` and make it executable.
-
 Contributing Translations
 =========================
 
diff --git a/share/completions/help.fish b/share/completions/help.fish
index a28af0c0f..1b9e33995 100644
--- a/share/completions/help.fish
+++ b/share/completions/help.fish
@@ -50,8 +50,6 @@ function __fish_help_describe -a help_item
             return
         case contributing#fish-script-style-guide
             return
-        case contributing#git-hooks
-            return
         case contributing#github
             return
         case contributing#guidelines