From d1c7a4b6e706314815b27c2cdf830aa26596675e Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Thu, 11 Dec 2025 10:38:26 +0100 Subject: [PATCH] Don't silence errors in fish_key_bindings/fish_user_key_bindings We silence erros from the key binding function since 2c5151bb786 (Fix bug in key binding code causing unneeded error messages, 2007-10-31). Reasons are 1. fish_key_bindings is not a valid function 2. fish_key_bindings runs "bind -k" for things that are not supported (#1155) Both reasons are obsolete: 1. we already check that earlier 2. "-k" is gone. (Also, we could have silenced "bind -k" invocations instead). --- share/functions/__fish_config_interactive.fish | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/share/functions/__fish_config_interactive.fish b/share/functions/__fish_config_interactive.fish index ce2aa3df4..4b168305a 100644 --- a/share/functions/__fish_config_interactive.fish +++ b/share/functions/__fish_config_interactive.fish @@ -117,11 +117,10 @@ end" >$__fish_config_dir/config.fish end set -g __fish_active_key_bindings "$fish_key_bindings" set -g fish_bind_mode default - # Redirect stderr per #1155 - $fish_key_bindings 2>/dev/null + $fish_key_bindings # Load user key bindings if they are defined if functions --query fish_user_key_bindings >/dev/null - fish_user_key_bindings 2>/dev/null + fish_user_key_bindings end end