From ca2b5dc40b14fc6968895e5e2181b433e55b0f46 Mon Sep 17 00:00:00 2001 From: Daniel Rainer Date: Sun, 19 Apr 2026 17:25:09 +0200 Subject: [PATCH] checks: run with all features enabled As discussed in #12649, we should check builds with all Cargo features enabled. Previously, this did cause issues with the `benchmark` feature, since that only works with nightly Rust. #12653 resolves that by only enabling the `benchmark` feature with the nightly toolchain, so now we can use `--all-features` with stable Rust. Closes #12657 --- .github/workflows/lint.yml | 2 ++ build_tools/check.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 927a3c559..fcd18686f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -32,6 +32,8 @@ jobs: features: "" - rust_version: "stable" features: "--no-default-features" + - rust_version: "stable" + features: "--all-features" - rust_version: "msrv" features: "" steps: diff --git a/build_tools/check.sh b/build_tools/check.sh index 017ec9769..3cd411372 100755 --- a/build_tools/check.sh +++ b/build_tools/check.sh @@ -99,7 +99,7 @@ if $lint; then cargo deny --all-features --locked --exclude-dev check licenses fi PATH="$build_dir:$PATH" cargo xtask format --all --check - for features in "" --no-default-features; do + for features in "" --no-default-features --all-features; do cargo clippy --workspace --all-targets $features done fi