From c145ee6df38a1b01bdb8b727a63b7b713355cc35 Mon Sep 17 00:00:00 2001 From: Daniel Rainer Date: Wed, 1 Oct 2025 01:19:33 +0200 Subject: [PATCH] Check exit status of `msgfmt` Prior to this, when `msgfmt` failed, this would be detected indirectly by the parser, which would then panic due to it input being empty. Explicit checking allows us to properly display `msgfmt`'s error message. Closes #11847 --- crates/gettext-maps/build.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/gettext-maps/build.rs b/crates/gettext-maps/build.rs index 35b62c935..25dea6952 100644 --- a/crates/gettext-maps/build.rs +++ b/crates/gettext-maps/build.rs @@ -97,6 +97,12 @@ fn embed_localizations(cache_dir: &Path) { .arg(&po_file_path) .output() .unwrap(); + if !output.status.success() { + panic!( + "msgfmt failed:\n{}", + String::from_utf8(output.stderr).unwrap() + ); + } let mo_data = output.stdout; // Extract map from MO data.