From bbb2f5aa14364cb31507d15d9966f0db4e70e12d Mon Sep 17 00:00:00 2001 From: ridiculousfish Date: Tue, 28 Dec 2021 21:35:30 -0800 Subject: [PATCH] Comment why certain tests are disabled under TSAN This makes it clear that it is due to a known limitation of TSan and not some lurking thread safety issue. --- tests/pexpects/bind_mode_events.py | 3 ++- tests/pexpects/cancel_event.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/pexpects/bind_mode_events.py b/tests/pexpects/bind_mode_events.py index d7ab5d675..4bed3c1f4 100644 --- a/tests/pexpects/bind_mode_events.py +++ b/tests/pexpects/bind_mode_events.py @@ -44,7 +44,8 @@ expect_prompt() timeout = 0.15 if "CI" in os.environ: - # This doesn't work under tsan. + # This doesn't work under TSan, because TSan prevents select() being + # interrupted by a signal. import sys print("SKIPPING the last of bind_mode_events.py") sys.exit(0) diff --git a/tests/pexpects/cancel_event.py b/tests/pexpects/cancel_event.py index c83efe857..ad6c7484c 100644 --- a/tests/pexpects/cancel_event.py +++ b/tests/pexpects/cancel_event.py @@ -16,7 +16,8 @@ expect_prompt() timeout = 0.15 if "CI" in os.environ: - # This doesn't work under tsan. + # This doesn't work under TSan, because TSan prevents select() being + # interrupted by a signal. import sys print("SKIPPING cancel_event.py") sys.exit(0)