From aff6a74770e5c05efbf6f9e14ccae0249eda504f Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Thu, 20 Feb 2020 22:51:01 -0800
Subject: [PATCH] [clang-tidy] use emplace_back

Found with hicpp-use-emplace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 src/fish.cpp       | 6 +++---
 src/parse_tree.cpp | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/fish.cpp b/src/fish.cpp
index a6520edc0..a6ac3a207 100644
--- a/src/fish.cpp
+++ b/src/fish.cpp
@@ -285,11 +285,11 @@ static int fish_parse_opt(int argc, char **argv, fish_cmd_opts_t *opts) {
     while ((opt = getopt_long(argc, argv, short_opts, long_opts, nullptr)) != -1) {
         switch (opt) {
             case 'c': {
-                opts->batch_cmds.push_back(optarg);
+                opts->batch_cmds.emplace_back(optarg);
                 break;
             }
             case 'C': {
-                opts->postconfig_cmds.push_back(optarg);
+                opts->postconfig_cmds.emplace_back(optarg);
                 break;
             }
             case 'd': {
@@ -315,7 +315,7 @@ static int fish_parse_opt(int argc, char **argv, fish_cmd_opts_t *opts) {
                 break;
             }
             case 'h': {
-                opts->batch_cmds.push_back("__fish_print_help fish");
+                opts->batch_cmds.emplace_back("__fish_print_help fish");
                 break;
             }
             case 'i': {
diff --git a/src/parse_tree.cpp b/src/parse_tree.cpp
index 0427f48c4..f07102d87 100644
--- a/src/parse_tree.cpp
+++ b/src/parse_tree.cpp
@@ -486,7 +486,7 @@ class parse_ll_t {
         while (idx--) {
             production_element_t elem = production[idx];
             PARSE_ASSERT(production_element_is_valid(elem));
-            symbol_stack.push_back(parse_stack_element_t(elem, child_start + idx));
+            symbol_stack.emplace_back(elem, child_start + idx);
         }
     }
 
@@ -731,7 +731,7 @@ void parse_ll_t::reset_symbols(enum parse_token_type_t goal) {
     nodes.push_back(parse_node_t(goal));
 
     symbol_stack.clear();
-    symbol_stack.push_back(parse_stack_element_t(goal, where));  // goal token
+    symbol_stack.emplace_back(goal, where);  // goal token
     this->fatal_errored = false;
 }