h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-20 14:11:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

Use internal job ids in builtin_wait

Browse Source 
This avoids any potential issues due to recycled job IDs.
No user visible change.
This commit is contained in:
ridiculousfish
2021-05-13 12:11:00 -07:00
parent 6bae9ebe62
commit aeabc76b2e
4 changed files with 28 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/parser.cpp
View File

@@ -566,16 +566,16 @@ void parser_t::job_promote(job_t *job) {
std::rotate(job_list.begin(), loc, std::next(loc));
}
job_t *parser_t::job_get(job_id_t id) {
const job_t *parser_t::job_with_id(job_id_t id) const {
for (const auto &job : job_list) {
if (id <= 0 || job->job_id() == id) return job.get();
}
return nullptr;
}
const job_t *parser_t::job_get(job_id_t id) const {
const job_t *parser_t::job_with_internal_id(internal_job_id_t id) const {
for (const auto &job : job_list) {
if (id <= 0 || job->job_id() == id) return job.get();
if (job->internal_job_id == id) return job.get();
}
return nullptr;
}