h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-09 03:51:20 -03:00
Code Issues Packages Projects Releases Wiki Activity

Move universal variable callbacks out from under the lock, to avoid a

Browse Source 
possible deadlock on reentrancy
This commit is contained in:
ridiculousfish
2014-04-29 11:28:00 -07:00
parent ffc23046a2
commit a949f0b0c3
3 changed files with 61 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fish_tests.cpp
View File

@@ -2170,7 +2170,7 @@ static int test_universal_helper(int *x)
const wcstring key = format_string(L"key_%d_%d", *x, j);
const wcstring val = format_string(L"val_%d_%d", *x, j);
uvars.set(key, val, false);
bool synced = uvars.sync();
bool synced = uvars.sync(NULL);
if (! synced)
{
err(L"Failed to sync universal variables");