h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-07-03 01:41:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Always pass in the working directory in path_get_cdpath

Browse Source 
If the user is in a directory which has been unlinked, it is possible
for the path .. to not exist, relative to the working directory.
Always pass in the working directory (potentially virtual) to
path_get_cdpath; this ensures we check absolute paths and are immune
from issues if the working directory has been unlinked.

Also introduce a new function path_normalize_for_cd which normalizes the
"join point" of a path and a working directory. This allows us to 'cd' out of
a non-existent directory, but not cd into such a directory.

Fixes #5341
This commit is contained in:
ridiculousfish
2018-11-17 18:02:28 -08:00
parent 1ab84ac62a
commit a8ce7bad7b
8 changed files with 76 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/highlight.cpp
View File

@@ -1021,7 +1021,7 @@ static bool command_is_valid(const wcstring &cmd, enum parse_statement_decoratio
// Implicit cd
if (!is_valid && implicit_cd_ok) {
is_valid = path_can_be_implicit_cd(cmd, NULL, working_directory, vars);
is_valid = path_can_be_implicit_cd(cmd, working_directory, NULL, vars);
}
// Return what we got.