From 9faf78d269c45280284b8aeca7c0e4cae9dd49ac Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Wed, 10 Sep 2025 10:01:58 +0200 Subject: [PATCH] github actions: fix warning about unexpected inputs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CI runs show warnings like ubuntu-32bit-static-pcre2 Unexpected input(s) 'targets', valid inputs are [''] This is about the rust-toolchain action, which is a composite action, see https://docs.github.com/en/actions/tutorials/create-actions/create-a-composite-action not a full workflow https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows Looks like composite actions specify inputs at top level. Also they should not need «on: ["workflow_call"]». The unexpected inputs are still forwared, so it happens to work. Fix the warnings. --- .../rust-toolchain@oldest-supported/action.yml | 16 +++++++--------- .github/actions/rust-toolchain@stable/action.yml | 16 +++++++--------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/.github/actions/rust-toolchain@oldest-supported/action.yml b/.github/actions/rust-toolchain@oldest-supported/action.yml index cbdfe382b..5bde7cf45 100644 --- a/.github/actions/rust-toolchain@oldest-supported/action.yml +++ b/.github/actions/rust-toolchain@oldest-supported/action.yml @@ -1,14 +1,12 @@ name: Oldest Supported Rust Toolchain -on: - workflow_call: - inputs: - targets: - description: Comma-separated list of target triples to install for this toolchain - required: false - components: - description: Comma-separated list of components to be additionally installed - required: false +inputs: + targets: + description: Comma-separated list of target triples to install for this toolchain + required: false + components: + description: Comma-separated list of components to be additionally installed + required: false permissions: contents: read diff --git a/.github/actions/rust-toolchain@stable/action.yml b/.github/actions/rust-toolchain@stable/action.yml index 4da4e365d..e3d4bd0e5 100644 --- a/.github/actions/rust-toolchain@stable/action.yml +++ b/.github/actions/rust-toolchain@stable/action.yml @@ -1,14 +1,12 @@ name: Stable Rust Toolchain -on: - workflow_call: - inputs: - targets: - description: Comma-separated list of target triples to install for this toolchain - required: false - components: - description: Comma-separated list of components to be additionally installed - required: false +inputs: + targets: + description: Comma-separated list of target triples to install for this toolchain + required: false + components: + description: Comma-separated list of components to be additionally installed + required: false permissions: contents: read