From 93dad29ec670ffdcbb99aee082b2091b84d57e48 Mon Sep 17 00:00:00 2001 From: Kurtis Rader Date: Sun, 18 Jun 2017 15:38:52 -0700 Subject: [PATCH] set `COLUMNS` and `LINES` earlier Fixes #4141 --- CHANGELOG.md | 1 + src/reader.cpp | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a600032f7..8b6afb140 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # fish 2.7b1 ## Notable fixes and improvements +- The `COLUMNS` and `LINES` env vars are now correctly set the first time `fish_prompt` is run (#4141). ## Other significant changes diff --git a/src/reader.cpp b/src/reader.cpp index 4a0e67c7b..bbd43b0ba 100644 --- a/src/reader.cpp +++ b/src/reader.cpp @@ -800,6 +800,10 @@ void reader_init() { if (is_interactive_session) { tcsetattr(STDIN_FILENO, TCSANOW, &shell_modes); } + + // We do this not because we actually need the window size but for its side-effect of correctly + // setting the COLUMNS and LINES env vars. + get_current_winsize(); } void reader_destroy() { pthread_key_delete(generation_count_key); }