h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-06 00:41:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

add_option to take new option by rvalue reference

Browse Source 
Saves some allocations/copying. No functional change here.
This commit is contained in:
ridiculousfish
2022-06-02 13:25:57 -07:00
parent 648fdc18f8
commit 8ff07d46c2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/complete.cpp
View File

@@ -138,7 +138,7 @@ class completion_entry_t {
const option_list_t &get_options() const { return options; } const option_list_t &get_options() const { return options; }
/// Adds an option. /// Adds an option.
void add_option(const complete_entry_opt_t &opt) { options.push_front(opt); } void add_option(complete_entry_opt_t &&opt) { options.push_front(std::move(opt)); }
/// Remove all completion options in the specified entry that match the specified short / long /// Remove all completion options in the specified entry that match the specified short / long
/// option strings. Returns true if it is now empty and should be deleted, false if it's not /// option strings. Returns true if it is now empty and should be deleted, false if it's not
@@ -1710,7 +1710,7 @@ void complete_add(const wcstring &cmd, bool cmd_is_path, const wcstring &option,
if (desc) opt.desc = desc; if (desc) opt.desc = desc;
opt.flags = flags; opt.flags = flags;
c.add_option(opt); c.add_option(std::move(opt));
} }
void complete_remove(const wcstring &cmd, bool cmd_is_path, const wcstring &option, void complete_remove(const wcstring &cmd, bool cmd_is_path, const wcstring &option,