h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-07-02 00:51:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

Port future_feature_flags.cpp to Rust

Browse Source 
This is early work but I guess there's no harm in pushing it?
Some thoughts on the conventions:

Types that live only inside Rust follow Rust naming convention
("FeatureMetadata").

Types that live on both sides of the language boundary follow the existing
naming ("feature_flag_t").
The alternative is to define a type alias ("using feature_flag_t =
rust::FeatureFlag") but that doesn't seem to be supported in "[cxx::bridge]"
blocks. We could put it in a header ("future_feature_flags.h").

"feature_metadata_t" is a variant of "FeatureMetadata" that can cross
the language boundary. This has the advantage that we can avoid tainting
"FeatureMetadata" with "CxxString" and such. This is an experimental approach,
probably not what we should do in general.
This commit is contained in:
Johannes Altmanninger
2023-02-03 16:34:29 +01:00
parent 132d99a27b
commit 83fd7ea7c4
17 changed files with 303 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/highlight.cpp
View File

@@ -25,7 +25,7 @@
#include "expand.h"
#include "fallback.h" // IWYU pragma: keep
#include "function.h"
#include "future_feature_flags.h"
#include "future_feature_flags.rs.h"
#include "history.h"
#include "maybe.h"
#include "operation_context.h"
@@ -665,7 +665,7 @@ static void color_string_internal(const wcstring &buffstr, highlight_spec_t base
break;
}
case L'?': {
if (!feature_test(features_t::qmark_noglob)) {
if (!feature_test(feature_flag_t::qmark_noglob)) {
colors[in_pos] = highlight_role_t::operat;
}
break;