From 835230a82f3f777e6de99eefe7de387527f78502 Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Wed, 12 Oct 2022 21:21:25 -0500 Subject: [PATCH] fish_config: Fully erase existing globals before replacing We only erase existing globals for some of the theme-related variables but not for all the `known_colors`, causing `fish_config` to still emit warnings for these if saving a theme choice after trying it. --- share/functions/fish_config.fish | 3 +++ 1 file changed, 3 insertions(+) diff --git a/share/functions/fish_config.fish b/share/functions/fish_config.fish index 257c43649..1533ab967 100644 --- a/share/functions/fish_config.fish +++ b/share/functions/fish_config.fish @@ -267,6 +267,9 @@ function fish_config --description "Launch fish's web based configuration" contains -- $c $have_colors and continue + # Erase conflicting global variables so we don't get a warning and + # so changes are observed immediately. + set -eg $c set $scope $c end