h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-19 18:01:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

completions: fix double evaluation of tokenized commandline

Browse Source 
Fix cases like

    eval my-cmd (commandline -o)
    complete -C "my-cmd $(commandline -o)"

In both cases, we spuriously evaluate tokens like "(inside-quoted-string)"
as command substitutions. Fix this by escaping the strings.  The momentarily
regresses the intended purpose of "eval" -- to expand variables -- but the
next commit will fix that.
This commit is contained in:
Johannes Altmanninger
2024-01-06 08:45:33 +01:00
parent 368017905e
commit 798527d79a
10 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
share/functions/__fish_complete_subcommand.fish
View File

@@ -18,7 +18,7 @@ function __fish_complete_subcommand -d "Complete subcommand" --no-scope-shadowin
set -l options_with_param $argv
if not string length -q -- $subcommand
set -l cmd (commandline -cop) (commandline -ct)
set -l cmd (commandline -cop | string escape) (commandline -ct)
while set -q cmd[1]
set -l token $cmd[1]
set -e cmd[1]