h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-07 10:01:14 -03:00
Code Issues Packages Projects Releases Wiki Activity

exec: If a job includes a builtin, it stays in our pgroup

Browse Source 
Fixes #5855.
This commit is contained in:
Fabian Homborg
2019-05-24 18:04:20 +02:00
parent f2bb1c8c1f
commit 711260593c
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/exec.cpp
View File

@@ -1019,6 +1019,19 @@ bool exec_job(parser_t &parser, shared_ptr<job_t> j) {
j->set_flag(job_flag_t::JOB_CONTROL, true); j->set_flag(job_flag_t::JOB_CONTROL, true);
} }
// If there's a builtin in the pipeline,
// we let the whole job stay in our pgroup.
// This fixes `builtin history | less`, and still lets `read | cat` and `cat | read` work.
// (Note that bash forks for the builtin in these cases, but that's also why its `read` often can't communicate variables back)
if (j->pgid == INVALID_PID) {
for (const auto& proc : j->processes) {
if (proc->type == process_type_t::builtin) {
j->pgid = getpgrp();
break;
}
}
}
size_t stdout_read_limit = 0; size_t stdout_read_limit = 0;
io_chain_t all_ios = j->all_io_redirections(); io_chain_t all_ios = j->all_io_redirections();