h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-18 03:41:16 -03:00
Code Issues Packages Projects Releases Wiki Activity

src/exec: fix assertion on failed exec redirection

Browse Source 
Minimal reproducer: `fish -c "exec cat<x"`
This commit is contained in:
Mrmaxmeier
2019-02-11 17:10:42 +01:00
committed by ridiculousfish
parent b247c8d9ad
commit 6e9250425a
5 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/exec.cpp
View File

@@ -970,7 +970,11 @@ bool exec_job(parser_t &parser, shared_ptr<job_t> j) {
if (j->processes.front()->type == INTERNAL_EXEC) {
internal_exec(parser.vars(), j.get(), all_ios);
DIE("this should be unreachable");
// internal_exec only returns if it failed to set up redirections.
// In case of an successful exec, this code is not reached.
bool status = j->get_flag(job_flag_t::NEGATE) ? 0 : 1;
proc_set_last_status(status);
return false;
}
// This loop loops over every process_t in the job, starting it as appropriate. This turns out