h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-13 07:21:13 -03:00
Code Issues Packages Projects Releases Wiki Activity

Stop passing mutable references to completions around

Browse Source 
Replace uses of vector<completion_t>& with vector<completion_t>*
This makes it clear at the call site that the object may be mutated.
This commit is contained in:
ridiculousfish
2015-07-27 18:45:47 -07:00
parent 85dad6913e
commit 6e3231a9d7
12 changed files with 101 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/fish_tests.cpp
View File

@@ -739,7 +739,7 @@ static void test_parser()
say(L"Testing eval_args");
completion_list_t comps;
parser_t::principal_parser().expand_argument_list(L"alpha 'beta gamma' delta", comps);
parser_t::principal_parser().expand_argument_list(L"alpha 'beta gamma' delta", &comps);
do_test(comps.size() == 3);
do_test(comps.at(0).completion == L"alpha");
do_test(comps.at(1).completion == L"beta gamma");
@@ -1344,7 +1344,7 @@ static bool expand_test(const wchar_t *in, expand_flags_t flags, ...)
wchar_t *arg;
parse_error_list_t errors;
if (expand_string(in, output, flags, &errors) == EXPAND_ERROR)
if (expand_string(in, &output, flags, &errors) == EXPAND_ERROR)
{
if (errors.empty())
{
@@ -1583,7 +1583,7 @@ static void test_pager_navigation()
completion_list_t completions;
for (size_t i=0; i < 19; i++)
{
append_completion(completions, L"abcdefghij");
append_completion(&completions, L"abcdefghij");
}
pager_t pager;