h/fish-shell
1
Fork 0
mirror of https://github.com/fish-shell/fish-shell.git synced 2026-05-19 18:01:15 -03:00
Code Issues Packages Projects Releases Wiki Activity

abbr: Let --function use a mandatory argument

Browse Source 
This now means `abbr --add` has two modes:

```fish
abbr --add name --function foo --regex regex
```

```fish
abbr --add name --regex regex replacement
```

This is because `--function` was seen to be confusing as a boolean flag.
This commit is contained in:
Fabian Boehm
2022-12-16 17:01:21 +01:00
parent 36e8117206
commit 4c39aeed87
3 changed files with 41 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/checks/abbr.fish
View File

@@ -133,11 +133,20 @@ echo $status
# CHECKERR: abbr: --position option requires --add
# CHECK: 2
abbr --query banana --function
abbr --query banana --function foo
echo $status
# CHECKERR: abbr: --function option requires --add
# CHECK: 2
abbr --query banana --function
echo $status
# CHECKERR: abbr: --function: option requires an argument
# CHECKERR: checks/abbr.fish (line 141):
# CHECKERR: abbr --query banana --function
# CHECKERR: ^
# CHECKERR: (Type 'help abbr' for related documentation)
# CHECK: 2
abbr --add peach --function invalid/function/name
echo $status
# CHECKERR: abbr: Invalid function name: invalid/function/name
@@ -160,7 +169,7 @@ abbr --add !! --position anywhere --function replace_history
abbr --show
# CHECK: abbr -a -- nonregex_name foo
# CHECK: abbr -a --regex 'A[0-9]B' -- regex_name bar
# CHECK: abbr -a --position anywhere --function -- !! replace_history
# CHECK: abbr -a --position anywhere --function replace_history -- !!
abbr --erase (abbr --list)
abbr --add bogus --position never stuff