Standardize shell script indent level

We have a mixture of 2 and 4 space indent.

    4 benchmarks/driver.sh
    2 build_tools/check.sh
    4 build_tools/git_version_gen.sh
    4 build_tools/mac_notarize.sh
    2 build_tools/make_pkg.sh
    2 build_tools/make_tarball.sh
    2 build_tools/make_vendor_tarball.sh
    4 docker/docker_run_tests.sh
    4 osx/install.sh
    2 tests/test_functions/sphinx-shared.sh

Our editorconfig file specifies 2, with no explicit reason.
Our fish and Python scripts use 4, so let's use that.

tests/test_functions/sphinx-shared.sh

@@ -3,9 +3,9 @@
 set -e
 
 cleanup () {
-  if [ -n "$tmp_dir" ] && [ -e "$tmp_dir" ]; then
-    rm -r "$tmp_dir"
-  fi
+    if [ -n "$tmp_dir" ] && [ -e "$tmp_dir" ]; then
+        rm -r "$tmp_dir"
+    fi
 }
 
 trap cleanup EXIT INT TERM HUP
@@ -17,12 +17,12 @@ tmp_dir=$(mktemp -d)
 doctree=$tmp_dir/doctree
 output_dir=$tmp_dir/$builder
 sphinx-build \
-  -j auto \
-  -q \
-  -W \
-  -E \
-  -b "$builder" \
-  -c "$docsrc" \
-  -d "$doctree" \
-  "$docsrc" \
-  "$output_dir"
+    -j auto \
+    -q \
+    -W \
+    -E \
+    -b "$builder" \
+    -c "$docsrc" \
+    -d "$doctree" \
+    "$docsrc" \
+    "$output_dir"