Big fat refactoring of how redirections work. In fish 1.x and 2.0.0, the redirections for a process were flattened into a big list associated with the job, so there was no way to tell which redirections applied to each process. Each process therefore got all the redirections associated with the job. See https://github.com/fish-shell/fish-shell/issues/877 for how this could manifest.

mirror of https://github.com/fish-shell/fish-shell.git synced 2026-06-01 04:41:14 -03:00

With this change, jobs only track their block-level redirections. Process level redirections are correctly associated with the process, and at exec time we stitch them together (block, pipe, and process redirects).

This fixes the weird issues where redirects bleed across pipelines (like #877), and also allows us to play with the order in which redirections are applied, since the final list is constructed right before it's needed.  This lets us put pipes after block level redirections but before process level redirections, so that a 2>&1-type redirection gets picked up after the pipe, i.e. it should fix https://github.com/fish-shell/fish-shell/issues/110

This is a significant change. The tests all pass. Cross your fingers.

This commit is contained in:

ridiculousfish

2013-08-19 16:16:41 -07:00

parent f4f2847662

commit 4899086b3c

11 changed files with 182 additions and 116 deletions

									
										2

exec.h
									
												View File
												
				@@ -42,7 +42,7 @@

				*/

				class parser_t;

				void exec(parser_t &parser, job_t *j);

				void exec_job(parser_t &parser, job_t *j);

				/**

				  Evaluate the expression cmd in a subshell, add the outputs into the

2 exec.h Unescape Escape View File

2

exec.h

View File