From 4336f9df7f30296c271bec9484af44fcf9c2e8c3 Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Mon, 23 Sep 2024 19:51:20 +0200 Subject: [PATCH] fish_key_reader: stop emitting \b for ctrl-h This is just too confusing; \b sounds like it would map backspace but it's actually just ctrl-h. Backspace is a different key ("bind backspace"), so let's move away from \b. Reproduce by typing ctrl-h in fish_key_reader, or, for even more confusion, use a terminal like tmux and type ctrl-backspace which also sends ctrl-h. I've thought about changing \b (and its aliases like \ch and \x08) to mean backspace but that seems like unnecessary breakage, since they all already mean ctrl-h, and can usually be mapped independent of backspace. See the discussion in #10738 --- src/key.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/key.rs b/src/key.rs index 7634f1485..207b4654f 100644 --- a/src/key.rs +++ b/src/key.rs @@ -420,7 +420,6 @@ fn ctrl_to_symbol(buf: &mut WString, c: char) { let c = u8::try_from(c).unwrap(); let symbolic_name = match c { - 8 => L!("\\b"), 9 => L!("\\t"), 10 => L!("\\n"), 13 => L!("\\r"),